fix: normalize preserveModulesRoot path by IWANABETHATGUY · Pull Request #7737 · rolldown/rolldown

IWANABETHATGUY · 2026-01-02T05:32:08Z

IWANABETHATGUY · 2026-01-02T05:32:27Z

fix: normalize preserveModulesRoot path #7737 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2026-01-02T05:34:32Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`2ee2b1c`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/6958a6d7eb79fa0008587622

pkg-pr-new · 2026-01-02T09:42:14Z

Open in StackBlitz

@rolldown/browser

npm i https://pkg.pr.new/@rolldown/browser@7737

@rolldown/debug

npm i https://pkg.pr.new/@rolldown/debug@7737

@rolldown/pluginutils

npm i https://pkg.pr.new/@rolldown/pluginutils@7737

rolldown

npm i https://pkg.pr.new/rolldown@7737

@rolldown/binding-android-arm64

npm i https://pkg.pr.new/@rolldown/binding-android-arm64@7737

@rolldown/binding-darwin-arm64

npm i https://pkg.pr.new/@rolldown/binding-darwin-arm64@7737

@rolldown/binding-darwin-x64

npm i https://pkg.pr.new/@rolldown/binding-darwin-x64@7737

@rolldown/binding-freebsd-x64

npm i https://pkg.pr.new/@rolldown/binding-freebsd-x64@7737

@rolldown/binding-linux-arm-gnueabihf

npm i https://pkg.pr.new/@rolldown/binding-linux-arm-gnueabihf@7737

@rolldown/binding-linux-arm64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-gnu@7737

@rolldown/binding-linux-arm64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-musl@7737

@rolldown/binding-linux-x64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-gnu@7737

@rolldown/binding-linux-x64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-musl@7737

@rolldown/binding-openharmony-arm64

npm i https://pkg.pr.new/@rolldown/binding-openharmony-arm64@7737

@rolldown/binding-wasm32-wasi

npm i https://pkg.pr.new/@rolldown/binding-wasm32-wasi@7737

@rolldown/binding-win32-arm64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-arm64-msvc@7737

@rolldown/binding-win32-x64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-x64-msvc@7737

commit: e34157f

crates/rolldown/src/utils/prepare_build_context.rs

Copilot

Pull request overview

This PR fixes issue #7733 by improving the handling of preserve_modules_root option in the bundler. The fix ensures that the path is always normalized, which resolves issues with relative path components.

Key changes:

Simplified and fixed the preserve_modules_root path handling logic to always normalize paths
Added comprehensive test coverage for the fix

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`crates/rolldown/src/utils/prepare_build_context.rs`	Simplified `preserve_modules_root` path handling to always join with cwd and normalize, removing the conditional absolute path check
`packages/rolldown/tests/fixtures/topics/preserve-modules/issue-7733/_config.ts`	Added test configuration to verify correct output structure when using `preserveModules` with `preserveModulesRoot`
`packages/rolldown/tests/fixtures/topics/preserve-modules/issue-7733/src/main/index.js`	Added test entry point that imports from sibling directories
`packages/rolldown/tests/fixtures/topics/preserve-modules/issue-7733/src/foo/foo.js`	Added test module exporting a constant
`packages/rolldown/tests/fixtures/topics/preserve-modules/issue-7733/src/bar/bar.js`	Added test module exporting a constant

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/rolldown/tests/fixtures/topics/preserve-modules/issue-7733/_config.ts

github-actions · 2026-01-02T11:19:48Z

Benchmarks Rust

target: main(400f146)
pr: 01-02-fix_7733(2ee2b1c)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.07     70.4±2.35ms        ? ?/sec    1.00     66.1±1.78ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.04     76.7±1.95ms        ? ?/sec    1.00     73.4±1.53ms        ? ?/sec
bundle/bundle@rome_ts                                        1.05    112.2±2.72ms        ? ?/sec    1.00    107.2±1.39ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.04    124.2±1.74ms        ? ?/sec    1.00    118.9±2.41ms        ? ?/sec
bundle/bundle@threejs                                        1.06     41.3±2.32ms        ? ?/sec    1.00     39.2±2.03ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.04     45.5±0.58ms        ? ?/sec    1.00     43.6±0.57ms        ? ?/sec
bundle/bundle@threejs10x                                     1.02    408.5±4.59ms        ? ?/sec    1.00    400.1±4.61ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.03    468.0±5.85ms        ? ?/sec    1.00    455.7±5.29ms        ? ?/sec
scan/scan@rome_ts                                            1.00     87.2±1.66ms        ? ?/sec    1.00     87.3±1.77ms        ? ?/sec
scan/scan@threejs                                            1.00     29.3±0.87ms        ? ?/sec    1.00     29.4±1.77ms        ? ?/sec
scan/scan@threejs10x                                         1.02    299.8±3.92ms        ? ?/sec    1.00    293.6±3.51ms        ? ?/sec

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/rolldown/tests/fixtures/topics/preserve-modules/issue-7733/_config.ts

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

graphite-app · 2026-01-03T05:18:44Z

Merge activity

Jan 3, 5:18 AM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Jan 3, 5:32 AM UTC: Merged by the Graphite merge queue.

Closed #7733

@shulaoda

## [1.0.0-beta.59] - 2026-01-07 ⚡ Inline Dynamic Imports for Statically Imported Modules - When a module is already statically imported, dynamic imports to that same module are now inlined instead of creating a separate chunk ### 🚀 Features - plugin_timings: add 3s threshold and doc link to warning message (#7741) by @shulaoda - improve treeshaking logic to handle empty parameter list in dynamic import .then() callbacks (#7781) by @Copilot - dev/lazy: don't include already executed modules (#7745) by @hyf0 - dev/lazy: support dynamic `import(..)` (#7726) by @hyf0 - inline dynamic imports that imports statically imported modules (#7742) by @IWANABETHATGUY - option: add experimental option to control chunk optimization (#7738) by @IWANABETHATGUY ### 🐛 Bug Fixes - inline dynamic entry to user defined entry with esm wrap kind (#7783) by @IWANABETHATGUY - use canonical namespace reference for property access (#7777) by @IWANABETHATGUY - dynamic entry merged into common chunk with cjs and esm wrap kind (#7771) by @IWANABETHATGUY - tla: should not await non-tla-related modules (#7768) by @hyf0 - dynamic entry captured by common chunk with CJS format (#7757) by @IWANABETHATGUY - module_loader: mark emitted chunks as user-defined entry when already loaded (#7765) by @shulaoda - normalize preserveModulesRoot path (#7737) by @IWANABETHATGUY - linker: resolve race condition in side effects computation for export-star (#7728) by @camc314 ### 🚜 Refactor - plugin_timings: filter out plugins with duration < 1s from timing warnings (#7785) by @shulaoda - module_loader: remove unnecessary collect before extend (#7769) by @shulaoda - rename _id suffixes to _idx for oxc_index types (#7767) by @IWANABETHATGUY - remove duplicate `preserve_entry_signatures` from `AddEntryModuleMsg` (#7762) by @shulaoda - module_loader: pass `user_defined_entries` by reference (#7756) by @shulaoda - dev/lazy: get proxy entry's `ResolvedId` correctly (#7746) by @hyf0 - simplify try_rewrite_import_expression control flow (#7753) by @IWANABETHATGUY - module_loader: remove unnecessary dynamic import handling for runtime module (#7754) by @shulaoda - inline __toDynamicImportESM (#7747) by @IWANABETHATGUY - use From impl for ModuleLoaderOutput conversion (#7732) by @shulaoda - remove duplicate fields from `ModuleLoader` (#7731) by @shulaoda - tweak `resolve_user_defined_entries` (#7727) by @shulaoda ### 📚 Documentation - add rolldown-string reference to native MagicString compatibility section (#7778) by @Copilot - improve comments for export star side effects handling (#7730) by @IWANABETHATGUY ### 🧪 Testing - use assertion instead of console.log for some testcase (#7744) by @IWANABETHATGUY ### ⚙️ Miscellaneous Tasks - tweak some `output.dynamicImportInCjs` related rollup test results (#7776) by @sapphi-red - mark esbuild/dce/dce_of_symbol_ctor_call as passed (#7775) by @sapphi-red - deps: update oxc apps (#7772) by @renovate[bot] - vite-tests: allow running on PRs with `test: vite-tests` label (#7770) by @shulaoda - deps: update oxc apps (#7760) by @renovate[bot] - deps: update rollup submodule for tests to v4.55.1 (#7763) by @sapphi-red - deps: update test262 submodule for tests (#7764) by @sapphi-red - deps: update oxc to v0.107.0 (#7758) by @camc314 - deps: update taiki-e/install-action action to v2.65.13 (#7751) by @renovate[bot] - deps: update rust crates (#7750) by @renovate[bot] - deps: update npm packages (#7749) by @renovate[bot] - deps: update github-actions (#7748) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.10.1 (#7729) by @renovate[bot] - deps: update crate-ci/typos action to v1.41.0 (#7725) by @renovate[bot] Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned IWANABETHATGUY Jan 2, 2026

IWANABETHATGUY force-pushed the 01-02-fix_7733 branch from 53ccd4e to e34157f Compare January 2, 2026 09:04

IWANABETHATGUY added the trigger: preview label Jan 2, 2026

IWANABETHATGUY commented Jan 2, 2026

View reviewed changes

crates/rolldown/src/utils/prepare_build_context.rs Show resolved Hide resolved

IWANABETHATGUY force-pushed the 01-02-fix_7733 branch from e34157f to 609a4e0 Compare January 2, 2026 11:03

IWANABETHATGUY marked this pull request as ready for review January 2, 2026 11:04

Copilot AI review requested due to automatic review settings January 2, 2026 11:04

Copilot started reviewing on behalf of IWANABETHATGUY January 2, 2026 11:04 View session

Copilot AI reviewed Jan 2, 2026

View reviewed changes

packages/rolldown/tests/fixtures/topics/preserve-modules/issue-7733/_config.ts Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings January 2, 2026 11:28

Copilot started reviewing on behalf of IWANABETHATGUY January 2, 2026 11:29 View session

Copilot AI reviewed Jan 2, 2026

View reviewed changes

packages/rolldown/tests/fixtures/topics/preserve-modules/issue-7733/_config.ts Outdated Show resolved Hide resolved

IWANABETHATGUY changed the title ~~fix: 7733~~ fix: normalize preserveModulesRoot path Jan 2, 2026

Copilot AI review requested due to automatic review settings January 2, 2026 11:43

Copilot started reviewing on behalf of IWANABETHATGUY January 2, 2026 11:43 View session

Copilot AI reviewed Jan 2, 2026

View reviewed changes

IWANABETHATGUY requested review from hyf0 and shulaoda January 3, 2026 04:34

shulaoda approved these changes Jan 3, 2026

View reviewed changes

fix: normalize preserveModulesRoot path (#7737)

2ee2b1c

Closed #7733

graphite-app bot force-pushed the 01-02-fix_7733 branch from 6f99519 to 2ee2b1c Compare January 3, 2026 05:19

graphite-app bot merged commit 2ee2b1c into main Jan 3, 2026
34 checks passed

graphite-app bot deleted the 01-02-fix_7733 branch January 3, 2026 05:32

This was referenced Jan 7, 2026

release: v1.0.0-beta.59 #7774

Closed

release: v1.0.0-beta.59 #7786

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

fix: normalize preserveModulesRoot path#7737

fix: normalize preserveModulesRoot path#7737
graphite-app[bot] merged 1 commit intomainfrom
01-02-fix_7733

IWANABETHATGUY commented Jan 2, 2026 •

edited

Loading

Uh oh!

IWANABETHATGUY commented Jan 2, 2026

Uh oh!

netlify bot commented Jan 2, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Jan 2, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

github-actions bot commented Jan 2, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

graphite-app bot commented Jan 3, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

IWANABETHATGUY commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IWANABETHATGUY commented Jan 2, 2026

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

pkg-pr-new bot commented Jan 2, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

github-actions bot commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

graphite-app bot commented Jan 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IWANABETHATGUY commented Jan 2, 2026 •

edited

Loading

netlify bot commented Jan 2, 2026 •

edited

Loading

github-actions bot commented Jan 2, 2026 •

edited

Loading

graphite-app bot commented Jan 3, 2026 •

edited

Loading