Skip to content

refactor(rust): return correct stable id of external module from Module#stable_id()#7716

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-30-refactor_rust_return_correct_stable_id_of_external_module_from_module_stable_id_
Dec 30, 2025
Merged

refactor(rust): return correct stable id of external module from Module#stable_id()#7716
graphite-app[bot] merged 1 commit intomainfrom
12-30-refactor_rust_return_correct_stable_id_of_external_module_from_module_stable_id_

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Dec 30, 2025

No description provided.

Copy link
Member Author

hyf0 commented Dec 30, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2025

Benchmarks Rust

  • target: main(e821572)
  • pr: 12-30-refactor_rust_return_correct_stable_id_of_external_module_from_module_stable_id_(9b975f9)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     66.3±1.41ms        ? ?/sec    1.00     65.6±1.20ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     72.7±1.43ms        ? ?/sec    1.00     72.1±1.39ms        ? ?/sec
bundle/bundle@rome_ts                                        1.03    111.5±2.52ms        ? ?/sec    1.00    108.1±5.35ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    121.4±2.50ms        ? ?/sec    1.00    120.1±1.67ms        ? ?/sec
bundle/bundle@threejs                                        1.00     38.9±2.14ms        ? ?/sec    1.03     40.2±2.21ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     44.7±0.69ms        ? ?/sec    1.00     44.2±0.65ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00   395.3±10.17ms        ? ?/sec    1.00    394.4±3.95ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    456.4±3.70ms        ? ?/sec    1.00    458.0±9.52ms        ? ?/sec
scan/scan@rome_ts                                            1.01     86.0±1.58ms        ? ?/sec    1.00     85.5±1.30ms        ? ?/sec
scan/scan@threejs                                            1.02     29.1±0.38ms        ? ?/sec    1.00     28.4±0.50ms        ? ?/sec
scan/scan@threejs10x                                         1.00    295.7±6.44ms        ? ?/sec    1.02    300.2±5.09ms        ? ?/sec

@graphite-app graphite-app bot changed the base branch from 12-30-refactor_rust_introduce_stablemoduleid_type to graphite-base/7716 December 30, 2025 22:12
@graphite-app graphite-app bot force-pushed the 12-30-refactor_rust_return_correct_stable_id_of_external_module_from_module_stable_id_ branch from aacf457 to bf2b1e6 Compare December 30, 2025 22:25
@graphite-app graphite-app bot force-pushed the graphite-base/7716 branch from d5e76e3 to 70765f3 Compare December 30, 2025 22:25
@graphite-app graphite-app bot changed the base branch from graphite-base/7716 to main December 30, 2025 22:25
@graphite-app graphite-app bot force-pushed the 12-30-refactor_rust_return_correct_stable_id_of_external_module_from_module_stable_id_ branch from bf2b1e6 to 51f1a6c Compare December 30, 2025 22:26
@netlify
Copy link

netlify bot commented Dec 30, 2025

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 9b975f9
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6954555556fdf30008f46b40
😎 Deploy Preview https://deploy-preview-7716--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

graphite-app bot pushed a commit that referenced this pull request Dec 30, 2025
@graphite-app graphite-app bot force-pushed the 12-30-refactor_rust_return_correct_stable_id_of_external_module_from_module_stable_id_ branch from 51f1a6c to 709c18f Compare December 30, 2025 22:39
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 30, 2025

Merge activity

Copilot AI review requested due to automatic review settings December 30, 2025 22:42
@graphite-app graphite-app bot force-pushed the 12-30-refactor_rust_return_correct_stable_id_of_external_module_from_module_stable_id_ branch from 709c18f to 9b975f9 Compare December 30, 2025 22:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@graphite-app graphite-app bot merged commit 9b975f9 into main Dec 30, 2025
34 checks passed
@graphite-app graphite-app bot deleted the 12-30-refactor_rust_return_correct_stable_id_of_external_module_from_module_stable_id_ branch December 30, 2025 22:56
This was referenced Dec 31, 2025
shulaoda added a commit that referenced this pull request Dec 31, 2025
## [1.0.0-beta.58] - 2025-12-31

### 💥 BREAKING CHANGES

- experimental/devtools: rename InputOptions#debug to InputOptions#devtools (#7686) by @Copilot

### 🚀 Features

- implement target feature check in `should_transform_js` for raw options (#7697) by @shulaoda
- support `output.dynamicImportInCjs` option (#7677) by @shulaoda
- types: expose `ChecksOptions` type (#7653) by @sapphi-red

### 🐛 Bug Fixes

- export runtime helpers for cross-chunk access (#7658) by @shulaoda
- cjs namespace merging regression (#7665) by @IWANABETHATGUY
- replace panic with proper error handling for hash placeholder generation (#7661) by @shulaoda
- remove the blank line between shebang and postBanner (#7643) by @btea
- rolldown_plugin_vite_reporter: apply padding before ANSI coloring for proper size column alignment (#7649) by @shulaoda

### 🚜 Refactor

- rust: use `StableModuleId` as the map key if possible (#7718) by @hyf0
- rust: return `StableModuleId` instead of `&str` from `Module#stable_id()` (#7717) by @hyf0
- rust: return correct stable id of external module from `Module#stable_id()` (#7716) by @hyf0
- rust: introduce `StableModuleId` type (#7715) by @hyf0
- rust: reduce unnecessary `id.as_arc_str().clone().into()` (#7714) by @hyf0
- rust: remove `ModuleId#resource_id` and use `as_arc_str` directly (#7710) by @hyf0
- rust: remove unused `Module#id_clone` (#7709) by @hyf0
- rust: remove `Module#id_as_str` and use `Module#id` directly (#7708) by @hyf0
- consolidate namespace call analysis into import analyzer (#7657) by @IWANABETHATGUY
- rust: make `ExternalModule#id` have the type `ModuleId` (#7707) by @hyf0
- rust: rename `Module#id` to `Module#id_as_str` (#7706) by @hyf0
- rust: use `ModuleId` instead of raw `ArcStr` for `ScanStageCache` (#7701) by @hyf0
- simplify error propagation in cache merge (#7702) by @shulaoda
- use `ModuleId` as the type of `ResolvedId#id` (#7694) by @hyf0
- types: rename `resolved_request_info.rs` to `resolved_id.rs` and move its contents (#7687) by @hyf0
- devtools: emit data to `<CWD>/node_modules/.rolldown` (#7692) by @hyf0
- use `InvalidOption` for hash placeholder generation errors (#7674) by @shulaoda
- rolldown_error: remove dependency on rolldown_utils (#7672) by @shulaoda
- use nodejs-built-in-modules v1.0.0 directly in callsites (#7667) by @Boshen

### 📚 Documentation

- migrate input options content from options to auto gen docs (#7663) by @mdong1909
- create reference index page (#7659) by @mdong1909
- tweak auto-generated reference output (#7654) by @sapphi-red
- initialize auto-gen docs (#7252) by @mdong1909

### ⚙️ Miscellaneous Tasks

- deps: update napi (#7705) by @renovate[bot]
- pin Node.js version to 24.12.0 LTS in .node-version file (#7713) by @Copilot
- update esbuild test reasons (#7703) by @sapphi-red
- deps: update crate-ci/typos action to v1.40.1 (#7696) by @renovate[bot]
- deps: update oxc to v0.106.0 (#7512) by @renovate[bot]
- js: replace dprint with oxfmt (#7214) by @Boshen
- deps: update dependency oxlint to v1.36.0 (#7691) by @renovate[bot]
- deps: update github-actions (#7679) by @renovate[bot]
- deps: update npm packages (#7680) by @renovate[bot]
- deps: update rust crates (#7678) by @renovate[bot]
- deps: update oxc resolver to v11.16.2 (#7668) by @renovate[bot]
- add API reference files to knip entry points (#7669) by @Copilot
- deps: update notify (#7651) by @sapphi-red
- add `homepage` field to package.json (#7648) by @trivikr
- deps: update oxc resolver to v11.16.1 (#7647) by @renovate[bot]
- deps: update rolldown-plugin-dts to 0.20.0 (#7645) by @shulaoda

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments