refactor(rust): reduce unnecessary `id.as_arc_str().clone().into()` by hyf0 · Pull Request #7714 · rolldown/rolldown

hyf0 · 2025-12-30T14:12:52Z

No description provided.

hyf0 · 2025-12-30T14:13:03Z

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

This PR refactors code to eliminate unnecessary type conversions when inserting ModuleId values into collections. The key change is adding a Borrow<str> implementation for ModuleId, which enables more efficient HashMap lookups while simplifying code that previously performed unnecessary conversions.

Key changes:

Added Borrow<str> trait implementation for ModuleId to enable efficient HashMap lookups using &str
Replaced verbose id.as_arc_str().clone().into() pattern with simpler id.clone() in three insertion operations

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
crates/rolldown_common/src/types/module_id.rs	Added `Borrow<str>` trait implementation and imported `std::borrow::Borrow` to enable efficient HashMap lookups
crates/rolldown/src/module_loader/module_task.rs	Simplified three module ID insertion operations by replacing `id.as_arc_str().clone().into()` with `id.clone()`

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/rolldown_common/src/types/module_id.rs

github-actions · 2025-12-30T14:57:09Z

Benchmarks Rust

target: main(8afbf65)
pr: 12-30-refactor_rust_reduce_unnecessary_id.as_arc_str_.clone_.into_(d35c43b)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     60.7±1.22ms        ? ?/sec    1.00     60.8±1.00ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     67.2±1.42ms        ? ?/sec    1.00     67.2±1.09ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    104.9±3.87ms        ? ?/sec    1.00    104.8±2.41ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    116.1±1.90ms        ? ?/sec    1.00    116.4±1.56ms        ? ?/sec
bundle/bundle@threejs                                        1.02     37.4±2.08ms        ? ?/sec    1.00     36.7±0.61ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     41.6±0.69ms        ? ?/sec    1.00     41.7±0.50ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    383.0±3.60ms        ? ?/sec    1.00    382.4±5.71ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    443.9±3.12ms        ? ?/sec    1.00    442.9±3.02ms        ? ?/sec
scan/scan@rome_ts                                            1.00     82.3±1.47ms        ? ?/sec    1.00     82.3±1.58ms        ? ?/sec
scan/scan@threejs                                            1.00     27.8±0.34ms        ? ?/sec    1.00     27.7±0.35ms        ? ?/sec
scan/scan@threejs10x                                         1.01    288.4±5.69ms        ? ?/sec    1.00    284.7±4.09ms        ? ?/sec

netlify · 2025-12-30T15:13:07Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`d35c43b`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/69544b6fc118ee000836fb33

graphite-app · 2025-12-30T21:59:48Z

Merge activity

Dec 30, 9:59 PM UTC: hyf0 added this pull request to the Graphite merge queue.
Dec 30, 10:11 PM UTC: Merged by the Graphite merge queue.

…7714)

@shulaoda

## [1.0.0-beta.58] - 2025-12-31 ### 💥 BREAKING CHANGES - experimental/devtools: rename InputOptions#debug to InputOptions#devtools (#7686) by @Copilot ### 🚀 Features - implement target feature check in `should_transform_js` for raw options (#7697) by @shulaoda - support `output.dynamicImportInCjs` option (#7677) by @shulaoda - types: expose `ChecksOptions` type (#7653) by @sapphi-red ### 🐛 Bug Fixes - export runtime helpers for cross-chunk access (#7658) by @shulaoda - cjs namespace merging regression (#7665) by @IWANABETHATGUY - replace panic with proper error handling for hash placeholder generation (#7661) by @shulaoda - remove the blank line between shebang and postBanner (#7643) by @btea - rolldown_plugin_vite_reporter: apply padding before ANSI coloring for proper size column alignment (#7649) by @shulaoda ### 🚜 Refactor - rust: use `StableModuleId` as the map key if possible (#7718) by @hyf0 - rust: return `StableModuleId` instead of `&str` from `Module#stable_id()` (#7717) by @hyf0 - rust: return correct stable id of external module from `Module#stable_id()` (#7716) by @hyf0 - rust: introduce `StableModuleId` type (#7715) by @hyf0 - rust: reduce unnecessary `id.as_arc_str().clone().into()` (#7714) by @hyf0 - rust: remove `ModuleId#resource_id` and use `as_arc_str` directly (#7710) by @hyf0 - rust: remove unused `Module#id_clone` (#7709) by @hyf0 - rust: remove `Module#id_as_str` and use `Module#id` directly (#7708) by @hyf0 - consolidate namespace call analysis into import analyzer (#7657) by @IWANABETHATGUY - rust: make `ExternalModule#id` have the type `ModuleId` (#7707) by @hyf0 - rust: rename `Module#id` to `Module#id_as_str` (#7706) by @hyf0 - rust: use `ModuleId` instead of raw `ArcStr` for `ScanStageCache` (#7701) by @hyf0 - simplify error propagation in cache merge (#7702) by @shulaoda - use `ModuleId` as the type of `ResolvedId#id` (#7694) by @hyf0 - types: rename `resolved_request_info.rs` to `resolved_id.rs` and move its contents (#7687) by @hyf0 - devtools: emit data to `<CWD>/node_modules/.rolldown` (#7692) by @hyf0 - use `InvalidOption` for hash placeholder generation errors (#7674) by @shulaoda - rolldown_error: remove dependency on rolldown_utils (#7672) by @shulaoda - use nodejs-built-in-modules v1.0.0 directly in callsites (#7667) by @Boshen ### 📚 Documentation - migrate input options content from options to auto gen docs (#7663) by @mdong1909 - create reference index page (#7659) by @mdong1909 - tweak auto-generated reference output (#7654) by @sapphi-red - initialize auto-gen docs (#7252) by @mdong1909 ### ⚙️ Miscellaneous Tasks - deps: update napi (#7705) by @renovate[bot] - pin Node.js version to 24.12.0 LTS in .node-version file (#7713) by @Copilot - update esbuild test reasons (#7703) by @sapphi-red - deps: update crate-ci/typos action to v1.40.1 (#7696) by @renovate[bot] - deps: update oxc to v0.106.0 (#7512) by @renovate[bot] - js: replace dprint with oxfmt (#7214) by @Boshen - deps: update dependency oxlint to v1.36.0 (#7691) by @renovate[bot] - deps: update github-actions (#7679) by @renovate[bot] - deps: update npm packages (#7680) by @renovate[bot] - deps: update rust crates (#7678) by @renovate[bot] - deps: update oxc resolver to v11.16.2 (#7668) by @renovate[bot] - add API reference files to knip entry points (#7669) by @Copilot - deps: update notify (#7651) by @sapphi-red - add `homepage` field to package.json (#7648) by @trivikr - deps: update oxc resolver to v11.16.1 (#7647) by @renovate[bot] - deps: update rolldown-plugin-dts to 0.20.0 (#7645) by @shulaoda Co-authored-by: shulaoda <[email protected]>

This was referenced Dec 30, 2025

refactor(rust): remove unused Module#id_clone #7709

Merged

refactor(rust): introduce StableModuleId type #7715

Merged

github-actions bot assigned hyf0 Dec 30, 2025

hyf0 marked this pull request as ready for review December 30, 2025 14:15

Copilot AI review requested due to automatic review settings December 30, 2025 14:15

Copilot started reviewing on behalf of hyf0 December 30, 2025 14:17 View session

Copilot AI reviewed Dec 30, 2025

View reviewed changes

crates/rolldown_common/src/types/module_id.rs Show resolved Hide resolved

graphite-app bot force-pushed the 12-30-refactor_rust_remove_moduleid_resource_id_and_use_as_arc_str_directly branch from 45d66bd to 1c65de4 Compare December 30, 2025 14:29

graphite-app bot force-pushed the 12-30-refactor_rust_reduce_unnecessary_id.as_arc_str_.clone_.into_ branch from 2f05628 to d0fcb2f Compare December 30, 2025 14:30

hyf0 force-pushed the 12-30-refactor_rust_remove_moduleid_resource_id_and_use_as_arc_str_directly branch from 1c65de4 to 0859859 Compare December 30, 2025 14:41

hyf0 force-pushed the 12-30-refactor_rust_reduce_unnecessary_id.as_arc_str_.clone_.into_ branch from d0fcb2f to 4267c5d Compare December 30, 2025 14:41

graphite-app bot changed the base branch from 12-30-refactor_rust_remove_moduleid_resource_id_and_use_as_arc_str_directly to graphite-base/7714 December 30, 2025 15:02

graphite-app bot force-pushed the 12-30-refactor_rust_reduce_unnecessary_id.as_arc_str_.clone_.into_ branch from 4267c5d to 7e360fa Compare December 30, 2025 15:11

graphite-app bot force-pushed the graphite-base/7714 branch from 0859859 to 8afbf65 Compare December 30, 2025 15:11

graphite-app bot changed the base branch from graphite-base/7714 to main December 30, 2025 15:12

graphite-app bot force-pushed the 12-30-refactor_rust_reduce_unnecessary_id.as_arc_str_.clone_.into_ branch from 7e360fa to e55767d Compare December 30, 2025 15:12

hyf0 requested review from IWANABETHATGUY and shulaoda December 30, 2025 15:12

shulaoda approved these changes Dec 30, 2025

View reviewed changes

refactor(rust): reduce unnecessary id.as_arc_str().clone().into() (#…

d35c43b

…7714)

graphite-app bot force-pushed the 12-30-refactor_rust_reduce_unnecessary_id.as_arc_str_.clone_.into_ branch from e55767d to d35c43b Compare December 30, 2025 22:00

graphite-app bot merged commit d35c43b into main Dec 30, 2025
34 checks passed

graphite-app bot deleted the 12-30-refactor_rust_reduce_unnecessary_id.as_arc_str_.clone_.into_ branch December 30, 2025 22:11

This was referenced Dec 31, 2025

release: v1.0.0-beta.58 #7719

Closed

release: v1.0.0-beta.58 #7721

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(rust): reduce unnecessary `id.as_arc_str().clone().into()`#7714

refactor(rust): reduce unnecessary `id.as_arc_str().clone().into()`#7714
graphite-app[bot] merged 1 commit intomainfrom
12-30-refactor_rust_reduce_unnecessary_id.as_arc_str_.clone_.into_

hyf0 commented Dec 30, 2025

Uh oh!

hyf0 commented Dec 30, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

github-actions bot commented Dec 30, 2025 •

edited

Loading

Uh oh!

netlify bot commented Dec 30, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Dec 30, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

hyf0 commented Dec 30, 2025

Uh oh!

hyf0 commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

github-actions bot commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

netlify bot commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

graphite-app bot commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

hyf0 commented Dec 30, 2025 •

edited

Loading

github-actions bot commented Dec 30, 2025 •

edited

Loading

netlify bot commented Dec 30, 2025 •

edited

Loading

graphite-app bot commented Dec 30, 2025 •

edited

Loading