chore: pin Node.js version to 24.12.0 LTS in .node-version file#7713
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 30, 2025
Merged
chore: pin Node.js version to 24.12.0 LTS in .node-version file#7713graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
Copilot
AI
changed the title
[WIP] Pin latest LTS Node version in .node_version file
Pin Node.js version to 22.21.1 LTS in .node-version file
Dec 30, 2025
Member
|
@copilot Use Krypton's latest version |
Contributor
Author
Copilot
AI
changed the title
Pin Node.js version to 22.21.1 LTS in .node-version file
Pin Node.js version to 24.12.0 LTS in .node-version file
Dec 30, 2025
Member
Merge activity
|
hyf0
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR pins the Node.js version from the dynamic lts/* specifier to a specific version 24.12.0 to ensure consistent test results across CI runs and developer environments.
Key Changes:
- Changed
.node-versionfromlts/*to24.12.0
Justification:
- The
lts/*specifier resolves dynamically, causing inconsistent test results as the LTS version changes - The validation script
scripts/misc/setup-prerequisites/node.jswas broken bylts/*(parsing it resulted inNaN) - Pinning to a semver version fixes the validation script and ensures reproducible builds
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shulaoda
approved these changes
Dec 30, 2025
The `lts/*` specifier in `.node-version` resolves dynamically, causing inconsistent test results across CI runs and developer environments as the LTS version changes over time. ### Changes - Pin `.node-version` to `24.12.0` (latest Node.js 24 Krypton LTS) ### Additional Context The `scripts/misc/setup-prerequisites/node.js` validation script was also broken—parsing `lts/*` resulted in `NaN`, silently bypassing version checks. A pinned semver version fixes this. <!-- START COPILOT CODING AGENT SUFFIX --> <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> > Pin latest lts node version in `.node_version` file. Explain the reason in PR that node version affects the test results of repo, not fixed version leads different results. </details> <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey).
graphite-app
bot
force-pushed
the
copilot/pin-node-version-in-file
branch
from
846380e to
f27a586
Compare
shulaoda
added a commit
that referenced
this pull request
Dec 31, 2025
## [1.0.0-beta.58] - 2025-12-31 ### 💥 BREAKING CHANGES - experimental/devtools: rename InputOptions#debug to InputOptions#devtools (#7686) by @Copilot ### 🚀 Features - implement target feature check in `should_transform_js` for raw options (#7697) by @shulaoda - support `output.dynamicImportInCjs` option (#7677) by @shulaoda - types: expose `ChecksOptions` type (#7653) by @sapphi-red ### 🐛 Bug Fixes - export runtime helpers for cross-chunk access (#7658) by @shulaoda - cjs namespace merging regression (#7665) by @IWANABETHATGUY - replace panic with proper error handling for hash placeholder generation (#7661) by @shulaoda - remove the blank line between shebang and postBanner (#7643) by @btea - rolldown_plugin_vite_reporter: apply padding before ANSI coloring for proper size column alignment (#7649) by @shulaoda ### 🚜 Refactor - rust: use `StableModuleId` as the map key if possible (#7718) by @hyf0 - rust: return `StableModuleId` instead of `&str` from `Module#stable_id()` (#7717) by @hyf0 - rust: return correct stable id of external module from `Module#stable_id()` (#7716) by @hyf0 - rust: introduce `StableModuleId` type (#7715) by @hyf0 - rust: reduce unnecessary `id.as_arc_str().clone().into()` (#7714) by @hyf0 - rust: remove `ModuleId#resource_id` and use `as_arc_str` directly (#7710) by @hyf0 - rust: remove unused `Module#id_clone` (#7709) by @hyf0 - rust: remove `Module#id_as_str` and use `Module#id` directly (#7708) by @hyf0 - consolidate namespace call analysis into import analyzer (#7657) by @IWANABETHATGUY - rust: make `ExternalModule#id` have the type `ModuleId` (#7707) by @hyf0 - rust: rename `Module#id` to `Module#id_as_str` (#7706) by @hyf0 - rust: use `ModuleId` instead of raw `ArcStr` for `ScanStageCache` (#7701) by @hyf0 - simplify error propagation in cache merge (#7702) by @shulaoda - use `ModuleId` as the type of `ResolvedId#id` (#7694) by @hyf0 - types: rename `resolved_request_info.rs` to `resolved_id.rs` and move its contents (#7687) by @hyf0 - devtools: emit data to `<CWD>/node_modules/.rolldown` (#7692) by @hyf0 - use `InvalidOption` for hash placeholder generation errors (#7674) by @shulaoda - rolldown_error: remove dependency on rolldown_utils (#7672) by @shulaoda - use nodejs-built-in-modules v1.0.0 directly in callsites (#7667) by @Boshen ### 📚 Documentation - migrate input options content from options to auto gen docs (#7663) by @mdong1909 - create reference index page (#7659) by @mdong1909 - tweak auto-generated reference output (#7654) by @sapphi-red - initialize auto-gen docs (#7252) by @mdong1909 ### ⚙️ Miscellaneous Tasks - deps: update napi (#7705) by @renovate[bot] - pin Node.js version to 24.12.0 LTS in .node-version file (#7713) by @Copilot - update esbuild test reasons (#7703) by @sapphi-red - deps: update crate-ci/typos action to v1.40.1 (#7696) by @renovate[bot] - deps: update oxc to v0.106.0 (#7512) by @renovate[bot] - js: replace dprint with oxfmt (#7214) by @Boshen - deps: update dependency oxlint to v1.36.0 (#7691) by @renovate[bot] - deps: update github-actions (#7679) by @renovate[bot] - deps: update npm packages (#7680) by @renovate[bot] - deps: update rust crates (#7678) by @renovate[bot] - deps: update oxc resolver to v11.16.2 (#7668) by @renovate[bot] - add API reference files to knip entry points (#7669) by @Copilot - deps: update notify (#7651) by @sapphi-red - add `homepage` field to package.json (#7648) by @trivikr - deps: update oxc resolver to v11.16.1 (#7647) by @renovate[bot] - deps: update rolldown-plugin-dts to 0.20.0 (#7645) by @shulaoda Co-authored-by: shulaoda <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lts/*specifier in.node-versionresolves dynamically, causing inconsistent test results across CI runs and developer environments as the LTS version changes over time.Changes
.node-versionto24.12.0(latest Node.js 24 Krypton LTS)Additional Context
The
scripts/misc/setup-prerequisites/node.jsvalidation script was also broken—parsinglts/*resulted inNaN, silently bypassing version checks. A pinned semver version fixes this.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.