refactor(rust): make `ExternalModule#id` have the type `ModuleId` by hyf0 · Pull Request #7707 · rolldown/rolldown

hyf0 · 2025-12-30T08:35:50Z

No description provided.

hyf0 · 2025-12-30T08:36:11Z

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

This PR refactors the ExternalModule struct to use ModuleId instead of ArcStr for its id field, making it consistent with how NormalModule already handles module IDs.

Key Changes:

Changed ExternalModule#id field type from ArcStr to ModuleId
Updated ExternalModuleTaskResult#id field type from ArcStr to ModuleId
Adjusted method calls to use ModuleId API methods (as_arc_str(), as_str())

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
`crates/rolldown_common/src/module_loader/task_result.rs`	Added `ModuleId` import and changed `ExternalModuleTaskResult#id` from `ArcStr` to `ModuleId`
`crates/rolldown_common/src/module/mod.rs`	Updated `Module::id_clone()` to call `v.id.as_arc_str()` for external modules instead of `&v.id`
`crates/rolldown_common/src/module/external_module.rs`	Changed `ExternalModule#id` field and constructor parameter from `ArcStr` to `ModuleId`, updated `get_file_name()` to use `self.id.as_str()`
`crates/rolldown/src/module_loader/external_module_task.rs`	Simplified code to clone `resolved_id.id` directly instead of calling `as_arc_str().clone()`

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2025-12-30T08:59:41Z

Benchmarks Rust

target: 12-30-refactor_rust_rename_module_id_to_module_id_as_str_(b4ff474)
pr: 12-30-refactor_rust_make_externalmodule_id_have_the_type_moduleid_(a21d7f2)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     62.5±1.80ms        ? ?/sec    1.02     64.0±1.66ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     68.7±3.64ms        ? ?/sec    1.01     69.5±1.47ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    103.2±1.46ms        ? ?/sec    1.02    104.8±5.08ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    117.7±2.02ms        ? ?/sec    1.00    117.8±1.86ms        ? ?/sec
bundle/bundle@threejs                                        1.01     39.6±2.18ms        ? ?/sec    1.00     39.4±0.52ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     43.4±0.65ms        ? ?/sec    1.00     43.4±0.54ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    388.6±5.01ms        ? ?/sec    1.01    391.0±6.86ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    454.8±6.32ms        ? ?/sec    1.01    459.6±4.40ms        ? ?/sec
scan/scan@rome_ts                                            1.00     79.7±1.06ms        ? ?/sec    1.00     79.5±1.10ms        ? ?/sec
scan/scan@threejs                                            1.00     28.0±1.68ms        ? ?/sec    1.00     28.1±1.79ms        ? ?/sec
scan/scan@threejs10x                                         1.00    281.6±2.73ms        ? ?/sec    1.01    283.8±7.02ms        ? ?/sec

graphite-app · 2025-12-30T09:22:14Z

Merge activity

Dec 30, 9:22 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
Dec 30, 9:36 AM UTC: hyf0 added this pull request to the Graphite merge queue.
Dec 30, 9:47 AM UTC: Merged by the Graphite merge queue.

)

netlify · 2025-12-30T09:37:46Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`21e1bd0`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/69539d3694af8a0008b28fc5

@shulaoda

## [1.0.0-beta.58] - 2025-12-31 ### 💥 BREAKING CHANGES - experimental/devtools: rename InputOptions#debug to InputOptions#devtools (#7686) by @Copilot ### 🚀 Features - implement target feature check in `should_transform_js` for raw options (#7697) by @shulaoda - support `output.dynamicImportInCjs` option (#7677) by @shulaoda - types: expose `ChecksOptions` type (#7653) by @sapphi-red ### 🐛 Bug Fixes - export runtime helpers for cross-chunk access (#7658) by @shulaoda - cjs namespace merging regression (#7665) by @IWANABETHATGUY - replace panic with proper error handling for hash placeholder generation (#7661) by @shulaoda - remove the blank line between shebang and postBanner (#7643) by @btea - rolldown_plugin_vite_reporter: apply padding before ANSI coloring for proper size column alignment (#7649) by @shulaoda ### 🚜 Refactor - rust: use `StableModuleId` as the map key if possible (#7718) by @hyf0 - rust: return `StableModuleId` instead of `&str` from `Module#stable_id()` (#7717) by @hyf0 - rust: return correct stable id of external module from `Module#stable_id()` (#7716) by @hyf0 - rust: introduce `StableModuleId` type (#7715) by @hyf0 - rust: reduce unnecessary `id.as_arc_str().clone().into()` (#7714) by @hyf0 - rust: remove `ModuleId#resource_id` and use `as_arc_str` directly (#7710) by @hyf0 - rust: remove unused `Module#id_clone` (#7709) by @hyf0 - rust: remove `Module#id_as_str` and use `Module#id` directly (#7708) by @hyf0 - consolidate namespace call analysis into import analyzer (#7657) by @IWANABETHATGUY - rust: make `ExternalModule#id` have the type `ModuleId` (#7707) by @hyf0 - rust: rename `Module#id` to `Module#id_as_str` (#7706) by @hyf0 - rust: use `ModuleId` instead of raw `ArcStr` for `ScanStageCache` (#7701) by @hyf0 - simplify error propagation in cache merge (#7702) by @shulaoda - use `ModuleId` as the type of `ResolvedId#id` (#7694) by @hyf0 - types: rename `resolved_request_info.rs` to `resolved_id.rs` and move its contents (#7687) by @hyf0 - devtools: emit data to `<CWD>/node_modules/.rolldown` (#7692) by @hyf0 - use `InvalidOption` for hash placeholder generation errors (#7674) by @shulaoda - rolldown_error: remove dependency on rolldown_utils (#7672) by @shulaoda - use nodejs-built-in-modules v1.0.0 directly in callsites (#7667) by @Boshen ### 📚 Documentation - migrate input options content from options to auto gen docs (#7663) by @mdong1909 - create reference index page (#7659) by @mdong1909 - tweak auto-generated reference output (#7654) by @sapphi-red - initialize auto-gen docs (#7252) by @mdong1909 ### ⚙️ Miscellaneous Tasks - deps: update napi (#7705) by @renovate[bot] - pin Node.js version to 24.12.0 LTS in .node-version file (#7713) by @Copilot - update esbuild test reasons (#7703) by @sapphi-red - deps: update crate-ci/typos action to v1.40.1 (#7696) by @renovate[bot] - deps: update oxc to v0.106.0 (#7512) by @renovate[bot] - js: replace dprint with oxfmt (#7214) by @Boshen - deps: update dependency oxlint to v1.36.0 (#7691) by @renovate[bot] - deps: update github-actions (#7679) by @renovate[bot] - deps: update npm packages (#7680) by @renovate[bot] - deps: update rust crates (#7678) by @renovate[bot] - deps: update oxc resolver to v11.16.2 (#7668) by @renovate[bot] - add API reference files to knip entry points (#7669) by @Copilot - deps: update notify (#7651) by @sapphi-red - add `homepage` field to package.json (#7648) by @trivikr - deps: update oxc resolver to v11.16.1 (#7647) by @renovate[bot] - deps: update rolldown-plugin-dts to 0.20.0 (#7645) by @shulaoda Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned hyf0 Dec 30, 2025

This was referenced Dec 30, 2025

refactor(rust): rename Module#id to Module#id_as_str #7706

Merged

refactor(rust): remove Module#id_as_str and use Module#id directly #7708

Merged

hyf0 marked this pull request as ready for review December 30, 2025 08:36

Copilot AI review requested due to automatic review settings December 30, 2025 08:36

Copilot started reviewing on behalf of hyf0 December 30, 2025 08:37 View session

Copilot AI reviewed Dec 30, 2025

View reviewed changes

hyf0 requested review from IWANABETHATGUY and shulaoda December 30, 2025 08:43

hyf0 force-pushed the 12-30-refactor_rust_make_externalmodule_id_have_the_type_moduleid_ branch from 22bd4a6 to a21d7f2 Compare December 30, 2025 08:43

hyf0 force-pushed the 12-30-refactor_rust_rename_module_id_to_module_id_as_str_ branch from 130f3bf to b4ff474 Compare December 30, 2025 08:43

hyf0 mentioned this pull request Dec 30, 2025

refactor(rust): remove unused Module#id_clone #7709

Merged

shulaoda approved these changes Dec 30, 2025

View reviewed changes

hyf0 mentioned this pull request Dec 30, 2025

refactor(rust): remove ModuleId#resource_id and use as_arc_str directly #7710

Merged

graphite-app bot added the graphite: merge-when-ready label Dec 30, 2025

graphite-app bot changed the base branch from 12-30-refactor_rust_rename_module_id_to_module_id_as_str_ to graphite-base/7707 December 30, 2025 09:03

hyf0 force-pushed the 12-30-refactor_rust_make_externalmodule_id_have_the_type_moduleid_ branch from a21d7f2 to ae2e951 Compare December 30, 2025 09:21

hyf0 force-pushed the graphite-base/7707 branch from b4ff474 to f26c993 Compare December 30, 2025 09:21

graphite-app bot changed the base branch from graphite-base/7707 to main December 30, 2025 09:22

refactor(rust): make ExternalModule#id have the type ModuleId (#7707

21e1bd0

)

graphite-app bot force-pushed the 12-30-refactor_rust_make_externalmodule_id_have_the_type_moduleid_ branch from ae2e951 to 21e1bd0 Compare December 30, 2025 09:36

graphite-app bot merged commit 21e1bd0 into main Dec 30, 2025
33 checks passed

graphite-app bot deleted the 12-30-refactor_rust_make_externalmodule_id_have_the_type_moduleid_ branch December 30, 2025 09:47

graphite-app bot removed the graphite: merge-when-ready label Dec 30, 2025

This was referenced Dec 30, 2025

refactor(rust): reduce unnecessary id.as_arc_str().clone().into() #7714

Merged

refactor(rust): introduce StableModuleId type #7715

Merged

This was referenced Dec 31, 2025

release: v1.0.0-beta.58 #7719

Closed

release: v1.0.0-beta.58 #7721

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(rust): make `ExternalModule#id` have the type `ModuleId`#7707

refactor(rust): make `ExternalModule#id` have the type `ModuleId`#7707
graphite-app[bot] merged 1 commit intomainfrom
12-30-refactor_rust_make_externalmodule_id_have_the_type_moduleid_

hyf0 commented Dec 30, 2025

Uh oh!

hyf0 commented Dec 30, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions bot commented Dec 30, 2025

Uh oh!

graphite-app bot commented Dec 30, 2025 •

edited

Loading

Uh oh!

netlify bot commented Dec 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

hyf0 commented Dec 30, 2025

Uh oh!

hyf0 commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

github-actions bot commented Dec 30, 2025

Benchmarks Rust

Uh oh!

graphite-app bot commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

netlify bot commented Dec 30, 2025

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

hyf0 commented Dec 30, 2025 •

edited

Loading

graphite-app bot commented Dec 30, 2025 •

edited

Loading