Skip to content

chore: add API reference files to knip entry points#7669

Merged
sapphi-red merged 2 commits intomainfrom
copilot/fix-ci-failure
Dec 26, 2025
Merged

chore: add API reference files to knip entry points#7669
sapphi-red merged 2 commits intomainfrom
copilot/fix-ci-failure

Conversation

Copy link
Contributor

Copilot AI commented Dec 26, 2025

The CI "Lint exports & dependencies" check was failing because knip couldn't resolve the dependency chain for recently added API reference documentation files.

Changes

  • Added .vitepress/theme/components/api.index.md and ApiIndex.vue as explicit entry points in knip.jsonc
  • Added pattern .vitepress/theme/components/*.data.{js,ts} to catch VitePress data loader files

The api.index.md file is copied to reference/index.md during docs build, so its imports resolve relative to that destination path rather than the source location where knip analyzes it.

Original prompt

Fix ci failure in https://github.com/rolldown/rolldown/actions/runs/20521242803/job/58956826320?pr=7667


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@netlify
Copy link

netlify bot commented Dec 26, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 49a3f10
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/694e6eedc23e00000707dd62

Copilot AI changed the title [WIP] Fix CI failure in RollDown Actions fix: add API reference files to knip entry points Dec 26, 2025
Copilot AI requested a review from IWANABETHATGUY December 26, 2025 11:22
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review December 26, 2025 11:26
Copilot AI review requested due to automatic review settings December 26, 2025 11:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a CI failure in the "Lint exports & dependencies" check by adding missing entry points to knip's configuration for recently added API reference documentation files.

  • Added explicit entry points for api.index.md and ApiIndex.vue files that are part of the API reference system
  • Added a glob pattern to catch VitePress data loader files in the components directory

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sapphi-red sapphi-red changed the title fix: add API reference files to knip entry points chore: add API reference files to knip entry points Dec 26, 2025
@sapphi-red sapphi-red merged commit 20e1576 into main Dec 26, 2025
39 of 41 checks passed
@sapphi-red sapphi-red deleted the copilot/fix-ci-failure branch December 26, 2025 12:23
This was referenced Dec 31, 2025
shulaoda added a commit that referenced this pull request Dec 31, 2025
## [1.0.0-beta.58] - 2025-12-31

### 💥 BREAKING CHANGES

- experimental/devtools: rename InputOptions#debug to InputOptions#devtools (#7686) by @Copilot

### 🚀 Features

- implement target feature check in `should_transform_js` for raw options (#7697) by @shulaoda
- support `output.dynamicImportInCjs` option (#7677) by @shulaoda
- types: expose `ChecksOptions` type (#7653) by @sapphi-red

### 🐛 Bug Fixes

- export runtime helpers for cross-chunk access (#7658) by @shulaoda
- cjs namespace merging regression (#7665) by @IWANABETHATGUY
- replace panic with proper error handling for hash placeholder generation (#7661) by @shulaoda
- remove the blank line between shebang and postBanner (#7643) by @btea
- rolldown_plugin_vite_reporter: apply padding before ANSI coloring for proper size column alignment (#7649) by @shulaoda

### 🚜 Refactor

- rust: use `StableModuleId` as the map key if possible (#7718) by @hyf0
- rust: return `StableModuleId` instead of `&str` from `Module#stable_id()` (#7717) by @hyf0
- rust: return correct stable id of external module from `Module#stable_id()` (#7716) by @hyf0
- rust: introduce `StableModuleId` type (#7715) by @hyf0
- rust: reduce unnecessary `id.as_arc_str().clone().into()` (#7714) by @hyf0
- rust: remove `ModuleId#resource_id` and use `as_arc_str` directly (#7710) by @hyf0
- rust: remove unused `Module#id_clone` (#7709) by @hyf0
- rust: remove `Module#id_as_str` and use `Module#id` directly (#7708) by @hyf0
- consolidate namespace call analysis into import analyzer (#7657) by @IWANABETHATGUY
- rust: make `ExternalModule#id` have the type `ModuleId` (#7707) by @hyf0
- rust: rename `Module#id` to `Module#id_as_str` (#7706) by @hyf0
- rust: use `ModuleId` instead of raw `ArcStr` for `ScanStageCache` (#7701) by @hyf0
- simplify error propagation in cache merge (#7702) by @shulaoda
- use `ModuleId` as the type of `ResolvedId#id` (#7694) by @hyf0
- types: rename `resolved_request_info.rs` to `resolved_id.rs` and move its contents (#7687) by @hyf0
- devtools: emit data to `<CWD>/node_modules/.rolldown` (#7692) by @hyf0
- use `InvalidOption` for hash placeholder generation errors (#7674) by @shulaoda
- rolldown_error: remove dependency on rolldown_utils (#7672) by @shulaoda
- use nodejs-built-in-modules v1.0.0 directly in callsites (#7667) by @Boshen

### 📚 Documentation

- migrate input options content from options to auto gen docs (#7663) by @mdong1909
- create reference index page (#7659) by @mdong1909
- tweak auto-generated reference output (#7654) by @sapphi-red
- initialize auto-gen docs (#7252) by @mdong1909

### ⚙️ Miscellaneous Tasks

- deps: update napi (#7705) by @renovate[bot]
- pin Node.js version to 24.12.0 LTS in .node-version file (#7713) by @Copilot
- update esbuild test reasons (#7703) by @sapphi-red
- deps: update crate-ci/typos action to v1.40.1 (#7696) by @renovate[bot]
- deps: update oxc to v0.106.0 (#7512) by @renovate[bot]
- js: replace dprint with oxfmt (#7214) by @Boshen
- deps: update dependency oxlint to v1.36.0 (#7691) by @renovate[bot]
- deps: update github-actions (#7679) by @renovate[bot]
- deps: update npm packages (#7680) by @renovate[bot]
- deps: update rust crates (#7678) by @renovate[bot]
- deps: update oxc resolver to v11.16.2 (#7668) by @renovate[bot]
- add API reference files to knip entry points (#7669) by @Copilot
- deps: update notify (#7651) by @sapphi-red
- add `homepage` field to package.json (#7648) by @trivikr
- deps: update oxc resolver to v11.16.1 (#7647) by @renovate[bot]
- deps: update rolldown-plugin-dts to 0.20.0 (#7645) by @shulaoda

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments