fix: export runtime helpers for cross-chunk access by shulaoda · Pull Request #7658 · rolldown/rolldown

shulaoda · 2025-12-25T21:06:50Z

shulaoda · 2025-12-25T21:07:09Z

fix: export runtime helpers for cross-chunk access #7658 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2025-12-25T21:07:51Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`233b5d1`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/694da7c533c28400085cf399

Copilot

Pull request overview

This PR fixes issues #7655 and #7656 by enabling runtime helpers to be exported from entry chunks in CJS/IIFE/UMD formats, allowing other chunks to access them across chunk boundaries.

Key Changes

Modified chunk export rendering logic to export runtime helpers (like __commonJSMin) from entry chunks for non-ESM modules
Added filtering to exclude module-owned exports while retaining cross-chunk runtime helpers
Added test case demonstrating the fix where a dynamically imported chunk can access runtime helpers from the main entry chunk

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`crates/rolldown/src/utils/chunk/render_chunk_exports.rs`	Inverted export condition logic to allow exporting runtime helpers from non-ESM entry chunks, filtering to only export symbols not owned by the module itself
`crates/rolldown/tests/rolldown/issues/7655/main.js`	New test entry point with dynamic import
`crates/rolldown/tests/rolldown/issues/7655/a.js`	New test module using CommonJS exports
`crates/rolldown/tests/rolldown/issues/7655/_config.json`	Test configuration specifying CJS output format
`crates/rolldown/tests/rolldown/issues/7655/artifacts.snap`	Snapshot showing expected output with runtime helper exported from main.js and imported by a.js
`crates/rolldown/tests/snapshots/integration_rolldown__filename_with_hash.snap`	Updated snapshot with hash mappings for new test case chunks

Comments suppressed due to low confidence (1)

crates/rolldown/src/utils/chunk/render_chunk_exports.rs:184

The comment explaining why __proto__ requires special handling has been removed. This comment provided valuable context about JavaScript semantics - that assigning to __proto__ sets the prototype rather than creating a property, which is why Object.defineProperty must be used. Removing this documentation makes the code less maintainable and the special case harder to understand for future developers.

                    } else if exported_name.as_str() == "__proto__" {
                      // `__proto__` has special semantics - assigning to it sets the prototype

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/rolldown/tests/rolldown/issues/7655/artifacts.snap

github-actions · 2025-12-25T21:24:08Z

Benchmarks Rust

target: main(dbd0f6d)
pr: 12-26-fix_export_runtime_helpers_for_cross-chunk_access(233b5d1)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     63.1±1.28ms        ? ?/sec    1.00     63.3±1.21ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     69.4±1.37ms        ? ?/sec    1.00     69.6±1.31ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    110.2±3.03ms        ? ?/sec    1.00    108.3±2.04ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    123.2±2.95ms        ? ?/sec    1.00    122.2±2.78ms        ? ?/sec
bundle/bundle@threejs                                        1.00     38.6±0.55ms        ? ?/sec    1.03     39.8±2.18ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     42.4±0.49ms        ? ?/sec    1.00     42.6±0.56ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    401.4±9.05ms        ? ?/sec    1.01    403.6±9.37ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    455.2±9.34ms        ? ?/sec    1.01   459.1±10.16ms        ? ?/sec
scan/scan@rome_ts                                            1.02     84.5±1.43ms        ? ?/sec    1.00     83.2±1.34ms        ? ?/sec
scan/scan@threejs                                            1.03     28.9±1.66ms        ? ?/sec    1.00     28.2±0.51ms        ? ?/sec
scan/scan@threejs10x                                         1.00    297.8±5.22ms        ? ?/sec    1.00    296.9±5.30ms        ? ?/sec

hyf0 · 2025-12-26T06:37:17Z

While this PR fixes the problem, I don't understand why it works and how the errro is caused.

crates/rolldown/src/utils/chunk/render_chunk_exports.rs

closes #7655, #7656

@shulaoda

## [1.0.0-beta.58] - 2025-12-31 ### 💥 BREAKING CHANGES - experimental/devtools: rename InputOptions#debug to InputOptions#devtools (#7686) by @Copilot ### 🚀 Features - implement target feature check in `should_transform_js` for raw options (#7697) by @shulaoda - support `output.dynamicImportInCjs` option (#7677) by @shulaoda - types: expose `ChecksOptions` type (#7653) by @sapphi-red ### 🐛 Bug Fixes - export runtime helpers for cross-chunk access (#7658) by @shulaoda - cjs namespace merging regression (#7665) by @IWANABETHATGUY - replace panic with proper error handling for hash placeholder generation (#7661) by @shulaoda - remove the blank line between shebang and postBanner (#7643) by @btea - rolldown_plugin_vite_reporter: apply padding before ANSI coloring for proper size column alignment (#7649) by @shulaoda ### 🚜 Refactor - rust: use `StableModuleId` as the map key if possible (#7718) by @hyf0 - rust: return `StableModuleId` instead of `&str` from `Module#stable_id()` (#7717) by @hyf0 - rust: return correct stable id of external module from `Module#stable_id()` (#7716) by @hyf0 - rust: introduce `StableModuleId` type (#7715) by @hyf0 - rust: reduce unnecessary `id.as_arc_str().clone().into()` (#7714) by @hyf0 - rust: remove `ModuleId#resource_id` and use `as_arc_str` directly (#7710) by @hyf0 - rust: remove unused `Module#id_clone` (#7709) by @hyf0 - rust: remove `Module#id_as_str` and use `Module#id` directly (#7708) by @hyf0 - consolidate namespace call analysis into import analyzer (#7657) by @IWANABETHATGUY - rust: make `ExternalModule#id` have the type `ModuleId` (#7707) by @hyf0 - rust: rename `Module#id` to `Module#id_as_str` (#7706) by @hyf0 - rust: use `ModuleId` instead of raw `ArcStr` for `ScanStageCache` (#7701) by @hyf0 - simplify error propagation in cache merge (#7702) by @shulaoda - use `ModuleId` as the type of `ResolvedId#id` (#7694) by @hyf0 - types: rename `resolved_request_info.rs` to `resolved_id.rs` and move its contents (#7687) by @hyf0 - devtools: emit data to `<CWD>/node_modules/.rolldown` (#7692) by @hyf0 - use `InvalidOption` for hash placeholder generation errors (#7674) by @shulaoda - rolldown_error: remove dependency on rolldown_utils (#7672) by @shulaoda - use nodejs-built-in-modules v1.0.0 directly in callsites (#7667) by @Boshen ### 📚 Documentation - migrate input options content from options to auto gen docs (#7663) by @mdong1909 - create reference index page (#7659) by @mdong1909 - tweak auto-generated reference output (#7654) by @sapphi-red - initialize auto-gen docs (#7252) by @mdong1909 ### ⚙️ Miscellaneous Tasks - deps: update napi (#7705) by @renovate[bot] - pin Node.js version to 24.12.0 LTS in .node-version file (#7713) by @Copilot - update esbuild test reasons (#7703) by @sapphi-red - deps: update crate-ci/typos action to v1.40.1 (#7696) by @renovate[bot] - deps: update oxc to v0.106.0 (#7512) by @renovate[bot] - js: replace dprint with oxfmt (#7214) by @Boshen - deps: update dependency oxlint to v1.36.0 (#7691) by @renovate[bot] - deps: update github-actions (#7679) by @renovate[bot] - deps: update npm packages (#7680) by @renovate[bot] - deps: update rust crates (#7678) by @renovate[bot] - deps: update oxc resolver to v11.16.2 (#7668) by @renovate[bot] - add API reference files to knip entry points (#7669) by @Copilot - deps: update notify (#7651) by @sapphi-red - add `homepage` field to package.json (#7648) by @trivikr - deps: update oxc resolver to v11.16.1 (#7647) by @renovate[bot] - deps: update rolldown-plugin-dts to 0.20.0 (#7645) by @shulaoda Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned shulaoda Dec 25, 2025

shulaoda requested review from IWANABETHATGUY and hyf0 December 25, 2025 21:07

shulaoda marked this pull request as ready for review December 25, 2025 21:07

Copilot AI review requested due to automatic review settings December 25, 2025 21:07

fix: export runtime helpers for cross-chunk access

233b5d1

Copilot started reviewing on behalf of shulaoda December 25, 2025 21:07 View session

shulaoda force-pushed the 12-26-fix_export_runtime_helpers_for_cross-chunk_access branch from f57c855 to 233b5d1 Compare December 25, 2025 21:08

Copilot AI reviewed Dec 25, 2025

View reviewed changes

crates/rolldown/tests/rolldown/issues/7655/artifacts.snap Show resolved Hide resolved

hyf0 assigned hyf0 and unassigned shulaoda Dec 26, 2025

hyf0 reviewed Dec 28, 2025

View reviewed changes

crates/rolldown/src/utils/chunk/render_chunk_exports.rs Show resolved Hide resolved

hyf0 approved these changes Dec 29, 2025

View reviewed changes

IWANABETHATGUY approved these changes Dec 29, 2025

View reviewed changes

shulaoda merged commit c080d79 into main Dec 29, 2025
34 checks passed

shulaoda deleted the 12-26-fix_export_runtime_helpers_for_cross-chunk_access branch December 29, 2025 07:36

IWANABETHATGUY pushed a commit that referenced this pull request Dec 30, 2025

fix: export runtime helpers for cross-chunk access (#7658)

4e73253

closes #7655, #7656

This was referenced Dec 31, 2025

release: v1.0.0-beta.58 #7719

Closed

release: v1.0.0-beta.58 #7721

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: export runtime helpers for cross-chunk access#7658

fix: export runtime helpers for cross-chunk access#7658
shulaoda merged 1 commit intomainfrom
12-26-fix_export_runtime_helpers_for_cross-chunk_access

shulaoda commented Dec 25, 2025 •

edited

Loading

Uh oh!

shulaoda commented Dec 25, 2025

Uh oh!

netlify bot commented Dec 25, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

github-actions bot commented Dec 25, 2025

Uh oh!

hyf0 commented Dec 26, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

shulaoda commented Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shulaoda commented Dec 25, 2025

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Uh oh!

github-actions bot commented Dec 25, 2025

Benchmarks Rust

Uh oh!

hyf0 commented Dec 26, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

shulaoda commented Dec 25, 2025 •

edited

Loading

netlify bot commented Dec 25, 2025 •

edited

Loading