Skip to content

Comments

feat(rolldown_plugin_vite_reporter): support custom logger for build infos#7652

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-25-feat_rolldown_plugin_vite_reporter_support_custom_logger_for_build_infos
Feb 13, 2026
Merged

feat(rolldown_plugin_vite_reporter): support custom logger for build infos#7652
graphite-app[bot] merged 1 commit intomainfrom
12-25-feat_rolldown_plugin_vite_reporter_support_custom_logger_for_build_infos

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Dec 25, 2025

Copy link
Member Author

shulaoda commented Dec 25, 2025


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Dec 25, 2025

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit cdd9719
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/698f46fbbda935000842a102
😎 Deploy Preview https://deploy-preview-7652--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@shulaoda shulaoda force-pushed the 12-25-feat_rolldown_plugin_vite_reporter_support_custom_logger_for_build_infos branch from bdd4d3f to 2d9bba6 Compare December 25, 2025 08:19
@shulaoda shulaoda force-pushed the 12-25-feat_rolldown_plugin_vite_reporter_support_custom_logger_for_build_infos branch from 2d9bba6 to e00cb01 Compare February 13, 2026 03:54
@shulaoda shulaoda requested a review from sapphi-red February 13, 2026 03:59
@shulaoda shulaoda marked this pull request as ready for review February 13, 2026 03:59
Copilot AI review requested due to automatic review settings February 13, 2026 03:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for routing Vite reporter “build info” output through a user-provided logger callback (instead of always printing to stdout), exposed through the JS/TS binding config.

Changes:

  • Extend BindingViteReporterPluginConfig (TS + NAPI) with a logInfo/log_info callback.
  • Update ViteReporterPlugin to aggregate write-bundle info output and emit it via the provided logger.
  • Add Rust deps needed for async callback typing and debuggability (anyhow, derive_more).

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/rolldown/src/binding.d.cts Adds logInfo callback to the TS-facing reporter plugin config type.
crates/rolldown_plugin_vite_reporter/src/lib.rs Introduces log_info callback field and uses it for final build info emission.
crates/rolldown_plugin_vite_reporter/Cargo.toml Adds dependencies to support the new async callback type + Debug derive.
crates/rolldown_binding/src/options/plugin/config/binding_vite_reporter_plugin_config.rs Wires a JS callback into the Rust plugin as an async log_info function.
Cargo.lock Records the new Rust dependency additions.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2026

Benchmarks Rust

  • target: main(26fc459)
  • pr: 12-25-feat_rolldown_plugin_vite_reporter_support_custom_logger_for_build_infos(d68ea2d)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.07     87.4±2.82ms        ? ?/sec    1.00     81.5±3.08ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.06     94.0±2.47ms        ? ?/sec    1.00     88.3±2.08ms        ? ?/sec
bundle/bundle@rome_ts                                        1.03    113.3±2.41ms        ? ?/sec    1.00    110.0±1.94ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.02    124.1±2.39ms        ? ?/sec    1.00    121.2±2.47ms        ? ?/sec
bundle/bundle@threejs                                        1.02     40.5±2.28ms        ? ?/sec    1.00     39.9±1.08ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.03     44.9±1.45ms        ? ?/sec    1.00     43.7±0.69ms        ? ?/sec
bundle/bundle@threejs10x                                     1.03    405.6±4.35ms        ? ?/sec    1.00    393.1±8.85ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.04    462.7±5.17ms        ? ?/sec    1.00    445.9±5.16ms        ? ?/sec
scan/scan@rome_ts                                            1.02     86.7±1.73ms        ? ?/sec    1.00     84.7±1.61ms        ? ?/sec
scan/scan@threejs                                            1.02     29.6±0.43ms        ? ?/sec    1.00     29.0±0.42ms        ? ?/sec
scan/scan@threejs10x                                         1.02    292.5±3.38ms        ? ?/sec    1.00    287.1±4.64ms        ? ?/sec

@shulaoda shulaoda force-pushed the 12-25-feat_rolldown_plugin_vite_reporter_support_custom_logger_for_build_infos branch from e00cb01 to d68ea2d Compare February 13, 2026 10:27
@shulaoda shulaoda requested a review from sapphi-red February 13, 2026 10:27
Copy link
Member

@hyf0 hyf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing positive significantly. Let's merge it first.

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 13, 2026

Merge activity

Copilot AI review requested due to automatic review settings February 13, 2026 15:44
@graphite-app graphite-app bot force-pushed the 12-25-feat_rolldown_plugin_vite_reporter_support_custom_logger_for_build_infos branch from d68ea2d to cdd9719 Compare February 13, 2026 15:44
@shulaoda shulaoda review requested due to automatic review settings February 13, 2026 15:44
@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedutil-deprecate@​1.0.21001008375100
Addedpicomatch@​4.0.310010010085100
Addedtypescript@​5.9.31001009010090
Addedsemver@​7.7.410010010090100

View full report

@graphite-app graphite-app bot merged commit cdd9719 into main Feb 13, 2026
35 checks passed
@graphite-app graphite-app bot deleted the 12-25-feat_rolldown_plugin_vite_reporter_support_custom_logger_for_build_infos branch February 13, 2026 15:54
shulaoda pushed a commit that referenced this pull request Feb 18, 2026
## [1.0.0-rc.5] - 2026-02-18

💡 Smarter `entriesAware` Manual Code Splitting                                                                 
                                             
New `entriesAware` and `entriesAwareMergeThreshold` options for `manualCodeSplitting.groups[]` enable              
entry-reachability-based chunk splitting with automatic small chunk merging.                                       
                                                                                                                   
- `entriesAware: true` splits matched modules by entry reachability — modules reached by the same set of entries are grouped together, providing the most precise loading behavior with less over-fetching
- Chunks now get more readable names reflecting their entry associations (e.g. `vendor-entry-a-entry-b.js`) instead of opaque hashes
- `entriesAwareMergeThreshold` sets a byte-size threshold to merge tiny subgroups into the closest sibling with the fewest extra entries, reducing micro-chunk fragmentation while preserving precision
- Recommended to use together with `maxSize`: merge tiny chunks first to reduce request overhead, then cap large chunks to control payload size

```js
manualCodeSplitting: {
  groups: [{
    name: 'vendor',
    test: /node_modules/,
    entriesAware: true,
    entriesAwareMergeThreshold: 28000, // bytes
  }]
}
```

### 🚀 Features

- add `Visitor` to `rolldown/utils` (#8373) by @sapphi-red
- module-info: add `inputFormat` property to `ModuleInfo` (#8329) by @shulaoda
- default `treeshake.invalid_import_side_effects` to `false` (#8357) by @sapphi-red
- rolldown_utils: add `IndexBitSet` (#8343) by @sapphi-red
- rolldown_utils: add more methods and trait impls to BitSet (#8342) by @sapphi-red
- rolldown_plugin_vite_build_import_analysis: add support for `await import().then((m) => m.prop)` (#8328) by @sapphi-red
- rolldown_plugin_vite_reporter: support custom logger for build infos (#7652) by @shulaoda
- rust/mcs: support `entriesAwareMergeThreshold` (#8312) by @hyf0
- mcs: `maxSize` will split the oversized chunk with taking file relevance into account (#8277) by @hyf0
- rolldown_plugin_vite_import_glob: support template literal in glob import patterns (#8298) by @shulaoda
- rolldown_plugin_chunk_import_map: output importmap without spaces (#8297) by @sapphi-red
- add INEFFECTIVE_DYNAMIC_IMPORT warning in core (#8284) by @shulaoda
- mcs: generate more readable name for `entriesAware` chunks (#8275) by @hyf0
- mcs: support `entriesAware` (#8274) by @hyf0

### 🐛 Bug Fixes

- improve circular dependency detection in chunk optimizer (#8371) by @IWANABETHATGUY
- align `minify.compress: true` and `minify.mangle: true` with `minify: true` (#8367) by @sapphi-red
- rolldown_plugin_esm_external_require: apply conversion to UMD and IIFE outputs (#8359) by @sapphi-red
- cjs: bailout treeshaking on cjs modules that have multiple re-exports (#8348) by @hyf0
- handle member expression and this expression in JSX element name rewriting (#8323) by @IWANABETHATGUY
- pad `encode_hash_with_base` output to fixed length to prevent slice panics (#8320) by @shulaoda
- `xxhash_with_base` skips hashing when input is exactly 16 bytes (#8319) by @shulaoda
- complete `ImportKind::try_from` with missing variants and correct `url-import` to `url-token` (#8310) by @shulaoda
- mark Node.js builtin modules as side-effect-free when resolved via `external` config (#8304) by @IWANABETHATGUY
- mcs: `maxSize` should split chunks correctly based on sizes (#8289) by @hyf0

### 🚜 Refactor

- introduce `RawMangleOptions` and `RawCompressOptions` (#8366) by @sapphi-red
- mcs: refactor `apply_manual_code_splitting` into `ManualSplitter` (#8346) by @hyf0
- rolldown_plugin_vite_reporter: simplify hook registration and remove redundant state (#8322) by @shulaoda
- use set to store user defined entry modules (#8315) by @IWANABETHATGUY
- rust/mcs: collect groups into map at first for having clean and performant operations (#8313) by @hyf0
- mcs: introduce newtype `ModuleGroupOrigin` and `ModuleGroupId` (#8311) by @hyf0
- remove unnecessary `FinalizerMutableState` struct (#8303) by @shulaoda
- move module finalization into `finalize_modules` (#8302) by @shulaoda
- extract `apply_transfer_parts_mutation` into its own module (#8301) by @shulaoda
- move ESM format check into `determine_export_mode` (#8294) by @shulaoda
- remove `warnings` field from `GenerateContext` (#8293) by @shulaoda
- extract util function remove clippy supression (#8290) by @IWANABETHATGUY
- move `is_in_node_modules` to `PathExt` trait in `rolldown_std_utils` (#8286) by @shulaoda
- rolldown_plugin_vite_reporter: remove unnecessary ineffective dynamic import detection logic (#8285) by @shulaoda
- dev: inject hmr runtime to `\0rolldown/runtime.js` (#8234) by @hyf0
- improve naming in chunk_optimizer (#8287) by @IWANABETHATGUY
- simplify PostChunkOptimizationOperation from bitflags to enum (#8283) by @IWANABETHATGUY
- optimize BitSet.index_of_one to return iterator instead of Vec (#8282) by @IWANABETHATGUY

### 📚 Documentation

- change default value in `format` JSDoc from `'esm'` to `'es'` (#8372) by @shulaoda
- in-depth: remove `invalidImportSideEffects` option mention from lazy barrel optimization doc (#8355) by @sapphi-red
- mcs: clarify `minSize` constraints (#8279) by @ShroXd

### ⚡ Performance

- use IndexVec for chunk TLA detection (#8341) by @sapphi-red
- only invoke single resolve call for the same specifier and import kind (#8332) by @sapphi-red
- rolldown_plugin_vite_reporter: skip gzip computation when `report_compressed_size` is disabled (#8321) by @shulaoda

### 🧪 Testing

- use `vi.waitFor` and `expect.poll` instead of custom `waitUtil` function (#8369) by @sapphi-red
- rolldown_plugin_esm_external_require_plugin: add tests (#8358) by @sapphi-red
- add watch file tests (#8330) by @sapphi-red
- rolldown_plugin_vite_build_import_analysis: add test for dynamic import treeshaking (#8327) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- prepare-release: skip workflow on forked repositories (#8368) by @shulaoda
- format more files (#8360) by @sapphi-red
- deps: update oxc to v0.114.0 (#8347) by @camc314
- deps: update test262 submodule for tests (#8354) by @sapphi-red
- deps: update crate-ci/typos action to v1.43.5 (#8350) by @renovate[bot]
- deps: update oxc apps (#8351) by @renovate[bot]
- rolldown_plugin_vite_reporter: remove unnecessary README.md (#8334) by @shulaoda
- deps: update npm packages (#8338) by @renovate[bot]
- deps: update rust crates (#8339) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.13.0 (#8337) by @renovate[bot]
- deps: update github-actions (#8336) by @renovate[bot]
- deps: update napi to v3.8.3 (#8331) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.12.2 (#8325) by @renovate[bot]
- remove unnecessary transform.decorator (#8314) by @IWANABETHATGUY
- deps: update dependency rust to v1.93.1 (#8305) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.12.1 (#8300) by @renovate[bot]
- deps: update oxc apps (#8296) by @renovate[bot]
- docs: don't skip for build runs without cache (#8281) by @sapphi-red
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to filter module info logs from rolldown

3 participants