refactor(dev): use direct module id instead of stable id#7638
Closed
refactor(dev): use direct module id instead of stable id#7638
Conversation
Member
Author
How to use the Graphite Merge QueueAdd the label graphite: merge-when-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
✅ Deploy Preview for rolldown-rs canceled.
|
hyf0
force-pushed
the
12-23-refactor_dev_use_direct_module_id_instead_of_stable_id
branch
from
f67dd49 to
67d3c72
Compare
hyf0
force-pushed
the
12-23-refactor_dev_use_direct_module_id_instead_of_stable_id
branch
from
67d3c72 to
be947d9
Compare
hyf0
changed the base branch from
graphite-base/7638
to
12-29-refactor_use_normalizedid_to_ensure_consistent_behavior_for_id
This was referenced Dec 29, 2025
Merged
hyf0
force-pushed
the
12-23-refactor_dev_use_direct_module_id_instead_of_stable_id
branch
2 times, most recently
from
2acd769 to
bd5d717
Compare
hyf0
force-pushed
the
12-29-refactor_use_normalizedid_to_ensure_consistent_behavior_for_id
branch
from
3f00fd2 to
aaaea8d
Compare
graphite-app
bot
force-pushed
the
12-29-refactor_use_normalizedid_to_ensure_consistent_behavior_for_id
branch
2 times, most recently
from
a3db8c3 to
cbe5fe8
Compare
graphite-app
bot
force-pushed
the
12-23-refactor_dev_use_direct_module_id_instead_of_stable_id
branch
from
bd5d717 to
18634e0
Compare
hyf0
force-pushed
the
12-29-refactor_use_normalizedid_to_ensure_consistent_behavior_for_id
branch
from
cbe5fe8 to
30cbc23
Compare
hyf0
force-pushed
the
12-23-refactor_dev_use_direct_module_id_instead_of_stable_id
branch
from
18634e0 to
db8b546
Compare
hyf0
changed the base branch from
12-29-refactor_use_normalizedid_to_ensure_consistent_behavior_for_id
to
graphite-base/7638
hyf0
force-pushed
the
graphite-base/7638
branch
from
30cbc23 to
9258689
Compare
hyf0
force-pushed
the
12-23-refactor_dev_use_direct_module_id_instead_of_stable_id
branch
from
db8b546 to
8bf9a5d
Compare
hyf0
force-pushed
the
12-23-refactor_dev_use_direct_module_id_instead_of_stable_id
branch
from
8bf9a5d to
b8da361
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's very annoying to calculate between stable id and id. The intial purpose of using stable id is for portable cache, which is in a very far future. So change to use module id directly for convenience.