chore(docs): fix Netlify ignore condition to detect docs changes across all PR commits#7637
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 23, 2025
Merged
Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
Copilot
AI
changed the title
[WIP] Update Netlify build conditions for docs folder
Fix Netlify ignore condition to detect docs changes across all PR commits
Dec 23, 2025
hyf0
changed the title
Member
Merge activity
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the Netlify build ignore condition to properly detect documentation changes across all commits in a pull request. The previous implementation using HEAD^ only compared against the immediate parent commit, which could miss docs changes from earlier commits in a PR.
Key Changes:
- Updated git diff comparison to use
$CACHED_COMMIT_REFinstead ofHEAD^to compare against the last deployed commit
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shulaoda
approved these changes
Dec 23, 2025
…ss all PR commits (#7637) The Netlify build ignore condition used `HEAD^` which only compares against the immediate parent commit. This fails to trigger docs builds when earlier commits in a PR touch the docs folder but the latest commit doesn't. **Change:** - Replace `HEAD^` with `$CACHED_COMMIT_REF` to compare against the last deployed commit ```toml # Before ignore = "git diff --quiet 'HEAD^' HEAD ./docs ./packages/rolldown" # After ignore = "git diff --quiet $CACHED_COMMIT_REF HEAD ./docs ./packages/rolldown" ``` `CACHED_COMMIT_REF` is a Netlify environment variable containing the SHA of the last successful deployment, ensuring all commits in a PR are considered. <!-- START COPILOT CODING AGENT SUFFIX --> <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> > Could you fix https://github.com/rolldown/rolldown/blob/main/docs/netlify.toml#L3? > > The condition is too limited. We want to trigger docs build as long the PR contains any commit that touches docs folder </details> <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey).
graphite-app
bot
force-pushed
the
copilot/update-docs-build-conditions
branch
from
56421ee to
beeb5ec
Compare
This was referenced Dec 24, 2025
shulaoda
added a commit
that referenced
this pull request
Dec 24, 2025
## [1.0.0-beta.57] - 2025-12-24 ✨ TypeScript Project References Support - Rolldown now supports TypeScript project references when manually specifying a `tsconfig` - See more details: https://rolldown.rs/options/tsconfig 💥 Rename `__export` to `__exportAll` - Update `rolldown-plugin-dts` to the latest version for compatibility ### 💥 BREAKING CHANGES - tsconfig: enable project references support in manual mode (#7545) by @shulaoda ### 🚀 Features - add `CANNOT_CALL_NAMESPACE` warning (#7636) by @sapphi-red - add import path for unresolved import diagnostics (#7625) by @sapphi-red - optimize dynamic entry facade chunks by merging with common chunks when they are captured by common chunks (#7486) by @IWANABETHATGUY ### 🐛 Bug Fixes - rename `__export` to `__exportAll` to be compatible with `cjs-module-lexer` (#7640) by @IWANABETHATGUY - strip UTF-8 BOM when using text loader (#7635) by @sapphi-red - rolldown_plugin_replace: avoid crashing with invalid delimiters (#7621) by @sapphi-red ### 🚜 Refactor - export all filter functions (#7622) by @sxzz - allow multiple help messages in diagnostics (#7624) by @sapphi-red ### 📚 Documentation - add README.md to packages/rolldown (#7556) by @Copilot ### ⚡ Performance - use fsevents on macOS for file watching (#7596) by @sapphi-red ### 🧪 Testing - handle re-exports of external modules in CJS format (#7641) by @IWANABETHATGUY - update integration to use vite's rolldown-canary branch (#7633) by @shulaoda ### ⚙️ Miscellaneous Tasks - docs: fix Netlify ignore condition to detect docs changes across all PR commits (#7637) by @Copilot - deps: update rollup submodule for tests to v4.54.0 (#7630) by @sapphi-red - skip benchmarks for PRs with 'graphite: merge-when-ready' label (#7631) by @Boshen - deps: update esbuild for tests to 0.27.2 (#7629) by @sapphi-red - fix "update-test-dependencies" workflow (#7628) by @sapphi-red - deps: update test262 submodule for tests (#7626) by @sapphi-red - deps: update dependency oxlint to v1.35.0 (#7623) by @renovate[bot] Co-authored-by: shulaoda <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Netlify build ignore condition used
HEAD^which only compares against the immediate parent commit. This fails to trigger docs builds when earlier commits in a PR touch the docs folder but the latest commit doesn't.Change:
HEAD^with$CACHED_COMMIT_REFto compare against the last deployed commitCACHED_COMMIT_REFis a Netlify environment variable containing the SHA of the last successful deployment, ensuring all commits in a PR are considered.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.