Skip to content

Comments

feat: add CANNOT_CALL_NAMESPACE warning#7636

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-23-feat_add_cannot_call_namespace_warning
Dec 23, 2025
Merged

feat: add CANNOT_CALL_NAMESPACE warning#7636
graphite-app[bot] merged 1 commit intomainfrom
12-23-feat_add_cannot_call_namespace_warning

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Dec 23, 2025

Added CANNOT_CALL_NAMESPACE warning which exists in Rollup. This warning also exists in esbuild.

Copy link
Member Author

sapphi-red commented Dec 23, 2025


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red force-pushed the 12-23-feat_add_cannot_call_namespace_warning branch from 56b3681 to 341fe9c Compare December 23, 2025 11:09
@sapphi-red sapphi-red marked this pull request as ready for review December 23, 2025 11:11
Copy link
Member Author

sapphi-red commented Dec 23, 2025

Merge activity

  • Dec 23, 11:11 AM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 23, 11:24 AM UTC: sapphi-red added this pull request to the Graphite merge queue.
  • Dec 23, 11:27 AM UTC: The Graphite merge queue couldn't merge this PR because it had merge conflicts.
  • Dec 23, 11:58 AM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 23, 12:10 PM UTC: sapphi-red added this pull request to the Graphite merge queue.
  • Dec 23, 12:21 PM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot changed the base branch from 12-22-fix_strip_utf-8_bom_when_using_text_loader to graphite-base/7636 December 23, 2025 11:15
@github-actions
Copy link
Contributor

Benchmarks Rust

  • target: 12-22-fix_strip_utf-8_bom_when_using_text_loader(9c88984)
  • pr: 12-23-feat_add_cannot_call_namespace_warning(341fe9c)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.03     63.9±1.37ms        ? ?/sec    1.00     61.7±1.22ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.06     72.5±2.22ms        ? ?/sec    1.00     68.4±1.14ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    107.0±1.62ms        ? ?/sec    1.00    106.8±2.69ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    119.3±1.69ms        ? ?/sec    1.00    118.3±1.40ms        ? ?/sec
bundle/bundle@threejs                                        1.04     41.0±1.60ms        ? ?/sec    1.00     39.3±0.61ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.02     43.3±0.84ms        ? ?/sec    1.00     42.5±0.58ms        ? ?/sec
bundle/bundle@threejs10x                                     1.04    404.5±6.10ms        ? ?/sec    1.00    389.9±5.89ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.02    459.4±5.27ms        ? ?/sec    1.00    449.8±3.61ms        ? ?/sec
scan/scan@rome_ts                                            1.00     84.1±1.40ms        ? ?/sec    1.00     84.1±1.46ms        ? ?/sec
scan/scan@threejs                                            1.02     28.8±1.80ms        ? ?/sec    1.00     28.3±0.35ms        ? ?/sec
scan/scan@threejs10x                                         1.00    293.5±4.30ms        ? ?/sec    1.00    294.7±4.84ms        ? ?/sec

@graphite-app graphite-app bot changed the base branch from graphite-base/7636 to main December 23, 2025 11:27
@sapphi-red sapphi-red force-pushed the 12-23-feat_add_cannot_call_namespace_warning branch from 341fe9c to 7b08280 Compare December 23, 2025 11:58
@netlify
Copy link

netlify bot commented Dec 23, 2025

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 81913ca
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/694a86a2ea7e3b0008dcfebf
😎 Deploy Preview https://deploy-preview-7636--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Added `CANNOT_CALL_NAMESPACE` warning which exists in Rollup. This warning also exists in esbuild.
@graphite-app graphite-app bot force-pushed the 12-23-feat_add_cannot_call_namespace_warning branch from 7b08280 to 81913ca Compare December 23, 2025 12:10
.with_severity_warning(),
);
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@graphite-app graphite-app bot merged commit 81913ca into main Dec 23, 2025
33 checks passed
@graphite-app graphite-app bot deleted the 12-23-feat_add_cannot_call_namespace_warning branch December 23, 2025 12:21
This was referenced Dec 24, 2025
shulaoda added a commit that referenced this pull request Dec 24, 2025
## [1.0.0-beta.57] - 2025-12-24

✨ TypeScript Project References Support
- Rolldown now supports TypeScript project references when manually specifying a `tsconfig`
- See more details: https://rolldown.rs/options/tsconfig

💥 Rename `__export` to `__exportAll`
- Update `rolldown-plugin-dts` to the latest version for compatibility

### 💥 BREAKING CHANGES

- tsconfig: enable project references support in manual mode (#7545) by @shulaoda

### 🚀 Features

- add `CANNOT_CALL_NAMESPACE` warning (#7636) by @sapphi-red
- add import path for unresolved import diagnostics (#7625) by @sapphi-red
- optimize dynamic entry facade chunks by merging with common chunks when they are captured by common chunks (#7486) by @IWANABETHATGUY

### 🐛 Bug Fixes

- rename `__export` to `__exportAll` to be compatible with `cjs-module-lexer` (#7640) by @IWANABETHATGUY
- strip UTF-8 BOM when using text loader (#7635) by @sapphi-red
- rolldown_plugin_replace: avoid crashing with invalid delimiters (#7621) by @sapphi-red

### 🚜 Refactor

- export all filter functions (#7622) by @sxzz
- allow multiple help messages in diagnostics (#7624) by @sapphi-red

### 📚 Documentation

- add README.md to packages/rolldown (#7556) by @Copilot

### ⚡ Performance

- use fsevents on macOS for file watching (#7596) by @sapphi-red

### 🧪 Testing

- handle re-exports of external modules in CJS format (#7641) by @IWANABETHATGUY
- update integration to use vite's rolldown-canary branch (#7633) by @shulaoda

### ⚙️ Miscellaneous Tasks

- docs: fix Netlify ignore condition to detect docs changes across all PR commits (#7637) by @Copilot
- deps: update rollup submodule for tests to v4.54.0 (#7630) by @sapphi-red
- skip benchmarks for PRs with 'graphite: merge-when-ready' label (#7631) by @Boshen
- deps: update esbuild for tests to 0.27.2 (#7629) by @sapphi-red
- fix "update-test-dependencies" workflow (#7628) by @sapphi-red
- deps: update test262 submodule for tests (#7626) by @sapphi-red
- deps: update dependency oxlint to v1.35.0 (#7623) by @renovate[bot]

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants