ci: fix event type handling in benchmark workflows#7632
Merged
hyf0 merged 3 commits intoskip-benchmarks-graphite-mergefrom Dec 23, 2025
Merged
ci: fix event type handling in benchmark workflows#7632hyf0 merged 3 commits intoskip-benchmarks-graphite-mergefrom
hyf0 merged 3 commits intoskip-benchmarks-graphite-mergefrom
Conversation
Co-authored-by: hyf0 <[email protected]>
Copilot
AI
changed the title
[WIP] Update CI to address feedback and optimize benchmark node job
ci: fix event type handling in benchmark workflows
Dec 23, 2025
Member
|
@copilot Change the label name to |
Co-authored-by: hyf0 <[email protected]>
Contributor
Author
Copilot stopped work on behalf of
hyf0 due to an error
December 23, 2025 03:34
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes event type handling in benchmark workflows to ensure jobs run correctly for both pull request and non-pull request events (push, workflow_dispatch), while also updating label filtering to skip PRs marked with the 'graphite: merge-when-ready' label.
- Updated conditional logic to properly handle non-PR events by adding
github.event_name != 'pull_request' ||checks - Changed label filter from 'graphite: merge' to 'graphite: merge-when-ready' across all benchmark jobs
- Added label filtering to the
benchmark-nodejob which previously lacked it
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/benchmark-rust.yml |
Updated conditions for codspeed-benchmark job to handle non-PR events and updated label name for both codspeed-benchmark and benchmark-rust jobs |
.github/workflows/benchmark-node.yml |
Added conditional check to benchmark-node job to skip draft PRs and those with 'graphite: merge-when-ready' label, and to allow non-PR events |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Benchmarks Rust |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
codspeed-benchmarkjob in benchmark-rust.yml to handle non-PR eventsbenchmark-nodejob in benchmark-node.yml to skip 'graphite: merge-when-ready' labeled PRs💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.