Skip to content

Comments

ci: skip benchmarks for PRs with 'graphite: merge-when-ready' label#7631

Merged
graphite-app[bot] merged 1 commit intomainfrom
skip-benchmarks-graphite-merge
Dec 23, 2025
Merged

ci: skip benchmarks for PRs with 'graphite: merge-when-ready' label#7631
graphite-app[bot] merged 1 commit intomainfrom
skip-benchmarks-graphite-merge

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Dec 23, 2025

Summary

Skip running benchmark jobs when a PR has the graphite: merge-when-ready label to avoid redundant benchmark runs when Graphite rebases and retriggers CI.

Changes

  • Updated codspeed-benchmark job to skip when PR has graphite: merge-when-ready label
  • Updated benchmark-rust job to skip when PR has graphite: merge-when-ready label
  • Updated benchmark-node job to skip when PR has graphite: merge-when-ready label

When Graphite rebases PRs in a stack, it retriggers all CI jobs including benchmarks. Since the benchmarks were already run on the original commit, there's no need to run them again after a simple rebase.

Copilot AI review requested due to automatic review settings December 23, 2025 03:10
@Boshen Boshen assigned hyf0 and unassigned Boshen Dec 23, 2025
@netlify
Copy link

netlify bot commented Dec 23, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 144a773
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/694a1078b074d600070ce226

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds logic to skip benchmark jobs when a PR has the graphite: merge label, avoiding redundant benchmark runs when Graphite rebases and retriggers CI.

Key Changes

  • Modified the codspeed-benchmark job condition to skip when PR has graphite: merge label
  • Modified the benchmark-rust job condition to skip when PR has graphite: merge label

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

Benchmarks Rust

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.09     69.6±1.93ms        ? ?/sec    1.00     63.7±1.77ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     70.4±2.52ms        ? ?/sec    1.00     69.6±1.92ms        ? ?/sec
bundle/bundle@rome_ts                                        1.03    112.5±3.13ms        ? ?/sec    1.00    108.7±2.21ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.05    126.6±2.49ms        ? ?/sec    1.00    121.0±2.24ms        ? ?/sec
bundle/bundle@threejs                                        1.04     41.5±0.59ms        ? ?/sec    1.00     39.8±1.00ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.04     45.1±0.97ms        ? ?/sec    1.00     43.3±0.85ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    393.9±5.25ms        ? ?/sec    1.02    403.6±7.06ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    458.2±6.35ms        ? ?/sec    1.02    469.3±8.94ms        ? ?/sec
scan/scan@rome_ts                                            1.00     85.5±2.58ms        ? ?/sec    1.01     86.6±2.56ms        ? ?/sec
scan/scan@threejs                                            1.00     28.6±0.35ms        ? ?/sec    1.03     29.4±0.39ms        ? ?/sec
scan/scan@threejs10x                                         1.00    299.2±4.88ms        ? ?/sec    1.02    306.2±7.76ms        ? ?/sec

Copy link
Contributor

Copilot AI commented Dec 23, 2025

@hyf0 I've opened a new pull request, #7632, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Member

hyf0 commented Dec 23, 2025

Merge activity

@hyf0 hyf0 changed the title ci: skip benchmarks for PRs with 'graphite: merge' label ci: skip benchmarks for PRs with 'graphite: merge-when-ready' label Dec 23, 2025
…7631)

## Summary

Skip running benchmark jobs when a PR has the `graphite: merge-when-ready` label to avoid redundant benchmark runs when Graphite rebases and retriggers CI.

### Changes

- Updated `codspeed-benchmark` job to skip when PR has `graphite: merge-when-ready` label
- Updated `benchmark-rust` job to skip when PR has `graphite: merge-when-ready` label
- Updated `benchmark-node` job to skip when PR has `graphite: merge-when-ready` label

When Graphite rebases PRs in a stack, it retriggers all CI jobs including benchmarks. Since the benchmarks were already run on the original commit, there's no need to run them again after a simple rebase.
@graphite-app graphite-app bot force-pushed the skip-benchmarks-graphite-merge branch from c430cfa to 144a773 Compare December 23, 2025 03:45
@graphite-app graphite-app bot merged commit 144a773 into main Dec 23, 2025
35 checks passed
@graphite-app graphite-app bot deleted the skip-benchmarks-graphite-merge branch December 23, 2025 03:55
This was referenced Dec 24, 2025
shulaoda added a commit that referenced this pull request Dec 24, 2025
## [1.0.0-beta.57] - 2025-12-24

✨ TypeScript Project References Support
- Rolldown now supports TypeScript project references when manually specifying a `tsconfig`
- See more details: https://rolldown.rs/options/tsconfig

💥 Rename `__export` to `__exportAll`
- Update `rolldown-plugin-dts` to the latest version for compatibility

### 💥 BREAKING CHANGES

- tsconfig: enable project references support in manual mode (#7545) by @shulaoda

### 🚀 Features

- add `CANNOT_CALL_NAMESPACE` warning (#7636) by @sapphi-red
- add import path for unresolved import diagnostics (#7625) by @sapphi-red
- optimize dynamic entry facade chunks by merging with common chunks when they are captured by common chunks (#7486) by @IWANABETHATGUY

### 🐛 Bug Fixes

- rename `__export` to `__exportAll` to be compatible with `cjs-module-lexer` (#7640) by @IWANABETHATGUY
- strip UTF-8 BOM when using text loader (#7635) by @sapphi-red
- rolldown_plugin_replace: avoid crashing with invalid delimiters (#7621) by @sapphi-red

### 🚜 Refactor

- export all filter functions (#7622) by @sxzz
- allow multiple help messages in diagnostics (#7624) by @sapphi-red

### 📚 Documentation

- add README.md to packages/rolldown (#7556) by @Copilot

### ⚡ Performance

- use fsevents on macOS for file watching (#7596) by @sapphi-red

### 🧪 Testing

- handle re-exports of external modules in CJS format (#7641) by @IWANABETHATGUY
- update integration to use vite's rolldown-canary branch (#7633) by @shulaoda

### ⚙️ Miscellaneous Tasks

- docs: fix Netlify ignore condition to detect docs changes across all PR commits (#7637) by @Copilot
- deps: update rollup submodule for tests to v4.54.0 (#7630) by @sapphi-red
- skip benchmarks for PRs with 'graphite: merge-when-ready' label (#7631) by @Boshen
- deps: update esbuild for tests to 0.27.2 (#7629) by @sapphi-red
- fix "update-test-dependencies" workflow (#7628) by @sapphi-red
- deps: update test262 submodule for tests (#7626) by @sapphi-red
- deps: update dependency oxlint to v1.35.0 (#7623) by @renovate[bot]

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants