Skip to content

Comments

ci: fix "update-test-dependencies" workflow#7628

Merged
sapphi-red merged 1 commit intomainfrom
12-23-ci_fix_update-test-dependencies_workflow
Dec 23, 2025
Merged

ci: fix "update-test-dependencies" workflow#7628
sapphi-red merged 1 commit intomainfrom
12-23-ci_fix_update-test-dependencies_workflow

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Dec 23, 2025

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Dec 23, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit d14233c
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6949f52d8147d700085f10b8

@sapphi-red
Copy link
Member Author

Worked: #7629, #7630

@sapphi-red sapphi-red marked this pull request as ready for review December 23, 2025 01:59
Copilot AI review requested due to automatic review settings December 23, 2025 01:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the "update-test-dependencies" workflow by adding support for processing all esbuild test suites at once and ensuring the native Rolldown build is available before running test generation.

Key changes:

  • Modified gen-tests.ts to accept 'all' as an argument to process all test suites in one run
  • Added a build step in the workflow to compile native Rolldown before generating esbuild tests

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
scripts/src/esbuild-tests/gen-tests.ts Refactored to support processing multiple test suites with a new 'all' argument, wrapping the main processing logic in a loop over suite names
.github/workflows/update-test-dependencies.yml Added native Rolldown build step and updated gen-esbuild-tests command to pass 'all' argument

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sapphi-red sapphi-red merged commit fc663bb into main Dec 23, 2025
45 checks passed
@sapphi-red sapphi-red deleted the 12-23-ci_fix_update-test-dependencies_workflow branch December 23, 2025 02:04
This was referenced Dec 24, 2025
shulaoda added a commit that referenced this pull request Dec 24, 2025
## [1.0.0-beta.57] - 2025-12-24

✨ TypeScript Project References Support
- Rolldown now supports TypeScript project references when manually specifying a `tsconfig`
- See more details: https://rolldown.rs/options/tsconfig

💥 Rename `__export` to `__exportAll`
- Update `rolldown-plugin-dts` to the latest version for compatibility

### 💥 BREAKING CHANGES

- tsconfig: enable project references support in manual mode (#7545) by @shulaoda

### 🚀 Features

- add `CANNOT_CALL_NAMESPACE` warning (#7636) by @sapphi-red
- add import path for unresolved import diagnostics (#7625) by @sapphi-red
- optimize dynamic entry facade chunks by merging with common chunks when they are captured by common chunks (#7486) by @IWANABETHATGUY

### 🐛 Bug Fixes

- rename `__export` to `__exportAll` to be compatible with `cjs-module-lexer` (#7640) by @IWANABETHATGUY
- strip UTF-8 BOM when using text loader (#7635) by @sapphi-red
- rolldown_plugin_replace: avoid crashing with invalid delimiters (#7621) by @sapphi-red

### 🚜 Refactor

- export all filter functions (#7622) by @sxzz
- allow multiple help messages in diagnostics (#7624) by @sapphi-red

### 📚 Documentation

- add README.md to packages/rolldown (#7556) by @Copilot

### ⚡ Performance

- use fsevents on macOS for file watching (#7596) by @sapphi-red

### 🧪 Testing

- handle re-exports of external modules in CJS format (#7641) by @IWANABETHATGUY
- update integration to use vite's rolldown-canary branch (#7633) by @shulaoda

### ⚙️ Miscellaneous Tasks

- docs: fix Netlify ignore condition to detect docs changes across all PR commits (#7637) by @Copilot
- deps: update rollup submodule for tests to v4.54.0 (#7630) by @sapphi-red
- skip benchmarks for PRs with 'graphite: merge-when-ready' label (#7631) by @Boshen
- deps: update esbuild for tests to 0.27.2 (#7629) by @sapphi-red
- fix "update-test-dependencies" workflow (#7628) by @sapphi-red
- deps: update test262 submodule for tests (#7626) by @sapphi-red
- deps: update dependency oxlint to v1.35.0 (#7623) by @renovate[bot]

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant