feat: add import path for unresolved import diagnostics by sapphi-red · Pull Request #7625 · rolldown/rolldown

sapphi-red · 2025-12-22T10:38:05Z

Added a help for UNRESOLVED_IMPORT error to output the import path.

[UNRESOLVED_IMPORT] Error: Could not resolve '../pkg' in node_modules/.pnpm/[email protected]/node_modules/lightningcss/node/index.js
    ╭─[ node_modules/.pnpm/[email protected]/node_modules/lightningcss/node/index.js:17:28 ]
    │
 17 │   module.exports = require(`../pkg`);
    │                            ────┬───  
    │                                ╰───── Module not found.
    │ 
    │ Help: 'node_modules/.pnpm/[email protected]/node_modules/lightningcss/node/index.js' is imported by the following path:
    │         - node_modules/.pnpm/[email protected]/node_modules/lightningcss/node/index.js
    │         - node_modules/.pnpm/[email protected]/node_modules/lightningcss/node/index.mjs
    │         - node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vite/dist/node/chunks/node.js
    │         - node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vite/dist/node/index.js
    │         - src/main.tsx
    │         - index.html
────╯

sapphi-red · 2025-12-22T10:38:21Z

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-12-22T10:59:36Z

Benchmarks Rust

target: main(e434577)
pr: 12-22-feat_add_import_path_for_unresolved_import_diagnostics(3a0e731)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     60.2±0.98ms        ? ?/sec    1.04     62.7±1.38ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     66.6±0.94ms        ? ?/sec    1.05     69.6±1.80ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    105.3±3.06ms        ? ?/sec    1.03    108.2±2.25ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    117.0±2.66ms        ? ?/sec    1.02    119.7±1.99ms        ? ?/sec
bundle/bundle@threejs                                        1.00     38.3±0.45ms        ? ?/sec    1.02     39.0±2.20ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     42.1±0.44ms        ? ?/sec    1.01     42.6±0.84ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    390.8±3.97ms        ? ?/sec    1.02    396.9±8.09ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    454.9±4.79ms        ? ?/sec    1.00    452.3±3.94ms        ? ?/sec
scan/scan@rome_ts                                            1.00     83.0±1.46ms        ? ?/sec    1.02     84.8±1.48ms        ? ?/sec
scan/scan@threejs                                            1.00     28.2±0.36ms        ? ?/sec    1.02     28.6±1.63ms        ? ?/sec
scan/scan@threejs10x                                         1.00    293.3±5.23ms        ? ?/sec    1.03    300.7±5.63ms        ? ?/sec

crates/rolldown/src/module_loader/module_loader.rs

crates/rolldown_error/src/build_diagnostic/events/resolve_error.rs

hyf0 · 2025-12-22T17:26:59Z

Merge activity

Dec 22, 5:26 PM UTC: The merge label 'graphite: merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Dec 23, 1:20 AM UTC: sapphi-red added this pull request to the Graphite merge queue.
Dec 23, 1:35 AM UTC: Merged by the Graphite merge queue.

netlify · 2025-12-22T17:40:09Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`3a0e731`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/6949eed4eb11c000086a1006

Added a help for UNRESOLVED_IMPORT error to output the import path. ``` [UNRESOLVED_IMPORT] Error: Could not resolve '../pkg' in node_modules/.pnpm/[email protected]/node_modules/lightningcss/node/index.js ╭─[ node_modules/.pnpm/[email protected]/node_modules/lightningcss/node/index.js:17:28 ] │ 17 │ module.exports = require(`../pkg`); │ ────┬─── │ ╰───── Module not found. │ │ Help: 'node_modules/.pnpm/[email protected]/node_modules/lightningcss/node/index.js' is imported by the following path: │ - node_modules/.pnpm/[email protected]/node_modules/lightningcss/node/index.js │ - node_modules/.pnpm/[email protected]/node_modules/lightningcss/node/index.mjs │ - node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vite/dist/node/chunks/node.js │ - node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vite/dist/node/index.js │ - src/main.tsx │ - index.html ────╯ ```

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Added a help for UNRESOLVED_IMPORT error to output the import path. ``` [UNRESOLVED_IMPORT] Error: Could not resolve '../pkg' in node_modules/.pnpm/[email protected]/node_modules/lightningcss/node/index.js ╭─[ node_modules/.pnpm/[email protected]/node_modules/lightningcss/node/index.js:17:28 ] │ 17 │ module.exports = require(`../pkg`); │ ────┬─── │ ╰───── Module not found. │ │ Help: 'node_modules/.pnpm/[email protected]/node_modules/lightningcss/node/index.js' is imported by the following path: │ - node_modules/.pnpm/[email protected]/node_modules/lightningcss/node/index.js │ - node_modules/.pnpm/[email protected]/node_modules/lightningcss/node/index.mjs │ - node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vite/dist/node/chunks/node.js │ - node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vite/dist/node/index.js │ - src/main.tsx │ - index.html ────╯ ```

@shulaoda

## [1.0.0-beta.57] - 2025-12-24 ✨ TypeScript Project References Support - Rolldown now supports TypeScript project references when manually specifying a `tsconfig` - See more details: https://rolldown.rs/options/tsconfig 💥 Rename `__export` to `__exportAll` - Update `rolldown-plugin-dts` to the latest version for compatibility ### 💥 BREAKING CHANGES - tsconfig: enable project references support in manual mode (#7545) by @shulaoda ### 🚀 Features - add `CANNOT_CALL_NAMESPACE` warning (#7636) by @sapphi-red - add import path for unresolved import diagnostics (#7625) by @sapphi-red - optimize dynamic entry facade chunks by merging with common chunks when they are captured by common chunks (#7486) by @IWANABETHATGUY ### 🐛 Bug Fixes - rename `__export` to `__exportAll` to be compatible with `cjs-module-lexer` (#7640) by @IWANABETHATGUY - strip UTF-8 BOM when using text loader (#7635) by @sapphi-red - rolldown_plugin_replace: avoid crashing with invalid delimiters (#7621) by @sapphi-red ### 🚜 Refactor - export all filter functions (#7622) by @sxzz - allow multiple help messages in diagnostics (#7624) by @sapphi-red ### 📚 Documentation - add README.md to packages/rolldown (#7556) by @Copilot ### ⚡ Performance - use fsevents on macOS for file watching (#7596) by @sapphi-red ### 🧪 Testing - handle re-exports of external modules in CJS format (#7641) by @IWANABETHATGUY - update integration to use vite's rolldown-canary branch (#7633) by @shulaoda ### ⚙️ Miscellaneous Tasks - docs: fix Netlify ignore condition to detect docs changes across all PR commits (#7637) by @Copilot - deps: update rollup submodule for tests to v4.54.0 (#7630) by @sapphi-red - skip benchmarks for PRs with 'graphite: merge-when-ready' label (#7631) by @Boshen - deps: update esbuild for tests to 0.27.2 (#7629) by @sapphi-red - fix "update-test-dependencies" workflow (#7628) by @sapphi-red - deps: update test262 submodule for tests (#7626) by @sapphi-red - deps: update dependency oxlint to v1.35.0 (#7623) by @renovate[bot] Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned sapphi-red Dec 22, 2025

sapphi-red mentioned this pull request Dec 22, 2025

refactor: allow multiple help messages in diagnostics #7624

Merged

sapphi-red requested review from IWANABETHATGUY and shulaoda December 22, 2025 10:41

sapphi-red marked this pull request as ready for review December 22, 2025 10:44

sapphi-red mentioned this pull request Dec 22, 2025

Add import chain infrastructure for UNRESOLVED_IMPORT errors #7618

Closed

IWANABETHATGUY reviewed Dec 22, 2025

View reviewed changes

crates/rolldown/src/module_loader/module_loader.rs Show resolved Hide resolved

IWANABETHATGUY reviewed Dec 22, 2025

View reviewed changes

crates/rolldown_error/src/build_diagnostic/events/resolve_error.rs Show resolved Hide resolved

IWANABETHATGUY approved these changes Dec 22, 2025

View reviewed changes

hyf0 added the graphite: merge label Dec 22, 2025

hyf0 removed the graphite: merge label Dec 22, 2025

graphite-app bot changed the base branch from 12-22-refactor_allow_multiple_help_messages_in_diagnostics to graphite-base/7625 December 22, 2025 17:27

graphite-app bot force-pushed the 12-22-feat_add_import_path_for_unresolved_import_diagnostics branch from 19af45b to 78c2c6b Compare December 22, 2025 17:38

graphite-app bot force-pushed the graphite-base/7625 branch from 434f788 to 5f12334 Compare December 22, 2025 17:38

graphite-app bot changed the base branch from graphite-base/7625 to main December 22, 2025 17:38

graphite-app bot force-pushed the 12-22-feat_add_import_path_for_unresolved_import_diagnostics branch from 78c2c6b to 061f76c Compare December 22, 2025 17:38

Copilot AI review requested due to automatic review settings December 23, 2025 01:20

graphite-app bot force-pushed the 12-22-feat_add_import_path_for_unresolved_import_diagnostics branch from 061f76c to ed6c962 Compare December 23, 2025 01:20

Copilot AI reviewed Dec 23, 2025

View reviewed changes

graphite-app bot force-pushed the 12-22-feat_add_import_path_for_unresolved_import_diagnostics branch from ed6c962 to 3a0e731 Compare December 23, 2025 01:22

graphite-app bot merged commit 3a0e731 into main Dec 23, 2025
34 checks passed

graphite-app bot deleted the 12-22-feat_add_import_path_for_unresolved_import_diagnostics branch December 23, 2025 01:35

This was referenced Dec 24, 2025

release: v1.0.0-beta.57 #7639

Closed

release: v1.0.0-beta.57 #7642

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

feat: add import path for unresolved import diagnostics#7625

feat: add import path for unresolved import diagnostics#7625
graphite-app[bot] merged 1 commit intomainfrom
12-22-feat_add_import_path_for_unresolved_import_diagnostics

sapphi-red commented Dec 22, 2025 •

edited

Loading

Uh oh!

sapphi-red commented Dec 22, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 22, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

hyf0 commented Dec 22, 2025 •

edited by graphite-app bot

Loading

Uh oh!

netlify bot commented Dec 22, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

sapphi-red commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sapphi-red commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

Uh oh!

Uh oh!

hyf0 commented Dec 22, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

netlify bot commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sapphi-red commented Dec 22, 2025 •

edited

Loading

sapphi-red commented Dec 22, 2025 •

edited

Loading

github-actions bot commented Dec 22, 2025 •

edited

Loading

hyf0 commented Dec 22, 2025 •

edited by graphite-app bot

Loading

netlify bot commented Dec 22, 2025 •

edited

Loading