refactor: export all filter functions#7622
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 22, 2025
Merged
Conversation
✅ Deploy Preview for rolldown-rs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the filter function exports to use wildcard exports instead of explicit named exports, ensuring all filter functions are properly exported. The main change switches from individually listing exports to using export *, which automatically includes previously missing functions like importerId, interpreter, exactRegex, prefixRegex, makeIdFiltersToMatchWithQuery, and filterVitePlugins.
Key Changes:
- Reorganized
@rolldown/pluginutilsto expose all filter functions through a dedicated/filtersubpath export - Updated TypeScript configuration to support the new module resolution strategy with
.tsextensions - Added new utility functions (
exactRegex,prefixRegex,makeIdFiltersToMatchWithQuery) and thefilterVitePluginshelper
Reviewed changes
Copilot reviewed 6 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
packages/rolldown/src/filter-index.ts |
Changed from named exports to wildcard export of pluginutils filters |
packages/pluginutils/tsconfig.json |
Updated module resolution to nodenext and enabled TypeScript extension imports |
packages/pluginutils/src/index.ts |
Simplified to export from new filter directory structure |
packages/pluginutils/src/filter/index.ts |
New index file that aggregates all filter-related exports |
packages/pluginutils/src/filter/simple-filters.ts |
Added utility functions for creating regex filters and query matching |
packages/pluginutils/src/filter/simple-filters.test.ts |
Comprehensive tests for the new simple filter functions |
packages/pluginutils/src/filter/simple-filters.test-d.ts |
Type-level tests for simple filter functions |
packages/pluginutils/src/filter/filter-vite-plugins.ts |
Added function to filter out Vite serve-mode plugins |
packages/pluginutils/src/filter/filter-vite-plugins.test.ts |
Tests for Vite plugin filtering functionality |
packages/pluginutils/src/filter/composable-filters.ts |
Updated import path for utils |
packages/pluginutils/src/filter/composable-filters.test.ts |
Tests for composable filter functions including new importerId filter |
packages/pluginutils/package.json |
Added /filter subpath export configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
IWANABETHATGUY
force-pushed
the
fix/reexport-filter
branch
from
33a07a1 to
a8d74e5
Compare
IWANABETHATGUY
approved these changes
Dec 22, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 12 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sxzz
force-pushed
the
fix/reexport-filter
branch
from
a8d74e5 to
712ef06
Compare
Member
Merge activity
|
Fix missing `resolveId` filter function.
graphite-app
bot
force-pushed
the
fix/reexport-filter
branch
from
712ef06 to
23da10d
Compare
This was referenced Dec 24, 2025
shulaoda
added a commit
that referenced
this pull request
Dec 24, 2025
## [1.0.0-beta.57] - 2025-12-24 ✨ TypeScript Project References Support - Rolldown now supports TypeScript project references when manually specifying a `tsconfig` - See more details: https://rolldown.rs/options/tsconfig 💥 Rename `__export` to `__exportAll` - Update `rolldown-plugin-dts` to the latest version for compatibility ### 💥 BREAKING CHANGES - tsconfig: enable project references support in manual mode (#7545) by @shulaoda ### 🚀 Features - add `CANNOT_CALL_NAMESPACE` warning (#7636) by @sapphi-red - add import path for unresolved import diagnostics (#7625) by @sapphi-red - optimize dynamic entry facade chunks by merging with common chunks when they are captured by common chunks (#7486) by @IWANABETHATGUY ### 🐛 Bug Fixes - rename `__export` to `__exportAll` to be compatible with `cjs-module-lexer` (#7640) by @IWANABETHATGUY - strip UTF-8 BOM when using text loader (#7635) by @sapphi-red - rolldown_plugin_replace: avoid crashing with invalid delimiters (#7621) by @sapphi-red ### 🚜 Refactor - export all filter functions (#7622) by @sxzz - allow multiple help messages in diagnostics (#7624) by @sapphi-red ### 📚 Documentation - add README.md to packages/rolldown (#7556) by @Copilot ### ⚡ Performance - use fsevents on macOS for file watching (#7596) by @sapphi-red ### 🧪 Testing - handle re-exports of external modules in CJS format (#7641) by @IWANABETHATGUY - update integration to use vite's rolldown-canary branch (#7633) by @shulaoda ### ⚙️ Miscellaneous Tasks - docs: fix Netlify ignore condition to detect docs changes across all PR commits (#7637) by @Copilot - deps: update rollup submodule for tests to v4.54.0 (#7630) by @sapphi-red - skip benchmarks for PRs with 'graphite: merge-when-ready' label (#7631) by @Boshen - deps: update esbuild for tests to 0.27.2 (#7629) by @sapphi-red - fix "update-test-dependencies" workflow (#7628) by @sapphi-red - deps: update test262 submodule for tests (#7626) by @sapphi-red - deps: update dependency oxlint to v1.35.0 (#7623) by @renovate[bot] Co-authored-by: shulaoda <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix missing
resolveIdfilter function.