refactor: use `LinkingMetadata::is_included` to check if a module is included by IWANABETHATGUY · Pull Request #7571 · rolldown/rolldown

IWANABETHATGUY · 2025-12-18T09:28:30Z

Use LinkingMetadata::is_included as the single source of truth to determine whether a module is included in the final bundle.

IWANABETHATGUY · 2025-12-18T09:28:47Z

feat: optimize dynamic entry facade chunks by merging with common chunks when they are captured by common chunks #7486
refactor: make include_runtime_symbol reuseable after linking stage #7580
refactor: use LinkingMetadata::stmt_info_included to check if a stmt_info is included #7572
refactor: use LinkingMetadata::is_included to check if a module is included #7571 👈 (View in Graphite)
refactor: store module and stmt_info is included info to module meta #7570
main

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-12-18T09:54:07Z

Benchmarks Rust

target: 12-18-refactor_store_module_and_stmt_info_is_included_info_to_module_meta(68e5c53)
pr: 12-18-refactor_use_meta_is_included_to_check_if_a_module_is_included(31eaa46)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     61.9±1.09ms        ? ?/sec    1.00     62.2±1.05ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     68.1±1.11ms        ? ?/sec    1.00     68.3±1.09ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    105.4±1.49ms        ? ?/sec    1.00    105.9±1.65ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    117.8±1.75ms        ? ?/sec    1.01    119.4±2.34ms        ? ?/sec
bundle/bundle@threejs                                        1.00     38.7±2.57ms        ? ?/sec    1.00     38.9±2.02ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     42.1±0.81ms        ? ?/sec    1.00     42.3±0.93ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    387.1±3.91ms        ? ?/sec    1.00    387.4±5.73ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    445.0±3.86ms        ? ?/sec    1.01    451.0±7.50ms        ? ?/sec
scan/scan@rome_ts                                            1.00     84.2±1.22ms        ? ?/sec    1.03     86.7±1.89ms        ? ?/sec
scan/scan@threejs                                            1.00     28.7±1.60ms        ? ?/sec    1.03     29.6±1.60ms        ? ?/sec
scan/scan@threejs10x                                         1.00    296.5±4.99ms        ? ?/sec    1.01    299.5±5.48ms        ? ?/sec

crates/rolldown/src/stages/generate_stage/advanced_chunks.rs

crates/rolldown/src/stages/generate_stage/code_splitting.rs

crates/rolldown/src/stages/link_stage/patch_module_dependencies.rs

graphite-app · 2025-12-18T16:53:34Z

Merge activity

Dec 18, 4:53 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
Dec 18, 6:34 PM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Dec 18, 6:44 PM UTC: Merged by the Graphite merge queue.

netlify · 2025-12-18T17:20:19Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`35e3261`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/694449644b4a0a0007bf47e4

Copilot

Pull request overview

This PR refactors the module inclusion tracking mechanism to use LinkingMetadata::is_included as the single source of truth, eliminating redundant tracking in EcmaViewMeta.

Key Changes:

Removed Included bitflag from EcmaViewMeta and adjusted remaining flag positions
Removed NormalModule::is_included() method and all direct access to the old flag
Updated all inclusion checks to use metas[idx].is_included instead

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`crates/rolldown_common/src/module/normal_module.rs`	Removed `is_included()` method; updated debug method to accept `is_included` parameter
`crates/rolldown_common/src/ecmascript/ecma_view.rs`	Removed `Included` bitflag and `is_included()` method; adjusted remaining flag bit positions
`crates/rolldown/src/stages/link_stage/tree_shaking/include_statements.rs`	Removed redundant flag set operations; updated debug call site; improved comment clarity
`crates/rolldown/src/stages/link_stage/patch_module_dependencies.rs`	Changed inclusion check to use `metas[idx].is_included`
`crates/rolldown/src/stages/generate_stage/mod.rs`	Updated filter to use `metas[idx].is_included`
`crates/rolldown/src/stages/generate_stage/compute_cross_chunk_links.rs`	Changed inclusion check to use `metas[idx].is_included`
`crates/rolldown/src/stages/generate_stage/code_splitting.rs`	Updated all inclusion checks (6 locations) to use `metas[idx].is_included`
`crates/rolldown/src/stages/generate_stage/advanced_chunks.rs`	Updated inclusion checks to use `metas[idx].is_included`

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…included (#7571) Use `LinkingMetadata::is_included` as the single source of truth to determine whether a module is included in the final bundle.

@sapphi-red

## [1.0.0-beta.56] - 2025-12-22 ### 💥 BREAKING CHANGES - rename `MIXED_EXPORT` error to `MIXED_EXPORTS` (#7565) by @sapphi-red ### 🚀 Features - rename `id` property to `exporter` in CIRCULAR_REEXPORT error (#7592) by @sapphi-red - add `ids` property to `CIRCULAR_DEPENDENCY` error (#7591) by @sapphi-red - node/dev: expose `devMode.lazy` (#7549) by @hyf0 - set log and pos properties for `parseAst` function errors (#7568) by @sapphi-red - set log and pos properties for logs (#7567) by @sapphi-red - test-dev-sever: support to manually configure port, run tests in concurrent (#7576) by @hyf0 - add `exporter` property to `MISSING_EXPORT` error (#7564) by @sapphi-red - add `id` property to `PARSE_ERROR` error (#7563) by @sapphi-red - support ImporterId hook filter (#7540) by @IWANABETHATGUY ### 🐛 Bug Fixes - types: better "go to definition" experience for interface `OutputPlugin` (#7610) by @KazariEX - `postBanner` content should be placed after shebang (#7583) by @btea - use sanitized filename for preserve modules chunk name (#7603) by @IWANABETHATGUY - correct filter out unused cjs namespace (#7602) by @IWANABETHATGUY - watch: property respect `notify.pollInternal` and `notify.compareContents` (#7595) by @sapphi-red - make `cleanDir` work with default output directory (#7579) by @shulaoda - merge `MISSING_NAME_OPTION_FOR_UMD_EXPORT` error to `MISSING_NAME_OPTION_FOR_IIFE_EXPORT` error (#7566) by @sapphi-red - dev/hmr: ensure cjs modules with no exports reference correct `module` identifier (#7544) by @leegeunhyeok ### 🚜 Refactor - remove `stable_id` field from `PARSE_ERROR` error (#7593) by @sapphi-red - make include_runtime_symbol reuseable after linking stage (#7580) by @IWANABETHATGUY - rust/dev: construct the bundler within itself (#7553) by @hyf0 - rust/watcher: polish API of `Watcher` struct (#7551) by @hyf0 - use `LinkingMetadata::stmt_info_included` to check if a stmt_info is included (#7572) by @IWANABETHATGUY - use `LinkingMetadata::is_included` to check if a module is included (#7571) by @IWANABETHATGUY - store module and stmt_info is included info to module meta (#7570) by @IWANABETHATGUY - make include_* method reunsable after linking stage (#7552) by @IWANABETHATGUY - rust/watcher: construct the bundler within watcher itself (#7550) by @hyf0 - extract make include_runtime_symbol reusable (#7546) by @IWANABETHATGUY ### ⚙️ Miscellaneous Tasks - renovate: add `kill-port` in `ignoreDeps` in renovate.json (#7619) by @sapphi-red - deps: update rust crates (#7617) by @renovate[bot] - deps: update npm packages (#7616) by @renovate[bot] - deps: update github-actions (#7615) by @renovate[bot] - ci: skip benchmark workflows on draft PRs (#7611) by @Copilot - deps: update dependency rolldown-plugin-dts to ^0.19.0 (#7607) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.10.0 (#7601) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.18.4 (#7599) by @renovate[bot] - deps: update notify (#7594) by @sapphi-red - test-dev-server: add retry mechanism to hmr-full-bundle-mode tests (#7588) by @Copilot - deps: update napi to v3.7.1 (#7590) by @renovate[bot] - add JSDoc documentation for memfs type (#7587) by @Copilot - deps: update dependency oxlint to v1.34.0 (#7589) by @renovate[bot] - move some tests in ignored-by-unsupported-features that are passing (#7569) by @sapphi-red - deps: update dependency oxlint-tsgolint to v0.9.2 (#7582) by @renovate[bot] - deps: update oxc resolver to v11.16.0 (#7574) by @renovate[bot] - test/dev-server: don't run `pnpm install` during tests (#7560) by @hyf0 - test/dev-server: use `kill-port@1` to improve performance (#7575) by @hyf0 - normalize error object to make some Rollup tests pass (#7562) by @sapphi-red - ci: separate dev-server(hmr) tests and normal tests (#7558) by @hyf0 - ci: make native rolldown build reusable (#7557) by @hyf0 - resolve some TODOs (#7561) by @sapphi-red ### ❤️ New Contributors * @KazariEX made their first contribution in [#7610](#7610) * @leegeunhyeok made their first contribution in [#7544](#7544) Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned IWANABETHATGUY Dec 18, 2025

IWANABETHATGUY mentioned this pull request Dec 18, 2025

refactor: store module and stmt_info is included info to module meta #7570

Merged

IWANABETHATGUY force-pushed the 12-18-refactor_use_meta_is_included_to_check_if_a_module_is_included branch from 2bc9875 to ebdc26c Compare December 18, 2025 09:35

IWANABETHATGUY marked this pull request as ready for review December 18, 2025 09:36

IWANABETHATGUY force-pushed the 12-18-refactor_store_module_and_stmt_info_is_included_info_to_module_meta branch from e70372f to 68e5c53 Compare December 18, 2025 09:38

IWANABETHATGUY force-pushed the 12-18-refactor_use_meta_is_included_to_check_if_a_module_is_included branch from ebdc26c to 31eaa46 Compare December 18, 2025 09:38

IWANABETHATGUY changed the title ~~refactor: use meta is_included to check if a module is included~~ refactor: use LinkingMetadata::is_included to check if a module is included Dec 18, 2025

IWANABETHATGUY requested review from hyf0 and sapphi-red and removed request for hyf0 December 18, 2025 09:55

IWANABETHATGUY mentioned this pull request Dec 18, 2025

refactor: use LinkingMetadata::stmt_info_included to check if a stmt_info is included #7572

Merged

IWANABETHATGUY force-pushed the 12-18-refactor_store_module_and_stmt_info_is_included_info_to_module_meta branch 2 times, most recently from 745d636 to 265c161 Compare December 18, 2025 13:49

IWANABETHATGUY force-pushed the 12-18-refactor_use_meta_is_included_to_check_if_a_module_is_included branch from 31eaa46 to d5c41db Compare December 18, 2025 13:52

IWANABETHATGUY mentioned this pull request Dec 18, 2025

feat: optimize dynamic entry facade chunks by merging with common chunks when they are captured by common chunks #7486

Merged

sapphi-red reviewed Dec 18, 2025

View reviewed changes

IWANABETHATGUY force-pushed the 12-18-refactor_store_module_and_stmt_info_is_included_info_to_module_meta branch from 00cfcb7 to 2745aba Compare December 18, 2025 16:11

graphite-app bot changed the base branch from 12-18-refactor_store_module_and_stmt_info_is_included_info_to_module_meta to graphite-base/7571 December 18, 2025 16:52

IWANABETHATGUY force-pushed the 12-18-refactor_use_meta_is_included_to_check_if_a_module_is_included branch from d5c41db to df8bf9b Compare December 18, 2025 16:53

IWANABETHATGUY force-pushed the graphite-base/7571 branch from 2745aba to 39fcf0c Compare December 18, 2025 16:53

graphite-app bot changed the base branch from graphite-base/7571 to main December 18, 2025 16:53

graphite-app bot force-pushed the 12-18-refactor_use_meta_is_included_to_check_if_a_module_is_included branch from df8bf9b to 473918d Compare December 18, 2025 17:19

Copilot AI review requested due to automatic review settings December 18, 2025 18:03

IWANABETHATGUY force-pushed the 12-18-refactor_use_meta_is_included_to_check_if_a_module_is_included branch from 473918d to 4f8ebd2 Compare December 18, 2025 18:03

Copilot started reviewing on behalf of IWANABETHATGUY December 18, 2025 18:03 View session

Copilot AI reviewed Dec 18, 2025

View reviewed changes

IWANABETHATGUY requested a review from sapphi-red December 18, 2025 18:20

IWANABETHATGUY force-pushed the 12-18-refactor_use_meta_is_included_to_check_if_a_module_is_included branch from 4f8ebd2 to a7c247c Compare December 18, 2025 18:21

sapphi-red approved these changes Dec 18, 2025

View reviewed changes

refactor: use LinkingMetadata::is_included to check if a module is …

35e3261

…included (#7571) Use `LinkingMetadata::is_included` as the single source of truth to determine whether a module is included in the final bundle.

graphite-app bot force-pushed the 12-18-refactor_use_meta_is_included_to_check_if_a_module_is_included branch from a7c247c to 35e3261 Compare December 18, 2025 18:35

graphite-app bot merged commit 35e3261 into main Dec 18, 2025
30 of 31 checks passed

graphite-app bot deleted the 12-18-refactor_use_meta_is_included_to_check_if_a_module_is_included branch December 18, 2025 18:44

IWANABETHATGUY mentioned this pull request Dec 18, 2025

refactor: make include_runtime_symbol reuseable after linking stage #7580

Merged

github-actions bot mentioned this pull request Dec 22, 2025

release: v1.0.0-beta.56 #7620

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

refactor: use `LinkingMetadata::is_included` to check if a module is included#7571

refactor: use `LinkingMetadata::is_included` to check if a module is included#7571
graphite-app[bot] merged 1 commit intomainfrom
12-18-refactor_use_meta_is_included_to_check_if_a_module_is_included

IWANABETHATGUY commented Dec 18, 2025 •

edited

Loading

Uh oh!

IWANABETHATGUY commented Dec 18, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 18, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

graphite-app bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

netlify bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

IWANABETHATGUY commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IWANABETHATGUY commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Dec 18, 2025

Benchmarks Rust

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

graphite-app bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

netlify bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IWANABETHATGUY commented Dec 18, 2025 •

edited

Loading

IWANABETHATGUY commented Dec 18, 2025 •

edited

Loading

graphite-app bot commented Dec 18, 2025 •

edited

Loading

netlify bot commented Dec 18, 2025 •

edited

Loading