refactor: store module and stmt_info is included info to module meta by IWANABETHATGUY · Pull Request #7570 · rolldown/rolldown

IWANABETHATGUY · 2025-12-18T09:28:29Z

Consolidating the tree-shaking info, two reasons:

All included information is generated in the linking stage(So store related info in LinkingMeta is clearer).
It easy to convert it back to IncludContext later using IndexVec, compared to storing it in StmtInfo

Will remove related info in NormalModule later

IWANABETHATGUY · 2025-12-18T09:28:46Z

feat: optimize dynamic entry facade chunks by merging with common chunks when they are captured by common chunks #7486
refactor: make include_runtime_symbol reuseable after linking stage #7580
refactor: use LinkingMetadata::stmt_info_included to check if a stmt_info is included #7572
refactor: use LinkingMetadata::is_included to check if a module is included #7571
refactor: store module and stmt_info is included info to module meta #7570 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2025-12-18T09:29:26Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`10c6fe0`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/6943c9404e782e000880ae15

netlify · 2025-12-18T09:30:41Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`b55b9c6`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/69443162f83e5c000824b189

Copilot

Pull request overview

This PR consolidates tree-shaking inclusion information into LinkingMetadata to improve code organization and clarity. The refactoring moves statement and module inclusion tracking from being scattered across different structures into a centralized location within the linking metadata, making it easier to convert back to IncludeContext later using IndexVec indexing.

Key changes:

Added two new fields to LinkingMetadata to track tree-shaking results: stmt_info_included and is_included
Renamed local variable for clarity: is_included_vec → is_stmt_info_included_vec
Added logic to store final inclusion results back into metadata after tree-shaking completes

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
crates/rolldown/src/types/linking_metadata.rs	Adds `stmt_info_included` and `is_included` fields to `LinkingMetadata` struct to track tree-shaking inclusion state
crates/rolldown/src/stages/link_stage/tree_shaking/include_statements.rs	Renames variable for clarity and adds logic to persist statement and module inclusion results to metadata after tree-shaking

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2025-12-18T09:54:29Z

Benchmarks Rust

target: main(12d1044)
pr: 12-18-refactor_store_module_and_stmt_info_is_included_info_to_module_meta(68e5c53)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     65.2±2.12ms        ? ?/sec    1.02     66.4±2.02ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     72.1±1.90ms        ? ?/sec    1.04     74.7±2.64ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    110.3±2.62ms        ? ?/sec    1.00    110.5±2.74ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    120.9±2.15ms        ? ?/sec    1.01    122.4±2.39ms        ? ?/sec
bundle/bundle@threejs                                        1.00     41.1±2.35ms        ? ?/sec    1.00     40.9±1.13ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     44.3±1.01ms        ? ?/sec    1.00     44.3±1.00ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    398.8±6.84ms        ? ?/sec    1.01    403.7±7.56ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    457.6±6.43ms        ? ?/sec    1.00    458.2±5.19ms        ? ?/sec
scan/scan@rome_ts                                            1.01     85.1±1.70ms        ? ?/sec    1.00     84.6±1.75ms        ? ?/sec
scan/scan@threejs                                            1.02     29.3±1.79ms        ? ?/sec    1.00     28.9±0.50ms        ? ?/sec
scan/scan@threejs10x                                         1.00    298.3±4.64ms        ? ?/sec    1.00    298.6±4.93ms        ? ?/sec

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/rolldown/src/stages/link_stage/tree_shaking/include_statements.rs

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

graphite-app · 2025-12-18T16:52:15Z

Merge activity

Dec 18, 4:52 PM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Dec 18, 5:18 PM UTC: Merged by the Graphite merge queue.

…7570) Consolidating the tree-shaking info, two reasons: 1. All included information is generated in the linking stage(So store related info in `LinkingMeta` is clearer). 2. It easy to convert it back to `IncludContext` later using `IndexVec`, compared to storing it in `StmtInfo` Will remove related info in `NormalModule` later

@sapphi-red

## [1.0.0-beta.56] - 2025-12-22 ### 💥 BREAKING CHANGES - rename `MIXED_EXPORT` error to `MIXED_EXPORTS` (#7565) by @sapphi-red ### 🚀 Features - rename `id` property to `exporter` in CIRCULAR_REEXPORT error (#7592) by @sapphi-red - add `ids` property to `CIRCULAR_DEPENDENCY` error (#7591) by @sapphi-red - node/dev: expose `devMode.lazy` (#7549) by @hyf0 - set log and pos properties for `parseAst` function errors (#7568) by @sapphi-red - set log and pos properties for logs (#7567) by @sapphi-red - test-dev-sever: support to manually configure port, run tests in concurrent (#7576) by @hyf0 - add `exporter` property to `MISSING_EXPORT` error (#7564) by @sapphi-red - add `id` property to `PARSE_ERROR` error (#7563) by @sapphi-red - support ImporterId hook filter (#7540) by @IWANABETHATGUY ### 🐛 Bug Fixes - types: better "go to definition" experience for interface `OutputPlugin` (#7610) by @KazariEX - `postBanner` content should be placed after shebang (#7583) by @btea - use sanitized filename for preserve modules chunk name (#7603) by @IWANABETHATGUY - correct filter out unused cjs namespace (#7602) by @IWANABETHATGUY - watch: property respect `notify.pollInternal` and `notify.compareContents` (#7595) by @sapphi-red - make `cleanDir` work with default output directory (#7579) by @shulaoda - merge `MISSING_NAME_OPTION_FOR_UMD_EXPORT` error to `MISSING_NAME_OPTION_FOR_IIFE_EXPORT` error (#7566) by @sapphi-red - dev/hmr: ensure cjs modules with no exports reference correct `module` identifier (#7544) by @leegeunhyeok ### 🚜 Refactor - remove `stable_id` field from `PARSE_ERROR` error (#7593) by @sapphi-red - make include_runtime_symbol reuseable after linking stage (#7580) by @IWANABETHATGUY - rust/dev: construct the bundler within itself (#7553) by @hyf0 - rust/watcher: polish API of `Watcher` struct (#7551) by @hyf0 - use `LinkingMetadata::stmt_info_included` to check if a stmt_info is included (#7572) by @IWANABETHATGUY - use `LinkingMetadata::is_included` to check if a module is included (#7571) by @IWANABETHATGUY - store module and stmt_info is included info to module meta (#7570) by @IWANABETHATGUY - make include_* method reunsable after linking stage (#7552) by @IWANABETHATGUY - rust/watcher: construct the bundler within watcher itself (#7550) by @hyf0 - extract make include_runtime_symbol reusable (#7546) by @IWANABETHATGUY ### ⚙️ Miscellaneous Tasks - renovate: add `kill-port` in `ignoreDeps` in renovate.json (#7619) by @sapphi-red - deps: update rust crates (#7617) by @renovate[bot] - deps: update npm packages (#7616) by @renovate[bot] - deps: update github-actions (#7615) by @renovate[bot] - ci: skip benchmark workflows on draft PRs (#7611) by @Copilot - deps: update dependency rolldown-plugin-dts to ^0.19.0 (#7607) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.10.0 (#7601) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.18.4 (#7599) by @renovate[bot] - deps: update notify (#7594) by @sapphi-red - test-dev-server: add retry mechanism to hmr-full-bundle-mode tests (#7588) by @Copilot - deps: update napi to v3.7.1 (#7590) by @renovate[bot] - add JSDoc documentation for memfs type (#7587) by @Copilot - deps: update dependency oxlint to v1.34.0 (#7589) by @renovate[bot] - move some tests in ignored-by-unsupported-features that are passing (#7569) by @sapphi-red - deps: update dependency oxlint-tsgolint to v0.9.2 (#7582) by @renovate[bot] - deps: update oxc resolver to v11.16.0 (#7574) by @renovate[bot] - test/dev-server: don't run `pnpm install` during tests (#7560) by @hyf0 - test/dev-server: use `kill-port@1` to improve performance (#7575) by @hyf0 - normalize error object to make some Rollup tests pass (#7562) by @sapphi-red - ci: separate dev-server(hmr) tests and normal tests (#7558) by @hyf0 - ci: make native rolldown build reusable (#7557) by @hyf0 - resolve some TODOs (#7561) by @sapphi-red ### ❤️ New Contributors * @KazariEX made their first contribution in [#7610](#7610) * @leegeunhyeok made their first contribution in [#7544](#7544) Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned IWANABETHATGUY Dec 18, 2025

IWANABETHATGUY mentioned this pull request Dec 18, 2025

refactor: use LinkingMetadata::is_included to check if a module is included #7571

Merged

IWANABETHATGUY marked this pull request as ready for review December 18, 2025 09:35

Copilot AI review requested due to automatic review settings December 18, 2025 09:35

Copilot started reviewing on behalf of IWANABETHATGUY December 18, 2025 09:36 View session

Copilot AI reviewed Dec 18, 2025

View reviewed changes

IWANABETHATGUY force-pushed the 12-18-refactor_store_module_and_stmt_info_is_included_info_to_module_meta branch from e70372f to 68e5c53 Compare December 18, 2025 09:38

IWANABETHATGUY mentioned this pull request Dec 18, 2025

refactor: use LinkingMetadata::stmt_info_included to check if a stmt_info is included #7572

Merged

IWANABETHATGUY requested review from hyf0, sapphi-red and shulaoda December 18, 2025 09:59

IWANABETHATGUY force-pushed the 12-18-refactor_store_module_and_stmt_info_is_included_info_to_module_meta branch from 68e5c53 to 745d636 Compare December 18, 2025 11:11

Copilot AI review requested due to automatic review settings December 18, 2025 11:11

Copilot started reviewing on behalf of IWANABETHATGUY December 18, 2025 11:12 View session

Copilot AI reviewed Dec 18, 2025

View reviewed changes

crates/rolldown/src/stages/link_stage/tree_shaking/include_statements.rs Show resolved Hide resolved

IWANABETHATGUY force-pushed the 12-18-refactor_store_module_and_stmt_info_is_included_info_to_module_meta branch 2 times, most recently from 265c161 to 00cfcb7 Compare December 18, 2025 13:52

IWANABETHATGUY mentioned this pull request Dec 18, 2025

feat: optimize dynamic entry facade chunks by merging with common chunks when they are captured by common chunks #7486

Merged

sapphi-red approved these changes Dec 18, 2025

View reviewed changes

Copilot AI review requested due to automatic review settings December 18, 2025 16:11

IWANABETHATGUY force-pushed the 12-18-refactor_store_module_and_stmt_info_is_included_info_to_module_meta branch from 00cfcb7 to 2745aba Compare December 18, 2025 16:11

Copilot started reviewing on behalf of IWANABETHATGUY December 18, 2025 16:12 View session

Copilot AI reviewed Dec 18, 2025

View reviewed changes

graphite-app bot force-pushed the 12-18-refactor_store_module_and_stmt_info_is_included_info_to_module_meta branch from 2745aba to b55b9c6 Compare December 18, 2025 16:52

graphite-app bot merged commit b55b9c6 into main Dec 18, 2025
31 checks passed

graphite-app bot deleted the 12-18-refactor_store_module_and_stmt_info_is_included_info_to_module_meta branch December 18, 2025 17:18

IWANABETHATGUY mentioned this pull request Dec 18, 2025

refactor: make include_runtime_symbol reuseable after linking stage #7580

Merged

github-actions bot mentioned this pull request Dec 22, 2025

release: v1.0.0-beta.56 #7620

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

refactor: store module and stmt_info is included info to module meta#7570

refactor: store module and stmt_info is included info to module meta#7570
graphite-app[bot] merged 1 commit intomainfrom
12-18-refactor_store_module_and_stmt_info_is_included_info_to_module_meta

IWANABETHATGUY commented Dec 18, 2025 •

edited

Loading

Uh oh!

IWANABETHATGUY commented Dec 18, 2025 •

edited

Loading

Uh oh!

netlify bot commented Dec 18, 2025

Uh oh!

netlify bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions bot commented Dec 18, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

graphite-app bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

IWANABETHATGUY commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IWANABETHATGUY commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Dec 18, 2025

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

netlify bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

github-actions bot commented Dec 18, 2025

Benchmarks Rust

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

graphite-app bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IWANABETHATGUY commented Dec 18, 2025 •

edited

Loading

IWANABETHATGUY commented Dec 18, 2025 •

edited

Loading

netlify bot commented Dec 18, 2025 •

edited

Loading

graphite-app bot commented Dec 18, 2025 •

edited

Loading