feat: set log and pos properties for logs by sapphi-red · Pull Request #7567 · rolldown/rolldown

sapphi-red · 2025-12-18T08:25:46Z

Added log and pos properties for logs.

sapphi-red · 2025-12-18T08:26:00Z

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-12-18T08:59:42Z

Benchmarks Rust

target: 12-17-fix_merge_missing_name_option_for_umd_export_error_to_missing_name_option_for_iife_export_error(00bd5df)
pr: 12-17-feat_set_log_and_pos_properties_for_logs(5fcc9b2)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     66.6±1.86ms        ? ?/sec    1.00     66.1±2.64ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.05     74.8±2.62ms        ? ?/sec    1.00     71.4±1.63ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    109.9±1.94ms        ? ?/sec    1.00    107.4±1.99ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.02    121.8±1.76ms        ? ?/sec    1.00    119.2±1.57ms        ? ?/sec
bundle/bundle@threejs                                        1.02     40.3±1.21ms        ? ?/sec    1.00     39.7±1.18ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.02     44.1±1.07ms        ? ?/sec    1.00     43.1±0.75ms        ? ?/sec
bundle/bundle@threejs10x                                     1.02    399.5±6.31ms        ? ?/sec    1.00    391.5±5.70ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.02    457.6±5.44ms        ? ?/sec    1.00    450.4±4.10ms        ? ?/sec
scan/scan@rome_ts                                            1.00     85.1±2.23ms        ? ?/sec    1.00     84.8±1.71ms        ? ?/sec
scan/scan@threejs                                            1.00     28.9±1.80ms        ? ?/sec    1.01     29.2±1.79ms        ? ?/sec
scan/scan@threejs10x                                         1.00    295.1±4.73ms        ? ?/sec    1.01    298.1±4.71ms        ? ?/sec

graphite-app · 2025-12-18T14:16:27Z

Merge activity

Dec 18, 2:16 PM UTC: sapphi-red added this pull request to the Graphite merge queue.
Dec 18, 2:23 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #7565.
Dec 18, 2:23 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #7565.
Dec 18, 3:53 PM UTC: sapphi-red added this pull request to the Graphite merge queue.
Dec 18, 4:07 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #7566.
Dec 18, 4:07 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #7566.
Dec 18, 4:53 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
Dec 18, 5:23 PM UTC: sapphi-red added this pull request to the Graphite merge queue.
Dec 18, 5:37 PM UTC: Merged by the Graphite merge queue.

Added `log` and `pos` properties for logs.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

netlify · 2025-12-18T17:24:57Z

✅ Deploy Preview for rolldown-rs ready!

Name	Link
🔨 Latest commit	`b846130`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/69443899fc85420008136cb4
😎 Deploy Preview	https://deploy-preview-7567--rolldown-rs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sapphi-red

## [1.0.0-beta.56] - 2025-12-22 ### 💥 BREAKING CHANGES - rename `MIXED_EXPORT` error to `MIXED_EXPORTS` (#7565) by @sapphi-red ### 🚀 Features - rename `id` property to `exporter` in CIRCULAR_REEXPORT error (#7592) by @sapphi-red - add `ids` property to `CIRCULAR_DEPENDENCY` error (#7591) by @sapphi-red - node/dev: expose `devMode.lazy` (#7549) by @hyf0 - set log and pos properties for `parseAst` function errors (#7568) by @sapphi-red - set log and pos properties for logs (#7567) by @sapphi-red - test-dev-sever: support to manually configure port, run tests in concurrent (#7576) by @hyf0 - add `exporter` property to `MISSING_EXPORT` error (#7564) by @sapphi-red - add `id` property to `PARSE_ERROR` error (#7563) by @sapphi-red - support ImporterId hook filter (#7540) by @IWANABETHATGUY ### 🐛 Bug Fixes - types: better "go to definition" experience for interface `OutputPlugin` (#7610) by @KazariEX - `postBanner` content should be placed after shebang (#7583) by @btea - use sanitized filename for preserve modules chunk name (#7603) by @IWANABETHATGUY - correct filter out unused cjs namespace (#7602) by @IWANABETHATGUY - watch: property respect `notify.pollInternal` and `notify.compareContents` (#7595) by @sapphi-red - make `cleanDir` work with default output directory (#7579) by @shulaoda - merge `MISSING_NAME_OPTION_FOR_UMD_EXPORT` error to `MISSING_NAME_OPTION_FOR_IIFE_EXPORT` error (#7566) by @sapphi-red - dev/hmr: ensure cjs modules with no exports reference correct `module` identifier (#7544) by @leegeunhyeok ### 🚜 Refactor - remove `stable_id` field from `PARSE_ERROR` error (#7593) by @sapphi-red - make include_runtime_symbol reuseable after linking stage (#7580) by @IWANABETHATGUY - rust/dev: construct the bundler within itself (#7553) by @hyf0 - rust/watcher: polish API of `Watcher` struct (#7551) by @hyf0 - use `LinkingMetadata::stmt_info_included` to check if a stmt_info is included (#7572) by @IWANABETHATGUY - use `LinkingMetadata::is_included` to check if a module is included (#7571) by @IWANABETHATGUY - store module and stmt_info is included info to module meta (#7570) by @IWANABETHATGUY - make include_* method reunsable after linking stage (#7552) by @IWANABETHATGUY - rust/watcher: construct the bundler within watcher itself (#7550) by @hyf0 - extract make include_runtime_symbol reusable (#7546) by @IWANABETHATGUY ### ⚙️ Miscellaneous Tasks - renovate: add `kill-port` in `ignoreDeps` in renovate.json (#7619) by @sapphi-red - deps: update rust crates (#7617) by @renovate[bot] - deps: update npm packages (#7616) by @renovate[bot] - deps: update github-actions (#7615) by @renovate[bot] - ci: skip benchmark workflows on draft PRs (#7611) by @Copilot - deps: update dependency rolldown-plugin-dts to ^0.19.0 (#7607) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.10.0 (#7601) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.18.4 (#7599) by @renovate[bot] - deps: update notify (#7594) by @sapphi-red - test-dev-server: add retry mechanism to hmr-full-bundle-mode tests (#7588) by @Copilot - deps: update napi to v3.7.1 (#7590) by @renovate[bot] - add JSDoc documentation for memfs type (#7587) by @Copilot - deps: update dependency oxlint to v1.34.0 (#7589) by @renovate[bot] - move some tests in ignored-by-unsupported-features that are passing (#7569) by @sapphi-red - deps: update dependency oxlint-tsgolint to v0.9.2 (#7582) by @renovate[bot] - deps: update oxc resolver to v11.16.0 (#7574) by @renovate[bot] - test/dev-server: don't run `pnpm install` during tests (#7560) by @hyf0 - test/dev-server: use `kill-port@1` to improve performance (#7575) by @hyf0 - normalize error object to make some Rollup tests pass (#7562) by @sapphi-red - ci: separate dev-server(hmr) tests and normal tests (#7558) by @hyf0 - ci: make native rolldown build reusable (#7557) by @hyf0 - resolve some TODOs (#7561) by @sapphi-red ### ❤️ New Contributors * @KazariEX made their first contribution in [#7610](#7610) * @leegeunhyeok made their first contribution in [#7544](#7544) Co-authored-by: shulaoda <[email protected]>

This was referenced Dec 18, 2025

chore: normalize error object to make some Rollup tests pass #7562

Merged

feat: add id property to PARSE_ERROR error #7563

Merged

feat: add exporter property to MISSING_EXPORT error #7564

Merged

sapphi-red force-pushed the 12-17-feat_set_log_and_pos_properties_for_logs branch from b313cae to 5fcc9b2 Compare December 18, 2025 08:43

sapphi-red force-pushed the 12-17-fix_merge_missing_name_option_for_umd_export_error_to_missing_name_option_for_iife_export_error branch from 1c74ea3 to 00bd5df Compare December 18, 2025 08:43

sapphi-red changed the base branch from 12-17-fix_merge_missing_name_option_for_umd_export_error_to_missing_name_option_for_iife_export_error to graphite-base/7567 December 18, 2025 08:56

sapphi-red force-pushed the graphite-base/7567 branch from 00bd5df to e4445d8 Compare December 18, 2025 09:16

sapphi-red force-pushed the 12-17-feat_set_log_and_pos_properties_for_logs branch from 5fcc9b2 to 262d53d Compare December 18, 2025 09:16

sapphi-red changed the base branch from graphite-base/7567 to 12-17-fix_merge_missing_name_option_for_umd_export_error_to_missing_name_option_for_iife_export_error December 18, 2025 09:17

sapphi-red requested review from hyf0 and shulaoda December 18, 2025 09:18

sapphi-red self-assigned this Dec 18, 2025

sapphi-red marked this pull request as ready for review December 18, 2025 09:19

hyf0 approved these changes Dec 18, 2025

View reviewed changes

graphite-app bot force-pushed the 12-17-fix_merge_missing_name_option_for_umd_export_error_to_missing_name_option_for_iife_export_error branch from e4445d8 to 8695846 Compare December 18, 2025 12:51

graphite-app bot force-pushed the 12-17-feat_set_log_and_pos_properties_for_logs branch from 262d53d to bee676e Compare December 18, 2025 12:52

graphite-app bot changed the base branch from 12-17-fix_merge_missing_name_option_for_umd_export_error_to_missing_name_option_for_iife_export_error to graphite-base/7567 December 18, 2025 13:59

graphite-app bot pushed a commit that referenced this pull request Dec 18, 2025

feat: set log and pos properties for logs (#7567)

acb5b17

Added `log` and `pos` properties for logs.

graphite-app bot force-pushed the 12-17-feat_set_log_and_pos_properties_for_logs branch from bee676e to acb5b17 Compare December 18, 2025 15:54

graphite-app bot changed the base branch from graphite-base/7567 to 12-17-fix_merge_missing_name_option_for_umd_export_error_to_missing_name_option_for_iife_export_error December 18, 2025 15:55

graphite-app bot changed the base branch from 12-17-fix_merge_missing_name_option_for_umd_export_error_to_missing_name_option_for_iife_export_error to graphite-base/7567 December 18, 2025 16:18

sapphi-red added a commit that referenced this pull request Dec 18, 2025

feat: set log and pos properties for logs (#7567)

5322e85

Added `log` and `pos` properties for logs.

sapphi-red force-pushed the 12-17-feat_set_log_and_pos_properties_for_logs branch from acb5b17 to 5322e85 Compare December 18, 2025 16:53

sapphi-red force-pushed the graphite-base/7567 branch from 1e5bc32 to 39fcf0c Compare December 18, 2025 16:53

graphite-app bot changed the base branch from graphite-base/7567 to main December 18, 2025 16:53

feat: set log and pos properties for logs (#7567)

b846130

Added `log` and `pos` properties for logs.

Copilot AI review requested due to automatic review settings December 18, 2025 17:23

graphite-app bot force-pushed the 12-17-feat_set_log_and_pos_properties_for_logs branch from 5322e85 to b846130 Compare December 18, 2025 17:23

Copilot AI reviewed Dec 18, 2025

View reviewed changes

graphite-app bot merged commit b846130 into main Dec 18, 2025
31 checks passed

graphite-app bot deleted the 12-17-feat_set_log_and_pos_properties_for_logs branch December 18, 2025 17:37

github-actions bot mentioned this pull request Dec 22, 2025

release: v1.0.0-beta.56 #7620

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

feat: set log and pos properties for logs#7567

feat: set log and pos properties for logs#7567
graphite-app[bot] merged 1 commit intomainfrom
12-17-feat_set_log_and_pos_properties_for_logs

sapphi-red commented Dec 18, 2025 •

edited

Loading

Uh oh!

sapphi-red commented Dec 18, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 18, 2025

Uh oh!

graphite-app bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

netlify bot commented Dec 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

sapphi-red commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sapphi-red commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Dec 18, 2025

Benchmarks Rust

Uh oh!

graphite-app bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

netlify bot commented Dec 18, 2025

✅ Deploy Preview for rolldown-rs ready!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sapphi-red commented Dec 18, 2025 •

edited

Loading

sapphi-red commented Dec 18, 2025 •

edited

Loading

graphite-app bot commented Dec 18, 2025 •

edited

Loading