fix!: rename `MIXED_EXPORT` error to `MIXED_EXPORTS` by sapphi-red · Pull Request #7565 · rolldown/rolldown

sapphi-red · 2025-12-18T08:25:42Z

Renamed MIXED_EXPORT error to MIXED_EXPORTS to align with Rollup. Also renamed checks.mixedExport to checks.mixedExports.

sapphi-red · 2025-12-18T08:25:59Z

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-12-18T09:26:05Z

Benchmarks Rust

target: 12-17-feat_add_exporter_property_to_missing_export_error(3f7290b)
pr: 12-17-fix_rename_mixed_export_error_to_mixed_exports_(0460c34)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     67.2±1.75ms        ? ?/sec    1.00     67.1±1.78ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     72.6±2.92ms        ? ?/sec    1.03     74.6±2.33ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    107.2±1.83ms        ? ?/sec    1.01    108.8±1.52ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    121.0±2.15ms        ? ?/sec    1.02    122.8±3.60ms        ? ?/sec
bundle/bundle@threejs                                        1.02     41.5±2.27ms        ? ?/sec    1.00     40.8±1.75ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     44.4±0.73ms        ? ?/sec    1.02     45.3±0.63ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    395.1±5.05ms        ? ?/sec    1.03    405.8±4.77ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    468.8±5.06ms        ? ?/sec    1.01    474.5±5.23ms        ? ?/sec
scan/scan@rome_ts                                            1.00     82.7±2.30ms        ? ?/sec    1.00     82.8±1.41ms        ? ?/sec
scan/scan@threejs                                            1.01     28.9±1.72ms        ? ?/sec    1.00     28.7±1.79ms        ? ?/sec
scan/scan@threejs10x                                         1.00    291.2±5.54ms        ? ?/sec    1.00    292.4±4.19ms        ? ?/sec

graphite-app · 2025-12-18T10:43:05Z

Merge activity

Dec 18, 10:43 AM UTC: sapphi-red added this pull request to the Graphite merge queue.
Dec 18, 10:43 AM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #7563.
Dec 18, 10:43 AM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #7563.
Dec 18, 2:23 PM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'cargo-test (macos-latest) / Cargo Test', 'build-rolldown-macos / Build Rolldown Native').
Dec 18, 3:52 PM UTC: sapphi-red added this pull request to the Graphite merge queue.
Dec 18, 4:04 PM UTC: Merged by the Graphite merge queue.

Renamed `MIXED_EXPORT` error to `MIXED_EXPORTS` to align with Rollup. Also renamed `checks.mixedExport` to `checks.mixedExports`.

netlify · 2025-12-18T14:00:16Z

✅ Deploy Preview for rolldown-rs ready!

Name	Link
🔨 Latest commit	`9252322`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/6944237259317700081a8b7a
😎 Deploy Preview	https://deploy-preview-7565--rolldown-rs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Renamed `MIXED_EXPORT` error to `MIXED_EXPORTS` to align with Rollup. Also renamed `checks.mixedExport` to `checks.mixedExports`.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@sapphi-red

## [1.0.0-beta.56] - 2025-12-22 ### 💥 BREAKING CHANGES - rename `MIXED_EXPORT` error to `MIXED_EXPORTS` (#7565) by @sapphi-red ### 🚀 Features - rename `id` property to `exporter` in CIRCULAR_REEXPORT error (#7592) by @sapphi-red - add `ids` property to `CIRCULAR_DEPENDENCY` error (#7591) by @sapphi-red - node/dev: expose `devMode.lazy` (#7549) by @hyf0 - set log and pos properties for `parseAst` function errors (#7568) by @sapphi-red - set log and pos properties for logs (#7567) by @sapphi-red - test-dev-sever: support to manually configure port, run tests in concurrent (#7576) by @hyf0 - add `exporter` property to `MISSING_EXPORT` error (#7564) by @sapphi-red - add `id` property to `PARSE_ERROR` error (#7563) by @sapphi-red - support ImporterId hook filter (#7540) by @IWANABETHATGUY ### 🐛 Bug Fixes - types: better "go to definition" experience for interface `OutputPlugin` (#7610) by @KazariEX - `postBanner` content should be placed after shebang (#7583) by @btea - use sanitized filename for preserve modules chunk name (#7603) by @IWANABETHATGUY - correct filter out unused cjs namespace (#7602) by @IWANABETHATGUY - watch: property respect `notify.pollInternal` and `notify.compareContents` (#7595) by @sapphi-red - make `cleanDir` work with default output directory (#7579) by @shulaoda - merge `MISSING_NAME_OPTION_FOR_UMD_EXPORT` error to `MISSING_NAME_OPTION_FOR_IIFE_EXPORT` error (#7566) by @sapphi-red - dev/hmr: ensure cjs modules with no exports reference correct `module` identifier (#7544) by @leegeunhyeok ### 🚜 Refactor - remove `stable_id` field from `PARSE_ERROR` error (#7593) by @sapphi-red - make include_runtime_symbol reuseable after linking stage (#7580) by @IWANABETHATGUY - rust/dev: construct the bundler within itself (#7553) by @hyf0 - rust/watcher: polish API of `Watcher` struct (#7551) by @hyf0 - use `LinkingMetadata::stmt_info_included` to check if a stmt_info is included (#7572) by @IWANABETHATGUY - use `LinkingMetadata::is_included` to check if a module is included (#7571) by @IWANABETHATGUY - store module and stmt_info is included info to module meta (#7570) by @IWANABETHATGUY - make include_* method reunsable after linking stage (#7552) by @IWANABETHATGUY - rust/watcher: construct the bundler within watcher itself (#7550) by @hyf0 - extract make include_runtime_symbol reusable (#7546) by @IWANABETHATGUY ### ⚙️ Miscellaneous Tasks - renovate: add `kill-port` in `ignoreDeps` in renovate.json (#7619) by @sapphi-red - deps: update rust crates (#7617) by @renovate[bot] - deps: update npm packages (#7616) by @renovate[bot] - deps: update github-actions (#7615) by @renovate[bot] - ci: skip benchmark workflows on draft PRs (#7611) by @Copilot - deps: update dependency rolldown-plugin-dts to ^0.19.0 (#7607) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.10.0 (#7601) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.18.4 (#7599) by @renovate[bot] - deps: update notify (#7594) by @sapphi-red - test-dev-server: add retry mechanism to hmr-full-bundle-mode tests (#7588) by @Copilot - deps: update napi to v3.7.1 (#7590) by @renovate[bot] - add JSDoc documentation for memfs type (#7587) by @Copilot - deps: update dependency oxlint to v1.34.0 (#7589) by @renovate[bot] - move some tests in ignored-by-unsupported-features that are passing (#7569) by @sapphi-red - deps: update dependency oxlint-tsgolint to v0.9.2 (#7582) by @renovate[bot] - deps: update oxc resolver to v11.16.0 (#7574) by @renovate[bot] - test/dev-server: don't run `pnpm install` during tests (#7560) by @hyf0 - test/dev-server: use `kill-port@1` to improve performance (#7575) by @hyf0 - normalize error object to make some Rollup tests pass (#7562) by @sapphi-red - ci: separate dev-server(hmr) tests and normal tests (#7558) by @hyf0 - ci: make native rolldown build reusable (#7557) by @hyf0 - resolve some TODOs (#7561) by @sapphi-red ### ❤️ New Contributors * @KazariEX made their first contribution in [#7610](#7610) * @leegeunhyeok made their first contribution in [#7544](#7544) Co-authored-by: shulaoda <[email protected]>

This was referenced Dec 18, 2025

chore: normalize error object to make some Rollup tests pass #7562

Merged

feat: add id property to PARSE_ERROR error #7563

Merged

sapphi-red force-pushed the 12-17-feat_add_exporter_property_to_missing_export_error branch from 0b5ad56 to c28ff3d Compare December 18, 2025 08:43

sapphi-red force-pushed the 12-17-fix_rename_mixed_export_error_to_mixed_exports_ branch from 6192e95 to 0725fa1 Compare December 18, 2025 08:43

sapphi-red requested review from IWANABETHATGUY and shulaoda December 18, 2025 08:50

sapphi-red self-assigned this Dec 18, 2025

sapphi-red marked this pull request as ready for review December 18, 2025 08:50

sapphi-red force-pushed the 12-17-feat_add_exporter_property_to_missing_export_error branch from c28ff3d to b9839ee Compare December 18, 2025 08:56

sapphi-red force-pushed the 12-17-fix_rename_mixed_export_error_to_mixed_exports_ branch 2 times, most recently from 2968b01 to fcb24da Compare December 18, 2025 08:57

sapphi-red force-pushed the 12-17-feat_add_exporter_property_to_missing_export_error branch from b9839ee to 61bfe72 Compare December 18, 2025 08:57

IWANABETHATGUY approved these changes Dec 18, 2025

View reviewed changes

shulaoda approved these changes Dec 18, 2025

View reviewed changes

sapphi-red force-pushed the 12-17-feat_add_exporter_property_to_missing_export_error branch from 61bfe72 to 49f2d51 Compare December 18, 2025 09:09

sapphi-red force-pushed the 12-17-fix_rename_mixed_export_error_to_mixed_exports_ branch from fcb24da to 133f8d3 Compare December 18, 2025 09:09

sapphi-red force-pushed the 12-17-feat_add_exporter_property_to_missing_export_error branch from 49f2d51 to 3f7290b Compare December 18, 2025 09:09

sapphi-red force-pushed the 12-17-fix_rename_mixed_export_error_to_mixed_exports_ branch from 133f8d3 to 0460c34 Compare December 18, 2025 09:09

graphite-app bot changed the base branch from 12-17-feat_add_exporter_property_to_missing_export_error to graphite-base/7565 December 18, 2025 10:35

graphite-app bot force-pushed the graphite-base/7565 branch from 3f7290b to 435f300 Compare December 18, 2025 12:51

graphite-app bot force-pushed the 12-17-fix_rename_mixed_export_error_to_mixed_exports_ branch from 0460c34 to b085e6f Compare December 18, 2025 12:51

graphite-app bot changed the base branch from graphite-base/7565 to 12-17-feat_add_exporter_property_to_missing_export_error December 18, 2025 12:51

graphite-app bot force-pushed the 12-17-fix_rename_mixed_export_error_to_mixed_exports_ branch from b085e6f to 8f8a3f4 Compare December 18, 2025 12:51

Base automatically changed from 12-17-feat_add_exporter_property_to_missing_export_error to main December 18, 2025 13:29

graphite-app bot pushed a commit that referenced this pull request Dec 18, 2025

fix!: rename MIXED_EXPORT error to MIXED_EXPORTS (#7565)

57ec346

Renamed `MIXED_EXPORT` error to `MIXED_EXPORTS` to align with Rollup. Also renamed `checks.mixedExport` to `checks.mixedExports`.

graphite-app bot force-pushed the 12-17-fix_rename_mixed_export_error_to_mixed_exports_ branch from 8f8a3f4 to 57ec346 Compare December 18, 2025 13:58

fix!: rename MIXED_EXPORT error to MIXED_EXPORTS (#7565)

9252322

Renamed `MIXED_EXPORT` error to `MIXED_EXPORTS` to align with Rollup. Also renamed `checks.mixedExport` to `checks.mixedExports`.

Copilot AI review requested due to automatic review settings December 18, 2025 15:53

graphite-app bot force-pushed the 12-17-fix_rename_mixed_export_error_to_mixed_exports_ branch from 57ec346 to 9252322 Compare December 18, 2025 15:53

Copilot AI reviewed Dec 18, 2025

View reviewed changes

graphite-app bot merged commit 9252322 into main Dec 18, 2025
31 checks passed

graphite-app bot deleted the 12-17-fix_rename_mixed_export_error_to_mixed_exports_ branch December 18, 2025 16:04

github-actions bot mentioned this pull request Dec 22, 2025

release: v1.0.0-beta.56 #7620

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

fix!: rename `MIXED_EXPORT` error to `MIXED_EXPORTS`#7565

fix!: rename `MIXED_EXPORT` error to `MIXED_EXPORTS`#7565
graphite-app[bot] merged 1 commit intomainfrom
12-17-fix_rename_mixed_export_error_to_mixed_exports_

sapphi-red commented Dec 18, 2025 •

edited

Loading

Uh oh!

sapphi-red commented Dec 18, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 18, 2025

Uh oh!

graphite-app bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

netlify bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

sapphi-red commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sapphi-red commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Dec 18, 2025

Benchmarks Rust

Uh oh!

graphite-app bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

netlify bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sapphi-red commented Dec 18, 2025 •

edited

Loading

sapphi-red commented Dec 18, 2025 •

edited

Loading

graphite-app bot commented Dec 18, 2025 •

edited

Loading

netlify bot commented Dec 18, 2025 •

edited

Loading