feat: add `id` property to `PARSE_ERROR` error by sapphi-red · Pull Request #7563 · rolldown/rolldown

sapphi-red · 2025-12-18T08:25:39Z

Added id property to PARSE_ERROR error to align with Rollup.

sapphi-red · 2025-12-18T08:25:55Z

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-12-18T09:25:24Z

Benchmarks Rust

target: 12-17-chore_normalize_error_object_to_make_some_rollup_tests_pass(3c18a8a)
pr: 12-17-feat_add_id_property_to_parse_error_error(6e6025e)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     65.3±1.99ms        ? ?/sec    1.01     66.1±2.05ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     71.9±1.95ms        ? ?/sec    1.01     72.3±1.87ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    107.6±1.73ms        ? ?/sec    1.01    108.6±1.93ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    120.7±2.55ms        ? ?/sec    1.01    121.4±2.16ms        ? ?/sec
bundle/bundle@threejs                                        1.00     39.7±0.85ms        ? ?/sec    1.01     39.9±1.91ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     43.2±0.75ms        ? ?/sec    1.00     43.2±0.62ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    394.8±5.54ms        ? ?/sec    1.01    397.0±7.88ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    455.6±5.45ms        ? ?/sec    1.00    454.5±4.73ms        ? ?/sec
scan/scan@rome_ts                                            1.03     86.4±1.75ms        ? ?/sec    1.00     84.1±1.58ms        ? ?/sec
scan/scan@threejs                                            1.03     29.3±1.78ms        ? ?/sec    1.00     28.5±0.42ms        ? ?/sec
scan/scan@threejs10x                                         1.00    296.6±4.53ms        ? ?/sec    1.00    297.9±4.51ms        ? ?/sec

graphite-app · 2025-12-18T10:17:26Z

Merge activity

Dec 18, 10:17 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
Dec 18, 10:37 AM UTC: sapphi-red added this pull request to the Graphite merge queue.
Dec 18, 10:42 AM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'cargo-test (ubuntu-latest) / Cargo Test', 'cargo-test (macos-latest) / Cargo Test', 'cargo-test (windows-latest) / Cargo Test').
Dec 18, 10:42 AM UTC: sapphi-red added this pull request to the Graphite merge queue.
Dec 18, 10:43 AM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'cargo-test (ubuntu-latest) / Cargo Test', 'cargo-test (macos-latest) / Cargo Test', 'cargo-test (windows-latest) / Cargo Test').
Dec 18, 12:07 PM UTC: hyf0 added this pull request to the Graphite merge queue.
Dec 18, 12:38 PM UTC: The Graphite merge queue couldn't merge this PR because it timed out.
Dec 18, 12:49 PM UTC: sapphi-red added this pull request to the Graphite merge queue.
Dec 18, 12:50 PM UTC: Merged by the Graphite merge queue.

netlify · 2025-12-18T10:18:20Z

✅ Deploy Preview for rolldown-rs ready!

Name	Link
🔨 Latest commit	`c644c48`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/6943eea7ad5e100008f1927e
😎 Deploy Preview	https://deploy-preview-7563--rolldown-rs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Added `id` property to `PARSE_ERROR` error to align with Rollup.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

refs #7563

Refactored to use `DiagnosticOptions::stabilize_path`. refs #7563

@sapphi-red

## [1.0.0-beta.56] - 2025-12-22 ### 💥 BREAKING CHANGES - rename `MIXED_EXPORT` error to `MIXED_EXPORTS` (#7565) by @sapphi-red ### 🚀 Features - rename `id` property to `exporter` in CIRCULAR_REEXPORT error (#7592) by @sapphi-red - add `ids` property to `CIRCULAR_DEPENDENCY` error (#7591) by @sapphi-red - node/dev: expose `devMode.lazy` (#7549) by @hyf0 - set log and pos properties for `parseAst` function errors (#7568) by @sapphi-red - set log and pos properties for logs (#7567) by @sapphi-red - test-dev-sever: support to manually configure port, run tests in concurrent (#7576) by @hyf0 - add `exporter` property to `MISSING_EXPORT` error (#7564) by @sapphi-red - add `id` property to `PARSE_ERROR` error (#7563) by @sapphi-red - support ImporterId hook filter (#7540) by @IWANABETHATGUY ### 🐛 Bug Fixes - types: better "go to definition" experience for interface `OutputPlugin` (#7610) by @KazariEX - `postBanner` content should be placed after shebang (#7583) by @btea - use sanitized filename for preserve modules chunk name (#7603) by @IWANABETHATGUY - correct filter out unused cjs namespace (#7602) by @IWANABETHATGUY - watch: property respect `notify.pollInternal` and `notify.compareContents` (#7595) by @sapphi-red - make `cleanDir` work with default output directory (#7579) by @shulaoda - merge `MISSING_NAME_OPTION_FOR_UMD_EXPORT` error to `MISSING_NAME_OPTION_FOR_IIFE_EXPORT` error (#7566) by @sapphi-red - dev/hmr: ensure cjs modules with no exports reference correct `module` identifier (#7544) by @leegeunhyeok ### 🚜 Refactor - remove `stable_id` field from `PARSE_ERROR` error (#7593) by @sapphi-red - make include_runtime_symbol reuseable after linking stage (#7580) by @IWANABETHATGUY - rust/dev: construct the bundler within itself (#7553) by @hyf0 - rust/watcher: polish API of `Watcher` struct (#7551) by @hyf0 - use `LinkingMetadata::stmt_info_included` to check if a stmt_info is included (#7572) by @IWANABETHATGUY - use `LinkingMetadata::is_included` to check if a module is included (#7571) by @IWANABETHATGUY - store module and stmt_info is included info to module meta (#7570) by @IWANABETHATGUY - make include_* method reunsable after linking stage (#7552) by @IWANABETHATGUY - rust/watcher: construct the bundler within watcher itself (#7550) by @hyf0 - extract make include_runtime_symbol reusable (#7546) by @IWANABETHATGUY ### ⚙️ Miscellaneous Tasks - renovate: add `kill-port` in `ignoreDeps` in renovate.json (#7619) by @sapphi-red - deps: update rust crates (#7617) by @renovate[bot] - deps: update npm packages (#7616) by @renovate[bot] - deps: update github-actions (#7615) by @renovate[bot] - ci: skip benchmark workflows on draft PRs (#7611) by @Copilot - deps: update dependency rolldown-plugin-dts to ^0.19.0 (#7607) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.10.0 (#7601) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.18.4 (#7599) by @renovate[bot] - deps: update notify (#7594) by @sapphi-red - test-dev-server: add retry mechanism to hmr-full-bundle-mode tests (#7588) by @Copilot - deps: update napi to v3.7.1 (#7590) by @renovate[bot] - add JSDoc documentation for memfs type (#7587) by @Copilot - deps: update dependency oxlint to v1.34.0 (#7589) by @renovate[bot] - move some tests in ignored-by-unsupported-features that are passing (#7569) by @sapphi-red - deps: update dependency oxlint-tsgolint to v0.9.2 (#7582) by @renovate[bot] - deps: update oxc resolver to v11.16.0 (#7574) by @renovate[bot] - test/dev-server: don't run `pnpm install` during tests (#7560) by @hyf0 - test/dev-server: use `kill-port@1` to improve performance (#7575) by @hyf0 - normalize error object to make some Rollup tests pass (#7562) by @sapphi-red - ci: separate dev-server(hmr) tests and normal tests (#7558) by @hyf0 - ci: make native rolldown build reusable (#7557) by @hyf0 - resolve some TODOs (#7561) by @sapphi-red ### ❤️ New Contributors * @KazariEX made their first contribution in [#7610](#7610) * @leegeunhyeok made their first contribution in [#7544](#7544) Co-authored-by: shulaoda <[email protected]>

sapphi-red force-pushed the 12-17-feat_add_id_property_to_parse_error_error branch from bed776e to 3ccaeeb Compare December 18, 2025 08:43

sapphi-red requested review from hyf0 and shulaoda December 18, 2025 08:48

sapphi-red self-assigned this Dec 18, 2025

sapphi-red marked this pull request as ready for review December 18, 2025 08:49

sapphi-red force-pushed the 12-17-feat_add_id_property_to_parse_error_error branch from 3ccaeeb to a426f0c Compare December 18, 2025 08:56

sapphi-red force-pushed the 12-17-chore_normalize_error_object_to_make_some_rollup_tests_pass branch 2 times, most recently from 0a91458 to 691df72 Compare December 18, 2025 08:57

sapphi-red force-pushed the 12-17-feat_add_id_property_to_parse_error_error branch from a426f0c to 66049d9 Compare December 18, 2025 08:57

shulaoda approved these changes Dec 18, 2025

View reviewed changes

sapphi-red force-pushed the 12-17-feat_add_id_property_to_parse_error_error branch from 66049d9 to a6a00ff Compare December 18, 2025 09:09

sapphi-red force-pushed the 12-17-chore_normalize_error_object_to_make_some_rollup_tests_pass branch from 691df72 to 6e865c4 Compare December 18, 2025 09:09

sapphi-red force-pushed the 12-17-feat_add_id_property_to_parse_error_error branch from a6a00ff to 6e6025e Compare December 18, 2025 09:09

sapphi-red force-pushed the 12-17-chore_normalize_error_object_to_make_some_rollup_tests_pass branch from 6e865c4 to 3c18a8a Compare December 18, 2025 09:09

Base automatically changed from 12-17-chore_normalize_error_object_to_make_some_rollup_tests_pass to main December 18, 2025 10:16

sapphi-red force-pushed the 12-17-feat_add_id_property_to_parse_error_error branch from 6e6025e to 02702b7 Compare December 18, 2025 10:16

graphite-app bot pushed a commit that referenced this pull request Dec 18, 2025

feat: add id property to PARSE_ERROR error (#7563)

806b01d

Added `id` property to `PARSE_ERROR` error to align with Rollup.

graphite-app bot force-pushed the 12-17-feat_add_id_property_to_parse_error_error branch from 02702b7 to 806b01d Compare December 18, 2025 10:35

feat: add id property to PARSE_ERROR error (#7563)

c644c48

Added `id` property to `PARSE_ERROR` error to align with Rollup.

Copilot AI review requested due to automatic review settings December 18, 2025 12:08

graphite-app bot force-pushed the 12-17-feat_add_id_property_to_parse_error_error branch from 806b01d to c644c48 Compare December 18, 2025 12:08

Copilot AI reviewed Dec 18, 2025

View reviewed changes

graphite-app bot merged commit c644c48 into main Dec 18, 2025
54 of 55 checks passed

graphite-app bot deleted the 12-17-feat_add_id_property_to_parse_error_error branch December 18, 2025 12:50

sapphi-red added a commit that referenced this pull request Dec 19, 2025

refactor: remove stable_id field from PARSE_ERROR error

d5eef48

refs #7563

sapphi-red mentioned this pull request Dec 19, 2025

refactor: remove stable_id field from PARSE_ERROR error #7593

Merged

graphite-app bot pushed a commit that referenced this pull request Dec 19, 2025

refactor: remove stable_id field from PARSE_ERROR error

ebc8fe0

refs #7563

sapphi-red added a commit that referenced this pull request Dec 19, 2025

refactor: remove stable_id field from PARSE_ERROR error

ac01fef

refs #7563

graphite-app bot pushed a commit that referenced this pull request Dec 19, 2025

refactor: remove stable_id field from PARSE_ERROR error (#7593)

476ff79

Refactored to use `DiagnosticOptions::stabilize_path`. refs #7563

github-actions bot mentioned this pull request Dec 22, 2025

release: v1.0.0-beta.56 #7620

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

feat: add `id` property to `PARSE_ERROR` error#7563

feat: add `id` property to `PARSE_ERROR` error#7563
graphite-app[bot] merged 1 commit intomainfrom
12-17-feat_add_id_property_to_parse_error_error

sapphi-red commented Dec 18, 2025 •

edited

Loading

Uh oh!

sapphi-red commented Dec 18, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 18, 2025

Uh oh!

graphite-app bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

netlify bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

sapphi-red commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sapphi-red commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Dec 18, 2025

Benchmarks Rust

Uh oh!

graphite-app bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

netlify bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sapphi-red commented Dec 18, 2025 •

edited

Loading

sapphi-red commented Dec 18, 2025 •

edited

Loading

graphite-app bot commented Dec 18, 2025 •

edited

Loading

netlify bot commented Dec 18, 2025 •

edited

Loading