Skip to content

Comments

refactor: store module and stmt info included index vec into LinkStage#7547

Closed
IWANABETHATGUY wants to merge 2 commits into12-17-refactor_extract_make_include_runtime_symbol_reusablefrom
12-17-refactor_store_module_and_stmt_info_included_index_vec_into_linkstage
Closed

refactor: store module and stmt info included index vec into LinkStage#7547
IWANABETHATGUY wants to merge 2 commits into12-17-refactor_extract_make_include_runtime_symbol_reusablefrom
12-17-refactor_store_module_and_stmt_info_included_index_vec_into_linkstage

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Dec 17, 2025 •
edited
Loading

related to #7486

@IWANABETHATGUY Graphite App
Copy link
Member Author

IWANABETHATGUY commented Dec 17, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Dec 17, 2025
Merged
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review December 17, 2025 13:56
@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2025 •
edited
Loading

Benchmarks Rust

  • target: 12-17-refactor_extract_make_include_runtime_symbol_reusable(cd7a624)
  • pr: 12-17-refactor_store_module_and_stmt_info_included_index_vec_into_linkstage(9fe1a20)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     62.2±1.53ms        ? ?/sec    1.00     61.4±1.60ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.02     68.8±1.63ms        ? ?/sec    1.00     67.5±1.23ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    103.5±1.54ms        ? ?/sec    1.01    104.1±1.68ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    116.6±1.56ms        ? ?/sec    1.00    116.5±1.48ms        ? ?/sec
bundle/bundle@threejs                                        1.00     38.8±0.63ms        ? ?/sec    1.02     39.6±0.91ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     43.1±0.52ms        ? ?/sec    1.01     43.6±0.62ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    386.5±5.22ms        ? ?/sec    1.00    384.6±7.72ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01   454.3±19.25ms        ? ?/sec    1.00    448.5±4.24ms        ? ?/sec
scan/scan@rome_ts                                            1.01     80.1±1.60ms        ? ?/sec    1.00     79.3±1.15ms        ? ?/sec
scan/scan@threejs                                            1.00     27.4±0.34ms        ? ?/sec    1.00     27.4±0.36ms        ? ?/sec
scan/scan@threejs10x                                         1.00    281.5±3.22ms        ? ?/sec    1.00    281.5±3.47ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY force-pushed the 12-17-refactor_extract_make_include_runtime_symbol_reusable branch from 3abc932 to cd7a624 Compare December 17, 2025 14:02
@IWANABETHATGUY IWANABETHATGUY force-pushed the 12-17-refactor_store_module_and_stmt_info_included_index_vec_into_linkstage branch from d35e9d2 to 9fe1a20 Compare December 17, 2025 14:02
This was referenced Dec 17, 2025
Closed
Merged
@IWANABETHATGUY IWANABETHATGUY requested review from hyf0 and shulaoda and removed request for shulaoda December 17, 2025 15:03
@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Dec 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 Awaiting requested review from hyf0

@shulaoda shulaoda Awaiting requested review from shulaoda

Assignees

@IWANABETHATGUY IWANABETHATGUY

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@IWANABETHATGUY