refactor: make include_runtime_symbol reusable by IWANABETHATGUY · Pull Request #7546 · rolldown/rolldown

IWANABETHATGUY · 2025-12-17T13:46:01Z

No description provided.

IWANABETHATGUY · 2025-12-17T13:46:16Z

refactor: make include_runtime_symbol reusable #7546 : 2 dependent PRs (#7547 , #7552 ) 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2025-12-17T13:47:20Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`a9747f0`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/6942df436c0c6300080a5771

github-actions · 2025-12-17T14:02:38Z

Benchmarks Rust

target: main(b343bbe)
pr: 12-17-refactor_extract_make_include_runtime_symbol_reusable(a9747f0)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     63.5±1.90ms        ? ?/sec    1.00     63.1±1.49ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.03     71.0±1.74ms        ? ?/sec    1.00     69.0±2.16ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    106.5±2.67ms        ? ?/sec    1.00    106.8±2.32ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    119.0±1.74ms        ? ?/sec    1.01    119.7±1.64ms        ? ?/sec
bundle/bundle@threejs                                        1.00     39.9±2.43ms        ? ?/sec    1.00     40.1±2.45ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     43.2±1.05ms        ? ?/sec    1.00     42.7±0.51ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    394.0±4.76ms        ? ?/sec    1.00    393.4±6.61ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    453.2±4.41ms        ? ?/sec    1.01    455.8±4.85ms        ? ?/sec
scan/scan@rome_ts                                            1.02     87.2±1.81ms        ? ?/sec    1.00     85.2±1.74ms        ? ?/sec
scan/scan@threejs                                            1.02     28.9±0.55ms        ? ?/sec    1.00     28.4±0.56ms        ? ?/sec
scan/scan@threejs10x                                         1.01    299.4±3.68ms        ? ?/sec    1.00    297.2±5.77ms        ? ?/sec

Copilot

Pull request overview

This PR refactors the include_runtime_symbol method by extracting the runtime helper collection logic into a separate, reusable function. The goal is to improve code organization and enable potential reuse of this logic elsewhere in the codebase.

Key Changes:

Extracted runtime helper collection logic into a standalone collect_depended_runtime_helper function
Modified include_runtime_symbol to accept the collected runtime helper as a parameter instead of computing it internally
Added comprehensive documentation for the new function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/rolldown/src/stages/link_stage/tree_shaking/include_statements.rs

graphite-app · 2025-12-17T16:49:32Z

Merge activity

Dec 17, 4:49 PM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Dec 17, 5:07 PM UTC: Merged by the Graphite merge queue.

@sapphi-red

## [1.0.0-beta.56] - 2025-12-22 ### 💥 BREAKING CHANGES - rename `MIXED_EXPORT` error to `MIXED_EXPORTS` (#7565) by @sapphi-red ### 🚀 Features - rename `id` property to `exporter` in CIRCULAR_REEXPORT error (#7592) by @sapphi-red - add `ids` property to `CIRCULAR_DEPENDENCY` error (#7591) by @sapphi-red - node/dev: expose `devMode.lazy` (#7549) by @hyf0 - set log and pos properties for `parseAst` function errors (#7568) by @sapphi-red - set log and pos properties for logs (#7567) by @sapphi-red - test-dev-sever: support to manually configure port, run tests in concurrent (#7576) by @hyf0 - add `exporter` property to `MISSING_EXPORT` error (#7564) by @sapphi-red - add `id` property to `PARSE_ERROR` error (#7563) by @sapphi-red - support ImporterId hook filter (#7540) by @IWANABETHATGUY ### 🐛 Bug Fixes - types: better "go to definition" experience for interface `OutputPlugin` (#7610) by @KazariEX - `postBanner` content should be placed after shebang (#7583) by @btea - use sanitized filename for preserve modules chunk name (#7603) by @IWANABETHATGUY - correct filter out unused cjs namespace (#7602) by @IWANABETHATGUY - watch: property respect `notify.pollInternal` and `notify.compareContents` (#7595) by @sapphi-red - make `cleanDir` work with default output directory (#7579) by @shulaoda - merge `MISSING_NAME_OPTION_FOR_UMD_EXPORT` error to `MISSING_NAME_OPTION_FOR_IIFE_EXPORT` error (#7566) by @sapphi-red - dev/hmr: ensure cjs modules with no exports reference correct `module` identifier (#7544) by @leegeunhyeok ### 🚜 Refactor - remove `stable_id` field from `PARSE_ERROR` error (#7593) by @sapphi-red - make include_runtime_symbol reuseable after linking stage (#7580) by @IWANABETHATGUY - rust/dev: construct the bundler within itself (#7553) by @hyf0 - rust/watcher: polish API of `Watcher` struct (#7551) by @hyf0 - use `LinkingMetadata::stmt_info_included` to check if a stmt_info is included (#7572) by @IWANABETHATGUY - use `LinkingMetadata::is_included` to check if a module is included (#7571) by @IWANABETHATGUY - store module and stmt_info is included info to module meta (#7570) by @IWANABETHATGUY - make include_* method reunsable after linking stage (#7552) by @IWANABETHATGUY - rust/watcher: construct the bundler within watcher itself (#7550) by @hyf0 - extract make include_runtime_symbol reusable (#7546) by @IWANABETHATGUY ### ⚙️ Miscellaneous Tasks - renovate: add `kill-port` in `ignoreDeps` in renovate.json (#7619) by @sapphi-red - deps: update rust crates (#7617) by @renovate[bot] - deps: update npm packages (#7616) by @renovate[bot] - deps: update github-actions (#7615) by @renovate[bot] - ci: skip benchmark workflows on draft PRs (#7611) by @Copilot - deps: update dependency rolldown-plugin-dts to ^0.19.0 (#7607) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.10.0 (#7601) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.18.4 (#7599) by @renovate[bot] - deps: update notify (#7594) by @sapphi-red - test-dev-server: add retry mechanism to hmr-full-bundle-mode tests (#7588) by @Copilot - deps: update napi to v3.7.1 (#7590) by @renovate[bot] - add JSDoc documentation for memfs type (#7587) by @Copilot - deps: update dependency oxlint to v1.34.0 (#7589) by @renovate[bot] - move some tests in ignored-by-unsupported-features that are passing (#7569) by @sapphi-red - deps: update dependency oxlint-tsgolint to v0.9.2 (#7582) by @renovate[bot] - deps: update oxc resolver to v11.16.0 (#7574) by @renovate[bot] - test/dev-server: don't run `pnpm install` during tests (#7560) by @hyf0 - test/dev-server: use `kill-port@1` to improve performance (#7575) by @hyf0 - normalize error object to make some Rollup tests pass (#7562) by @sapphi-red - ci: separate dev-server(hmr) tests and normal tests (#7558) by @hyf0 - ci: make native rolldown build reusable (#7557) by @hyf0 - resolve some TODOs (#7561) by @sapphi-red ### ❤️ New Contributors * @KazariEX made their first contribution in [#7610](#7610) * @leegeunhyeok made their first contribution in [#7544](#7544) Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned IWANABETHATGUY Dec 17, 2025

IWANABETHATGUY mentioned this pull request Dec 17, 2025

refactor: store module and stmt info included index vec into LinkStage #7547

Closed

IWANABETHATGUY force-pushed the 12-17-refactor_extract_make_include_runtime_symbol_reusable branch from 3abc932 to cd7a624 Compare December 17, 2025 14:02

IWANABETHATGUY mentioned this pull request Dec 17, 2025

refactor: use treeshake_context.is_stmt_info_included_vec to inspect if a stmt_info is included after linking #7548

Closed

IWANABETHATGUY marked this pull request as ready for review December 17, 2025 14:03

Copilot AI review requested due to automatic review settings December 17, 2025 14:03

Copilot started reviewing on behalf of IWANABETHATGUY December 17, 2025 14:03 View session

Copilot AI reviewed Dec 17, 2025

View reviewed changes

crates/rolldown/src/stages/link_stage/tree_shaking/include_statements.rs Show resolved Hide resolved

IWANABETHATGUY mentioned this pull request Dec 17, 2025

feat: optimize dynamic entry facade chunks by merging with common chunks when they are captured by common chunks #7486

Merged

IWANABETHATGUY requested review from hyf0 and shulaoda December 17, 2025 15:03

IWANABETHATGUY mentioned this pull request Dec 17, 2025

refactor: make include_* method reunsable after linking stage #7552

Merged

hyf0 approved these changes Dec 17, 2025

View reviewed changes

refactor: extract make include_runtime_symbol reusable (#7546)

a9747f0

graphite-app bot force-pushed the 12-17-refactor_extract_make_include_runtime_symbol_reusable branch from cd7a624 to a9747f0 Compare December 17, 2025 16:50

graphite-app bot merged commit a9747f0 into main Dec 17, 2025
28 checks passed

graphite-app bot deleted the 12-17-refactor_extract_make_include_runtime_symbol_reusable branch December 17, 2025 17:07

IWANABETHATGUY changed the title ~~refactor: extract make include_runtime_symbol reusable~~ refactor:make include_runtime_symbol reusable Dec 18, 2025

IWANABETHATGUY changed the title ~~refactor:make include_runtime_symbol reusable~~ refactor: make include_runtime_symbol reusable Dec 18, 2025

github-actions bot mentioned this pull request Dec 22, 2025

release: v1.0.0-beta.56 #7620

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

refactor: make include_runtime_symbol reusable#7546

refactor: make include_runtime_symbol reusable#7546
graphite-app[bot] merged 1 commit intomainfrom
12-17-refactor_extract_make_include_runtime_symbol_reusable

IWANABETHATGUY commented Dec 17, 2025

Uh oh!

IWANABETHATGUY commented Dec 17, 2025 •

edited

Loading

Uh oh!

netlify bot commented Dec 17, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 17, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

graphite-app bot commented Dec 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

IWANABETHATGUY commented Dec 17, 2025

Uh oh!

IWANABETHATGUY commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

github-actions bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

graphite-app bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IWANABETHATGUY commented Dec 17, 2025 •

edited

Loading

netlify bot commented Dec 17, 2025 •

edited

Loading

github-actions bot commented Dec 17, 2025 •

edited

Loading

graphite-app bot commented Dec 17, 2025 •

edited

Loading