Skip to content

Comments

fix: handle __proto__ export for module namespace correctly#7534

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-16-fix_handle___proto___export_for_module_namespace_correctly
Dec 17, 2025
Merged

fix: handle __proto__ export for module namespace correctly#7534
graphite-app[bot] merged 1 commit intomainfrom
12-16-fix_handle___proto___export_for_module_namespace_correctly

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Dec 16, 2025

Similar to #7533 but for namespace related cases.

Copy link
Member Author

sapphi-red commented Dec 16, 2025


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2025

Benchmarks Rust

  • target: 12-16-fix_handle___proto___export_correctly(e2d2f53)
  • pr: 12-16-fix_handle___proto___export_for_module_namespace_correctly(1f496ce)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.02     67.9±1.73ms        ? ?/sec    1.00     66.5±1.59ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     72.5±1.58ms        ? ?/sec    1.00     72.5±2.13ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    106.2±1.46ms        ? ?/sec    1.00    106.6±3.35ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    121.4±3.24ms        ? ?/sec    1.00    120.3±1.51ms        ? ?/sec
bundle/bundle@threejs                                        1.02     40.7±2.28ms        ? ?/sec    1.00     40.0±0.58ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     44.7±0.68ms        ? ?/sec    1.00     44.3±0.60ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    396.7±4.39ms        ? ?/sec    1.00    392.6±5.19ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    463.5±7.26ms        ? ?/sec    1.00    462.8±4.85ms        ? ?/sec
scan/scan@rome_ts                                            1.00     80.9±1.36ms        ? ?/sec    1.01     81.5±1.85ms        ? ?/sec
scan/scan@threejs                                            1.01     28.5±1.79ms        ? ?/sec    1.00     28.2±1.46ms        ? ?/sec
scan/scan@threejs10x                                         1.00    284.4±4.00ms        ? ?/sec    1.00    285.5±3.21ms        ? ?/sec

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 16, 2025

Merge activity

  • Dec 16, 1:08 PM UTC: sapphi-red added this pull request to the Graphite merge queue.
  • Dec 16, 1:26 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #7533.
  • Dec 16, 1:26 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #7533.
  • Dec 16, 3:36 PM UTC: sapphi-red added this pull request to the Graphite merge queue.
  • Dec 16, 3:55 PM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'node-test (ubuntu-latest) / Node Test', 'node-test (macos-latest) / Node Test', 'node-test (windows-latest) / Node Test').
  • Dec 17, 2:44 AM UTC: Merged by the Graphite merge queue.
  • Dec 17, 2:45 AM UTC: sapphi-red added this pull request to the Graphite merge queue.

@sapphi-red sapphi-red force-pushed the 12-16-fix_handle___proto___export_correctly branch from 8b7bbde to d26e8ea Compare December 16, 2025 15:19
@sapphi-red sapphi-red force-pushed the 12-16-fix_handle___proto___export_for_module_namespace_correctly branch from 470a75d to a69b628 Compare December 16, 2025 15:19
Similar to #7533 but for namespace related cases.
@graphite-app graphite-app bot force-pushed the 12-16-fix_handle___proto___export_correctly branch from d26e8ea to e2d2f53 Compare December 16, 2025 15:36
@graphite-app graphite-app bot force-pushed the 12-16-fix_handle___proto___export_for_module_namespace_correctly branch from a69b628 to 1f496ce Compare December 16, 2025 15:37
Base automatically changed from 12-16-fix_handle___proto___export_correctly to main December 16, 2025 15:54
@graphite-app graphite-app bot merged commit 1f496ce into main Dec 17, 2025
87 of 93 checks passed
@graphite-app graphite-app bot deleted the 12-16-fix_handle___proto___export_for_module_namespace_correctly branch December 17, 2025 02:44
shulaoda added a commit that referenced this pull request Dec 17, 2025
## [1.0.0-beta.55] - 2025-12-17

### 🚀 Features

- add validation errors for incompatible `inlineDynamicImports` options (#7539) by @Copilot
- rolldown_plugin_vite_reporter: truncate long importer lists in ineffective dynamic import warnings (#7528) by @Copilot
- export `memfs` from `rolldown/experimental` for browser builds (#7490) by @Copilot
- implement `postBanner` and `postFooter` (#7487) by @sevenc-nanashi
- port getLogFilter helper from Rollup for advanced log filtering (#6890) by @taearls
- dev: initialize `rolldown_plugin_lazy_compilation` (#7488) by @hyf0
- enable `experimental.transform_hires_sourcemap: 'boundary'` by default (#7478) by @sapphi-red
- apply merge CJS namespace optimizations more generally (#7475) by @sapphi-red

### 🐛 Bug Fixes

- avoid panic on invalid values for `output.exports`, `output.format`, `output.hash_characters` (#7542) by @sapphi-red
- handle `__proto__` export for module namespace correctly (#7534) by @sapphi-red
- handle `__proto__` export correctly (#7533) by @sapphi-red
- rolldown_plugin_vite_resolve: acquire resolver lock before package json resolution (#7524) by @sapphi-red
- disable syntax transform optimization for `minify: 'dce-only'` (#7520) by @sapphi-red
- arrow function expression keep names (#7519) by @IWANABETHATGUY
- skip symbols that are imported from other module when deconflicting module symbols (#7510) by @IWANABETHATGUY
- preserve class names in assignment expressions with keepNames option (#7491) by @IWANABETHATGUY
- accessor with decorators should be kept (#7499) by @Copilot
- rolldown_plugin_vite_reporter: support `Infinity` for chunk_limit (#7497) by @shulaoda
- change filename template validation errors from UNHANDLEABLE_ERROR to INVALID_OPTION (#7472) by @Copilot
- `no entry found for key` error when merging CJS namespace exports (#7474) by @sapphi-red
- generate output with syntax error when wrapped esm module using tla syntax (#7468) by @IWANABETHATGUY

### 🚜 Refactor

- dev: rename `experimental.hmr` to `experimental.devMode` (#7527) by @hyf0
- pass addon option to rust as it is (#7526) by @hyf0
- remove unused stmtinfo meta flag (#7518) by @IWANABETHATGUY

### 📚 Documentation

- clarify `closeBundle` behavior (#7525) by @sapphi-red

### 🧪 Testing

- add tests for static string postBanner and postFooter (#7516) by @Copilot
- disable pluginTimings in Rust integration tests to avoid snapshot noise (#7485) by @shulaoda
- port Rollup JSX tests to `crates/rolldown/tests/rollup` (#7480) by @sapphi-red
- re-triage some esbuild JSX preserve tests (#7479) by @sapphi-red
- disable pluginTimings by default to avoid snapshot noise (#7471) by @shulaoda

### ⚙️ Miscellaneous Tasks

- mark feature that will not be supported as ignored in rollup test status (#7535) by @sapphi-red
- support `banner`/`footer`/`intro`/`outro` for config variants (#7532) by @sapphi-red
- `dce/dce_of_decorators` esbuild test is now passing (#7531) by @sapphi-red
- deps: update github-actions (major) (#7495) by @renovate[bot]
- deps: update npm packages (#7493) by @renovate[bot]
- add a check to verify failedReasons are updated (#7521) by @sapphi-red
- deps: update test262 submodule for tests (#7523) by @sapphi-red
- deps: update taiki-e/install-action action to v2.63.2 (#7496) by @renovate[bot]
- deps: update oxc apps (#7511) by @renovate[bot]
- deps: update oxc to v0.103.0 (#7513) by @camc314
- fix format in `.github/instructions/bug-investigation.instructions.md` (#7506) by @sapphi-red
- add instructions for REPL decoding (#7502) by @sapphi-red
- deps: update github-actions (#7492) by @renovate[bot]
- deps: cargo-shear v1.9.0 (#7483) by @Boshen
- deps: update dependency oxlint-tsgolint to v0.9.0 (#7484) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.8.6 (#7470) by @renovate[bot]
- add syntax validation for test output chunks that are not executed (#7466) by @IWANABETHATGUY
- deps: update dependency rust to v1.92.0 (#7467) by @renovate[bot]
- deps: update test262 submodule for tests (#7457) by @sapphi-red

### ❤️ New Contributors

* @sevenc-nanashi made their first contribution in [#7487](#7487)
* @taearls made their first contribution in [#6890](#6890)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants