fix: handle __proto__ export correctly#7533
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 16, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd the label graphite: merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 16, 2025
Contributor
Benchmarks Rust |
graphite-app
bot
changed the base branch from
12-16-chore_support_banner___footer___intro___outro_for_config_variants
to
graphite-base/7533
IWANABETHATGUY
approved these changes
Dec 16, 2025
Contributor
Merge activity
|
sapphi-red
force-pushed
the
12-16-fix_handle___proto___export_correctly
branch
from
8b7bbde to
d26e8ea
Compare
✅ Deploy Preview for rolldown-rs canceled.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the handling of exports named __proto__ by using Object.defineProperty instead of direct property assignment, matching Rollup's behavior. Direct assignment to __proto__ sets the prototype instead of creating a property with that name.
Key Changes:
- Added special case detection for
__proto__exports in the rendering logic - Implemented
Object.definePropertywith avaluedescriptor for__proto__exports - Added comprehensive test coverage for CJS, IIFE, and UMD formats
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
scripts/src/esbuild-tests/snap-diff/summary/default.md |
Removed failing test entry and added passing test entry for export_special_name |
scripts/src/esbuild-tests/snap-diff/stats/stats.md |
Updated test pass count and ratios reflecting the fix |
scripts/src/esbuild-tests/reasons.ts |
Removed failure reason for export_special_name test |
crates/rolldown/tests/snapshots/integration_rolldown__filename_with_hash.snap |
Updated hash values for affected test outputs |
crates/rolldown/tests/rolldown/function/format/export_proto/main.js |
New test file exporting __proto__ constant |
crates/rolldown/tests/rolldown/function/format/export_proto/artifacts.snap |
Snapshot showing correct Object.defineProperty usage across formats |
crates/rolldown/tests/rolldown/function/format/export_proto/_test.mjs |
Test assertions verifying __proto__ is an own property with correct value |
crates/rolldown/tests/rolldown/function/format/export_proto/_config.json |
Test configuration for CJS, IIFE, and UMD format variants |
crates/rolldown/tests/esbuild/default/export_special_name/diff.md |
Removed diff file as test now passes |
crates/rolldown/tests/esbuild/default/export_special_name/artifacts.snap |
Updated snapshot showing Object.defineProperty output |
crates/rolldown/src/utils/chunk/render_chunk_exports.rs |
Added __proto__ check and new helper function for value-based property definition |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Added special handling for export named `__proto__`. Use `Object.defineProperty` instead of a normal assign in this case like Rollup does.
graphite-app
bot
force-pushed
the
12-16-fix_handle___proto___export_correctly
branch
from
d26e8ea to
e2d2f53
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Dec 16, 2025
Similar to #7533 but for namespace related cases.
graphite-app
bot
deleted the
12-16-fix_handle___proto___export_correctly
branch
This was referenced Dec 17, 2025
shulaoda
added a commit
that referenced
this pull request
Dec 17, 2025
## [1.0.0-beta.55] - 2025-12-17 ### 🚀 Features - add validation errors for incompatible `inlineDynamicImports` options (#7539) by @Copilot - rolldown_plugin_vite_reporter: truncate long importer lists in ineffective dynamic import warnings (#7528) by @Copilot - export `memfs` from `rolldown/experimental` for browser builds (#7490) by @Copilot - implement `postBanner` and `postFooter` (#7487) by @sevenc-nanashi - port getLogFilter helper from Rollup for advanced log filtering (#6890) by @taearls - dev: initialize `rolldown_plugin_lazy_compilation` (#7488) by @hyf0 - enable `experimental.transform_hires_sourcemap: 'boundary'` by default (#7478) by @sapphi-red - apply merge CJS namespace optimizations more generally (#7475) by @sapphi-red ### 🐛 Bug Fixes - avoid panic on invalid values for `output.exports`, `output.format`, `output.hash_characters` (#7542) by @sapphi-red - handle `__proto__` export for module namespace correctly (#7534) by @sapphi-red - handle `__proto__` export correctly (#7533) by @sapphi-red - rolldown_plugin_vite_resolve: acquire resolver lock before package json resolution (#7524) by @sapphi-red - disable syntax transform optimization for `minify: 'dce-only'` (#7520) by @sapphi-red - arrow function expression keep names (#7519) by @IWANABETHATGUY - skip symbols that are imported from other module when deconflicting module symbols (#7510) by @IWANABETHATGUY - preserve class names in assignment expressions with keepNames option (#7491) by @IWANABETHATGUY - accessor with decorators should be kept (#7499) by @Copilot - rolldown_plugin_vite_reporter: support `Infinity` for chunk_limit (#7497) by @shulaoda - change filename template validation errors from UNHANDLEABLE_ERROR to INVALID_OPTION (#7472) by @Copilot - `no entry found for key` error when merging CJS namespace exports (#7474) by @sapphi-red - generate output with syntax error when wrapped esm module using tla syntax (#7468) by @IWANABETHATGUY ### 🚜 Refactor - dev: rename `experimental.hmr` to `experimental.devMode` (#7527) by @hyf0 - pass addon option to rust as it is (#7526) by @hyf0 - remove unused stmtinfo meta flag (#7518) by @IWANABETHATGUY ### 📚 Documentation - clarify `closeBundle` behavior (#7525) by @sapphi-red ### 🧪 Testing - add tests for static string postBanner and postFooter (#7516) by @Copilot - disable pluginTimings in Rust integration tests to avoid snapshot noise (#7485) by @shulaoda - port Rollup JSX tests to `crates/rolldown/tests/rollup` (#7480) by @sapphi-red - re-triage some esbuild JSX preserve tests (#7479) by @sapphi-red - disable pluginTimings by default to avoid snapshot noise (#7471) by @shulaoda ### ⚙️ Miscellaneous Tasks - mark feature that will not be supported as ignored in rollup test status (#7535) by @sapphi-red - support `banner`/`footer`/`intro`/`outro` for config variants (#7532) by @sapphi-red - `dce/dce_of_decorators` esbuild test is now passing (#7531) by @sapphi-red - deps: update github-actions (major) (#7495) by @renovate[bot] - deps: update npm packages (#7493) by @renovate[bot] - add a check to verify failedReasons are updated (#7521) by @sapphi-red - deps: update test262 submodule for tests (#7523) by @sapphi-red - deps: update taiki-e/install-action action to v2.63.2 (#7496) by @renovate[bot] - deps: update oxc apps (#7511) by @renovate[bot] - deps: update oxc to v0.103.0 (#7513) by @camc314 - fix format in `.github/instructions/bug-investigation.instructions.md` (#7506) by @sapphi-red - add instructions for REPL decoding (#7502) by @sapphi-red - deps: update github-actions (#7492) by @renovate[bot] - deps: cargo-shear v1.9.0 (#7483) by @Boshen - deps: update dependency oxlint-tsgolint to v0.9.0 (#7484) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.8.6 (#7470) by @renovate[bot] - add syntax validation for test output chunks that are not executed (#7466) by @IWANABETHATGUY - deps: update dependency rust to v1.92.0 (#7467) by @renovate[bot] - deps: update test262 submodule for tests (#7457) by @sapphi-red ### ❤️ New Contributors * @sevenc-nanashi made their first contribution in [#7487](#7487) * @taearls made their first contribution in [#6890](#6890) Co-authored-by: shulaoda <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added special handling for export named
__proto__. UseObject.definePropertyinstead of a normal assign in this case like Rollup does.