refactor(dev): rename `experimental.hmr` to `experimental.devMode` by hyf0 · Pull Request #7527 · rolldown/rolldown

hyf0 · 2025-12-16T07:35:04Z

No description provided.

hyf0 · 2025-12-16T07:35:19Z

refactor(dev): rename experimental.hmr to experimental.devMode #7527 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2025-12-16T07:37:03Z

✅ Deploy Preview for rolldown-rs ready!

Name	Link
🔨 Latest commit	`13c8c78`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/69415fe2246ccf0008b25ce6
😎 Deploy Preview	https://deploy-preview-7527--rolldown-rs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Pull request overview

This PR refactors the experimental HMR (Hot Module Replacement) configuration API by renaming experimental.hmr to experimental.devMode. This is a comprehensive rename that updates type definitions, function names, method names, error messages, and documentation to reflect the new terminology.

Key Changes

Renamed HmrOptions type to DevModeOptions across TypeScript and Rust codebases
Updated the configuration field from experimental.hmr to experimental.devMode
Renamed Rust methods like is_hmr_enabled() to is_dev_mode_enabled()
Updated test files, examples, and validation error messages to use the new naming

Reviewed changes

Copilot reviewed 62 out of 62 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`packages/rolldown/src/options/input-options.ts`	Renamed `HmrOptions` type to `DevModeOptions` and updated field from `hmr` to `devMode`
`packages/rolldown/src/utils/validator.ts`	Renamed schema from `HmrSchema` to `DevModeSchema`
`packages/rolldown/src/utils/bindingify-input-options.ts`	Renamed binding function from `bindingifyHmr` to `bindingifyDevMode`
`packages/rolldown/tests/dev-mode-validation.test.ts`	Updated test descriptions, variable names, and error message expectations
`packages/rolldown/src/binding.d.cts`	Renamed TypeScript binding interface from `BindingExperimentalHmrOptions` to `BindingExperimentalDevModeOptions`
`crates/rolldown_common/src/inner_bundler_options/types/dev_mode_options.rs`	Renamed struct from `HmrOptions` to `DevModeOptions` and updated documentation comment
`crates/rolldown_common/src/inner_bundler_options/types/experimental_options.rs`	Updated field from `hmr` to `dev_mode`
`crates/rolldown_common/src/inner_bundler_options/types/normalized_bundler_options.rs`	Renamed method from `is_hmr_enabled` to `is_dev_mode_enabled`
`crates/rolldown_binding/src/options/binding_input_options/binding_experimental_options.rs`	Renamed binding structs and conversion implementations
`crates/rolldown_binding/src/binding_bundler.rs`	Updated validation error messages and documentation comments
`crates/rolldown_binding/src/watcher.rs`	Updated error message for dev mode validation in watch mode
`crates/rolldown/src/utils/prepare_build_context.rs`	Updated condition check and added comment about dev mode requiring treeshaking disabled
`crates/rolldown/src/utils/apply_inner_plugins.rs`	Changed field access from `hmr` to `dev_mode`
`crates/rolldown_testing/src/integration_test.rs`	Updated field access in test integration code
`crates/rolldown_plugin_hmr/src/hmr_plugin.rs`	Changed field access from `hmr_options` to `dev_mode_options`
`crates/rolldown/src/stages/link_stage/tree_shaking/include_statements.rs`	Updated method call to `is_dev_mode_enabled()`
`crates/rolldown/src/stages/generate_stage/on_demand_wrapping.rs`	Updated method call to `is_dev_mode_enabled()`
`crates/rolldown/src/module_finalizers/*.rs`	Updated multiple method calls to use `is_dev_mode_enabled()`
`crates/rolldown/src/ast_scanner/*.rs`	Updated field access and method calls
`crates/rolldown/examples/lazy.rs`	Updated example code to use `DevModeOptions`
`crates/rolldown/tests/rolldown/topics/hmr/**/_config.json`	Updated all test config files to use `devMode` instead of `hmr`
`docs/options/experimental.md`	Removed old `hmr` documentation section
`examples/hmr-raw/dev.config.mjs`	Updated example configuration to use `devMode`
Test fixtures and playground configs	Updated all dev server test configurations

Comments suppressed due to low confidence (1)

docs/options/experimental.md:88

The documentation section for the old experimental.hmr option needs to be removed or replaced with documentation for the new experimental.devMode option. Currently, the diff shows that lines 69-88 were removed, but the file still contains these lines in the current state. This creates confusion for users as the option has been renamed to experimental.devMode.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/rolldown_binding/src/binding_bundler.rs

crates/rolldown/tests/rolldown/topics/hmr/non_used_export/_config.json

packages/rolldown/src/utils/bindingify-input-options.ts

github-actions · 2025-12-16T08:05:12Z

Benchmarks Rust

target: main(22ce689)
pr: 12-16-refactor_dev_rename_experimental.hmr_to_experimental.devmode_(13c8c78)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     63.4±1.20ms        ? ?/sec    1.00     62.6±1.48ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.02     70.0±1.50ms        ? ?/sec    1.00     68.9±1.51ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    107.0±2.46ms        ? ?/sec    1.00    107.1±1.61ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    119.5±2.28ms        ? ?/sec    1.00    118.9±1.56ms        ? ?/sec
bundle/bundle@threejs                                        1.02     39.4±2.45ms        ? ?/sec    1.00     38.7±0.59ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     42.8±0.60ms        ? ?/sec    1.00     42.7±1.16ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    392.2±4.46ms        ? ?/sec    1.00    388.5±6.10ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    451.3±3.25ms        ? ?/sec    1.00    447.3±3.69ms        ? ?/sec
scan/scan@rome_ts                                            1.00     83.1±1.32ms        ? ?/sec    1.00     83.0±1.39ms        ? ?/sec
scan/scan@threejs                                            1.02     28.7±1.90ms        ? ?/sec    1.00     28.2±0.60ms        ? ?/sec
scan/scan@threejs10x                                         1.00    292.2±4.29ms        ? ?/sec    1.01    294.3±4.70ms        ? ?/sec

hyf0 · 2025-12-16T13:33:53Z

Merge activity

Dec 16, 1:33 PM UTC: The merge label 'graphite: merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Dec 16, 1:33 PM UTC: hyf0 added this pull request to the Graphite merge queue.
Dec 16, 1:51 PM UTC: Merged by the Graphite merge queue.

…7527)

@sevenc-nanashi

## [1.0.0-beta.55] - 2025-12-17 ### 🚀 Features - add validation errors for incompatible `inlineDynamicImports` options (#7539) by @Copilot - rolldown_plugin_vite_reporter: truncate long importer lists in ineffective dynamic import warnings (#7528) by @Copilot - export `memfs` from `rolldown/experimental` for browser builds (#7490) by @Copilot - implement `postBanner` and `postFooter` (#7487) by @sevenc-nanashi - port getLogFilter helper from Rollup for advanced log filtering (#6890) by @taearls - dev: initialize `rolldown_plugin_lazy_compilation` (#7488) by @hyf0 - enable `experimental.transform_hires_sourcemap: 'boundary'` by default (#7478) by @sapphi-red - apply merge CJS namespace optimizations more generally (#7475) by @sapphi-red ### 🐛 Bug Fixes - avoid panic on invalid values for `output.exports`, `output.format`, `output.hash_characters` (#7542) by @sapphi-red - handle `__proto__` export for module namespace correctly (#7534) by @sapphi-red - handle `__proto__` export correctly (#7533) by @sapphi-red - rolldown_plugin_vite_resolve: acquire resolver lock before package json resolution (#7524) by @sapphi-red - disable syntax transform optimization for `minify: 'dce-only'` (#7520) by @sapphi-red - arrow function expression keep names (#7519) by @IWANABETHATGUY - skip symbols that are imported from other module when deconflicting module symbols (#7510) by @IWANABETHATGUY - preserve class names in assignment expressions with keepNames option (#7491) by @IWANABETHATGUY - accessor with decorators should be kept (#7499) by @Copilot - rolldown_plugin_vite_reporter: support `Infinity` for chunk_limit (#7497) by @shulaoda - change filename template validation errors from UNHANDLEABLE_ERROR to INVALID_OPTION (#7472) by @Copilot - `no entry found for key` error when merging CJS namespace exports (#7474) by @sapphi-red - generate output with syntax error when wrapped esm module using tla syntax (#7468) by @IWANABETHATGUY ### 🚜 Refactor - dev: rename `experimental.hmr` to `experimental.devMode` (#7527) by @hyf0 - pass addon option to rust as it is (#7526) by @hyf0 - remove unused stmtinfo meta flag (#7518) by @IWANABETHATGUY ### 📚 Documentation - clarify `closeBundle` behavior (#7525) by @sapphi-red ### 🧪 Testing - add tests for static string postBanner and postFooter (#7516) by @Copilot - disable pluginTimings in Rust integration tests to avoid snapshot noise (#7485) by @shulaoda - port Rollup JSX tests to `crates/rolldown/tests/rollup` (#7480) by @sapphi-red - re-triage some esbuild JSX preserve tests (#7479) by @sapphi-red - disable pluginTimings by default to avoid snapshot noise (#7471) by @shulaoda ### ⚙️ Miscellaneous Tasks - mark feature that will not be supported as ignored in rollup test status (#7535) by @sapphi-red - support `banner`/`footer`/`intro`/`outro` for config variants (#7532) by @sapphi-red - `dce/dce_of_decorators` esbuild test is now passing (#7531) by @sapphi-red - deps: update github-actions (major) (#7495) by @renovate[bot] - deps: update npm packages (#7493) by @renovate[bot] - add a check to verify failedReasons are updated (#7521) by @sapphi-red - deps: update test262 submodule for tests (#7523) by @sapphi-red - deps: update taiki-e/install-action action to v2.63.2 (#7496) by @renovate[bot] - deps: update oxc apps (#7511) by @renovate[bot] - deps: update oxc to v0.103.0 (#7513) by @camc314 - fix format in `.github/instructions/bug-investigation.instructions.md` (#7506) by @sapphi-red - add instructions for REPL decoding (#7502) by @sapphi-red - deps: update github-actions (#7492) by @renovate[bot] - deps: cargo-shear v1.9.0 (#7483) by @Boshen - deps: update dependency oxlint-tsgolint to v0.9.0 (#7484) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.8.6 (#7470) by @renovate[bot] - add syntax validation for test output chunks that are not executed (#7466) by @IWANABETHATGUY - deps: update dependency rust to v1.92.0 (#7467) by @renovate[bot] - deps: update test262 submodule for tests (#7457) by @sapphi-red ### ❤️ New Contributors * @sevenc-nanashi made their first contribution in [#7487](#7487) * @taearls made their first contribution in [#6890](#6890) Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned hyf0 Dec 16, 2025

hyf0 marked this pull request as ready for review December 16, 2025 07:36

hyf0 requested review from Copilot, sapphi-red and shulaoda and removed request for Copilot December 16, 2025 07:36

Copilot started reviewing on behalf of hyf0 December 16, 2025 07:39 View session

Copilot AI review requested due to automatic review settings December 16, 2025 07:49

hyf0 force-pushed the 12-16-refactor_dev_rename_experimental.hmr_to_experimental.devmode_ branch from 810757a to 0fe16c8 Compare December 16, 2025 07:49

Copilot started reviewing on behalf of hyf0 December 16, 2025 07:49 View session

Copilot AI reviewed Dec 16, 2025

View reviewed changes

crates/rolldown_binding/src/binding_bundler.rs Show resolved Hide resolved

crates/rolldown/tests/rolldown/topics/hmr/non_used_export/_config.json Show resolved Hide resolved

packages/rolldown/src/utils/bindingify-input-options.ts Show resolved Hide resolved

shulaoda approved these changes Dec 16, 2025

View reviewed changes

hyf0 added the graphite: merge label Dec 16, 2025

refactor(dev): rename experimental.hmr to experimental.devMode (#…

13c8c78

…7527)

graphite-app bot force-pushed the 12-16-refactor_dev_rename_experimental.hmr_to_experimental.devmode_ branch from 0fe16c8 to 13c8c78 Compare December 16, 2025 13:34

graphite-app bot merged commit 13c8c78 into main Dec 16, 2025
28 checks passed

graphite-app bot deleted the 12-16-refactor_dev_rename_experimental.hmr_to_experimental.devmode_ branch December 16, 2025 13:51

graphite-app bot removed the graphite: merge label Dec 16, 2025

This was referenced Dec 17, 2025

release: v1.0.0-beta.55 #7536

Closed

release: v1.0.0-beta.55 #7543

Merged

Copilot AI mentioned this pull request Dec 30, 2025

test(hmr): add test case for #5301 #5302

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

refactor(dev): rename `experimental.hmr` to `experimental.devMode`#7527

refactor(dev): rename `experimental.hmr` to `experimental.devMode`#7527
graphite-app[bot] merged 1 commit intomainfrom
12-16-refactor_dev_rename_experimental.hmr_to_experimental.devmode_

hyf0 commented Dec 16, 2025

Uh oh!

hyf0 commented Dec 16, 2025

Uh oh!

netlify bot commented Dec 16, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 16, 2025 •

edited

Loading

Uh oh!

hyf0 commented Dec 16, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

hyf0 commented Dec 16, 2025

Uh oh!

hyf0 commented Dec 16, 2025

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

hyf0 commented Dec 16, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Dec 16, 2025 •

edited

Loading

github-actions bot commented Dec 16, 2025 •

edited

Loading

hyf0 commented Dec 16, 2025 •

edited by graphite-app bot

Loading