fix: preserve class names in assignment expressions with keepNames option by IWANABETHATGUY · Pull Request #7491 · rolldown/rolldown

IWANABETHATGUY · 2025-12-14T14:41:02Z

IWANABETHATGUY · 2025-12-14T14:41:21Z

fix: preserve class names in assignment expressions with keepNames option #7491 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2025-12-14T14:41:59Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`bb3a709`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/693fc46ca6c34700085b02e8

github-actions · 2025-12-14T14:56:28Z

Benchmarks Rust

target: main(0c819ab)
pr: 12-14-fix_7481(bb3a709)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.03     71.7±1.39ms        ? ?/sec    1.00     69.9±1.58ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.02     78.5±1.44ms        ? ?/sec    1.00     76.6±1.71ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    114.0±3.04ms        ? ?/sec    1.00    112.1±2.33ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.02    127.3±2.61ms        ? ?/sec    1.00    124.5±1.90ms        ? ?/sec
bundle/bundle@threejs                                        1.00     42.5±2.26ms        ? ?/sec    1.01     42.9±2.55ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     45.9±0.79ms        ? ?/sec    1.00     45.6±0.73ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    412.6±5.38ms        ? ?/sec    1.00    411.0±5.96ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    470.5±3.77ms        ? ?/sec    1.01    473.0±5.32ms        ? ?/sec
scan/scan@rome_ts                                            1.00     87.7±1.71ms        ? ?/sec    1.02     89.8±1.60ms        ? ?/sec
scan/scan@threejs                                            1.00     29.7±0.43ms        ? ?/sec    1.03     30.5±1.91ms        ? ?/sec
scan/scan@threejs10x                                         1.00    307.2±4.51ms        ? ?/sec    1.01    308.8±4.14ms        ? ?/sec

Copilot

Pull request overview

This PR fixes issue #7481 related to the keep_names functionality in rolldown. The fix ensures that class names are properly preserved in assignment expressions and decorated classes by introducing a more flexible way to identify and track names during code transformation.

Key changes:

Introduced a new KeepNameId enum to support multiple ways of identifying names (via SymbolId, ReferenceId, or direct string)
Added support for processing keep_names in assignment expressions (e.g., let Test = _Test = class {})
Enhanced class expression handling to work with decorators and assignment patterns

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
test.js	Testing artifact at project root - should not be committed
crates/rolldown/tests/snapshots/integration_rolldown__filename_with_hash.snap	Updated snapshot to include new test cases
crates/rolldown/tests/rolldown/topics/keep_names/issue_7481_2/tsconfig.json	TypeScript config for decorator test case (has formatting issues)
crates/rolldown/tests/rolldown/topics/keep_names/issue_7481_2/main.ts	Test case for decorated class with keep_names
crates/rolldown/tests/rolldown/topics/keep_names/issue_7481_2/artifacts.snap	Expected output snapshot for decorator test
crates/rolldown/tests/rolldown/topics/keep_names/issue_7481_2/_config.json	Test configuration enabling keep_names
crates/rolldown/tests/rolldown/topics/keep_names/issue_7481/main.js	Main entry for assignment pattern test case
crates/rolldown/tests/rolldown/topics/keep_names/issue_7481/lib2.js	Test case for assignment pattern `let Test = _Test = class {}`
crates/rolldown/tests/rolldown/topics/keep_names/issue_7481/lib.js	Test case for standard class declaration
crates/rolldown/tests/rolldown/topics/keep_names/issue_7481/artifacts.snap	Expected output snapshot for assignment pattern test
crates/rolldown/tests/rolldown/topics/keep_names/issue_7481/_config.json	Test configuration enabling keep_names
crates/rolldown/src/module_finalizers/mod.rs	Core changes: added KeepNameId enum, refactored keep_name methods to use it
crates/rolldown/src/module_finalizers/impl_visit_mut.rs	Added visit_assignment_expression to handle keep_names in assignments
crates/rolldown/src/ast_scanner/impl_visit.rs	Added visit_class to mark class expressions for keep_names processing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/rolldown/tests/rolldown/topics/keep_names/issue_7481_2/tsconfig.json

crates/rolldown/src/module_finalizers/mod.rs

test.js

crates/rolldown/src/ast_scanner/impl_visit.rs

crates/rolldown/tests/rolldown/topics/keep_names/issue_7481_2/tsconfig.json

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test.js

crates/rolldown/src/module_finalizers/mod.rs

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/rolldown/src/module_finalizers/mod.rs

crates/rolldown/src/module_finalizers/impl_visit_mut.rs

graphite-app · 2025-12-15T08:13:51Z

Merge activity

Dec 15, 8:13 AM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Dec 15, 8:36 AM UTC: Merged by the Graphite merge queue.

…tion (#7491) closed #7481

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@sevenc-nanashi

## [1.0.0-beta.55] - 2025-12-17 ### 🚀 Features - add validation errors for incompatible `inlineDynamicImports` options (#7539) by @Copilot - rolldown_plugin_vite_reporter: truncate long importer lists in ineffective dynamic import warnings (#7528) by @Copilot - export `memfs` from `rolldown/experimental` for browser builds (#7490) by @Copilot - implement `postBanner` and `postFooter` (#7487) by @sevenc-nanashi - port getLogFilter helper from Rollup for advanced log filtering (#6890) by @taearls - dev: initialize `rolldown_plugin_lazy_compilation` (#7488) by @hyf0 - enable `experimental.transform_hires_sourcemap: 'boundary'` by default (#7478) by @sapphi-red - apply merge CJS namespace optimizations more generally (#7475) by @sapphi-red ### 🐛 Bug Fixes - avoid panic on invalid values for `output.exports`, `output.format`, `output.hash_characters` (#7542) by @sapphi-red - handle `__proto__` export for module namespace correctly (#7534) by @sapphi-red - handle `__proto__` export correctly (#7533) by @sapphi-red - rolldown_plugin_vite_resolve: acquire resolver lock before package json resolution (#7524) by @sapphi-red - disable syntax transform optimization for `minify: 'dce-only'` (#7520) by @sapphi-red - arrow function expression keep names (#7519) by @IWANABETHATGUY - skip symbols that are imported from other module when deconflicting module symbols (#7510) by @IWANABETHATGUY - preserve class names in assignment expressions with keepNames option (#7491) by @IWANABETHATGUY - accessor with decorators should be kept (#7499) by @Copilot - rolldown_plugin_vite_reporter: support `Infinity` for chunk_limit (#7497) by @shulaoda - change filename template validation errors from UNHANDLEABLE_ERROR to INVALID_OPTION (#7472) by @Copilot - `no entry found for key` error when merging CJS namespace exports (#7474) by @sapphi-red - generate output with syntax error when wrapped esm module using tla syntax (#7468) by @IWANABETHATGUY ### 🚜 Refactor - dev: rename `experimental.hmr` to `experimental.devMode` (#7527) by @hyf0 - pass addon option to rust as it is (#7526) by @hyf0 - remove unused stmtinfo meta flag (#7518) by @IWANABETHATGUY ### 📚 Documentation - clarify `closeBundle` behavior (#7525) by @sapphi-red ### 🧪 Testing - add tests for static string postBanner and postFooter (#7516) by @Copilot - disable pluginTimings in Rust integration tests to avoid snapshot noise (#7485) by @shulaoda - port Rollup JSX tests to `crates/rolldown/tests/rollup` (#7480) by @sapphi-red - re-triage some esbuild JSX preserve tests (#7479) by @sapphi-red - disable pluginTimings by default to avoid snapshot noise (#7471) by @shulaoda ### ⚙️ Miscellaneous Tasks - mark feature that will not be supported as ignored in rollup test status (#7535) by @sapphi-red - support `banner`/`footer`/`intro`/`outro` for config variants (#7532) by @sapphi-red - `dce/dce_of_decorators` esbuild test is now passing (#7531) by @sapphi-red - deps: update github-actions (major) (#7495) by @renovate[bot] - deps: update npm packages (#7493) by @renovate[bot] - add a check to verify failedReasons are updated (#7521) by @sapphi-red - deps: update test262 submodule for tests (#7523) by @sapphi-red - deps: update taiki-e/install-action action to v2.63.2 (#7496) by @renovate[bot] - deps: update oxc apps (#7511) by @renovate[bot] - deps: update oxc to v0.103.0 (#7513) by @camc314 - fix format in `.github/instructions/bug-investigation.instructions.md` (#7506) by @sapphi-red - add instructions for REPL decoding (#7502) by @sapphi-red - deps: update github-actions (#7492) by @renovate[bot] - deps: cargo-shear v1.9.0 (#7483) by @Boshen - deps: update dependency oxlint-tsgolint to v0.9.0 (#7484) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.8.6 (#7470) by @renovate[bot] - add syntax validation for test output chunks that are not executed (#7466) by @IWANABETHATGUY - deps: update dependency rust to v1.92.0 (#7467) by @renovate[bot] - deps: update test262 submodule for tests (#7457) by @sapphi-red ### ❤️ New Contributors * @sevenc-nanashi made their first contribution in [#7487](#7487) * @taearls made their first contribution in [#6890](#6890) Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned IWANABETHATGUY Dec 14, 2025

IWANABETHATGUY force-pushed the 12-14-fix_7481 branch 3 times, most recently from f0e59d8 to ff4b423 Compare December 15, 2025 05:21

IWANABETHATGUY marked this pull request as ready for review December 15, 2025 05:34

Copilot AI review requested due to automatic review settings December 15, 2025 05:34

Copilot started reviewing on behalf of IWANABETHATGUY December 15, 2025 05:34 View session

Copilot AI reviewed Dec 15, 2025

View reviewed changes

IWANABETHATGUY force-pushed the 12-14-fix_7481 branch from ff4b423 to 8c9c85c Compare December 15, 2025 06:12

IWANABETHATGUY changed the title ~~fix: 7481~~ fix: preserve class names in assignment expressions with keepNames option Dec 15, 2025

Copilot AI review requested due to automatic review settings December 15, 2025 07:29

IWANABETHATGUY force-pushed the 12-14-fix_7481 branch from 8c9c85c to 4ab2d8e Compare December 15, 2025 07:29

Copilot started reviewing on behalf of IWANABETHATGUY December 15, 2025 07:29 View session

Copilot AI reviewed Dec 15, 2025

View reviewed changes

test.js Outdated Show resolved Hide resolved

crates/rolldown/src/module_finalizers/mod.rs Show resolved Hide resolved

IWANABETHATGUY force-pushed the 12-14-fix_7481 branch from 4ab2d8e to 0582e62 Compare December 15, 2025 07:34

Copilot AI review requested due to automatic review settings December 15, 2025 07:37

IWANABETHATGUY force-pushed the 12-14-fix_7481 branch from 0582e62 to 682e436 Compare December 15, 2025 07:37

Copilot started reviewing on behalf of IWANABETHATGUY December 15, 2025 07:38 View session

IWANABETHATGUY requested review from Copilot and sapphi-red and removed request for Copilot December 15, 2025 07:39

IWANABETHATGUY force-pushed the 12-14-fix_7481 branch from 682e436 to 0d95b1e Compare December 15, 2025 07:39

Copilot started reviewing on behalf of IWANABETHATGUY December 15, 2025 07:40 View session

IWANABETHATGUY force-pushed the 12-14-fix_7481 branch from 0d95b1e to ad7e046 Compare December 15, 2025 07:43

Copilot AI reviewed Dec 15, 2025

View reviewed changes

IWANABETHATGUY force-pushed the 12-14-fix_7481 branch from ad7e046 to 268c778 Compare December 15, 2025 07:51

sapphi-red approved these changes Dec 15, 2025

View reviewed changes

graphite-app bot pushed a commit that referenced this pull request Dec 15, 2025

fix: preserve class names in assignment expressions with keepNames op…

b6cad5e

…tion (#7491) closed #7481

graphite-app bot force-pushed the 12-14-fix_7481 branch from 268c778 to b6cad5e Compare December 15, 2025 08:14

fix: preserve class names in assignment expressions with keepNames op…

bb3a709

…tion (#7491) closed #7481

Copilot AI review requested due to automatic review settings December 15, 2025 08:18

graphite-app bot force-pushed the 12-14-fix_7481 branch from b6cad5e to bb3a709 Compare December 15, 2025 08:18

Copilot AI reviewed Dec 15, 2025

View reviewed changes

graphite-app bot merged commit bb3a709 into main Dec 15, 2025
28 checks passed

graphite-app bot deleted the 12-14-fix_7481 branch December 15, 2025 08:36

sapphi-red mentioned this pull request Dec 15, 2025

[Bug]: __name is not properly injected when the class name is deconflicted even if keepNames is enabled #7481

Closed

This was referenced Dec 17, 2025

release: v1.0.0-beta.55 #7536

Closed

release: v1.0.0-beta.55 #7543

Merged

sapphi-red mentioned this pull request Feb 4, 2026

feat(test): decorator and deconflict_exported_names #4596

Closed

Comments

Conversation

IWANABETHATGUY commented Dec 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IWANABETHATGUY commented Dec 14, 2025

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Dec 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

github-actions bot commented Dec 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

graphite-app bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IWANABETHATGUY commented Dec 14, 2025 •

edited

Loading

netlify bot commented Dec 14, 2025 •

edited

Loading

github-actions bot commented Dec 14, 2025 •

edited

Loading

graphite-app bot commented Dec 15, 2025 •

edited

Loading