Skip to content

Comments

feat: enable experimental.transform_hires_sourcemap: 'boundary' by default#7478

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-12-feat_enable_experimental.transform_hires_sourcemap_boundary_by_default
Dec 12, 2025
Merged

feat: enable experimental.transform_hires_sourcemap: 'boundary' by default#7478
graphite-app[bot] merged 1 commit intomainfrom
12-12-feat_enable_experimental.transform_hires_sourcemap_boundary_by_default

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Dec 12, 2025

refs #7477, #5346

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Dec 12, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit d23d30f
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/693bfe2b4158da0008ee633c

@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2025

Benchmarks Rust

  • target: main(331c812)
  • pr: 12-12-feat_enable_experimental.transform_hires_sourcemap_boundary_by_default(d23d30f)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     64.7±2.24ms        ? ?/sec    1.01     65.2±1.78ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     72.9±1.52ms        ? ?/sec    1.00     72.5±2.34ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    106.9±3.67ms        ? ?/sec    1.01    108.5±2.14ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    119.2±2.74ms        ? ?/sec    1.01    120.1±1.90ms        ? ?/sec
bundle/bundle@threejs                                        1.01     39.6±2.50ms        ? ?/sec    1.00     39.1±0.72ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     43.1±0.77ms        ? ?/sec    1.00     42.5±0.65ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    392.1±7.61ms        ? ?/sec    1.01    395.7±6.95ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    445.7±3.30ms        ? ?/sec    1.02    454.3±5.13ms        ? ?/sec
scan/scan@rome_ts                                            1.01     84.2±1.59ms        ? ?/sec    1.00     83.1±1.36ms        ? ?/sec
scan/scan@threejs                                            1.01     29.1±1.92ms        ? ?/sec    1.00     28.9±1.88ms        ? ?/sec
scan/scan@threejs10x                                         1.01    295.1±5.17ms        ? ?/sec    1.00    293.6±4.57ms        ? ?/sec

@sapphi-red
Copy link
Member Author

@sapphi-red sapphi-red marked this pull request as ready for review December 12, 2025 11:06
Copilot AI review requested due to automatic review settings December 12, 2025 11:06
@sapphi-red sapphi-red requested a review from shulaoda December 12, 2025 11:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR changes the default value of the experimental transform_hires_sourcemap option from Boolean(true) (high-resolution sourcemaps enabled) to Boundary (boundary-only high-resolution sourcemaps). This affects sourcemap generation during the transform phase of the build process.

Key Changes

  • Default sourcemap hires mode changes from boolean true to boundary mode across plugin system
  • Binding layer now returns Some(Boundary) instead of None when option is not explicitly set
  • All three usage sites (plugin driver, transform context, bindings) consistently apply the new default

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
crates/rolldown_plugin/src/plugin_driver/build_hooks.rs Updates default in normalize_transform_sourcemap when creating fallback sourcemaps
crates/rolldown_plugin/src/plugin_context/transform_plugin_context.rs Updates default in create_sourcemap method for transform plugin context
crates/rolldown_binding/src/options/binding_input_options/binding_experimental_options.rs Changes binding conversion to return Some(Boundary) instead of None when option is unset

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sapphi-red sapphi-red self-assigned this Dec 12, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 12, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 12-12-feat_enable_experimental.transform_hires_sourcemap_boundary_by_default branch from 602c41a to d23d30f Compare December 12, 2025 11:36
@graphite-app graphite-app bot merged commit d23d30f into main Dec 12, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 12-12-feat_enable_experimental.transform_hires_sourcemap_boundary_by_default branch December 12, 2025 11:52
This was referenced Dec 17, 2025
shulaoda added a commit that referenced this pull request Dec 17, 2025
## [1.0.0-beta.55] - 2025-12-17

### 🚀 Features

- add validation errors for incompatible `inlineDynamicImports` options (#7539) by @Copilot
- rolldown_plugin_vite_reporter: truncate long importer lists in ineffective dynamic import warnings (#7528) by @Copilot
- export `memfs` from `rolldown/experimental` for browser builds (#7490) by @Copilot
- implement `postBanner` and `postFooter` (#7487) by @sevenc-nanashi
- port getLogFilter helper from Rollup for advanced log filtering (#6890) by @taearls
- dev: initialize `rolldown_plugin_lazy_compilation` (#7488) by @hyf0
- enable `experimental.transform_hires_sourcemap: 'boundary'` by default (#7478) by @sapphi-red
- apply merge CJS namespace optimizations more generally (#7475) by @sapphi-red

### 🐛 Bug Fixes

- avoid panic on invalid values for `output.exports`, `output.format`, `output.hash_characters` (#7542) by @sapphi-red
- handle `__proto__` export for module namespace correctly (#7534) by @sapphi-red
- handle `__proto__` export correctly (#7533) by @sapphi-red
- rolldown_plugin_vite_resolve: acquire resolver lock before package json resolution (#7524) by @sapphi-red
- disable syntax transform optimization for `minify: 'dce-only'` (#7520) by @sapphi-red
- arrow function expression keep names (#7519) by @IWANABETHATGUY
- skip symbols that are imported from other module when deconflicting module symbols (#7510) by @IWANABETHATGUY
- preserve class names in assignment expressions with keepNames option (#7491) by @IWANABETHATGUY
- accessor with decorators should be kept (#7499) by @Copilot
- rolldown_plugin_vite_reporter: support `Infinity` for chunk_limit (#7497) by @shulaoda
- change filename template validation errors from UNHANDLEABLE_ERROR to INVALID_OPTION (#7472) by @Copilot
- `no entry found for key` error when merging CJS namespace exports (#7474) by @sapphi-red
- generate output with syntax error when wrapped esm module using tla syntax (#7468) by @IWANABETHATGUY

### 🚜 Refactor

- dev: rename `experimental.hmr` to `experimental.devMode` (#7527) by @hyf0
- pass addon option to rust as it is (#7526) by @hyf0
- remove unused stmtinfo meta flag (#7518) by @IWANABETHATGUY

### 📚 Documentation

- clarify `closeBundle` behavior (#7525) by @sapphi-red

### 🧪 Testing

- add tests for static string postBanner and postFooter (#7516) by @Copilot
- disable pluginTimings in Rust integration tests to avoid snapshot noise (#7485) by @shulaoda
- port Rollup JSX tests to `crates/rolldown/tests/rollup` (#7480) by @sapphi-red
- re-triage some esbuild JSX preserve tests (#7479) by @sapphi-red
- disable pluginTimings by default to avoid snapshot noise (#7471) by @shulaoda

### ⚙️ Miscellaneous Tasks

- mark feature that will not be supported as ignored in rollup test status (#7535) by @sapphi-red
- support `banner`/`footer`/`intro`/`outro` for config variants (#7532) by @sapphi-red
- `dce/dce_of_decorators` esbuild test is now passing (#7531) by @sapphi-red
- deps: update github-actions (major) (#7495) by @renovate[bot]
- deps: update npm packages (#7493) by @renovate[bot]
- add a check to verify failedReasons are updated (#7521) by @sapphi-red
- deps: update test262 submodule for tests (#7523) by @sapphi-red
- deps: update taiki-e/install-action action to v2.63.2 (#7496) by @renovate[bot]
- deps: update oxc apps (#7511) by @renovate[bot]
- deps: update oxc to v0.103.0 (#7513) by @camc314
- fix format in `.github/instructions/bug-investigation.instructions.md` (#7506) by @sapphi-red
- add instructions for REPL decoding (#7502) by @sapphi-red
- deps: update github-actions (#7492) by @renovate[bot]
- deps: cargo-shear v1.9.0 (#7483) by @Boshen
- deps: update dependency oxlint-tsgolint to v0.9.0 (#7484) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.8.6 (#7470) by @renovate[bot]
- add syntax validation for test output chunks that are not executed (#7466) by @IWANABETHATGUY
- deps: update dependency rust to v1.92.0 (#7467) by @renovate[bot]
- deps: update test262 submodule for tests (#7457) by @sapphi-red

### ❤️ New Contributors

* @sevenc-nanashi made their first contribution in [#7487](#7487)
* @taearls made their first contribution in [#6890](#6890)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants