test: disable pluginTimings by default to avoid snapshot noise by shulaoda · Pull Request #7471 · rolldown/rolldown

shulaoda · 2025-12-12T02:38:33Z

See https://github.com/rolldown/rolldown/actions/runs/20154042854/job/57852611690?pr=7470

shulaoda · 2025-12-12T02:38:48Z

test: disable pluginTimings by default to avoid snapshot noise #7471 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2025-12-12T02:39:55Z

✅ Deploy Preview for rolldown-rs ready!

Name	Link
🔨 Latest commit	`4b85b97`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/693bc2c13d22730008beb056
😎 Deploy Preview	https://deploy-preview-7471--rolldown-rs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Pull request overview

This PR aims to disable the pluginTimings check by default in fixture tests to prevent non-deterministic timing data from causing snapshot test failures.

Sets inputOptions.checks.pluginTimings to false by default in the test fixture compilation function
Adds a comment explaining this is to avoid snapshot noise from timing data

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/rolldown/tests/fixture.test.ts

sapphi-red

Would you update these as well?:

rolldown/packages/rollup-tests/test/form/index.js

Line 81 in db1e842

if (warnings.length > 0) {
rolldown/packages/rollup-tests/test/sourcemaps/index.js

Line 63 in e041fed

throw new Error(`Unexpected warnings`);
rolldown/packages/rollup-tests/test/browser/index.js

Line 34 in e041fed

`Unexpected warnings (${warning.code}): ${warning.message}\n` +
rolldown/packages/rollup-tests/test/chunking-form/index.js

Line 63 in e041fed

`Unexpected warnings (${[...codes].join(', ')}): \n${warnings
rolldown/packages/rollup-tests/test/function/index.js

Line 220 in e041fed

`Got unexpected warnings:\n${warnings

packages/rollup-tests/test/utils.js

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/rollup-tests/test/utils.js

graphite-app · 2025-12-12T04:19:35Z

Merge activity

Dec 12, 4:19 AM UTC: shulaoda added this pull request to the Graphite merge queue.
Dec 12, 4:32 AM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'node-test (ubuntu-latest) / Node Test', 'node-test (macos-latest) / Node Test', 'node-test (windows-latest) / Node Test').

See https://github.com/rolldown/rolldown/actions/runs/20154042854/job/57852611690?pr=7470

sapphi-red · 2025-12-12T05:28:41Z

It seems it's still happening?
https://github.com/rolldown/rolldown/actions/runs/20156164537/job/57859137892?pr=7471#step:23:2192

See https://github.com/rolldown/rolldown/actions/runs/20154042854/job/57852611690?pr=7470

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/rollup-tests/test/sourcemaps/index.js

@sevenc-nanashi

## [1.0.0-beta.55] - 2025-12-17 ### 🚀 Features - add validation errors for incompatible `inlineDynamicImports` options (#7539) by @Copilot - rolldown_plugin_vite_reporter: truncate long importer lists in ineffective dynamic import warnings (#7528) by @Copilot - export `memfs` from `rolldown/experimental` for browser builds (#7490) by @Copilot - implement `postBanner` and `postFooter` (#7487) by @sevenc-nanashi - port getLogFilter helper from Rollup for advanced log filtering (#6890) by @taearls - dev: initialize `rolldown_plugin_lazy_compilation` (#7488) by @hyf0 - enable `experimental.transform_hires_sourcemap: 'boundary'` by default (#7478) by @sapphi-red - apply merge CJS namespace optimizations more generally (#7475) by @sapphi-red ### 🐛 Bug Fixes - avoid panic on invalid values for `output.exports`, `output.format`, `output.hash_characters` (#7542) by @sapphi-red - handle `__proto__` export for module namespace correctly (#7534) by @sapphi-red - handle `__proto__` export correctly (#7533) by @sapphi-red - rolldown_plugin_vite_resolve: acquire resolver lock before package json resolution (#7524) by @sapphi-red - disable syntax transform optimization for `minify: 'dce-only'` (#7520) by @sapphi-red - arrow function expression keep names (#7519) by @IWANABETHATGUY - skip symbols that are imported from other module when deconflicting module symbols (#7510) by @IWANABETHATGUY - preserve class names in assignment expressions with keepNames option (#7491) by @IWANABETHATGUY - accessor with decorators should be kept (#7499) by @Copilot - rolldown_plugin_vite_reporter: support `Infinity` for chunk_limit (#7497) by @shulaoda - change filename template validation errors from UNHANDLEABLE_ERROR to INVALID_OPTION (#7472) by @Copilot - `no entry found for key` error when merging CJS namespace exports (#7474) by @sapphi-red - generate output with syntax error when wrapped esm module using tla syntax (#7468) by @IWANABETHATGUY ### 🚜 Refactor - dev: rename `experimental.hmr` to `experimental.devMode` (#7527) by @hyf0 - pass addon option to rust as it is (#7526) by @hyf0 - remove unused stmtinfo meta flag (#7518) by @IWANABETHATGUY ### 📚 Documentation - clarify `closeBundle` behavior (#7525) by @sapphi-red ### 🧪 Testing - add tests for static string postBanner and postFooter (#7516) by @Copilot - disable pluginTimings in Rust integration tests to avoid snapshot noise (#7485) by @shulaoda - port Rollup JSX tests to `crates/rolldown/tests/rollup` (#7480) by @sapphi-red - re-triage some esbuild JSX preserve tests (#7479) by @sapphi-red - disable pluginTimings by default to avoid snapshot noise (#7471) by @shulaoda ### ⚙️ Miscellaneous Tasks - mark feature that will not be supported as ignored in rollup test status (#7535) by @sapphi-red - support `banner`/`footer`/`intro`/`outro` for config variants (#7532) by @sapphi-red - `dce/dce_of_decorators` esbuild test is now passing (#7531) by @sapphi-red - deps: update github-actions (major) (#7495) by @renovate[bot] - deps: update npm packages (#7493) by @renovate[bot] - add a check to verify failedReasons are updated (#7521) by @sapphi-red - deps: update test262 submodule for tests (#7523) by @sapphi-red - deps: update taiki-e/install-action action to v2.63.2 (#7496) by @renovate[bot] - deps: update oxc apps (#7511) by @renovate[bot] - deps: update oxc to v0.103.0 (#7513) by @camc314 - fix format in `.github/instructions/bug-investigation.instructions.md` (#7506) by @sapphi-red - add instructions for REPL decoding (#7502) by @sapphi-red - deps: update github-actions (#7492) by @renovate[bot] - deps: cargo-shear v1.9.0 (#7483) by @Boshen - deps: update dependency oxlint-tsgolint to v0.9.0 (#7484) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.8.6 (#7470) by @renovate[bot] - add syntax validation for test output chunks that are not executed (#7466) by @IWANABETHATGUY - deps: update dependency rust to v1.92.0 (#7467) by @renovate[bot] - deps: update test262 submodule for tests (#7457) by @sapphi-red ### ❤️ New Contributors * @sevenc-nanashi made their first contribution in [#7487](#7487) * @taearls made their first contribution in [#6890](#6890) Co-authored-by: shulaoda <[email protected]>

See https://github.com/rolldown/rolldown/actions/runs/20154042854/job/57852611690?pr=7470

github-actions bot assigned shulaoda Dec 12, 2025

shulaoda requested review from IWANABETHATGUY and hyf0 December 12, 2025 02:38

shulaoda marked this pull request as ready for review December 12, 2025 02:38

Copilot AI review requested due to automatic review settings December 12, 2025 02:38

Copilot started reviewing on behalf of shulaoda December 12, 2025 02:39 View session

Copilot AI reviewed Dec 12, 2025

View reviewed changes

packages/rolldown/tests/fixture.test.ts Show resolved Hide resolved

sapphi-red reviewed Dec 12, 2025

View reviewed changes

shulaoda marked this pull request as draft December 12, 2025 03:22

shulaoda marked this pull request as ready for review December 12, 2025 03:47

shulaoda requested a review from sapphi-red December 12, 2025 03:47

shulaoda force-pushed the 12-12-test_disable_plugintimings_by_default_to_avoid_snapshot_noise branch from db1e842 to 82344a5 Compare December 12, 2025 03:47

shulaoda marked this pull request as draft December 12, 2025 03:48

shulaoda force-pushed the 12-12-test_disable_plugintimings_by_default_to_avoid_snapshot_noise branch from 82344a5 to e3b95c0 Compare December 12, 2025 03:56

shulaoda commented Dec 12, 2025

View reviewed changes

packages/rollup-tests/test/utils.js Outdated Show resolved Hide resolved

shulaoda marked this pull request as ready for review December 12, 2025 03:57

Copilot AI review requested due to automatic review settings December 12, 2025 03:57

Copilot started reviewing on behalf of shulaoda December 12, 2025 03:58 View session

Copilot AI reviewed Dec 12, 2025

View reviewed changes

packages/rollup-tests/test/utils.js Outdated Show resolved Hide resolved

packages/rollup-tests/test/utils.js Outdated Show resolved Hide resolved

shulaoda force-pushed the 12-12-test_disable_plugintimings_by_default_to_avoid_snapshot_noise branch from e3b95c0 to eca4d60 Compare December 12, 2025 04:02

sapphi-red approved these changes Dec 12, 2025

View reviewed changes

graphite-app bot force-pushed the 12-12-test_disable_plugintimings_by_default_to_avoid_snapshot_noise branch from eca4d60 to 8773fe6 Compare December 12, 2025 04:20

test: disable pluginTimings by default to avoid snapshot noise (#7471)

4b85b97

See https://github.com/rolldown/rolldown/actions/runs/20154042854/job/57852611690?pr=7470

Copilot AI review requested due to automatic review settings December 12, 2025 07:22

shulaoda force-pushed the 12-12-test_disable_plugintimings_by_default_to_avoid_snapshot_noise branch from 8773fe6 to 4b85b97 Compare December 12, 2025 07:22

Copilot started reviewing on behalf of shulaoda December 12, 2025 07:23 View session

Copilot AI reviewed Dec 12, 2025

View reviewed changes

packages/rollup-tests/test/sourcemaps/index.js Show resolved Hide resolved

shulaoda merged commit a4ca830 into main Dec 12, 2025
45 of 48 checks passed

shulaoda deleted the 12-12-test_disable_plugintimings_by_default_to_avoid_snapshot_noise branch December 12, 2025 08:08

This was referenced Dec 17, 2025

release: v1.0.0-beta.55 #7536

Closed

release: v1.0.0-beta.55 #7543

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

test: disable pluginTimings by default to avoid snapshot noise#7471

test: disable pluginTimings by default to avoid snapshot noise#7471
shulaoda merged 1 commit intomainfrom
12-12-test_disable_plugintimings_by_default_to_avoid_snapshot_noise

shulaoda commented Dec 12, 2025 •

edited

Loading

Uh oh!

shulaoda commented Dec 12, 2025

Uh oh!

netlify bot commented Dec 12, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

sapphi-red left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

graphite-app bot commented Dec 12, 2025 •

edited

Loading

Uh oh!

sapphi-red commented Dec 12, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

shulaoda commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shulaoda commented Dec 12, 2025

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

sapphi-red left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

graphite-app bot commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

sapphi-red commented Dec 12, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shulaoda commented Dec 12, 2025 •

edited

Loading

netlify bot commented Dec 12, 2025 •

edited

Loading

graphite-app bot commented Dec 12, 2025 •

edited

Loading