fix: generate output with syntax error when wrapped esm module using tla syntax by IWANABETHATGUY · Pull Request #7468 · rolldown/rolldown

IWANABETHATGUY · 2025-12-11T17:35:16Z

No description provided.

IWANABETHATGUY · 2025-12-11T17:35:41Z

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-12-11T18:00:39Z

Benchmarks Rust

target: main(1432dbb)
pr: 12-12-fix_generate_output_with_syntax_error_when_wrapped_esm_module_with_tla_syntax(a44cf98)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     65.0±2.36ms        ? ?/sec    1.02     66.5±1.70ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     70.9±1.57ms        ? ?/sec    1.03     72.7±1.65ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    107.7±2.15ms        ? ?/sec    1.01    109.0±1.76ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    119.3±2.79ms        ? ?/sec    1.03    122.7±2.77ms        ? ?/sec
bundle/bundle@threejs                                        1.02     40.8±2.86ms        ? ?/sec    1.00     40.1±2.52ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     42.9±0.70ms        ? ?/sec    1.02     43.8±0.78ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    395.8±6.48ms        ? ?/sec    1.01    398.8±7.20ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    451.7±4.67ms        ? ?/sec    1.01    456.9±4.10ms        ? ?/sec
scan/scan@rome_ts                                            1.01     84.8±1.50ms        ? ?/sec    1.00     83.9±1.44ms        ? ?/sec
scan/scan@threejs                                            1.02     29.0±1.81ms        ? ?/sec    1.00     28.3±0.42ms        ? ?/sec
scan/scan@threejs10x                                         1.00    293.7±3.96ms        ? ?/sec    1.00    293.9±4.22ms        ? ?/sec

netlify · 2025-12-12T05:31:48Z

❌ Deploy Preview for rolldown-rs failed.

Name	Link
🔨 Latest commit	`a44cf98`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/693bae8cf03e8600089f51c0

…tla syntax (#7468)

graphite-app · 2025-12-12T05:51:15Z

Merge activity

Dec 12, 5:50 AM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Dec 12, 6:14 AM UTC: Merged by the Graphite merge queue.

…tla syntax (#7468)

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@sevenc-nanashi

## [1.0.0-beta.55] - 2025-12-17 ### 🚀 Features - add validation errors for incompatible `inlineDynamicImports` options (#7539) by @Copilot - rolldown_plugin_vite_reporter: truncate long importer lists in ineffective dynamic import warnings (#7528) by @Copilot - export `memfs` from `rolldown/experimental` for browser builds (#7490) by @Copilot - implement `postBanner` and `postFooter` (#7487) by @sevenc-nanashi - port getLogFilter helper from Rollup for advanced log filtering (#6890) by @taearls - dev: initialize `rolldown_plugin_lazy_compilation` (#7488) by @hyf0 - enable `experimental.transform_hires_sourcemap: 'boundary'` by default (#7478) by @sapphi-red - apply merge CJS namespace optimizations more generally (#7475) by @sapphi-red ### 🐛 Bug Fixes - avoid panic on invalid values for `output.exports`, `output.format`, `output.hash_characters` (#7542) by @sapphi-red - handle `__proto__` export for module namespace correctly (#7534) by @sapphi-red - handle `__proto__` export correctly (#7533) by @sapphi-red - rolldown_plugin_vite_resolve: acquire resolver lock before package json resolution (#7524) by @sapphi-red - disable syntax transform optimization for `minify: 'dce-only'` (#7520) by @sapphi-red - arrow function expression keep names (#7519) by @IWANABETHATGUY - skip symbols that are imported from other module when deconflicting module symbols (#7510) by @IWANABETHATGUY - preserve class names in assignment expressions with keepNames option (#7491) by @IWANABETHATGUY - accessor with decorators should be kept (#7499) by @Copilot - rolldown_plugin_vite_reporter: support `Infinity` for chunk_limit (#7497) by @shulaoda - change filename template validation errors from UNHANDLEABLE_ERROR to INVALID_OPTION (#7472) by @Copilot - `no entry found for key` error when merging CJS namespace exports (#7474) by @sapphi-red - generate output with syntax error when wrapped esm module using tla syntax (#7468) by @IWANABETHATGUY ### 🚜 Refactor - dev: rename `experimental.hmr` to `experimental.devMode` (#7527) by @hyf0 - pass addon option to rust as it is (#7526) by @hyf0 - remove unused stmtinfo meta flag (#7518) by @IWANABETHATGUY ### 📚 Documentation - clarify `closeBundle` behavior (#7525) by @sapphi-red ### 🧪 Testing - add tests for static string postBanner and postFooter (#7516) by @Copilot - disable pluginTimings in Rust integration tests to avoid snapshot noise (#7485) by @shulaoda - port Rollup JSX tests to `crates/rolldown/tests/rollup` (#7480) by @sapphi-red - re-triage some esbuild JSX preserve tests (#7479) by @sapphi-red - disable pluginTimings by default to avoid snapshot noise (#7471) by @shulaoda ### ⚙️ Miscellaneous Tasks - mark feature that will not be supported as ignored in rollup test status (#7535) by @sapphi-red - support `banner`/`footer`/`intro`/`outro` for config variants (#7532) by @sapphi-red - `dce/dce_of_decorators` esbuild test is now passing (#7531) by @sapphi-red - deps: update github-actions (major) (#7495) by @renovate[bot] - deps: update npm packages (#7493) by @renovate[bot] - add a check to verify failedReasons are updated (#7521) by @sapphi-red - deps: update test262 submodule for tests (#7523) by @sapphi-red - deps: update taiki-e/install-action action to v2.63.2 (#7496) by @renovate[bot] - deps: update oxc apps (#7511) by @renovate[bot] - deps: update oxc to v0.103.0 (#7513) by @camc314 - fix format in `.github/instructions/bug-investigation.instructions.md` (#7506) by @sapphi-red - add instructions for REPL decoding (#7502) by @sapphi-red - deps: update github-actions (#7492) by @renovate[bot] - deps: cargo-shear v1.9.0 (#7483) by @Boshen - deps: update dependency oxlint-tsgolint to v0.9.0 (#7484) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.8.6 (#7470) by @renovate[bot] - add syntax validation for test output chunks that are not executed (#7466) by @IWANABETHATGUY - deps: update dependency rust to v1.92.0 (#7467) by @renovate[bot] - deps: update test262 submodule for tests (#7457) by @sapphi-red ### ❤️ New Contributors * @sevenc-nanashi made their first contribution in [#7487](#7487) * @taearls made their first contribution in [#6890](#6890) Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned IWANABETHATGUY Dec 11, 2025

IWANABETHATGUY mentioned this pull request Dec 11, 2025

chore: add syntax validation for test output chunks that are not executed #7466

Merged

IWANABETHATGUY marked this pull request as ready for review December 11, 2025 17:35

shulaoda approved these changes Dec 11, 2025

View reviewed changes

IWANABETHATGUY changed the title ~~fix: generate output with syntax error when wrapped esm module with tla syntax~~ fix: generate output with syntax error when wrapped esm module using tla syntax Dec 11, 2025

IWANABETHATGUY force-pushed the 12-12-fix_generate_output_with_syntax_error_when_wrapped_esm_module_with_tla_syntax branch 2 times, most recently from 2892bbc to 21910d1 Compare December 11, 2025 17:45

graphite-app bot changed the base branch from 12-12-chore_ensure_there_is_no_unexpected_syntax_error_for_test_case_that_are_not_executed to graphite-base/7468 December 12, 2025 03:17

graphite-app bot force-pushed the graphite-base/7468 branch from 9c83470 to b4e6dd1 Compare December 12, 2025 05:30

graphite-app bot force-pushed the 12-12-fix_generate_output_with_syntax_error_when_wrapped_esm_module_with_tla_syntax branch from 21910d1 to b66aa6b Compare December 12, 2025 05:30

graphite-app bot changed the base branch from graphite-base/7468 to main December 12, 2025 05:30

graphite-app bot force-pushed the 12-12-fix_generate_output_with_syntax_error_when_wrapped_esm_module_with_tla_syntax branch from b66aa6b to 03442c5 Compare December 12, 2025 05:30

graphite-app bot pushed a commit that referenced this pull request Dec 12, 2025

fix: generate output with syntax error when wrapped esm module using …

bfad31a

…tla syntax (#7468)

graphite-app bot force-pushed the 12-12-fix_generate_output_with_syntax_error_when_wrapped_esm_module_with_tla_syntax branch from 03442c5 to bfad31a Compare December 12, 2025 05:51

fix: generate output with syntax error when wrapped esm module using …

a44cf98

…tla syntax (#7468)

graphite-app bot force-pushed the 12-12-fix_generate_output_with_syntax_error_when_wrapped_esm_module_with_tla_syntax branch from bfad31a to a44cf98 Compare December 12, 2025 05:56

Copilot AI review requested due to automatic review settings December 12, 2025 05:56

Copilot AI reviewed Dec 12, 2025

View reviewed changes

graphite-app bot merged commit a44cf98 into main Dec 12, 2025
24 of 28 checks passed

graphite-app bot deleted the 12-12-fix_generate_output_with_syntax_error_when_wrapped_esm_module_with_tla_syntax branch December 12, 2025 06:14

This was referenced Dec 17, 2025

release: v1.0.0-beta.55 #7536

Closed

release: v1.0.0-beta.55 #7543

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

fix: generate output with syntax error when wrapped esm module using tla syntax#7468

fix: generate output with syntax error when wrapped esm module using tla syntax#7468
graphite-app[bot] merged 1 commit intomainfrom
12-12-fix_generate_output_with_syntax_error_when_wrapped_esm_module_with_tla_syntax

IWANABETHATGUY commented Dec 11, 2025

Uh oh!

IWANABETHATGUY commented Dec 11, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 11, 2025 •

edited

Loading

Uh oh!

netlify bot commented Dec 12, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Dec 12, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

IWANABETHATGUY commented Dec 11, 2025

Uh oh!

IWANABETHATGUY commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

netlify bot commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Deploy Preview for rolldown-rs failed.

Uh oh!

graphite-app bot commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IWANABETHATGUY commented Dec 11, 2025 •

edited

Loading

github-actions bot commented Dec 11, 2025 •

edited

Loading

netlify bot commented Dec 12, 2025 •

edited

Loading

graphite-app bot commented Dec 12, 2025 •

edited

Loading