chore: jsx_import_meta tests to `ignoreReasons` due to architectural limitation by Copilot · Pull Request #7434 · rolldown/rolldown

Copilot · 2025-12-10T15:21:06Z

The jsx_import_meta_property and jsx_import_meta_value tests cannot be supported due to the multi-pass transformer architecture in Rolldown.

Problem

When JSX is configured with pragma: "import.meta.factory" and define: { "import.meta": "{}" }, the JSX transformer injects import.meta references that should be replaced by the define plugin. However, this cannot be supported due to architectural constraints.

Why It Cannot Be Fixed

The define plugin must run before JSX transformation to avoid breaking other tests like define_optional_chain_lowered. This is because:

If define runs first, user-written code like a.b.c gets replaced with 1 before optional chain lowering
If define runs after JSX, the optional chain expressions would already be lowered (e.g., (_a = a) === null ? ...), and the define plugin would try to replace a.b.c within these complex expressions, producing incorrect output

Since JSX transformation happens after the define plugin, any import.meta references injected by JSX cannot be replaced.

Solution

Rather than attempting to fix this with code changes that would break other tests, these tests have been moved from failedReasons to ignoreReasons with a clear explanation of the architectural limitation.

Changes

scripts/src/esbuild-tests/reasons.ts:
- Removed jsx_import_meta_property and jsx_import_meta_value from failedReasons
- Added them to ignoreReasons with explanation: "due to multi pass transformer arch, import.meta injected by JSX transform cannot be replaced by the define plugin (define runs before JSX transform to avoid breaking other tests)"
- No code changes to the transformer pipeline - original behavior is preserved

Original prompt

Fix these two tests:

rolldown/scripts/src/esbuild-tests/reasons.ts

Lines 35 to 38 in 4649a86

'default/jsx_import_meta_property':

'`import.meta` injected by transform.jsx is not replaced with `{}`',

'default/jsx_import_meta_value':

'`import.meta` injected by transform.jsx is not replaced with `{}`',

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

netlify · 2025-12-10T15:22:08Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`81d6291`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/693a4843440f8e0008898270

…X transform Co-authored-by: sapphi-red <[email protected]>

Co-authored-by: sapphi-red <[email protected]>

sapphi-red · 2025-12-11T02:35:19Z

@copilot it's not working, try again

Co-authored-by: sapphi-red <[email protected]>

Copilot · 2025-12-11T02:39:58Z

@copilot it's not working, try again

Fixed in 081f167. The issue was that after JSX transformation consumed the scoping, I wasn't recreating it before running the define plugin. Now using recreate_scoping before the define plugin runs, consistent with how the inject plugin works.

github-actions · 2025-12-11T03:03:38Z

Benchmarks Rust

target: main(6cc187d)
pr: copilot/fix-esbuild-tests(42fa8bc)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.03     65.4±1.76ms        ? ?/sec    1.00     63.8±2.95ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     70.4±1.86ms        ? ?/sec    1.00     69.6±1.74ms        ? ?/sec
bundle/bundle@rome_ts                                        1.06    112.7±5.24ms        ? ?/sec    1.00    105.8±2.17ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.03    122.5±2.43ms        ? ?/sec    1.00    119.3±1.82ms        ? ?/sec
bundle/bundle@threejs                                        1.04     41.4±2.96ms        ? ?/sec    1.00     39.6±2.53ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.06     45.2±0.77ms        ? ?/sec    1.00     42.7±0.71ms        ? ?/sec
bundle/bundle@threejs10x                                     1.03    406.5±6.80ms        ? ?/sec    1.00    394.6±7.45ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.04    470.3±6.81ms        ? ?/sec    1.00    452.1±3.72ms        ? ?/sec
scan/scan@rome_ts                                            1.00     85.9±1.68ms        ? ?/sec    1.00     85.5±1.99ms        ? ?/sec
scan/scan@threejs                                            1.04     30.1±1.99ms        ? ?/sec    1.00     28.9±1.97ms        ? ?/sec
scan/scan@threejs10x                                         1.00    293.6±4.31ms        ? ?/sec    1.03    303.8±5.86ms        ? ?/sec

sapphi-red · 2025-12-11T03:22:58Z

@copilot the process order should be kept as before, otherwise the test will fail like

Snapshot file: crates/rolldown/tests/esbuild/default/define_optional_chain_lowered/artifacts.snap
Snapshot: artifacts
Source: crates/rolldown_testing/src/integration_test.rs:494
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬───────────────────────────────────────────────────────────────────
    3     3 │ ## entry.js
    4     4 │ 
    5     5 │ ```js
    6     6 │ //#region entry.js
    7       │-var _a, _a$b;
          7 │+var _a, _a$b, _a2, _a$b2, _a3, _a$b3;
    8     8 │ console.log([
    9     9 │ 	1,
   10       │-	1,
   11       │-	1
         10 │+	(_a = a) === null || _a === void 0 ? void 0 : _a.b.c,
         11 │+	(_a$b = a.b) === null || _a$b === void 0 ? void 0 : _a$b.c
   12    12 │ ], [
   13    13 │ 	1,
   14       │-	1,
   15       │-	1
         14 │+	(_a2 = a) === null || _a2 === void 0 ? void 0 : _a2["b"]["c"],
         15 │+	(_a$b2 = a["b"]) === null || _a$b2 === void 0 ? void 0 : _a$b2["c"]
   16    16 │ ], [
   17    17 │ 	a[b][c],
   18       │-	(_a = a) === null || _a === void 0 ? void 0 : _a[b][c],
   19       │-	(_a$b = a[b]) === null || _a$b === void 0 ? void 0 : _a$b[c]
         18 │+	(_a3 = a) === null || _a3 === void 0 ? void 0 : _a3[b][c],
         19 │+	(_a$b3 = a[b]) === null || _a$b3 === void 0 ? void 0 : _a$b3[c]
   20    20 │ ]);
   21    21 │ 
   22    22 │ //#endregion
   23    23 │ ```
────────────┴───────────────────────────────────────────────────────────────────

Co-authored-by: sapphi-red <[email protected]>

Copilot · 2025-12-11T03:39:04Z

@copilot the process order should be kept as before, otherwise the test will fail like
Snapshot file: crates/rolldown/tests/esbuild/default/define_optional_chain_lowered/artifacts.snap

...

Fixed in 42fa8bc. The second define plugin run now only executes for JSX/TSX files where JSX transformation might inject new import.meta references. This preserves the original behavior for other file types like the define_optional_chain_lowered test.

sapphi-red · 2025-12-11T04:04:33Z

@copilot let's keep the behavior as-is. move the failReason to ignoreReason and update the reason that describes it's not supported because ...

Co-authored-by: sapphi-red <[email protected]>

Copilot · 2025-12-11T04:09:15Z

@copilot let's keep the behavior as-is. move the failReason to ignoreReason and update the reason that describes it's not supported because ...

Done in 3a52f3b. Reverted all code changes and moved jsx_import_meta_property and jsx_import_meta_value from failedReasons to ignoreReasons with explanation: "due to multi pass transformer arch, import.meta injected by JSX transform cannot be replaced by the define plugin (define runs before JSX transform to avoid breaking other tests)".

scripts/src/esbuild-tests/reasons.ts

Signed-off-by: 翠 <[email protected]>

Copilot

Pull request overview

This PR addresses an architectural limitation in Rolldown's multi-pass transformer by moving two JSX-related test cases from failedReasons to ignoreReasons. The tests involve JSX configuration that injects import.meta references, which cannot be replaced by the define plugin due to the required execution order (define must run before JSX transformation to avoid breaking other tests).

Key changes:

Reclassified jsx_import_meta_property and jsx_import_meta_value tests as ignored rather than failed
Added architectural explanation for why these tests cannot be supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

scripts/src/esbuild-tests/reasons.ts

@shulaoda

## [1.0.0-beta.54] - 2025-12-11 ⏱️ Plugin Timing Analysis - Added `checks.pluginTimings` option to emit warnings when plugins significantly impact build performance - More details: https://rolldown.rs/options/checks#plugintimings <img width="834" height="119" alt="image" src="https://github.com/user-attachments/assets/e819f906-6192-4503-8d5c-854fa92ecb45" /> > [!WARNING] > For hooks using `ctx.resolve()` or `ctx.load()`, the reported time includes waiting for other plugins, which may overestimate that plugin's actual cost. > > Additionally, since plugin hooks execute concurrently, the statistics represent accumulated time rather than wall-clock time. The measured duration also includes Rust-side processing overhead, Tokio async scheduling overhead, NAPI data conversion overhead, and JavaScript event loop overhead. ### 🚀 Features - rolldown_plugin_vite_reporter: add newline after build summary for better log separation (#7458) by @shulaoda - plugin: collect plugin hook execution timings (#7364) by @shulaoda - test-dev-server: reload page when detecting hmr reload message (#7422) by @hyf0 - rolldown_plugin_vite_dynamic_import_vars: add transform-based v2 implementation (#7400) by @shulaoda - rolldown_plugin_vite_import_glob: add transform-based v2 implementation (#7394) by @shulaoda - rolldown_plugin_vite_wasm_helper: add v2 implementation (#7402) by @shulaoda - expose error location and context fields on JS API error objects (#7341) by @Copilot - add `CIRCULAR_REEXPORT` error (#7337) by @Copilot - support emit prebuilt chunk (#7277) by @Copilot ### 🐛 Bug Fixes - preserve object key order when parse json with serde_json (#7443) by @IWANABETHATGUY - improve JSON parsing with serde_json to emit proper diagnostic (#7442) by @IWANABETHATGUY - deconflict external symbols in CJS modules (#7447) by @IWANABETHATGUY - rolldown_plugin_vite_transform,rolldown_plugin_vite_resolve: enable `yarnPnp` option when pnp is detected (#5791) by @sapphi-red - skip deconflicting top-level symbols for CJS modules (#7425) by @IWANABETHATGUY - rolldown_plugin_esm_external_require: run resolveId hook before other plugins (#7426) by @shulaoda - avoid duplicate underscores in legitimized identifiers (#7418) by @IWANABETHATGUY - use `process.on('exit')` instead of `signal-exit` on webcontainers (#7421) by @sapphi-red - dev: remove `imports` when an import is removed (#7348) by @sapphi-red - bench: access latency.mean instead of mean in tinybench result (#7417) by @shulaoda - path compression in symbol linking (#7392) by @IWANABETHATGUY - rolldown_plugin_vite_resolve: add RwLock to avoid clearing cache while resolving (#7386) by @sapphi-red - handle JSON prototype properties correctly (#7383) by @IWANABETHATGUY - preserve entry signature strict chunk merging (#7343) by @IWANABETHATGUY - support eliminating multiple unused dynamic imports in a single statement (#7361) by @IWANABETHATGUY - eliminate unreachable dynamic entry (#7356) by @IWANABETHATGUY - `NormalizedInputOptions#cwd` should always exists (#7360) by @hyf0 - cli: support multiple comma-separated define arguments (#7340) by @Copilot - remove redundant symbol param in __reExport runtime helper (#7346) by @IWANABETHATGUY - always use __export for empty namespace objects when symbols enabled (#7345) by @IWANABETHATGUY - relax the restriction of preserveEntrySignatures when merging chunks (#7339) by @IWANABETHATGUY ### 🚜 Refactor - builtin-plugin: make config parameter required for vite plugins (#7451) by @shulaoda - move esbuild test related scripts to `scripts/src/esbuild-tests` (#7377) by @sapphi-red - rewrite gen-esbuild-test in TypeScript (#7376) by @sapphi-red - remove unnecessary Option in current_stmt_idx (#7359) by @IWANABETHATGUY - move more code into chunk optimizer (#7335) by @IWANABETHATGUY ### 📚 Documentation - checks: clarify pluginTimings measures CPU time due to concurrent execution (#7448) by @shulaoda - checks: add accuracy note to pluginTimings documentation (#7441) by @shulaoda - development-guide: add esbuild test description (#7439) by @sapphi-red - checks: expand `pluginTimings` documentation with detection mechanism (#7428) by @shulaoda - add checks options documentation (#7427) by @shulaoda - development-guide: add test262 integration test description (#7430) by @sapphi-red - guide: fix grammer in getting-started (#7331) by @jakeparis ### 🧪 Testing - rollup-tests: make `--grep` work and document it (#7431) by @sapphi-red - add a way to run some test262 test cases by name (#7429) by @sapphi-red - rolldown_plugin_vite_dynamic_import_vars: add test cases for v2 implementation (#7401) by @shulaoda - rolldown_plugin_vite_import_glob: add test cases for v2 implementation (#7395) by @shulaoda - triage new esbuild tests (#7405) by @sapphi-red - hmr: delete file used (#5933) by @sapphi-red - watch: add `watchChange` hook `create` / `delete` tests (#7349) by @sapphi-red - hmr: delete file not used anymore (#5932) by @sapphi-red - triage esbuild failed reasons (#7391) by @sapphi-red - change esbuild tests stats and diff generation (#7379) by @sapphi-red - dev: add `continuous generate hmr patch` and `debounce bundle` tests (#7368) by @hyf0 - add new esbuild tests (#7353) by @sapphi-red ### ⚙️ Miscellaneous Tasks - setup Node before updating snapshots for test262 update (#7435) by @sapphi-red - run tests when submodules are updated (#7455) by @sapphi-red - exclude NUL path pattern to prevent crash on Windows (#7450) by @IWANABETHATGUY - run cargo-test for esbuild script changes and update esbuild snapshot (#7440) by @sapphi-red - jsx_import_meta tests to `ignoreReasons` due to architectural limitation (#7434) by @Copilot - deps: update dependency oxlint-tsgolint to v0.8.5 (#7433) by @renovate[bot] - update test dependencies automatically (#7432) by @sapphi-red - remove unused code (#7420) by @IWANABETHATGUY - add back `just update-esbuild-diff` and add it to CI (#7404) by @sapphi-red - deps: update oxc-resolver to 11.15.0 (#7415) by @shulaoda - deps: update rust crate napi to v3.7.0 (#7393) by @renovate[bot] - fix esbuild compatibility metrics calculation (#7390) by @sapphi-red - support `tsconfig: true` in rust tests (#7389) by @sapphi-red - hide oxc runtime in snapshots (#7388) by @sapphi-red - deps: update oxc to v0.102.0 (#7385) by @camc314 - improve esbuild tests to download snapshots automatically (#7378) by @sapphi-red - deps: update dependency tinybench to v6 (#7371) by @renovate[bot] - deps: update actions/checkout action to v6 (#7370) by @renovate[bot] - deps: update rust crates (#7367) by @renovate[bot] - deps: update dependency oxlint to v1.32.0 (#7374) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.8.4 (#7373) by @renovate[bot] - node/test-dev-server: support using custom html file (#7357) by @hyf0 - test: setup browser-based e2e test for `test-dev-server` (#7351) by @hyf0 - pin pnpm to version 10.23.0 (#7369) by @IWANABETHATGUY - deps: update dependency rolldown-plugin-dts to v0.18.3 (#7372) by @renovate[bot] - deps: update github-actions (#7365) by @renovate[bot] - deps: update npm packages (#7366) by @renovate[bot] - polish the comments about `SymbolRefFlags` (#7358) by @IWANABETHATGUY - deps: update dependency rolldown-plugin-dts to v0.18.2 (#7355) by @renovate[bot] - fix esbuild test generation script (#7352) by @sapphi-red - apply cargo shear suggestion (#7347) by @IWANABETHATGUY - deps: update oxc to v11.15.0 (#7344) by @renovate[bot] - deps: update dependency @napi-rs/cli to v3.5.0 (#7338) by @renovate[bot] - deps: update dependency oxlint to v1.31.0 (#7305) by @renovate[bot] - update rollup-tests results (#7333) by @sapphi-red - update rollup-tests Rollup version (#7332) by @sapphi-red - add ignore config for test262 submodule (#7326) by @Copilot ### ❤️ New Contributors * @jakeparis made their first contribution in [#7331](#7331) Co-authored-by: shulaoda <[email protected]>

Initial plan

c2d05b2

Copilot AI assigned Copilot and sapphi-red Dec 10, 2025

Copilot started work on behalf of sapphi-red December 10, 2025 15:21 View session

Copilot AI and others added 2 commits December 10, 2025 15:52

Fix jsx_import_meta tests by reordering define plugin to run after JS…

41337fd

…X transform Co-authored-by: sapphi-red <[email protected]>

Remove jsx_import_meta tests from failed reasons list

ef6900c

Co-authored-by: sapphi-red <[email protected]>

Copilot AI changed the title ~~[WIP] Fix failing tests in esbuild test suite~~ Fix jsx_import_meta tests by running define plugin after JSX transform Dec 10, 2025

Copilot AI requested a review from sapphi-red December 10, 2025 16:16

Copilot finished work on behalf of sapphi-red December 10, 2025 16:16

Copilot started work on behalf of sapphi-red December 11, 2025 02:35 View session

Fix define plugin scoping after JSX transformation

081f167

Co-authored-by: sapphi-red <[email protected]>

Copilot finished work on behalf of sapphi-red December 11, 2025 02:42

Copilot started work on behalf of sapphi-red December 11, 2025 03:23 View session

Copilot AI and others added 3 commits December 11, 2025 03:28

Run define plugin twice: before and after JSX transform

580d474

Co-authored-by: sapphi-red <[email protected]>

Refactor: extract run_define_plugin helper method to reduce duplication

d8fe445

Co-authored-by: sapphi-red <[email protected]>

Add documentation for run_define_plugin helper method

e204c6e

Co-authored-by: sapphi-red <[email protected]>

Copilot AI changed the title ~~Fix jsx_import_meta tests by running define plugin after JSX transform~~ Fix jsx_import_meta tests by running define plugin twice Dec 11, 2025

Copilot finished work on behalf of sapphi-red December 11, 2025 03:34

Copilot started work on behalf of sapphi-red December 11, 2025 03:35 View session

Only run second define plugin pass for JSX/TSX files

42fa8bc

Co-authored-by: sapphi-red <[email protected]>

Copilot finished work on behalf of sapphi-red December 11, 2025 03:41

Copilot started work on behalf of sapphi-red December 11, 2025 04:04 View session

Move jsx_import_meta tests from failedReasons to ignoreReasons

3a52f3b

Co-authored-by: sapphi-red <[email protected]>

Copilot AI changed the title ~~Fix jsx_import_meta tests by running define plugin twice~~ Move jsx_import_meta tests to ignoreReasons due to architectural limitation Dec 11, 2025

Copilot finished work on behalf of sapphi-red December 11, 2025 04:11

sapphi-red changed the title ~~Move jsx_import_meta tests to ignoreReasons due to architectural limitation~~ chore: jsx_import_meta tests to ignoreReasons due to architectural limitation Dec 11, 2025

sapphi-red reviewed Dec 11, 2025

View reviewed changes

scripts/src/esbuild-tests/reasons.ts Outdated Show resolved Hide resolved

chore: update

81d6291

Signed-off-by: 翠 <[email protected]>

sapphi-red marked this pull request as ready for review December 11, 2025 04:54

Copilot AI review requested due to automatic review settings December 11, 2025 04:54

Copilot started reviewing on behalf of sapphi-red December 11, 2025 04:55 View session

sapphi-red merged commit 25cbc4b into main Dec 11, 2025
29 checks passed

sapphi-red deleted the copilot/fix-esbuild-tests branch December 11, 2025 04:55

Copilot AI reviewed Dec 11, 2025

View reviewed changes

scripts/src/esbuild-tests/reasons.ts Show resolved Hide resolved

This was referenced Dec 11, 2025

release: v1.0.0-beta.54 #7454

Closed

release: v1.0.0-beta.54 #7461

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

chore: jsx_import_meta tests to `ignoreReasons` due to architectural limitation#7434

chore: jsx_import_meta tests to `ignoreReasons` due to architectural limitation#7434
sapphi-red merged 10 commits intomainfrom
copilot/fix-esbuild-tests

Copilot AI commented Dec 10, 2025 •

edited

Loading

Uh oh!

netlify bot commented Dec 10, 2025 •

edited

Loading

Uh oh!

sapphi-red commented Dec 11, 2025

Uh oh!

Copilot AI commented Dec 11, 2025

Uh oh!

github-actions bot commented Dec 11, 2025 •

edited

Loading

Uh oh!

sapphi-red commented Dec 11, 2025

Uh oh!

Copilot AI commented Dec 11, 2025

Uh oh!

sapphi-red commented Dec 11, 2025

Uh oh!

Copilot AI commented Dec 11, 2025

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	'default/jsx_import_meta_property':
	'`import.meta` injected by transform.jsx is not replaced with `{}`',
	'default/jsx_import_meta_value':
	'`import.meta` injected by transform.jsx is not replaced with `{}`',

Comments

Conversation

Copilot AI commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Why It Cannot Be Fixed

Solution

Changes

Uh oh!

netlify bot commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

sapphi-red commented Dec 11, 2025

Uh oh!

Copilot AI commented Dec 11, 2025

Uh oh!

github-actions bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

sapphi-red commented Dec 11, 2025

Uh oh!

Copilot AI commented Dec 11, 2025

Uh oh!

sapphi-red commented Dec 11, 2025

Uh oh!

Copilot AI commented Dec 11, 2025

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Dec 10, 2025 •

edited

Loading

netlify bot commented Dec 10, 2025 •

edited

Loading

github-actions bot commented Dec 11, 2025 •

edited

Loading