Skip to content

Comments

fix(rolldown_plugin_esm_external_require): run resolveId hook before other plugins#7426

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-10-fix_rolldown_plugin_esm_external_require_run_resolveid_hook_before_other_plugins
Dec 10, 2025
Merged

fix(rolldown_plugin_esm_external_require): run resolveId hook before other plugins#7426
graphite-app[bot] merged 1 commit intomainfrom
12-10-fix_rolldown_plugin_esm_external_require_run_resolveid_hook_before_other_plugins

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Dec 10, 2025

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shulaoda shulaoda requested a review from sapphi-red December 10, 2025 10:48
@shulaoda shulaoda marked this pull request as ready for review December 10, 2025 10:48
@shulaoda shulaoda requested review from IWANABETHATGUY, Copilot and hyf0 and removed request for Copilot December 10, 2025 10:48
@netlify
Copy link

netlify bot commented Dec 10, 2025

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 64b073f
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/693961619e38e90008d10199
😎 Deploy Preview https://deploy-preview-7426--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add enforce: 'pre' here as well?

return new BuiltinPlugin('builtin:esm-external-require', config);

So that this plugin runs before other plugins with resolveId.order: 'pre'

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

Benchmarks Rust

  • target: main(97cf38f)
  • pr: 12-10-fix_rolldown_plugin_esm_external_require_run_resolveid_hook_before_other_plugins(64b073f)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     67.7±2.33ms        ? ?/sec    1.12     75.7±3.48ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     76.2±2.51ms        ? ?/sec    1.05     79.8±2.46ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    112.7±3.16ms        ? ?/sec    1.03    115.8±2.57ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    125.6±4.72ms        ? ?/sec    1.03    129.1±2.55ms        ? ?/sec
bundle/bundle@threejs                                        1.00     42.3±3.39ms        ? ?/sec    1.02     43.2±1.12ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     45.7±1.27ms        ? ?/sec    1.05     47.8±1.13ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    411.4±6.35ms        ? ?/sec    1.01    416.4±6.29ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01   476.2±10.01ms        ? ?/sec    1.00    473.1±5.31ms        ? ?/sec
scan/scan@rome_ts                                            1.01     92.2±2.64ms        ? ?/sec    1.00     91.6±3.51ms        ? ?/sec
scan/scan@threejs                                            1.02     31.5±1.83ms        ? ?/sec    1.00     31.0±1.11ms        ? ?/sec
scan/scan@threejs10x                                         1.00    313.5±5.11ms        ? ?/sec    1.00    312.2±6.13ms        ? ?/sec

@shulaoda shulaoda force-pushed the 12-10-fix_rolldown_plugin_esm_external_require_run_resolveid_hook_before_other_plugins branch from c8151d5 to 84a050c Compare December 10, 2025 11:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the plugin execution order for esmExternalRequirePlugin to ensure it processes imports before other plugins. This is necessary to resolve external requires correctly before other plugin transformations occur, addressing issue vitejs/rolldown-vite#513.

Key Changes:

  • Added resolve_id_meta() method in Rust returning PluginOrder::Pre to ensure early hook execution
  • Set enforce: 'pre' on the TypeScript plugin wrapper for Vite compatibility
  • Updated documentation to explain the plugin ordering behavior

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
packages/rolldown/src/builtin-plugin/utils.ts Added enforce property to BuiltinPlugin class for Vite-compatible plugin ordering
packages/rolldown/src/builtin-plugin/constructors.ts Set enforce: 'pre' on esmExternalRequirePlugin to run before other plugins
docs/builtin-plugins/esm-external-require.md Documented the plugin's execution order behavior for users
crates/rolldown_plugin_esm_external_require/src/lib.rs Implemented resolve_id_meta() to return PluginOrder::Pre for early hook execution

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 10, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 12-10-fix_rolldown_plugin_esm_external_require_run_resolveid_hook_before_other_plugins branch from 84a050c to 64b073f Compare December 10, 2025 12:02
@graphite-app graphite-app bot merged commit 64b073f into main Dec 10, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 12-10-fix_rolldown_plugin_esm_external_require_run_resolveid_hook_before_other_plugins branch December 10, 2025 12:20
This was referenced Dec 11, 2025
shulaoda added a commit that referenced this pull request Dec 11, 2025
## [1.0.0-beta.54] - 2025-12-11

⏱️ Plugin Timing Analysis
- Added `checks.pluginTimings` option to emit warnings when plugins significantly impact build performance
- More details: https://rolldown.rs/options/checks#plugintimings
<img width="834" height="119" alt="image" src="https://github.com/user-attachments/assets/e819f906-6192-4503-8d5c-854fa92ecb45" />

> [!WARNING]
> For hooks using `ctx.resolve()` or `ctx.load()`, the reported time includes waiting for other plugins, which may overestimate that plugin's actual cost.
>
> Additionally, since plugin hooks execute concurrently, the statistics represent accumulated time rather than wall-clock time. The measured duration also includes Rust-side processing overhead, Tokio async scheduling overhead, NAPI data conversion overhead, and JavaScript event loop overhead.

### 🚀 Features

- rolldown_plugin_vite_reporter: add newline after build summary for better log separation (#7458) by @shulaoda
- plugin: collect plugin hook execution timings (#7364) by @shulaoda
- test-dev-server: reload page when detecting hmr reload message (#7422) by @hyf0
- rolldown_plugin_vite_dynamic_import_vars: add transform-based v2 implementation (#7400) by @shulaoda
- rolldown_plugin_vite_import_glob: add transform-based v2 implementation (#7394) by @shulaoda
- rolldown_plugin_vite_wasm_helper: add v2 implementation (#7402) by @shulaoda
- expose error location and context fields on JS API error objects (#7341) by @Copilot
- add `CIRCULAR_REEXPORT` error (#7337) by @Copilot
- support emit prebuilt chunk (#7277) by @Copilot

### 🐛 Bug Fixes

- preserve object key order when parse json with serde_json (#7443) by @IWANABETHATGUY
- improve JSON parsing with serde_json to emit proper diagnostic (#7442) by @IWANABETHATGUY
- deconflict external symbols in CJS modules (#7447) by @IWANABETHATGUY
- rolldown_plugin_vite_transform,rolldown_plugin_vite_resolve: enable `yarnPnp` option when pnp is detected (#5791) by @sapphi-red
- skip deconflicting top-level symbols for CJS modules (#7425) by @IWANABETHATGUY
- rolldown_plugin_esm_external_require: run resolveId hook before other plugins (#7426) by @shulaoda
- avoid duplicate underscores in legitimized identifiers (#7418) by @IWANABETHATGUY
- use `process.on('exit')` instead of `signal-exit` on webcontainers (#7421) by @sapphi-red
- dev: remove `imports` when an import is removed (#7348) by @sapphi-red
- bench: access latency.mean instead of mean in tinybench result (#7417) by @shulaoda
- path compression in symbol linking (#7392) by @IWANABETHATGUY
- rolldown_plugin_vite_resolve: add RwLock to avoid clearing cache while resolving (#7386) by @sapphi-red
- handle JSON prototype properties correctly (#7383) by @IWANABETHATGUY
- preserve entry signature strict chunk merging (#7343) by @IWANABETHATGUY
- support eliminating multiple unused dynamic imports in a single statement (#7361) by @IWANABETHATGUY
- eliminate unreachable dynamic entry (#7356) by @IWANABETHATGUY
- `NormalizedInputOptions#cwd` should always exists (#7360) by @hyf0
- cli: support multiple comma-separated define arguments (#7340) by @Copilot
- remove redundant symbol param in __reExport runtime helper (#7346) by @IWANABETHATGUY
- always use __export for empty namespace objects when symbols enabled (#7345) by @IWANABETHATGUY
- relax the restriction of preserveEntrySignatures when merging chunks (#7339) by @IWANABETHATGUY

### 🚜 Refactor

- builtin-plugin: make config parameter required for vite plugins (#7451) by @shulaoda
- move esbuild test related scripts to `scripts/src/esbuild-tests` (#7377) by @sapphi-red
- rewrite gen-esbuild-test in TypeScript (#7376) by @sapphi-red
- remove unnecessary Option in current_stmt_idx (#7359) by @IWANABETHATGUY
- move more code into chunk optimizer (#7335) by @IWANABETHATGUY

### 📚 Documentation

- checks: clarify pluginTimings measures CPU time due to concurrent execution (#7448) by @shulaoda
- checks: add accuracy note to pluginTimings documentation (#7441) by @shulaoda
- development-guide: add esbuild test description (#7439) by @sapphi-red
- checks: expand `pluginTimings` documentation with detection mechanism (#7428) by @shulaoda
- add checks options documentation (#7427) by @shulaoda
- development-guide: add test262 integration test description (#7430) by @sapphi-red
- guide: fix grammer in getting-started (#7331) by @jakeparis

### 🧪 Testing

- rollup-tests: make `--grep` work and document it (#7431) by @sapphi-red
- add a way to run some test262 test cases by name (#7429) by @sapphi-red
- rolldown_plugin_vite_dynamic_import_vars: add test cases for v2 implementation (#7401) by @shulaoda
- rolldown_plugin_vite_import_glob: add test cases for v2 implementation (#7395) by @shulaoda
- triage new esbuild tests (#7405) by @sapphi-red
- hmr: delete file used (#5933) by @sapphi-red
- watch: add `watchChange` hook `create` / `delete` tests (#7349) by @sapphi-red
- hmr: delete file not used anymore (#5932) by @sapphi-red
- triage esbuild failed reasons (#7391) by @sapphi-red
- change esbuild tests stats and diff generation (#7379) by @sapphi-red
- dev: add `continuous generate hmr patch` and `debounce bundle` tests (#7368) by @hyf0
- add new esbuild tests (#7353) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- setup Node before updating snapshots for test262 update (#7435) by @sapphi-red
- run tests when submodules are updated (#7455) by @sapphi-red
- exclude NUL path pattern to prevent crash on Windows (#7450) by @IWANABETHATGUY
- run cargo-test for esbuild script changes and update esbuild snapshot (#7440) by @sapphi-red
- jsx_import_meta tests to `ignoreReasons` due to architectural limitation (#7434) by @Copilot
- deps: update dependency oxlint-tsgolint to v0.8.5 (#7433) by @renovate[bot]
- update test dependencies automatically (#7432) by @sapphi-red
- remove unused code (#7420) by @IWANABETHATGUY
- add back `just update-esbuild-diff` and add it to CI (#7404) by @sapphi-red
- deps: update oxc-resolver to 11.15.0 (#7415) by @shulaoda
- deps: update rust crate napi to v3.7.0 (#7393) by @renovate[bot]
- fix esbuild compatibility metrics calculation (#7390) by @sapphi-red
- support `tsconfig: true` in rust tests (#7389) by @sapphi-red
- hide oxc runtime in snapshots (#7388) by @sapphi-red
- deps: update oxc to v0.102.0 (#7385) by @camc314
- improve esbuild tests to download snapshots automatically (#7378) by @sapphi-red
- deps: update dependency tinybench to v6 (#7371) by @renovate[bot]
- deps: update actions/checkout action to v6 (#7370) by @renovate[bot]
- deps: update rust crates (#7367) by @renovate[bot]
- deps: update dependency oxlint to v1.32.0 (#7374) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.8.4 (#7373) by @renovate[bot]
- node/test-dev-server: support using custom html file (#7357) by @hyf0
- test: setup browser-based e2e test for `test-dev-server` (#7351) by @hyf0
- pin pnpm to version 10.23.0 (#7369) by @IWANABETHATGUY
- deps: update dependency rolldown-plugin-dts to v0.18.3 (#7372) by @renovate[bot]
- deps: update github-actions (#7365) by @renovate[bot]
- deps: update npm packages (#7366) by @renovate[bot]
- polish the comments about `SymbolRefFlags` (#7358) by @IWANABETHATGUY
- deps: update dependency rolldown-plugin-dts to v0.18.2 (#7355) by @renovate[bot]
- fix esbuild test generation script (#7352) by @sapphi-red
- apply cargo shear suggestion (#7347) by @IWANABETHATGUY
- deps: update oxc to v11.15.0 (#7344) by @renovate[bot]
- deps: update dependency @napi-rs/cli to v3.5.0 (#7338) by @renovate[bot]
- deps: update dependency oxlint to v1.31.0 (#7305) by @renovate[bot]
- update rollup-tests results (#7333) by @sapphi-red
- update rollup-tests Rollup version (#7332) by @sapphi-red
- add ignore config for test262 submodule (#7326) by @Copilot

### ❤️ New Contributors

* @jakeparis made their first contribution in [#7331](#7331)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The esmExternalRequirePlugin not work on rolldown-vite

2 participants