fix: preserve entry signature strict chunk merging by IWANABETHATGUY · Pull Request #7343 · rolldown/rolldown

IWANABETHATGUY · 2025-12-04T13:34:08Z

No description provided.

IWANABETHATGUY · 2025-12-04T13:34:25Z

fix: preserve entry signature strict chunk merging #7343 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2025-12-04T13:35:14Z

✅ Deploy Preview for rolldown-rs ready!

Name	Link
🔨 Latest commit	`a244fb6`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/693660134cbc8100087eec6a
😎 Deploy Preview	https://deploy-preview-7343--rolldown-rs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2025-12-04T14:01:25Z

Benchmarks Rust

target: main(5493488)
pr: 12-04-fix_preserve_entry_signature_strict_chunk_merging(a244fb6)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.02     64.4±1.65ms        ? ?/sec    1.00     63.2±1.58ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.02     70.9±1.61ms        ? ?/sec    1.00     69.7±1.63ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    107.6±4.39ms        ? ?/sec    1.00    106.0±2.89ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.02    120.1±1.99ms        ? ?/sec    1.00    118.0±1.55ms        ? ?/sec
bundle/bundle@threejs                                        1.00     39.1±0.57ms        ? ?/sec    1.01     39.6±2.25ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     42.6±0.57ms        ? ?/sec    1.00     42.2±0.67ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    393.9±4.45ms        ? ?/sec    1.00    390.9±5.48ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    449.9±3.26ms        ? ?/sec    1.00    448.8±3.75ms        ? ?/sec
scan/scan@rome_ts                                            1.00     83.6±1.42ms        ? ?/sec    1.01     84.5±1.69ms        ? ?/sec
scan/scan@threejs                                            1.00     28.0±0.35ms        ? ?/sec    1.03     28.8±1.91ms        ? ?/sec
scan/scan@threejs10x                                         1.00    292.0±3.83ms        ? ?/sec    1.01    295.6±5.02ms        ? ?/sec

crates/rolldown/src/types/generator.rs

Copilot

Pull request overview

This PR fixes chunk merging behavior when preserveEntrySignatures: 'strict' is configured. Previously, strict entry signature preservation prevented any module merging into entry chunks. Now, the bundler can safely merge modules into entry chunks if those modules' exports are already part of the entry's signature (i.e., re-exported by the entry). This optimization reduces the number of output chunks while still preserving the entry's public API.

Key changes:

Added logic to determine if modules can be merged without changing an entry's signature
Fixed default export handling in CJS format for cross-chunk imports
Added support for .cjs test files in the test infrastructure

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
crates/rolldown/src/stages/generate_stage/chunk_optimizer.rs	Implements `can_merge_without_changing_entry_signature` to enable safe merging of modules into strict entry chunks
crates/rolldown/src/types/generator.rs	Fixes default export handling in CJS format based on `exports` mode (auto vs named)
crates/rolldown_testing/src/integration_test.rs	Adds support for `_test.cjs` files in addition to `_test.mjs`
crates/rolldown/tests/rolldown/optimization/chunk_merging/cjs_format/*	New test case verifying CJS chunk merging with different export modes
Multiple snapshot files	Updated snapshots reflecting reduced chunk count due to improved merging

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/rolldown/src/stages/generate_stage/chunk_optimizer.rs

crates/rolldown/src/types/generator.rs

pkg-pr-new · 2025-12-08T02:39:17Z

Open in StackBlitz

@rolldown/browser

npm i https://pkg.pr.new/@rolldown/browser@7343

@rolldown/debug

npm i https://pkg.pr.new/@rolldown/debug@7343

@rolldown/pluginutils

npm i https://pkg.pr.new/@rolldown/pluginutils@7343

rolldown

npm i https://pkg.pr.new/rolldown@7343

@rolldown/binding-android-arm64

npm i https://pkg.pr.new/@rolldown/binding-android-arm64@7343

@rolldown/binding-darwin-arm64

npm i https://pkg.pr.new/@rolldown/binding-darwin-arm64@7343

@rolldown/binding-darwin-x64

npm i https://pkg.pr.new/@rolldown/binding-darwin-x64@7343

@rolldown/binding-freebsd-x64

npm i https://pkg.pr.new/@rolldown/binding-freebsd-x64@7343

@rolldown/binding-linux-arm-gnueabihf

npm i https://pkg.pr.new/@rolldown/binding-linux-arm-gnueabihf@7343

@rolldown/binding-linux-arm64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-gnu@7343

@rolldown/binding-linux-arm64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-musl@7343

@rolldown/binding-linux-x64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-gnu@7343

@rolldown/binding-linux-x64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-musl@7343

@rolldown/binding-openharmony-arm64

npm i https://pkg.pr.new/@rolldown/binding-openharmony-arm64@7343

@rolldown/binding-wasm32-wasi

npm i https://pkg.pr.new/@rolldown/binding-wasm32-wasi@7343

@rolldown/binding-win32-arm64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-arm64-msvc@7343

@rolldown/binding-win32-x64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-x64-msvc@7343

commit: 4a78072

crates/rolldown/tests/rolldown/function/format/cjs/shared_entry_modules/artifacts.snap

graphite-app · 2025-12-08T05:20:01Z

Merge activity

Dec 8, 5:20 AM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Dec 8, 5:36 AM UTC: Merged by the Graphite merge queue.

@shulaoda

## [1.0.0-beta.54] - 2025-12-11 ⏱️ Plugin Timing Analysis - Added `checks.pluginTimings` option to emit warnings when plugins significantly impact build performance - More details: https://rolldown.rs/options/checks#plugintimings <img width="834" height="119" alt="image" src="https://github.com/user-attachments/assets/e819f906-6192-4503-8d5c-854fa92ecb45" /> > [!WARNING] > For hooks using `ctx.resolve()` or `ctx.load()`, the reported time includes waiting for other plugins, which may overestimate that plugin's actual cost. > > Additionally, since plugin hooks execute concurrently, the statistics represent accumulated time rather than wall-clock time. The measured duration also includes Rust-side processing overhead, Tokio async scheduling overhead, NAPI data conversion overhead, and JavaScript event loop overhead. ### 🚀 Features - rolldown_plugin_vite_reporter: add newline after build summary for better log separation (#7458) by @shulaoda - plugin: collect plugin hook execution timings (#7364) by @shulaoda - test-dev-server: reload page when detecting hmr reload message (#7422) by @hyf0 - rolldown_plugin_vite_dynamic_import_vars: add transform-based v2 implementation (#7400) by @shulaoda - rolldown_plugin_vite_import_glob: add transform-based v2 implementation (#7394) by @shulaoda - rolldown_plugin_vite_wasm_helper: add v2 implementation (#7402) by @shulaoda - expose error location and context fields on JS API error objects (#7341) by @Copilot - add `CIRCULAR_REEXPORT` error (#7337) by @Copilot - support emit prebuilt chunk (#7277) by @Copilot ### 🐛 Bug Fixes - preserve object key order when parse json with serde_json (#7443) by @IWANABETHATGUY - improve JSON parsing with serde_json to emit proper diagnostic (#7442) by @IWANABETHATGUY - deconflict external symbols in CJS modules (#7447) by @IWANABETHATGUY - rolldown_plugin_vite_transform,rolldown_plugin_vite_resolve: enable `yarnPnp` option when pnp is detected (#5791) by @sapphi-red - skip deconflicting top-level symbols for CJS modules (#7425) by @IWANABETHATGUY - rolldown_plugin_esm_external_require: run resolveId hook before other plugins (#7426) by @shulaoda - avoid duplicate underscores in legitimized identifiers (#7418) by @IWANABETHATGUY - use `process.on('exit')` instead of `signal-exit` on webcontainers (#7421) by @sapphi-red - dev: remove `imports` when an import is removed (#7348) by @sapphi-red - bench: access latency.mean instead of mean in tinybench result (#7417) by @shulaoda - path compression in symbol linking (#7392) by @IWANABETHATGUY - rolldown_plugin_vite_resolve: add RwLock to avoid clearing cache while resolving (#7386) by @sapphi-red - handle JSON prototype properties correctly (#7383) by @IWANABETHATGUY - preserve entry signature strict chunk merging (#7343) by @IWANABETHATGUY - support eliminating multiple unused dynamic imports in a single statement (#7361) by @IWANABETHATGUY - eliminate unreachable dynamic entry (#7356) by @IWANABETHATGUY - `NormalizedInputOptions#cwd` should always exists (#7360) by @hyf0 - cli: support multiple comma-separated define arguments (#7340) by @Copilot - remove redundant symbol param in __reExport runtime helper (#7346) by @IWANABETHATGUY - always use __export for empty namespace objects when symbols enabled (#7345) by @IWANABETHATGUY - relax the restriction of preserveEntrySignatures when merging chunks (#7339) by @IWANABETHATGUY ### 🚜 Refactor - builtin-plugin: make config parameter required for vite plugins (#7451) by @shulaoda - move esbuild test related scripts to `scripts/src/esbuild-tests` (#7377) by @sapphi-red - rewrite gen-esbuild-test in TypeScript (#7376) by @sapphi-red - remove unnecessary Option in current_stmt_idx (#7359) by @IWANABETHATGUY - move more code into chunk optimizer (#7335) by @IWANABETHATGUY ### 📚 Documentation - checks: clarify pluginTimings measures CPU time due to concurrent execution (#7448) by @shulaoda - checks: add accuracy note to pluginTimings documentation (#7441) by @shulaoda - development-guide: add esbuild test description (#7439) by @sapphi-red - checks: expand `pluginTimings` documentation with detection mechanism (#7428) by @shulaoda - add checks options documentation (#7427) by @shulaoda - development-guide: add test262 integration test description (#7430) by @sapphi-red - guide: fix grammer in getting-started (#7331) by @jakeparis ### 🧪 Testing - rollup-tests: make `--grep` work and document it (#7431) by @sapphi-red - add a way to run some test262 test cases by name (#7429) by @sapphi-red - rolldown_plugin_vite_dynamic_import_vars: add test cases for v2 implementation (#7401) by @shulaoda - rolldown_plugin_vite_import_glob: add test cases for v2 implementation (#7395) by @shulaoda - triage new esbuild tests (#7405) by @sapphi-red - hmr: delete file used (#5933) by @sapphi-red - watch: add `watchChange` hook `create` / `delete` tests (#7349) by @sapphi-red - hmr: delete file not used anymore (#5932) by @sapphi-red - triage esbuild failed reasons (#7391) by @sapphi-red - change esbuild tests stats and diff generation (#7379) by @sapphi-red - dev: add `continuous generate hmr patch` and `debounce bundle` tests (#7368) by @hyf0 - add new esbuild tests (#7353) by @sapphi-red ### ⚙️ Miscellaneous Tasks - setup Node before updating snapshots for test262 update (#7435) by @sapphi-red - run tests when submodules are updated (#7455) by @sapphi-red - exclude NUL path pattern to prevent crash on Windows (#7450) by @IWANABETHATGUY - run cargo-test for esbuild script changes and update esbuild snapshot (#7440) by @sapphi-red - jsx_import_meta tests to `ignoreReasons` due to architectural limitation (#7434) by @Copilot - deps: update dependency oxlint-tsgolint to v0.8.5 (#7433) by @renovate[bot] - update test dependencies automatically (#7432) by @sapphi-red - remove unused code (#7420) by @IWANABETHATGUY - add back `just update-esbuild-diff` and add it to CI (#7404) by @sapphi-red - deps: update oxc-resolver to 11.15.0 (#7415) by @shulaoda - deps: update rust crate napi to v3.7.0 (#7393) by @renovate[bot] - fix esbuild compatibility metrics calculation (#7390) by @sapphi-red - support `tsconfig: true` in rust tests (#7389) by @sapphi-red - hide oxc runtime in snapshots (#7388) by @sapphi-red - deps: update oxc to v0.102.0 (#7385) by @camc314 - improve esbuild tests to download snapshots automatically (#7378) by @sapphi-red - deps: update dependency tinybench to v6 (#7371) by @renovate[bot] - deps: update actions/checkout action to v6 (#7370) by @renovate[bot] - deps: update rust crates (#7367) by @renovate[bot] - deps: update dependency oxlint to v1.32.0 (#7374) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.8.4 (#7373) by @renovate[bot] - node/test-dev-server: support using custom html file (#7357) by @hyf0 - test: setup browser-based e2e test for `test-dev-server` (#7351) by @hyf0 - pin pnpm to version 10.23.0 (#7369) by @IWANABETHATGUY - deps: update dependency rolldown-plugin-dts to v0.18.3 (#7372) by @renovate[bot] - deps: update github-actions (#7365) by @renovate[bot] - deps: update npm packages (#7366) by @renovate[bot] - polish the comments about `SymbolRefFlags` (#7358) by @IWANABETHATGUY - deps: update dependency rolldown-plugin-dts to v0.18.2 (#7355) by @renovate[bot] - fix esbuild test generation script (#7352) by @sapphi-red - apply cargo shear suggestion (#7347) by @IWANABETHATGUY - deps: update oxc to v11.15.0 (#7344) by @renovate[bot] - deps: update dependency @napi-rs/cli to v3.5.0 (#7338) by @renovate[bot] - deps: update dependency oxlint to v1.31.0 (#7305) by @renovate[bot] - update rollup-tests results (#7333) by @sapphi-red - update rollup-tests Rollup version (#7332) by @sapphi-red - add ignore config for test262 submodule (#7326) by @Copilot ### ❤️ New Contributors * @jakeparis made their first contribution in [#7331](#7331) Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned IWANABETHATGUY Dec 4, 2025

IWANABETHATGUY force-pushed the 12-04-fix_preserve_entry_signature_strict_chunk_merging branch 2 times, most recently from af23f1e to e608a17 Compare December 4, 2025 13:45

IWANABETHATGUY force-pushed the 12-04-fix_preserve_entry_signature_strict_chunk_merging branch 2 times, most recently from 95805cd to c291357 Compare December 7, 2025 18:06

IWANABETHATGUY commented Dec 7, 2025

View reviewed changes

crates/rolldown/src/types/generator.rs Show resolved Hide resolved

IWANABETHATGUY force-pushed the 12-04-fix_preserve_entry_signature_strict_chunk_merging branch 3 times, most recently from e50d441 to 4a78072 Compare December 8, 2025 02:19

IWANABETHATGUY marked this pull request as ready for review December 8, 2025 02:19

Copilot AI review requested due to automatic review settings December 8, 2025 02:19

Copilot started reviewing on behalf of IWANABETHATGUY December 8, 2025 02:20 View session

Copilot AI reviewed Dec 8, 2025

View reviewed changes

crates/rolldown/src/stages/generate_stage/chunk_optimizer.rs Outdated Show resolved Hide resolved

crates/rolldown/src/types/generator.rs Outdated Show resolved Hide resolved

IWANABETHATGUY added the trigger: preview label Dec 8, 2025

IWANABETHATGUY requested review from hyf0 and sapphi-red December 8, 2025 02:32

IWANABETHATGUY force-pushed the 12-04-fix_preserve_entry_signature_strict_chunk_merging branch from 4a78072 to 939eca3 Compare December 8, 2025 02:44

sapphi-red reviewed Dec 8, 2025

View reviewed changes

crates/rolldown/tests/rolldown/function/format/cjs/shared_entry_modules/artifacts.snap Show resolved Hide resolved

IWANABETHATGUY force-pushed the 12-04-fix_preserve_entry_signature_strict_chunk_merging branch from 939eca3 to 0aaefa9 Compare December 8, 2025 03:47

sapphi-red approved these changes Dec 8, 2025

View reviewed changes

fix: preserve entry signature strict chunk merging (#7343)

a244fb6

graphite-app bot force-pushed the 12-04-fix_preserve_entry_signature_strict_chunk_merging branch from 0aaefa9 to a244fb6 Compare December 8, 2025 05:20

graphite-app bot merged commit a244fb6 into main Dec 8, 2025
28 checks passed

graphite-app bot deleted the 12-04-fix_preserve_entry_signature_strict_chunk_merging branch December 8, 2025 05:36

IWANABETHATGUY mentioned this pull request Dec 8, 2025

[Feature Request]: remove unnecessary re-export module #4904

Closed

This was referenced Dec 10, 2025

release: v1.0.0-beta.54 #7412

Closed

release: v1.0.0-beta.54 #7454

Closed

release: v1.0.0-beta.54 #7461

Merged

TheAlexLichter mentioned this pull request Dec 15, 2025

8.0.0-beta.2 import mermaid from 'mermaid' error vitejs/rolldown-vite#561

Open

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

fix: preserve entry signature strict chunk merging#7343

fix: preserve entry signature strict chunk merging#7343
graphite-app[bot] merged 1 commit intomainfrom
12-04-fix_preserve_entry_signature_strict_chunk_merging

IWANABETHATGUY commented Dec 4, 2025

Uh oh!

IWANABETHATGUY commented Dec 4, 2025

Uh oh!

netlify bot commented Dec 4, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 4, 2025 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

pkg-pr-new bot commented Dec 8, 2025

Uh oh!

Uh oh!

graphite-app bot commented Dec 8, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

IWANABETHATGUY commented Dec 4, 2025

Uh oh!

IWANABETHATGUY commented Dec 4, 2025

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs ready!

Uh oh!

github-actions bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

pkg-pr-new bot commented Dec 8, 2025

Uh oh!

Uh oh!

graphite-app bot commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Dec 4, 2025 •

edited

Loading

github-actions bot commented Dec 4, 2025 •

edited

Loading

graphite-app bot commented Dec 8, 2025 •

edited

Loading