Skip to content

Comments

fix: relax the restriction of preserveEntrySignatures when merging chunks#7339

Merged
IWANABETHATGUY merged 1 commit intomainfrom
12-04-fix_relex_the_restriction_of_preserveentrysignatures
Dec 4, 2025
Merged

fix: relax the restriction of preserveEntrySignatures when merging chunks#7339
IWANABETHATGUY merged 1 commit intomainfrom
12-04-fix_relex_the_restriction_of_preserveentrysignatures

Conversation

@IWANABETHATGUY
Copy link
Member

No description provided.

Copy link
Member Author

IWANABETHATGUY commented Dec 4, 2025


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

Benchmarks Rust

  • target: main(daeb48f)
  • pr: 12-04-fix_relex_the_restriction_of_preserveentrysignatures(c107f59)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.11     79.6±3.28ms        ? ?/sec    1.00     71.8±2.39ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     81.5±2.17ms        ? ?/sec    1.01     82.3±5.37ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    119.2±3.92ms        ? ?/sec    1.00    119.6±4.70ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    132.8±3.00ms        ? ?/sec    1.00    132.0±3.97ms        ? ?/sec
bundle/bundle@threejs                                        1.02     43.7±2.91ms        ? ?/sec    1.00     42.6±0.92ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     46.2±0.87ms        ? ?/sec    1.02     46.9±1.41ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00   427.9±11.70ms        ? ?/sec    1.01    432.5±6.19ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00   493.4±10.34ms        ? ?/sec    1.00   495.5±10.89ms        ? ?/sec
scan/scan@rome_ts                                            1.02     91.2±1.89ms        ? ?/sec    1.00     89.5±1.90ms        ? ?/sec
scan/scan@threejs                                            1.06     31.9±1.96ms        ? ?/sec    1.00     30.2±0.86ms        ? ?/sec
scan/scan@threejs10x                                         1.02    319.0±5.53ms        ? ?/sec    1.00    312.2±5.27ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY changed the title fix: relex the restriction of preserveEntrySignatures fix: refleax the restriction of preserveEntrySignatures Dec 4, 2025
@IWANABETHATGUY IWANABETHATGUY force-pushed the 12-04-refactor_move_more_code_into_chunk_optimizer branch from 9d5da4a to ad07a44 Compare December 4, 2025 08:30
@IWANABETHATGUY IWANABETHATGUY force-pushed the 12-04-fix_relex_the_restriction_of_preserveentrysignatures branch from 03caeda to 7cae458 Compare December 4, 2025 08:30
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review December 4, 2025 08:59
@IWANABETHATGUY IWANABETHATGUY changed the title fix: refleax the restriction of preserveEntrySignatures fix: relax the restriction of preserveEntrySignatures Dec 4, 2025
@IWANABETHATGUY IWANABETHATGUY changed the title fix: relax the restriction of preserveEntrySignatures fix: relax the restriction of preserveEntrySignatures when merge chunks Dec 4, 2025
@IWANABETHATGUY IWANABETHATGUY force-pushed the 12-04-fix_relex_the_restriction_of_preserveentrysignatures branch from 7cae458 to a9c524d Compare December 4, 2025 11:40
@IWANABETHATGUY IWANABETHATGUY changed the title fix: relax the restriction of preserveEntrySignatures when merge chunks fix: relax the restriction of preserveEntrySignatures when merging chunks Dec 4, 2025
@graphite-app graphite-app bot changed the base branch from 12-04-refactor_move_more_code_into_chunk_optimizer to graphite-base/7339 December 4, 2025 11:47
@graphite-app graphite-app bot force-pushed the 12-04-fix_relex_the_restriction_of_preserveentrysignatures branch from a9c524d to 4ee3cba Compare December 4, 2025 12:04
@graphite-app graphite-app bot force-pushed the graphite-base/7339 branch from ad07a44 to daeb48f Compare December 4, 2025 12:04
@graphite-app graphite-app bot changed the base branch from graphite-base/7339 to main December 4, 2025 12:04
@graphite-app graphite-app bot force-pushed the 12-04-fix_relex_the_restriction_of_preserveentrysignatures branch from 4ee3cba to 9bd0246 Compare December 4, 2025 12:05
@netlify
Copy link

netlify bot commented Dec 4, 2025

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit c107f59
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/69318c40a3ca9a000771bbe7
😎 Deploy Preview https://deploy-preview-7339--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 4, 2025

Merge activity

  • Dec 4, 12:39 PM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
  • Dec 4, 12:44 PM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Repo Validation').
  • Dec 4, 1:26 PM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.

Copilot AI review requested due to automatic review settings December 4, 2025 12:41
@graphite-app graphite-app bot force-pushed the 12-04-fix_relex_the_restriction_of_preserveentrysignatures branch from 6e6eec6 to a357420 Compare December 4, 2025 12:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR relaxes the preserveEntrySignatures: 'strict' restriction to allow chunk merging optimization for dynamically imported entry chunks. The main goal is to reduce the number of output chunks by allowing shared modules to be merged into dynamic entry chunks, even when strict entry signature preservation is enabled.

Key changes:

  • Removed the blanket restriction that prevented chunk merging when preserveEntrySignatures: 'strict' is set
  • Added logic to allow merging for dynamic-only entry chunks (not user-defined) even with strict preservation
  • Refactored chunk assignment logic into separate helper methods for better maintainability

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
crates/rolldown_common/src/chunk/mod.rs Added PartialEq, Eq traits to ChunkMeta bitflags for equality comparison
crates/rolldown/src/stages/generate_stage/code_splitting.rs Removed the check that prevented chunk optimization when preserveEntrySignatures: 'strict' is set
crates/rolldown/src/stages/generate_stage/chunk_optimizer.rs Refactored chunk assignment logic into separate methods; added conditional check to allow merging for dynamic-only entries
crates/rolldown/tests/rolldown/issues/4904/_config.json Added preserveEntrySignatures: "strict" to test configuration
crates/rolldown/tests/rolldown/issues/4904_1/_config.json Added test variant with preserveEntrySignatures: "strict"
crates/rolldown/tests/rolldown/issues/4904_1/artifacts.snap Updated snapshot with expected output for strict preservation variant
packages/rolldown/tests/fixtures/issues/4904_bailout/*.js Added test fixture files to verify bailout behavior with strict preservation
packages/rolldown/tests/fixtures/issues/4904_bailout/_config.ts Added test configuration verifying 4 chunks are created (no merging) with strict preservation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@IWANABETHATGUY IWANABETHATGUY force-pushed the 12-04-fix_relex_the_restriction_of_preserveentrysignatures branch from a357420 to a239c38 Compare December 4, 2025 12:52
@graphite-app graphite-app bot force-pushed the 12-04-fix_relex_the_restriction_of_preserveentrysignatures branch from a239c38 to c107f59 Compare December 4, 2025 13:27
@IWANABETHATGUY IWANABETHATGUY merged commit 93e2f40 into main Dec 4, 2025
19 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 12-04-fix_relex_the_restriction_of_preserveentrysignatures branch December 4, 2025 13:28
shulaoda added a commit that referenced this pull request Dec 11, 2025
## [1.0.0-beta.54] - 2025-12-11

⏱️ Plugin Timing Analysis
- Added `checks.pluginTimings` option to emit warnings when plugins significantly impact build performance
- More details: https://rolldown.rs/options/checks#plugintimings
<img width="834" height="119" alt="image" src="https://github.com/user-attachments/assets/e819f906-6192-4503-8d5c-854fa92ecb45" />

> [!WARNING]
> For hooks using `ctx.resolve()` or `ctx.load()`, the reported time includes waiting for other plugins, which may overestimate that plugin's actual cost.
>
> Additionally, since plugin hooks execute concurrently, the statistics represent accumulated time rather than wall-clock time. The measured duration also includes Rust-side processing overhead, Tokio async scheduling overhead, NAPI data conversion overhead, and JavaScript event loop overhead.

### 🚀 Features

- rolldown_plugin_vite_reporter: add newline after build summary for better log separation (#7458) by @shulaoda
- plugin: collect plugin hook execution timings (#7364) by @shulaoda
- test-dev-server: reload page when detecting hmr reload message (#7422) by @hyf0
- rolldown_plugin_vite_dynamic_import_vars: add transform-based v2 implementation (#7400) by @shulaoda
- rolldown_plugin_vite_import_glob: add transform-based v2 implementation (#7394) by @shulaoda
- rolldown_plugin_vite_wasm_helper: add v2 implementation (#7402) by @shulaoda
- expose error location and context fields on JS API error objects (#7341) by @Copilot
- add `CIRCULAR_REEXPORT` error (#7337) by @Copilot
- support emit prebuilt chunk (#7277) by @Copilot

### 🐛 Bug Fixes

- preserve object key order when parse json with serde_json (#7443) by @IWANABETHATGUY
- improve JSON parsing with serde_json to emit proper diagnostic (#7442) by @IWANABETHATGUY
- deconflict external symbols in CJS modules (#7447) by @IWANABETHATGUY
- rolldown_plugin_vite_transform,rolldown_plugin_vite_resolve: enable `yarnPnp` option when pnp is detected (#5791) by @sapphi-red
- skip deconflicting top-level symbols for CJS modules (#7425) by @IWANABETHATGUY
- rolldown_plugin_esm_external_require: run resolveId hook before other plugins (#7426) by @shulaoda
- avoid duplicate underscores in legitimized identifiers (#7418) by @IWANABETHATGUY
- use `process.on('exit')` instead of `signal-exit` on webcontainers (#7421) by @sapphi-red
- dev: remove `imports` when an import is removed (#7348) by @sapphi-red
- bench: access latency.mean instead of mean in tinybench result (#7417) by @shulaoda
- path compression in symbol linking (#7392) by @IWANABETHATGUY
- rolldown_plugin_vite_resolve: add RwLock to avoid clearing cache while resolving (#7386) by @sapphi-red
- handle JSON prototype properties correctly (#7383) by @IWANABETHATGUY
- preserve entry signature strict chunk merging (#7343) by @IWANABETHATGUY
- support eliminating multiple unused dynamic imports in a single statement (#7361) by @IWANABETHATGUY
- eliminate unreachable dynamic entry (#7356) by @IWANABETHATGUY
- `NormalizedInputOptions#cwd` should always exists (#7360) by @hyf0
- cli: support multiple comma-separated define arguments (#7340) by @Copilot
- remove redundant symbol param in __reExport runtime helper (#7346) by @IWANABETHATGUY
- always use __export for empty namespace objects when symbols enabled (#7345) by @IWANABETHATGUY
- relax the restriction of preserveEntrySignatures when merging chunks (#7339) by @IWANABETHATGUY

### 🚜 Refactor

- builtin-plugin: make config parameter required for vite plugins (#7451) by @shulaoda
- move esbuild test related scripts to `scripts/src/esbuild-tests` (#7377) by @sapphi-red
- rewrite gen-esbuild-test in TypeScript (#7376) by @sapphi-red
- remove unnecessary Option in current_stmt_idx (#7359) by @IWANABETHATGUY
- move more code into chunk optimizer (#7335) by @IWANABETHATGUY

### 📚 Documentation

- checks: clarify pluginTimings measures CPU time due to concurrent execution (#7448) by @shulaoda
- checks: add accuracy note to pluginTimings documentation (#7441) by @shulaoda
- development-guide: add esbuild test description (#7439) by @sapphi-red
- checks: expand `pluginTimings` documentation with detection mechanism (#7428) by @shulaoda
- add checks options documentation (#7427) by @shulaoda
- development-guide: add test262 integration test description (#7430) by @sapphi-red
- guide: fix grammer in getting-started (#7331) by @jakeparis

### 🧪 Testing

- rollup-tests: make `--grep` work and document it (#7431) by @sapphi-red
- add a way to run some test262 test cases by name (#7429) by @sapphi-red
- rolldown_plugin_vite_dynamic_import_vars: add test cases for v2 implementation (#7401) by @shulaoda
- rolldown_plugin_vite_import_glob: add test cases for v2 implementation (#7395) by @shulaoda
- triage new esbuild tests (#7405) by @sapphi-red
- hmr: delete file used (#5933) by @sapphi-red
- watch: add `watchChange` hook `create` / `delete` tests (#7349) by @sapphi-red
- hmr: delete file not used anymore (#5932) by @sapphi-red
- triage esbuild failed reasons (#7391) by @sapphi-red
- change esbuild tests stats and diff generation (#7379) by @sapphi-red
- dev: add `continuous generate hmr patch` and `debounce bundle` tests (#7368) by @hyf0
- add new esbuild tests (#7353) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- setup Node before updating snapshots for test262 update (#7435) by @sapphi-red
- run tests when submodules are updated (#7455) by @sapphi-red
- exclude NUL path pattern to prevent crash on Windows (#7450) by @IWANABETHATGUY
- run cargo-test for esbuild script changes and update esbuild snapshot (#7440) by @sapphi-red
- jsx_import_meta tests to `ignoreReasons` due to architectural limitation (#7434) by @Copilot
- deps: update dependency oxlint-tsgolint to v0.8.5 (#7433) by @renovate[bot]
- update test dependencies automatically (#7432) by @sapphi-red
- remove unused code (#7420) by @IWANABETHATGUY
- add back `just update-esbuild-diff` and add it to CI (#7404) by @sapphi-red
- deps: update oxc-resolver to 11.15.0 (#7415) by @shulaoda
- deps: update rust crate napi to v3.7.0 (#7393) by @renovate[bot]
- fix esbuild compatibility metrics calculation (#7390) by @sapphi-red
- support `tsconfig: true` in rust tests (#7389) by @sapphi-red
- hide oxc runtime in snapshots (#7388) by @sapphi-red
- deps: update oxc to v0.102.0 (#7385) by @camc314
- improve esbuild tests to download snapshots automatically (#7378) by @sapphi-red
- deps: update dependency tinybench to v6 (#7371) by @renovate[bot]
- deps: update actions/checkout action to v6 (#7370) by @renovate[bot]
- deps: update rust crates (#7367) by @renovate[bot]
- deps: update dependency oxlint to v1.32.0 (#7374) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.8.4 (#7373) by @renovate[bot]
- node/test-dev-server: support using custom html file (#7357) by @hyf0
- test: setup browser-based e2e test for `test-dev-server` (#7351) by @hyf0
- pin pnpm to version 10.23.0 (#7369) by @IWANABETHATGUY
- deps: update dependency rolldown-plugin-dts to v0.18.3 (#7372) by @renovate[bot]
- deps: update github-actions (#7365) by @renovate[bot]
- deps: update npm packages (#7366) by @renovate[bot]
- polish the comments about `SymbolRefFlags` (#7358) by @IWANABETHATGUY
- deps: update dependency rolldown-plugin-dts to v0.18.2 (#7355) by @renovate[bot]
- fix esbuild test generation script (#7352) by @sapphi-red
- apply cargo shear suggestion (#7347) by @IWANABETHATGUY
- deps: update oxc to v11.15.0 (#7344) by @renovate[bot]
- deps: update dependency @napi-rs/cli to v3.5.0 (#7338) by @renovate[bot]
- deps: update dependency oxlint to v1.31.0 (#7305) by @renovate[bot]
- update rollup-tests results (#7333) by @sapphi-red
- update rollup-tests Rollup version (#7332) by @sapphi-red
- add ignore config for test262 submodule (#7326) by @Copilot

### ❤️ New Contributors

* @jakeparis made their first contribution in [#7331](#7331)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants