Skip to content

Comments

feat(rolldown_plugin_vite_manifest): pass normalized options to isLegacy callback#7321

Merged
shulaoda merged 1 commit intomainfrom
12-03-feat_rolldown_plugin_vite_manifest_pass_normalized_options_to_islegacy_callback
Dec 3, 2025
Merged

feat(rolldown_plugin_vite_manifest): pass normalized options to isLegacy callback#7321
shulaoda merged 1 commit intomainfrom
12-03-feat_rolldown_plugin_vite_manifest_pass_normalized_options_to_islegacy_callback

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Dec 3, 2025

No description provided.

@shulaoda shulaoda changed the title feat(rolldown_plugin_vite_manifest): pass normalized options to isLegacy callback feat(rolldown_plugin_vite_manifest): pass normalized options to isLegacy callback Dec 3, 2025
@shulaoda shulaoda marked this pull request as ready for review December 3, 2025 02:19
Copilot AI review requested due to automatic review settings December 3, 2025 02:19
Copy link
Member Author

shulaoda commented Dec 3, 2025


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Dec 3, 2025

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit f3adf7b
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/692f9e11dd869e0008e9134f
😎 Deploy Preview https://deploy-preview-7321--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the viteManifestPlugin by passing normalized bundler options to the isLegacy callback, enabling more sophisticated legacy detection logic. The changes follow the established pattern used by viteCSSPostPlugin for exposing normalized options to builtin plugin callbacks.

Key Changes

  • Refactored viteManifestPlugin into a dedicated file with custom TypeScript types that expose NormalizedOutputOptions to user code
  • Added bindingify logic to convert between TypeScript's NormalizedOutputOptions and Rust's BindingNormalizedOptions
  • Updated Rust plugin to receive and use NormalizedBundlerOptions in the isLegacy callback

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/rolldown/src/utils/bindingify-input-options.ts Refactored if-else chain to switch statement and added case for builtin:vite-manifest to use new bindingify function
packages/rolldown/src/experimental-index.ts Moved viteManifestPlugin export from constructors to dedicated plugin file
packages/rolldown/src/builtin-plugin/vite-manifest-plugin.ts New file defining ViteManifestPluginConfig type and viteManifestPlugin factory function with user-friendly API
packages/rolldown/src/builtin-plugin/utils.ts Added bindingifyManifestPlugin function to transform user-facing config to binding config, wrapping callback to convert options
packages/rolldown/src/builtin-plugin/constructors.ts Removed viteManifestPlugin function that's now in dedicated file
packages/rolldown/src/binding.d.cts Updated isLegacy callback signature to accept BindingNormalizedOptions parameter
crates/rolldown_plugin_vite_manifest/src/lib.rs Updated IsLegacyFn type to accept &Arc<NormalizedBundlerOptions> and pass options to callback in generate_bundle hook
crates/rolldown_binding/src/options/plugin/config/binding_vite_manifest_plugin_config.rs Updated binding config to accept options parameter and create BindingNormalizedOptions wrapper when invoking callback

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

Benchmarks Rust

  • target: main(5c9b6f8)
  • pr: 12-03-feat_rolldown_plugin_vite_manifest_pass_normalized_options_to_islegacy_callback(f3adf7b)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     68.0±1.71ms        ? ?/sec    1.02     69.6±2.04ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     73.4±1.24ms        ? ?/sec    1.02     75.1±1.72ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    110.9±3.49ms        ? ?/sec    1.00    110.6±2.36ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    122.5±2.07ms        ? ?/sec    1.02    125.4±2.73ms        ? ?/sec
bundle/bundle@threejs                                        1.00     40.8±0.62ms        ? ?/sec    1.00     40.7±0.64ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     44.2±0.57ms        ? ?/sec    1.00     43.9±0.82ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    399.7±4.79ms        ? ?/sec    1.00    395.0±4.27ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    460.9±5.66ms        ? ?/sec    1.00    456.3±6.13ms        ? ?/sec
scan/scan@rome_ts                                            1.02     87.3±2.99ms        ? ?/sec    1.00     85.7±1.62ms        ? ?/sec
scan/scan@threejs                                            1.04     29.9±1.96ms        ? ?/sec    1.00     28.8±0.55ms        ? ?/sec
scan/scan@threejs10x                                         1.02    304.8±5.18ms        ? ?/sec    1.00    299.3±4.63ms        ? ?/sec

@shulaoda shulaoda merged commit 7cb27c3 into main Dec 3, 2025
37 checks passed
@shulaoda shulaoda deleted the 12-03-feat_rolldown_plugin_vite_manifest_pass_normalized_options_to_islegacy_callback branch December 3, 2025 04:56
@github-actions github-actions bot mentioned this pull request Dec 3, 2025
shulaoda added a commit that referenced this pull request Dec 3, 2025
## [1.0.0-beta.53] - 2025-12-03

💥 Breaking Changes
- Drop `i686-pc-windows-msvc` target support

🚀 Chunk Merging Optimization
- Rolldown now automatically merges shared chunks when entries import each other (when `preserveEntrySignature` is not `strict`)
```shell
Before:
entry.js   → imports → shared.js (common chunk)
entry2.js  → imports → shared.js
Output: 3 chunks (entry.js, entry2.js, shared.js)

After:
entry.js   → contains shared code
entry2.js  → imports → entry.js
Output: 2 chunks (entry.js, entry2.js)
```

### 💥 BREAKING CHANGES

- drop `i686-pc-windows-msvc` target support (#7230) by @sapphi-red

### 🚀 Features

- rolldown_plugin_vite_manifest: pass normalized options to `isLegacy` callback (#7321) by @shulaoda
- plugin/vite-resolve: add `disableCache` option (#6763) by @sapphi-red
- rolldown: export `createTokioRuntime` for tsdown (#7264) by @shulaoda
- rolldown_plugin_vite_html: sync `moduleSideEffects` for already loaded modules (#7254) by @shulaoda
- rolldown_plugin_vite_html: load module scripts with side effects to prevent tree-shaking (#7244) by @shulaoda
- rolldown_plugin_vite_css_post: implement `cssScopeTo` for scoped CSS tree-shaking (#7240) by @shulaoda

### 🐛 Bug Fixes

- export default class decl __name runtime insertion (#7316) by @IWANABETHATGUY
- chunk side effects calculation (#7273) by @IWANABETHATGUY
- node: `output.generateCode.preset: 'es2015'` should set `output.generateCode.symbols: true` by default (#7314) by @sapphi-red
- skip name helper for classes with static name property (#7312) by @IWANABETHATGUY
- preserve chunk imports relationship after chunk merging (#7303) by @shulaoda
- dev: make `register_modules` async (#7289) by @hyf0
- preserve computed property in object destructuring (#7288) by @IWANABETHATGUY
- support dynamic imports with shared dependencies (#7261) by @IWANABETHATGUY
- call `defer_sync_scan_data` in non-incremental build mode (#7255) by @shulaoda
- optimize chunk merging for shared entry points (#7194) by @IWANABETHATGUY
- add indentation for UMD format output (#7263) by @IWANABETHATGUY
- rolldown_plugin_vite_css_post: pass options to `isLegacy` callback for proper legacy detection (#7260) by @shulaoda
- rolldown_plugin_vite_css_post: also detect `?inline=true` query for inlined CSS (#7245) by @shulaoda
- rolldown_plugin_vite_css_post: distinguish empty CSS from no CSS (#7241) by @shulaoda
- add Windows support for t-run command (#7242) by @IWANABETHATGUY
- cjs: prevent duplicate require declarations for external modules with preserveModules (#7234) by @logaretm
- rolldown_plugin_vite_resolve: resolve from root for virtual modules (#7236) by @sapphi-red
- include entry level external modules in chunk exports (#7218) by @IWANABETHATGUY

### 🚜 Refactor

- dev: make `removeClient` async (#7313) by @hyf0
- move chunk merging code out of code_splitting.rs (#7285) by @IWANABETHATGUY
- extract common function util for chunk merging (#7271) by @IWANABETHATGUY
- use iterative method to merge chunks (#7256) by @IWANABETHATGUY
- use concat_string! instead of string replace for generating chunk level exports (#7247) by @IWANABETHATGUY

### 📚 Documentation

- add warning to experimental.resolveNewUrlToAsset about JS/TS files (#7300) by @Copilot
- add sequential hook execution difference in plugin-api.md (#7308) by @Copilot
- add migration example from onwarn to onLog (#7299) by @Copilot
- add migration example for manualChunks to advancedChunks (#7298) by @Copilot
- deps: bump vitepress to fix build (#7307) by @sapphi-red
- examples & text for experimental.resolveNewUrlToAsset (#7259) by @TheAlexLichter

### ⚡ Performance

- rolldown_plugin_vite_css_post: lazily load `cssScopeTo` from JS module options (#7253) by @shulaoda
- rolldown_plugin_vite_css_post: avoid unnecessary string clones in `resolve_asset_urls_in_css` (#7250) by @shulaoda

### 🧪 Testing

- generate relative path like name in advanced chunks (#7267) by @IWANABETHATGUY
- add test case for preserveEntrySignatures with re-exports (#7279) by @IWANABETHATGUY
- add test262 integration tests (#7196) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- deps: update dependency rolldown-plugin-dts to v0.18.1 (#7304) by @renovate[bot]
- enable tracing feature for napi (#7322) by @sapphi-red
- deps: update napi (#7320) by @renovate[bot]
- deps: update oxc (#7318) by @renovate[bot]
- deps: update napi (#7317) by @renovate[bot]
- deps: update oxc to v0.100.0 (#7301) by @renovate[bot]
- deps: downgrade pnpm to 10.23.0 to fix Netlify build (#7306) by @shulaoda
- add `trustPolicyExclude` for chokidar and semver (#7302) by @sapphi-red
- update pnpm lockfile (#7291) by @IWANABETHATGUY
- deps: update npm packages (#7272) by @renovate[bot]
- deps: update rust crates (#7270) by @renovate[bot]
- deps: update oxc (#7262) by @renovate[bot]
- deps: update github-actions (#7269) by @renovate[bot]
- deps: update dependency dprint-typescript to v0.95.13 (#7268) by @renovate[bot]
- deps: update `html5gum` to 0.8.1 (#7265) by @shulaoda
- rolldown: remove unused `getModuleOptions` from `PluginContext` (#7266) by @shulaoda
- remove unnecessary justfile ignore (#7243) by @IWANABETHATGUY
- deps: update oxc apps (#7238) by @renovate[bot]
- add `nul` to workaround https://github.com/anthropics/claude-c… (#7237) by @IWANABETHATGUY
- deps: update dependency valibot to v1.2.0 [security] (#7231) by @renovate[bot]
- deps: update crate-ci/typos action to v1.40.0 (#7232) by @renovate[bot]

### ❤️ New Contributors

* @logaretm made their first contribution in [#7234](#7234)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant