refactor(dev): make `removeClient` async by hyf0 · Pull Request #7313 · rolldown/rolldown

hyf0 · 2025-12-02T07:37:47Z

No description provided.

hyf0 · 2025-12-02T07:38:03Z

refactor(dev): make removeClient async #7313 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2025-12-02T07:39:28Z

✅ Deploy Preview for rolldown-rs ready!

Name	Link
🔨 Latest commit	`4ac8233`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/692ea474c39aba000874637d
😎 Deploy Preview	https://deploy-preview-7313--rolldown-rs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Pull request overview

This PR refactors the removeClient method in the dev engine to be asynchronous, aligning it with the existing pattern used by registerModules. The change ensures consistency across the API and prevents potential blocking of the Node.js thread or deadlocks when acquiring locks in the Rust implementation.

Key Changes

Made removeClient async across all layers (TypeScript bindings, DevEngine API, and Rust implementation)
Added clippy allow attributes with a clear reason referencing issue #7311
Updated method signature to return Promise<void> instead of void

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
packages/rolldown/src/binding.d.cts	Updated TypeScript binding signature to return `Promise<void>`
packages/rolldown/src/api/dev/dev-engine.ts	Made method async and added await for inner call
crates/rolldown_binding/src/binding_dev_engine.rs	Made Rust method async with clippy allow attributes for unused_async

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2025-12-02T07:51:07Z

Benchmarks Rust

target: main(9d98317)
pr: 12-02-refactor_dev_make_removeclient_async(4ac8233)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     63.7±1.40ms        ? ?/sec    1.04     66.4±1.72ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     70.8±1.95ms        ? ?/sec    1.11     78.6±3.70ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    106.8±2.17ms        ? ?/sec    1.01    107.4±2.55ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    121.1±2.05ms        ? ?/sec    1.00    120.5±2.20ms        ? ?/sec
bundle/bundle@threejs                                        1.00     40.3±0.86ms        ? ?/sec    1.00     40.4±1.06ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     44.8±0.81ms        ? ?/sec    1.01     45.3±1.03ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    389.2±4.96ms        ? ?/sec    1.02    396.6±5.42ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    461.0±4.74ms        ? ?/sec    1.01    466.0±6.49ms        ? ?/sec
scan/scan@rome_ts                                            1.00     82.9±1.63ms        ? ?/sec    1.00     82.5±2.17ms        ? ?/sec
scan/scan@threejs                                            1.02     28.3±1.95ms        ? ?/sec    1.00     27.7±0.46ms        ? ?/sec
scan/scan@threejs10x                                         1.00    286.3±4.50ms        ? ?/sec    1.00    285.5±5.63ms        ? ?/sec

hyf0 · 2025-12-02T08:32:24Z

Merge activity

Dec 2, 8:32 AM UTC: The merge label 'graphite: merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Dec 2, 8:32 AM UTC: hyf0 added this pull request to the Graphite merge queue.
Dec 2, 8:49 AM UTC: Merged by the Graphite merge queue.

@sapphi-red

## [1.0.0-beta.53] - 2025-12-03 💥 Breaking Changes - Drop `i686-pc-windows-msvc` target support 🚀 Chunk Merging Optimization - Rolldown now automatically merges shared chunks when entries import each other (when `preserveEntrySignature` is not `strict`) ```shell Before: entry.js → imports → shared.js (common chunk) entry2.js → imports → shared.js Output: 3 chunks (entry.js, entry2.js, shared.js) After: entry.js → contains shared code entry2.js → imports → entry.js Output: 2 chunks (entry.js, entry2.js) ``` ### 💥 BREAKING CHANGES - drop `i686-pc-windows-msvc` target support (#7230) by @sapphi-red ### 🚀 Features - rolldown_plugin_vite_manifest: pass normalized options to `isLegacy` callback (#7321) by @shulaoda - plugin/vite-resolve: add `disableCache` option (#6763) by @sapphi-red - rolldown: export `createTokioRuntime` for tsdown (#7264) by @shulaoda - rolldown_plugin_vite_html: sync `moduleSideEffects` for already loaded modules (#7254) by @shulaoda - rolldown_plugin_vite_html: load module scripts with side effects to prevent tree-shaking (#7244) by @shulaoda - rolldown_plugin_vite_css_post: implement `cssScopeTo` for scoped CSS tree-shaking (#7240) by @shulaoda ### 🐛 Bug Fixes - export default class decl __name runtime insertion (#7316) by @IWANABETHATGUY - chunk side effects calculation (#7273) by @IWANABETHATGUY - node: `output.generateCode.preset: 'es2015'` should set `output.generateCode.symbols: true` by default (#7314) by @sapphi-red - skip name helper for classes with static name property (#7312) by @IWANABETHATGUY - preserve chunk imports relationship after chunk merging (#7303) by @shulaoda - dev: make `register_modules` async (#7289) by @hyf0 - preserve computed property in object destructuring (#7288) by @IWANABETHATGUY - support dynamic imports with shared dependencies (#7261) by @IWANABETHATGUY - call `defer_sync_scan_data` in non-incremental build mode (#7255) by @shulaoda - optimize chunk merging for shared entry points (#7194) by @IWANABETHATGUY - add indentation for UMD format output (#7263) by @IWANABETHATGUY - rolldown_plugin_vite_css_post: pass options to `isLegacy` callback for proper legacy detection (#7260) by @shulaoda - rolldown_plugin_vite_css_post: also detect `?inline=true` query for inlined CSS (#7245) by @shulaoda - rolldown_plugin_vite_css_post: distinguish empty CSS from no CSS (#7241) by @shulaoda - add Windows support for t-run command (#7242) by @IWANABETHATGUY - cjs: prevent duplicate require declarations for external modules with preserveModules (#7234) by @logaretm - rolldown_plugin_vite_resolve: resolve from root for virtual modules (#7236) by @sapphi-red - include entry level external modules in chunk exports (#7218) by @IWANABETHATGUY ### 🚜 Refactor - dev: make `removeClient` async (#7313) by @hyf0 - move chunk merging code out of code_splitting.rs (#7285) by @IWANABETHATGUY - extract common function util for chunk merging (#7271) by @IWANABETHATGUY - use iterative method to merge chunks (#7256) by @IWANABETHATGUY - use concat_string! instead of string replace for generating chunk level exports (#7247) by @IWANABETHATGUY ### 📚 Documentation - add warning to experimental.resolveNewUrlToAsset about JS/TS files (#7300) by @Copilot - add sequential hook execution difference in plugin-api.md (#7308) by @Copilot - add migration example from onwarn to onLog (#7299) by @Copilot - add migration example for manualChunks to advancedChunks (#7298) by @Copilot - deps: bump vitepress to fix build (#7307) by @sapphi-red - examples & text for experimental.resolveNewUrlToAsset (#7259) by @TheAlexLichter ### ⚡ Performance - rolldown_plugin_vite_css_post: lazily load `cssScopeTo` from JS module options (#7253) by @shulaoda - rolldown_plugin_vite_css_post: avoid unnecessary string clones in `resolve_asset_urls_in_css` (#7250) by @shulaoda ### 🧪 Testing - generate relative path like name in advanced chunks (#7267) by @IWANABETHATGUY - add test case for preserveEntrySignatures with re-exports (#7279) by @IWANABETHATGUY - add test262 integration tests (#7196) by @sapphi-red ### ⚙️ Miscellaneous Tasks - deps: update dependency rolldown-plugin-dts to v0.18.1 (#7304) by @renovate[bot] - enable tracing feature for napi (#7322) by @sapphi-red - deps: update napi (#7320) by @renovate[bot] - deps: update oxc (#7318) by @renovate[bot] - deps: update napi (#7317) by @renovate[bot] - deps: update oxc to v0.100.0 (#7301) by @renovate[bot] - deps: downgrade pnpm to 10.23.0 to fix Netlify build (#7306) by @shulaoda - add `trustPolicyExclude` for chokidar and semver (#7302) by @sapphi-red - update pnpm lockfile (#7291) by @IWANABETHATGUY - deps: update npm packages (#7272) by @renovate[bot] - deps: update rust crates (#7270) by @renovate[bot] - deps: update oxc (#7262) by @renovate[bot] - deps: update github-actions (#7269) by @renovate[bot] - deps: update dependency dprint-typescript to v0.95.13 (#7268) by @renovate[bot] - deps: update `html5gum` to 0.8.1 (#7265) by @shulaoda - rolldown: remove unused `getModuleOptions` from `PluginContext` (#7266) by @shulaoda - remove unnecessary justfile ignore (#7243) by @IWANABETHATGUY - deps: update oxc apps (#7238) by @renovate[bot] - add `nul` to workaround https://github.com/anthropics/claude-c… (#7237) by @IWANABETHATGUY - deps: update dependency valibot to v1.2.0 [security] (#7231) by @renovate[bot] - deps: update crate-ci/typos action to v1.40.0 (#7232) by @renovate[bot] ### ❤️ New Contributors * @logaretm made their first contribution in [#7234](#7234) Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned hyf0 Dec 2, 2025

hyf0 marked this pull request as ready for review December 2, 2025 07:37

Copilot AI review requested due to automatic review settings December 2, 2025 07:37

Copilot started reviewing on behalf of hyf0 December 2, 2025 07:38 View session

Copilot finished reviewing on behalf of hyf0 December 2, 2025 07:39

Copilot AI reviewed Dec 2, 2025

View reviewed changes

hyf0 requested review from sapphi-red and shulaoda December 2, 2025 08:22

shulaoda approved these changes Dec 2, 2025

View reviewed changes

hyf0 mentioned this pull request Dec 2, 2025

audit: Review sync NAPI bindings for deadlock safety #7311

Closed

8 tasks

hyf0 added the graphite: merge label Dec 2, 2025

refactor(dev): make removeClient async (#7313)

4ac8233

graphite-app bot force-pushed the 12-02-refactor_dev_make_removeclient_async branch from 7848222 to 4ac8233 Compare December 2, 2025 08:33

graphite-app bot merged commit 4ac8233 into main Dec 2, 2025
28 checks passed

graphite-app bot deleted the 12-02-refactor_dev_make_removeclient_async branch December 2, 2025 08:49

graphite-app bot removed the graphite: merge label Dec 2, 2025

This was referenced Dec 3, 2025

release: v1.0.0-beta.53 #7319

Closed

release: v1.0.0-beta.53 #7324

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

refactor(dev): make `removeClient` async#7313

refactor(dev): make `removeClient` async#7313
graphite-app[bot] merged 1 commit intomainfrom
12-02-refactor_dev_make_removeclient_async

hyf0 commented Dec 2, 2025

Uh oh!

hyf0 commented Dec 2, 2025

Uh oh!

netlify bot commented Dec 2, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions bot commented Dec 2, 2025 •

edited

Loading

Uh oh!

hyf0 commented Dec 2, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

hyf0 commented Dec 2, 2025

Uh oh!

hyf0 commented Dec 2, 2025

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

github-actions bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

hyf0 commented Dec 2, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Dec 2, 2025 •

edited

Loading

github-actions bot commented Dec 2, 2025 •

edited

Loading

hyf0 commented Dec 2, 2025 •

edited by graphite-app bot

Loading