Skip to content

Comments

fix: skip name helper for classes with static name property#7312

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-02-fix_7195
Dec 2, 2025
Merged

fix: skip name helper for classes with static name property#7312
graphite-app[bot] merged 1 commit intomainfrom
12-02-fix_7195

Conversation

@IWANABETHATGUY
Copy link
Member

No description provided.

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IWANABETHATGUY IWANABETHATGUY changed the title fix: 7195 fix: skip name helper for classes with static name property Dec 2, 2025
@netlify
Copy link

netlify bot commented Dec 2, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 9d98317
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/692ea09e8c2419000855af75

@IWANABETHATGUY IWANABETHATGUY force-pushed the 12-02-fix_7195 branch 2 times, most recently from 520187d to 5b95030 Compare December 2, 2025 07:46
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review December 2, 2025 07:47
Copilot AI review requested due to automatic review settings December 2, 2025 07:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where Rolldown was incorrectly overriding static name properties/methods in classes when the keep_names option is enabled. The fix adds detection logic to skip adding the __name() helper for classes that already have their own static name member.

Key Changes:

  • Added class_body_has_static_name() helper function to detect static name properties, methods, or accessors
  • Modified name preservation logic to skip classes with existing static name members
  • Two test262 tests now pass: eval-export-dflt-cls-name-meth.js and eval-export-dflt-expr-cls-name-meth.js

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
crates/rolldown/tests/test262_failures.json Removed two test failures that are now passing after the fix
crates/rolldown/tests/snapshots/integration_test262__test262_module_code.snap Updated test summary showing 2 more tests passing (536 vs 534) and updated test results to PASS
crates/rolldown/src/module_finalizers/mod.rs Added class_body_has_static_name() helper and integrated it into name preservation logic for default exports and class declarations
crates/rolldown/src/module_finalizers/impl_visit_mut.rs Updated keep_name_helper_for_class calls to include the class_body parameter

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Benchmarks Rust

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     64.0±1.61ms        ? ?/sec    1.06     68.1±2.53ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     72.1±1.89ms        ? ?/sec    1.00     72.5±2.14ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    105.9±1.94ms        ? ?/sec    1.00    106.4±2.29ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    121.0±2.68ms        ? ?/sec    1.00    120.1±1.83ms        ? ?/sec
bundle/bundle@threejs                                        1.00     39.5±0.95ms        ? ?/sec    1.02     40.4±2.36ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     43.8±2.45ms        ? ?/sec    1.00     43.9±0.66ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    391.5±5.58ms        ? ?/sec    1.00    392.8±7.69ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    463.1±6.34ms        ? ?/sec    1.00    463.2±6.03ms        ? ?/sec
scan/scan@rome_ts                                            1.00     80.4±1.34ms        ? ?/sec    1.01     81.4±1.57ms        ? ?/sec
scan/scan@threejs                                            1.02     28.2±2.06ms        ? ?/sec    1.00     27.6±0.34ms        ? ?/sec
scan/scan@threejs10x                                         1.00    284.0±3.19ms        ? ?/sec    1.01    286.6±3.78ms        ? ?/sec

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 2, 2025

Merge activity

@graphite-app graphite-app bot merged commit 9d98317 into main Dec 2, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 12-02-fix_7195 branch December 2, 2025 08:33
This was referenced Dec 3, 2025
shulaoda added a commit that referenced this pull request Dec 3, 2025
## [1.0.0-beta.53] - 2025-12-03

💥 Breaking Changes
- Drop `i686-pc-windows-msvc` target support

🚀 Chunk Merging Optimization
- Rolldown now automatically merges shared chunks when entries import each other (when `preserveEntrySignature` is not `strict`)
```shell
Before:
entry.js   → imports → shared.js (common chunk)
entry2.js  → imports → shared.js
Output: 3 chunks (entry.js, entry2.js, shared.js)

After:
entry.js   → contains shared code
entry2.js  → imports → entry.js
Output: 2 chunks (entry.js, entry2.js)
```

### 💥 BREAKING CHANGES

- drop `i686-pc-windows-msvc` target support (#7230) by @sapphi-red

### 🚀 Features

- rolldown_plugin_vite_manifest: pass normalized options to `isLegacy` callback (#7321) by @shulaoda
- plugin/vite-resolve: add `disableCache` option (#6763) by @sapphi-red
- rolldown: export `createTokioRuntime` for tsdown (#7264) by @shulaoda
- rolldown_plugin_vite_html: sync `moduleSideEffects` for already loaded modules (#7254) by @shulaoda
- rolldown_plugin_vite_html: load module scripts with side effects to prevent tree-shaking (#7244) by @shulaoda
- rolldown_plugin_vite_css_post: implement `cssScopeTo` for scoped CSS tree-shaking (#7240) by @shulaoda

### 🐛 Bug Fixes

- export default class decl __name runtime insertion (#7316) by @IWANABETHATGUY
- chunk side effects calculation (#7273) by @IWANABETHATGUY
- node: `output.generateCode.preset: 'es2015'` should set `output.generateCode.symbols: true` by default (#7314) by @sapphi-red
- skip name helper for classes with static name property (#7312) by @IWANABETHATGUY
- preserve chunk imports relationship after chunk merging (#7303) by @shulaoda
- dev: make `register_modules` async (#7289) by @hyf0
- preserve computed property in object destructuring (#7288) by @IWANABETHATGUY
- support dynamic imports with shared dependencies (#7261) by @IWANABETHATGUY
- call `defer_sync_scan_data` in non-incremental build mode (#7255) by @shulaoda
- optimize chunk merging for shared entry points (#7194) by @IWANABETHATGUY
- add indentation for UMD format output (#7263) by @IWANABETHATGUY
- rolldown_plugin_vite_css_post: pass options to `isLegacy` callback for proper legacy detection (#7260) by @shulaoda
- rolldown_plugin_vite_css_post: also detect `?inline=true` query for inlined CSS (#7245) by @shulaoda
- rolldown_plugin_vite_css_post: distinguish empty CSS from no CSS (#7241) by @shulaoda
- add Windows support for t-run command (#7242) by @IWANABETHATGUY
- cjs: prevent duplicate require declarations for external modules with preserveModules (#7234) by @logaretm
- rolldown_plugin_vite_resolve: resolve from root for virtual modules (#7236) by @sapphi-red
- include entry level external modules in chunk exports (#7218) by @IWANABETHATGUY

### 🚜 Refactor

- dev: make `removeClient` async (#7313) by @hyf0
- move chunk merging code out of code_splitting.rs (#7285) by @IWANABETHATGUY
- extract common function util for chunk merging (#7271) by @IWANABETHATGUY
- use iterative method to merge chunks (#7256) by @IWANABETHATGUY
- use concat_string! instead of string replace for generating chunk level exports (#7247) by @IWANABETHATGUY

### 📚 Documentation

- add warning to experimental.resolveNewUrlToAsset about JS/TS files (#7300) by @Copilot
- add sequential hook execution difference in plugin-api.md (#7308) by @Copilot
- add migration example from onwarn to onLog (#7299) by @Copilot
- add migration example for manualChunks to advancedChunks (#7298) by @Copilot
- deps: bump vitepress to fix build (#7307) by @sapphi-red
- examples & text for experimental.resolveNewUrlToAsset (#7259) by @TheAlexLichter

### ⚡ Performance

- rolldown_plugin_vite_css_post: lazily load `cssScopeTo` from JS module options (#7253) by @shulaoda
- rolldown_plugin_vite_css_post: avoid unnecessary string clones in `resolve_asset_urls_in_css` (#7250) by @shulaoda

### 🧪 Testing

- generate relative path like name in advanced chunks (#7267) by @IWANABETHATGUY
- add test case for preserveEntrySignatures with re-exports (#7279) by @IWANABETHATGUY
- add test262 integration tests (#7196) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- deps: update dependency rolldown-plugin-dts to v0.18.1 (#7304) by @renovate[bot]
- enable tracing feature for napi (#7322) by @sapphi-red
- deps: update napi (#7320) by @renovate[bot]
- deps: update oxc (#7318) by @renovate[bot]
- deps: update napi (#7317) by @renovate[bot]
- deps: update oxc to v0.100.0 (#7301) by @renovate[bot]
- deps: downgrade pnpm to 10.23.0 to fix Netlify build (#7306) by @shulaoda
- add `trustPolicyExclude` for chokidar and semver (#7302) by @sapphi-red
- update pnpm lockfile (#7291) by @IWANABETHATGUY
- deps: update npm packages (#7272) by @renovate[bot]
- deps: update rust crates (#7270) by @renovate[bot]
- deps: update oxc (#7262) by @renovate[bot]
- deps: update github-actions (#7269) by @renovate[bot]
- deps: update dependency dprint-typescript to v0.95.13 (#7268) by @renovate[bot]
- deps: update `html5gum` to 0.8.1 (#7265) by @shulaoda
- rolldown: remove unused `getModuleOptions` from `PluginContext` (#7266) by @shulaoda
- remove unnecessary justfile ignore (#7243) by @IWANABETHATGUY
- deps: update oxc apps (#7238) by @renovate[bot]
- add `nul` to workaround https://github.com/anthropics/claude-c… (#7237) by @IWANABETHATGUY
- deps: update dependency valibot to v1.2.0 [security] (#7231) by @renovate[bot]
- deps: update crate-ci/typos action to v1.40.0 (#7232) by @renovate[bot]

### ❤️ New Contributors

* @logaretm made their first contribution in [#7234](#7234)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants