test: generate relative path like name in advanced chunks by IWANABETHATGUY · Pull Request #7267 · rolldown/rolldown

IWANABETHATGUY · 2025-11-30T16:18:55Z

related to #6424

IWANABETHATGUY · 2025-11-30T16:19:11Z

test: generate relative path like name in advanced chunks #7267 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2025-11-30T16:19:52Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`1f6518e`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/692c6e72f102ad00088ff623

netlify · 2025-11-30T16:20:40Z

❌ Deploy Preview for rolldown-rs failed.

Name	Link
🔨 Latest commit	`36bdcc4`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/692d9c0408ae0a00088c68c1

crates/rolldown/src/stages/generate_stage/mod.rs

Copilot

Pull request overview

This PR fixes issue #6424 by adding support for using custom chunk names (including path separators) in advanced chunk groups. The implementation adds a manual_chunk_alias field to the Chunk struct to preserve the user-provided name and uses it during chunk name generation.

Key changes:

Added manual_chunk_alias field to track custom chunk names from advanced chunk groups
Updated chunk name generation logic to use the alias when available for common chunks
Added comprehensive test case demonstrating relative path names in chunk outputs

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`crates/rolldown_common/src/chunk/mod.rs`	Added `manual_chunk_alias` field to `Chunk` struct and updated constructor signature with `#[expect(clippy::too_many_arguments)]`
`crates/rolldown/src/stages/generate_stage/mod.rs`	Added logic to use `manual_chunk_alias` for chunk name generation when present, with `#[expect(clippy::too_many_lines)]` annotation
`crates/rolldown/src/stages/generate_stage/code_splitting.rs`	Updated all `Chunk::new` call sites to pass `None` for the new `manual_chunk_alias` parameter
`crates/rolldown/src/stages/generate_stage/advanced_chunks.rs`	Updated `Chunk::new` calls, passing the group name as `manual_chunk_alias` for user-defined chunks
`packages/rolldown/tests/fixtures/function/advanced-chunks/relative-path-name/_config.ts`	Added test configuration verifying chunk name with path separators works correctly
`packages/rolldown/tests/fixtures/function/advanced-chunks/relative-path-name/entry.js`	Entry point file for the test case
`packages/rolldown/tests/fixtures/function/advanced-chunks/relative-path-name/src/folder/a.js`	Test fixture file in nested directory
`packages/rolldown/tests/fixtures/function/advanced-chunks/relative-path-name/src/b.js`	Test fixture file in src directory

Comments suppressed due to low confidence (1)

packages/rolldown/tests/fixtures/function/advanced-chunks/relative-path-name/_config.ts:16

The value assigned to r here is unused.

              r = r.replace(/\\/g, '/');

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/rolldown/src/stages/generate_stage/mod.rs

packages/rolldown/tests/fixtures/function/advanced-chunks/relative-path-name/_config.ts

pkg-pr-new · 2025-11-30T16:39:08Z

Open in StackBlitz

@rolldown/browser

npm i https://pkg.pr.new/@rolldown/browser@7267

@rolldown/debug

npm i https://pkg.pr.new/@rolldown/debug@7267

@rolldown/pluginutils

npm i https://pkg.pr.new/@rolldown/pluginutils@7267

rolldown

npm i https://pkg.pr.new/rolldown@7267

@rolldown/binding-android-arm64

npm i https://pkg.pr.new/@rolldown/binding-android-arm64@7267

@rolldown/binding-darwin-arm64

npm i https://pkg.pr.new/@rolldown/binding-darwin-arm64@7267

@rolldown/binding-darwin-x64

npm i https://pkg.pr.new/@rolldown/binding-darwin-x64@7267

@rolldown/binding-freebsd-x64

npm i https://pkg.pr.new/@rolldown/binding-freebsd-x64@7267

@rolldown/binding-linux-arm-gnueabihf

npm i https://pkg.pr.new/@rolldown/binding-linux-arm-gnueabihf@7267

@rolldown/binding-linux-arm64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-gnu@7267

@rolldown/binding-linux-arm64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-musl@7267

@rolldown/binding-linux-x64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-gnu@7267

@rolldown/binding-linux-x64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-musl@7267

@rolldown/binding-openharmony-arm64

npm i https://pkg.pr.new/@rolldown/binding-openharmony-arm64@7267

@rolldown/binding-wasm32-wasi

npm i https://pkg.pr.new/@rolldown/binding-wasm32-wasi@7267

@rolldown/binding-win32-arm64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-arm64-msvc@7267

@rolldown/binding-win32-x64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-x64-msvc@7267

commit: 601b74f

github-actions · 2025-11-30T16:41:18Z

Benchmarks Rust

target: main(4c29202)
pr: 12-01-fix_6424(ebffc54)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     65.2±2.00ms        ? ?/sec    1.00     65.3±2.09ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     70.3±2.04ms        ? ?/sec    1.05     73.6±2.36ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    109.2±3.50ms        ? ?/sec    1.00    109.7±2.74ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    120.1±1.81ms        ? ?/sec    1.02    122.7±1.93ms        ? ?/sec
bundle/bundle@threejs                                        1.00     39.0±2.35ms        ? ?/sec    1.00     38.9±0.92ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     42.4±0.72ms        ? ?/sec    1.03     43.5±0.97ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    399.2±8.51ms        ? ?/sec    1.00    400.0±7.29ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    464.1±8.75ms        ? ?/sec    1.00    458.7±7.99ms        ? ?/sec
scan/scan@rome_ts                                            1.01     85.6±1.92ms        ? ?/sec    1.00     84.8±1.85ms        ? ?/sec
scan/scan@threejs                                            1.00     29.0±0.75ms        ? ?/sec    1.00     29.0±1.97ms        ? ?/sec
scan/scan@threejs10x                                         1.02    301.2±5.38ms        ? ?/sec    1.00    295.5±5.63ms        ? ?/sec

IWANABETHATGUY · 2025-12-01T07:10:53Z

I found the extra implementation is redundant.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

packages/rolldown/tests/fixtures/function/advanced-chunks/relative-path-name/_config.ts:16

The value assigned to r here is unused.

              r = r.replace(/\\/g, '/');

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/rolldown/tests/fixtures/function/advanced-chunks/relative-path-name/_config.ts

graphite-app · 2025-12-01T13:45:20Z

Merge activity

Dec 1, 1:45 PM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Dec 1, 2:01 PM UTC: Merged by the Graphite merge queue.

related to #6424

@sapphi-red

## [1.0.0-beta.53] - 2025-12-03 💥 Breaking Changes - Drop `i686-pc-windows-msvc` target support 🚀 Chunk Merging Optimization - Rolldown now automatically merges shared chunks when entries import each other (when `preserveEntrySignature` is not `strict`) ```shell Before: entry.js → imports → shared.js (common chunk) entry2.js → imports → shared.js Output: 3 chunks (entry.js, entry2.js, shared.js) After: entry.js → contains shared code entry2.js → imports → entry.js Output: 2 chunks (entry.js, entry2.js) ``` ### 💥 BREAKING CHANGES - drop `i686-pc-windows-msvc` target support (#7230) by @sapphi-red ### 🚀 Features - rolldown_plugin_vite_manifest: pass normalized options to `isLegacy` callback (#7321) by @shulaoda - plugin/vite-resolve: add `disableCache` option (#6763) by @sapphi-red - rolldown: export `createTokioRuntime` for tsdown (#7264) by @shulaoda - rolldown_plugin_vite_html: sync `moduleSideEffects` for already loaded modules (#7254) by @shulaoda - rolldown_plugin_vite_html: load module scripts with side effects to prevent tree-shaking (#7244) by @shulaoda - rolldown_plugin_vite_css_post: implement `cssScopeTo` for scoped CSS tree-shaking (#7240) by @shulaoda ### 🐛 Bug Fixes - export default class decl __name runtime insertion (#7316) by @IWANABETHATGUY - chunk side effects calculation (#7273) by @IWANABETHATGUY - node: `output.generateCode.preset: 'es2015'` should set `output.generateCode.symbols: true` by default (#7314) by @sapphi-red - skip name helper for classes with static name property (#7312) by @IWANABETHATGUY - preserve chunk imports relationship after chunk merging (#7303) by @shulaoda - dev: make `register_modules` async (#7289) by @hyf0 - preserve computed property in object destructuring (#7288) by @IWANABETHATGUY - support dynamic imports with shared dependencies (#7261) by @IWANABETHATGUY - call `defer_sync_scan_data` in non-incremental build mode (#7255) by @shulaoda - optimize chunk merging for shared entry points (#7194) by @IWANABETHATGUY - add indentation for UMD format output (#7263) by @IWANABETHATGUY - rolldown_plugin_vite_css_post: pass options to `isLegacy` callback for proper legacy detection (#7260) by @shulaoda - rolldown_plugin_vite_css_post: also detect `?inline=true` query for inlined CSS (#7245) by @shulaoda - rolldown_plugin_vite_css_post: distinguish empty CSS from no CSS (#7241) by @shulaoda - add Windows support for t-run command (#7242) by @IWANABETHATGUY - cjs: prevent duplicate require declarations for external modules with preserveModules (#7234) by @logaretm - rolldown_plugin_vite_resolve: resolve from root for virtual modules (#7236) by @sapphi-red - include entry level external modules in chunk exports (#7218) by @IWANABETHATGUY ### 🚜 Refactor - dev: make `removeClient` async (#7313) by @hyf0 - move chunk merging code out of code_splitting.rs (#7285) by @IWANABETHATGUY - extract common function util for chunk merging (#7271) by @IWANABETHATGUY - use iterative method to merge chunks (#7256) by @IWANABETHATGUY - use concat_string! instead of string replace for generating chunk level exports (#7247) by @IWANABETHATGUY ### 📚 Documentation - add warning to experimental.resolveNewUrlToAsset about JS/TS files (#7300) by @Copilot - add sequential hook execution difference in plugin-api.md (#7308) by @Copilot - add migration example from onwarn to onLog (#7299) by @Copilot - add migration example for manualChunks to advancedChunks (#7298) by @Copilot - deps: bump vitepress to fix build (#7307) by @sapphi-red - examples & text for experimental.resolveNewUrlToAsset (#7259) by @TheAlexLichter ### ⚡ Performance - rolldown_plugin_vite_css_post: lazily load `cssScopeTo` from JS module options (#7253) by @shulaoda - rolldown_plugin_vite_css_post: avoid unnecessary string clones in `resolve_asset_urls_in_css` (#7250) by @shulaoda ### 🧪 Testing - generate relative path like name in advanced chunks (#7267) by @IWANABETHATGUY - add test case for preserveEntrySignatures with re-exports (#7279) by @IWANABETHATGUY - add test262 integration tests (#7196) by @sapphi-red ### ⚙️ Miscellaneous Tasks - deps: update dependency rolldown-plugin-dts to v0.18.1 (#7304) by @renovate[bot] - enable tracing feature for napi (#7322) by @sapphi-red - deps: update napi (#7320) by @renovate[bot] - deps: update oxc (#7318) by @renovate[bot] - deps: update napi (#7317) by @renovate[bot] - deps: update oxc to v0.100.0 (#7301) by @renovate[bot] - deps: downgrade pnpm to 10.23.0 to fix Netlify build (#7306) by @shulaoda - add `trustPolicyExclude` for chokidar and semver (#7302) by @sapphi-red - update pnpm lockfile (#7291) by @IWANABETHATGUY - deps: update npm packages (#7272) by @renovate[bot] - deps: update rust crates (#7270) by @renovate[bot] - deps: update oxc (#7262) by @renovate[bot] - deps: update github-actions (#7269) by @renovate[bot] - deps: update dependency dprint-typescript to v0.95.13 (#7268) by @renovate[bot] - deps: update `html5gum` to 0.8.1 (#7265) by @shulaoda - rolldown: remove unused `getModuleOptions` from `PluginContext` (#7266) by @shulaoda - remove unnecessary justfile ignore (#7243) by @IWANABETHATGUY - deps: update oxc apps (#7238) by @renovate[bot] - add `nul` to workaround https://github.com/anthropics/claude-c… (#7237) by @IWANABETHATGUY - deps: update dependency valibot to v1.2.0 [security] (#7231) by @renovate[bot] - deps: update crate-ci/typos action to v1.40.0 (#7232) by @renovate[bot] ### ❤️ New Contributors * @logaretm made their first contribution in [#7234](#7234) Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned IWANABETHATGUY Nov 30, 2025

IWANABETHATGUY force-pushed the 12-01-fix_6424 branch 2 times, most recently from 5f711bf to 601b74f Compare November 30, 2025 16:23

IWANABETHATGUY marked this pull request as ready for review November 30, 2025 16:24

Copilot AI review requested due to automatic review settings November 30, 2025 16:24

IWANABETHATGUY changed the title ~~fix: 6424~~ feat: support custom chunk names in advanced chunks Nov 30, 2025

Copilot started reviewing on behalf of IWANABETHATGUY November 30, 2025 16:24 View session

IWANABETHATGUY changed the title ~~feat: support custom chunk names in advanced chunks~~ fix: generate relative path like name in advanced chunks Nov 30, 2025

graphite-app bot reviewed Nov 30, 2025

View reviewed changes

crates/rolldown/src/stages/generate_stage/mod.rs Outdated Show resolved Hide resolved

IWANABETHATGUY added the trigger: preview label Nov 30, 2025

IWANABETHATGUY force-pushed the 12-01-fix_6424 branch from 601b74f to 3bba70a Compare November 30, 2025 16:26

Copilot finished reviewing on behalf of IWANABETHATGUY November 30, 2025 16:27

Copilot AI reviewed Nov 30, 2025

View reviewed changes

crates/rolldown/src/stages/generate_stage/mod.rs Outdated Show resolved Hide resolved

packages/rolldown/tests/fixtures/function/advanced-chunks/relative-path-name/_config.ts Show resolved Hide resolved

hyf0 assigned hyf0 and unassigned IWANABETHATGUY Nov 30, 2025

IWANABETHATGUY force-pushed the 12-01-fix_6424 branch from 3bba70a to ee0bef1 Compare December 1, 2025 07:00

Copilot AI review requested due to automatic review settings December 1, 2025 07:08

IWANABETHATGUY force-pushed the 12-01-fix_6424 branch from ee0bef1 to ebffc54 Compare December 1, 2025 07:08

IWANABETHATGUY changed the title ~~fix: generate relative path like name in advanced chunks~~ test: generate relative path like name in advanced chunks Dec 1, 2025

Copilot started reviewing on behalf of IWANABETHATGUY December 1, 2025 07:08 View session

Copilot finished reviewing on behalf of IWANABETHATGUY December 1, 2025 07:09

Copilot AI reviewed Dec 1, 2025

View reviewed changes

packages/rolldown/tests/fixtures/function/advanced-chunks/relative-path-name/_config.ts Show resolved Hide resolved

IWANABETHATGUY mentioned this pull request Dec 1, 2025

[Bug]: advancedChunks(manualChunks) ignores the directory part of the name #6424

Closed

hyf0 approved these changes Dec 1, 2025

View reviewed changes

test: generate relative path like name in advanced chunks (#7267)

36bdcc4

related to #6424

graphite-app bot force-pushed the 12-01-fix_6424 branch from ef80f4a to 36bdcc4 Compare December 1, 2025 13:45

graphite-app bot merged commit 36bdcc4 into main Dec 1, 2025
21 of 25 checks passed

graphite-app bot deleted the 12-01-fix_6424 branch December 1, 2025 14:01

This was referenced Dec 3, 2025

release: v1.0.0-beta.53 #7319

Closed

release: v1.0.0-beta.53 #7324

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

test: generate relative path like name in advanced chunks#7267

test: generate relative path like name in advanced chunks#7267
graphite-app[bot] merged 1 commit intomainfrom
12-01-fix_6424

IWANABETHATGUY commented Nov 30, 2025 •

edited

Loading

Uh oh!

IWANABETHATGUY commented Nov 30, 2025

Uh oh!

netlify bot commented Nov 30, 2025

Uh oh!

netlify bot commented Nov 30, 2025 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

pkg-pr-new bot commented Nov 30, 2025

Uh oh!

github-actions bot commented Nov 30, 2025 •

edited

Loading

Uh oh!

IWANABETHATGUY commented Dec 1, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

graphite-app bot commented Dec 1, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

IWANABETHATGUY commented Nov 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IWANABETHATGUY commented Nov 30, 2025

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Nov 30, 2025

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

netlify bot commented Nov 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Deploy Preview for rolldown-rs failed.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

pkg-pr-new bot commented Nov 30, 2025

Uh oh!

github-actions bot commented Nov 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

IWANABETHATGUY commented Dec 1, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

graphite-app bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IWANABETHATGUY commented Nov 30, 2025 •

edited

Loading

netlify bot commented Nov 30, 2025 •

edited

Loading

github-actions bot commented Nov 30, 2025 •

edited

Loading

graphite-app bot commented Dec 1, 2025 •

edited

Loading