Skip to content

Comments

fix(rolldown_plugin_vite_css_post): pass options to isLegacy callback for proper legacy detection#7260

Merged
shulaoda merged 1 commit intomainfrom
11-29-fix_rolldown_plugin_vite_css_post_pass_options_to_islegacy_callback_for_proper_legacy_detection
Nov 30, 2025
Merged

fix(rolldown_plugin_vite_css_post): pass options to isLegacy callback for proper legacy detection#7260
shulaoda merged 1 commit intomainfrom
11-29-fix_rolldown_plugin_vite_css_post_pass_options_to_islegacy_callback_for_proper_legacy_detection

Conversation

@shulaoda
Copy link
Member

No description provided.

@shulaoda shulaoda changed the title fix(rolldown_plugin_vite_css_post): pass options to isLegacy callback for proper legacy detection fix(rolldown_plugin_vite_css_post): pass options to isLegacy callback for proper legacy detection Nov 29, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shulaoda shulaoda marked this pull request as ready for review November 29, 2025 09:36
Copilot AI review requested due to automatic review settings November 29, 2025 09:36
@netlify
Copy link

netlify bot commented Nov 29, 2025

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit b8182af
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/692abe789b80980008d019d6
😎 Deploy Preview https://deploy-preview-7260--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the Vite CSS Post Plugin where the isLegacy callback was not receiving the necessary output options to properly detect legacy chunks. The fix threads the NormalizedBundlerOptions through the entire plugin architecture, from the TypeScript API layer to the Rust implementation.

Key changes:

  • Updated the TypeScript API to expose isOutputOptionsForLegacyChunks callback that receives NormalizedOutputOptions instead of the internal isLegacy callback
  • Modified the binding layer to properly wrap and transform the callback, passing BindingNormalizedOptions to JavaScript
  • Updated Rust implementation to pass options to the isLegacy callback in both renderChunk and generateBundle hooks

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/rolldown/src/builtin-plugin/vite-css-post-plugin.ts Renamed callback to isOutputOptionsForLegacyChunks and added NormalizedOutputOptions parameter
packages/rolldown/src/builtin-plugin/utils.ts Added callback wrapper that transforms TypeScript callback to match Rust signature with proper options passing
packages/rolldown/src/binding.d.cts Updated TypeScript type definition for isLegacy callback to accept BindingNormalizedOptions
crates/rolldown_plugin_vite_css_post/src/utils.rs Updated isLegacy callback invocation in renderChunk to pass ctx.args.options
crates/rolldown_plugin_vite_css_post/src/lib.rs Updated IsLegacyFn type signature and callback invocation in generateBundle to accept and pass options
crates/rolldown_binding/src/options/plugin/config/binding_vite_css_post_plugin_config.rs Updated binding to wrap callback with BindingNormalizedOptions::new() transformation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

Benchmarks Rust

  • target: main(cae0e2a)
  • pr: 11-29-fix_rolldown_plugin_vite_css_post_pass_options_to_islegacy_callback_for_proper_legacy_detection(b8182af)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     65.8±4.09ms        ? ?/sec    1.14     75.0±5.55ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.02     88.0±8.70ms        ? ?/sec    1.00     85.9±5.81ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    123.4±6.82ms        ? ?/sec    1.00   121.2±11.24ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    125.1±6.98ms        ? ?/sec    1.01    126.0±6.53ms        ? ?/sec
bundle/bundle@threejs                                        1.08     45.4±2.61ms        ? ?/sec    1.00     42.1±1.86ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.07     48.0±3.39ms        ? ?/sec    1.00     45.0±1.84ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00   434.4±25.57ms        ? ?/sec    1.07   466.0±20.30ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.03   515.4±33.15ms        ? ?/sec    1.00   499.3±27.38ms        ? ?/sec
scan/scan@rome_ts                                            1.00     89.9±3.54ms        ? ?/sec    1.01     90.9±4.41ms        ? ?/sec
scan/scan@threejs                                            1.00     28.3±1.91ms        ? ?/sec    1.07     30.2±1.57ms        ? ?/sec
scan/scan@threejs10x                                         1.00    305.8±9.44ms        ? ?/sec    1.01   308.8±12.45ms        ? ?/sec

@shulaoda shulaoda merged commit bd6dd42 into main Nov 30, 2025
37 checks passed
@shulaoda shulaoda deleted the 11-29-fix_rolldown_plugin_vite_css_post_pass_options_to_islegacy_callback_for_proper_legacy_detection branch November 30, 2025 06:01
This was referenced Dec 3, 2025
shulaoda added a commit that referenced this pull request Dec 3, 2025
## [1.0.0-beta.53] - 2025-12-03

💥 Breaking Changes
- Drop `i686-pc-windows-msvc` target support

🚀 Chunk Merging Optimization
- Rolldown now automatically merges shared chunks when entries import each other (when `preserveEntrySignature` is not `strict`)
```shell
Before:
entry.js   → imports → shared.js (common chunk)
entry2.js  → imports → shared.js
Output: 3 chunks (entry.js, entry2.js, shared.js)

After:
entry.js   → contains shared code
entry2.js  → imports → entry.js
Output: 2 chunks (entry.js, entry2.js)
```

### 💥 BREAKING CHANGES

- drop `i686-pc-windows-msvc` target support (#7230) by @sapphi-red

### 🚀 Features

- rolldown_plugin_vite_manifest: pass normalized options to `isLegacy` callback (#7321) by @shulaoda
- plugin/vite-resolve: add `disableCache` option (#6763) by @sapphi-red
- rolldown: export `createTokioRuntime` for tsdown (#7264) by @shulaoda
- rolldown_plugin_vite_html: sync `moduleSideEffects` for already loaded modules (#7254) by @shulaoda
- rolldown_plugin_vite_html: load module scripts with side effects to prevent tree-shaking (#7244) by @shulaoda
- rolldown_plugin_vite_css_post: implement `cssScopeTo` for scoped CSS tree-shaking (#7240) by @shulaoda

### 🐛 Bug Fixes

- export default class decl __name runtime insertion (#7316) by @IWANABETHATGUY
- chunk side effects calculation (#7273) by @IWANABETHATGUY
- node: `output.generateCode.preset: 'es2015'` should set `output.generateCode.symbols: true` by default (#7314) by @sapphi-red
- skip name helper for classes with static name property (#7312) by @IWANABETHATGUY
- preserve chunk imports relationship after chunk merging (#7303) by @shulaoda
- dev: make `register_modules` async (#7289) by @hyf0
- preserve computed property in object destructuring (#7288) by @IWANABETHATGUY
- support dynamic imports with shared dependencies (#7261) by @IWANABETHATGUY
- call `defer_sync_scan_data` in non-incremental build mode (#7255) by @shulaoda
- optimize chunk merging for shared entry points (#7194) by @IWANABETHATGUY
- add indentation for UMD format output (#7263) by @IWANABETHATGUY
- rolldown_plugin_vite_css_post: pass options to `isLegacy` callback for proper legacy detection (#7260) by @shulaoda
- rolldown_plugin_vite_css_post: also detect `?inline=true` query for inlined CSS (#7245) by @shulaoda
- rolldown_plugin_vite_css_post: distinguish empty CSS from no CSS (#7241) by @shulaoda
- add Windows support for t-run command (#7242) by @IWANABETHATGUY
- cjs: prevent duplicate require declarations for external modules with preserveModules (#7234) by @logaretm
- rolldown_plugin_vite_resolve: resolve from root for virtual modules (#7236) by @sapphi-red
- include entry level external modules in chunk exports (#7218) by @IWANABETHATGUY

### 🚜 Refactor

- dev: make `removeClient` async (#7313) by @hyf0
- move chunk merging code out of code_splitting.rs (#7285) by @IWANABETHATGUY
- extract common function util for chunk merging (#7271) by @IWANABETHATGUY
- use iterative method to merge chunks (#7256) by @IWANABETHATGUY
- use concat_string! instead of string replace for generating chunk level exports (#7247) by @IWANABETHATGUY

### 📚 Documentation

- add warning to experimental.resolveNewUrlToAsset about JS/TS files (#7300) by @Copilot
- add sequential hook execution difference in plugin-api.md (#7308) by @Copilot
- add migration example from onwarn to onLog (#7299) by @Copilot
- add migration example for manualChunks to advancedChunks (#7298) by @Copilot
- deps: bump vitepress to fix build (#7307) by @sapphi-red
- examples & text for experimental.resolveNewUrlToAsset (#7259) by @TheAlexLichter

### ⚡ Performance

- rolldown_plugin_vite_css_post: lazily load `cssScopeTo` from JS module options (#7253) by @shulaoda
- rolldown_plugin_vite_css_post: avoid unnecessary string clones in `resolve_asset_urls_in_css` (#7250) by @shulaoda

### 🧪 Testing

- generate relative path like name in advanced chunks (#7267) by @IWANABETHATGUY
- add test case for preserveEntrySignatures with re-exports (#7279) by @IWANABETHATGUY
- add test262 integration tests (#7196) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- deps: update dependency rolldown-plugin-dts to v0.18.1 (#7304) by @renovate[bot]
- enable tracing feature for napi (#7322) by @sapphi-red
- deps: update napi (#7320) by @renovate[bot]
- deps: update oxc (#7318) by @renovate[bot]
- deps: update napi (#7317) by @renovate[bot]
- deps: update oxc to v0.100.0 (#7301) by @renovate[bot]
- deps: downgrade pnpm to 10.23.0 to fix Netlify build (#7306) by @shulaoda
- add `trustPolicyExclude` for chokidar and semver (#7302) by @sapphi-red
- update pnpm lockfile (#7291) by @IWANABETHATGUY
- deps: update npm packages (#7272) by @renovate[bot]
- deps: update rust crates (#7270) by @renovate[bot]
- deps: update oxc (#7262) by @renovate[bot]
- deps: update github-actions (#7269) by @renovate[bot]
- deps: update dependency dprint-typescript to v0.95.13 (#7268) by @renovate[bot]
- deps: update `html5gum` to 0.8.1 (#7265) by @shulaoda
- rolldown: remove unused `getModuleOptions` from `PluginContext` (#7266) by @shulaoda
- remove unnecessary justfile ignore (#7243) by @IWANABETHATGUY
- deps: update oxc apps (#7238) by @renovate[bot]
- add `nul` to workaround https://github.com/anthropics/claude-c… (#7237) by @IWANABETHATGUY
- deps: update dependency valibot to v1.2.0 [security] (#7231) by @renovate[bot]
- deps: update crate-ci/typos action to v1.40.0 (#7232) by @renovate[bot]

### ❤️ New Contributors

* @logaretm made their first contribution in [#7234](#7234)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant