Skip to content

Comments

refactor: use iterative method to merge chunks#7256

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-28-refactor_use_iterative_method_to_merge_chunks
Nov 29, 2025
Merged

refactor: use iterative method to merge chunks#7256
graphite-app[bot] merged 1 commit intomainfrom
11-28-refactor_use_iterative_method_to_merge_chunks

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Nov 28, 2025 •
edited
Loading

  1. Make chunk reduction optimization more performant and simpler.

@IWANABETHATGUY Graphite App
Copy link
Member Author

IWANABETHATGUY commented Nov 28, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Nov 28, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit cae0e2a
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/692a79eb69a2670008e5336c

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review November 28, 2025 15:02
Copilot AI review requested due to automatic review settings November 28, 2025 15:02
@IWANABETHATGUY IWANABETHATGUY force-pushed the 11-28-refactor_use_iterative_method_to_merge_chunks branch from fa7db25 to bd7f89e Compare November 28, 2025 15:02
@IWANABETHATGUY IWANABETHATGUY force-pushed the 11-28-refactor_use_iterative_method_to_merge_chunks branch from bd7f89e to e590896 Compare November 28, 2025 15:03
Copilot AI reviewed Nov 28, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the chunk merging logic to use an iterative approach instead of a recursive divide-and-conquer strategy, making the code simpler and easier to understand. It also correctly reorganizes dependencies by moving test/benchmark-only dependencies to [dev-dependencies].

  • Replaces recursive try_insert_into_exists_chunk implementation with a straightforward iterative loop
  • Removes the CombineChunkRet enum that was only needed for the recursive approach
  • Moves dunce, rolldown_common, rolldown_testing, and tokio to dev-dependencies where appropriate

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
crates/rolldown/src/stages/generate_stage/code_splitting.rs Refactored chunk merging from recursive to iterative approach; removed CombineChunkRet enum; simplified match patterns
crates/rolldown/Cargo.toml Moved dunce to dev-dependencies (only used in tests)
crates/bench/Cargo.toml Moved rolldown_common, rolldown_testing, and tokio to dev-dependencies (only used in benchmarks)
Comments suppressed due to low confidence (1)

crates/rolldown/src/stages/generate_stage/code_splitting.rs:1

  • The vec import is unnecessary. The vec! macro is available in the Rust prelude and doesn't need to be explicitly imported. Remove vec from this import statement.
use std::{cmp::Ordering, collections::VecDeque, path::Path};

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(927e0e4)
  • pr: 11-28-refactor_use_iterative_method_to_merge_chunks(cae0e2a)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     71.5±1.61ms        ? ?/sec    1.03     73.4±2.54ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     78.5±1.88ms        ? ?/sec    1.02     80.4±3.86ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    112.2±2.55ms        ? ?/sec    1.01    113.7±2.05ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    126.9±1.87ms        ? ?/sec    1.00    126.4±2.06ms        ? ?/sec
bundle/bundle@threejs                                        1.00     42.1±2.40ms        ? ?/sec    1.01     42.5±2.41ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     45.2±1.17ms        ? ?/sec    1.01     45.8±0.63ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    412.1±5.35ms        ? ?/sec    1.00    413.6±6.43ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    475.8±5.25ms        ? ?/sec    1.00    475.4±3.56ms        ? ?/sec
scan/scan@rome_ts                                            1.01     91.1±2.24ms        ? ?/sec    1.00     90.4±1.79ms        ? ?/sec
scan/scan@threejs                                            1.01     30.8±2.06ms        ? ?/sec    1.00     30.5±2.46ms        ? ?/sec
scan/scan@threejs10x                                         1.01    311.9±5.57ms        ? ?/sec    1.00    307.8±5.35ms        ? ?/sec

IWANABETHATGUY
IWANABETHATGUY commented Nov 28, 2025
View reviewed changes
@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Nov 28, 2025
Merged
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 29, 2025 •
edited
Loading

Merge activity

  • Nov 29, 4:42 AM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
  • Nov 29, 4:54 AM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'node-test (ubuntu-latest) / Node Test', 'node-test (macos-latest) / Node Test', 'node-test (windows-latest) / Node Test').
  • Nov 29, 5:55 AM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
  • Nov 29, 5:55 AM UTC: Merged by the Graphite merge queue.

@IWANABETHATGUY
refactor: use iterative method to merge chunks (#7256)
cae0e2a 
1. Make chunk reduction optimization more performant and simpler.
@graphite-app graphite-app bot force-pushed the 11-28-refactor_use_iterative_method_to_merge_chunks branch from e590896 to cae0e2a Compare November 29, 2025 04:43
@graphite-app graphite-app bot merged commit cae0e2a into main Nov 29, 2025
42 of 45 checks passed
@graphite-app graphite-app bot deleted the 11-28-refactor_use_iterative_method_to_merge_chunks branch November 29, 2025 05:55
This was referenced Nov 29, 2025
Merged
Merged
Merged
Merged
This was referenced Dec 3, 2025
Closed
Merged
shulaoda added a commit that referenced this pull request Dec 3, 2025
@github-actions @shulaoda
release: v1.0.0-beta.53 (#7324)
c013fc8 
## [1.0.0-beta.53] - 2025-12-03

💥 Breaking Changes
- Drop `i686-pc-windows-msvc` target support

🚀 Chunk Merging Optimization
- Rolldown now automatically merges shared chunks when entries import each other (when `preserveEntrySignature` is not `strict`)
```shell
Before:
entry.js   → imports → shared.js (common chunk)
entry2.js  → imports → shared.js
Output: 3 chunks (entry.js, entry2.js, shared.js)

After:
entry.js   → contains shared code
entry2.js  → imports → entry.js
Output: 2 chunks (entry.js, entry2.js)
```

### 💥 BREAKING CHANGES

- drop `i686-pc-windows-msvc` target support (#7230) by @sapphi-red

### 🚀 Features

- rolldown_plugin_vite_manifest: pass normalized options to `isLegacy` callback (#7321) by @shulaoda
- plugin/vite-resolve: add `disableCache` option (#6763) by @sapphi-red
- rolldown: export `createTokioRuntime` for tsdown (#7264) by @shulaoda
- rolldown_plugin_vite_html: sync `moduleSideEffects` for already loaded modules (#7254) by @shulaoda
- rolldown_plugin_vite_html: load module scripts with side effects to prevent tree-shaking (#7244) by @shulaoda
- rolldown_plugin_vite_css_post: implement `cssScopeTo` for scoped CSS tree-shaking (#7240) by @shulaoda

### 🐛 Bug Fixes

- export default class decl __name runtime insertion (#7316) by @IWANABETHATGUY
- chunk side effects calculation (#7273) by @IWANABETHATGUY
- node: `output.generateCode.preset: 'es2015'` should set `output.generateCode.symbols: true` by default (#7314) by @sapphi-red
- skip name helper for classes with static name property (#7312) by @IWANABETHATGUY
- preserve chunk imports relationship after chunk merging (#7303) by @shulaoda
- dev: make `register_modules` async (#7289) by @hyf0
- preserve computed property in object destructuring (#7288) by @IWANABETHATGUY
- support dynamic imports with shared dependencies (#7261) by @IWANABETHATGUY
- call `defer_sync_scan_data` in non-incremental build mode (#7255) by @shulaoda
- optimize chunk merging for shared entry points (#7194) by @IWANABETHATGUY
- add indentation for UMD format output (#7263) by @IWANABETHATGUY
- rolldown_plugin_vite_css_post: pass options to `isLegacy` callback for proper legacy detection (#7260) by @shulaoda
- rolldown_plugin_vite_css_post: also detect `?inline=true` query for inlined CSS (#7245) by @shulaoda
- rolldown_plugin_vite_css_post: distinguish empty CSS from no CSS (#7241) by @shulaoda
- add Windows support for t-run command (#7242) by @IWANABETHATGUY
- cjs: prevent duplicate require declarations for external modules with preserveModules (#7234) by @logaretm
- rolldown_plugin_vite_resolve: resolve from root for virtual modules (#7236) by @sapphi-red
- include entry level external modules in chunk exports (#7218) by @IWANABETHATGUY

### 🚜 Refactor

- dev: make `removeClient` async (#7313) by @hyf0
- move chunk merging code out of code_splitting.rs (#7285) by @IWANABETHATGUY
- extract common function util for chunk merging (#7271) by @IWANABETHATGUY
- use iterative method to merge chunks (#7256) by @IWANABETHATGUY
- use concat_string! instead of string replace for generating chunk level exports (#7247) by @IWANABETHATGUY

### 📚 Documentation

- add warning to experimental.resolveNewUrlToAsset about JS/TS files (#7300) by @Copilot
- add sequential hook execution difference in plugin-api.md (#7308) by @Copilot
- add migration example from onwarn to onLog (#7299) by @Copilot
- add migration example for manualChunks to advancedChunks (#7298) by @Copilot
- deps: bump vitepress to fix build (#7307) by @sapphi-red
- examples & text for experimental.resolveNewUrlToAsset (#7259) by @TheAlexLichter

### ⚡ Performance

- rolldown_plugin_vite_css_post: lazily load `cssScopeTo` from JS module options (#7253) by @shulaoda
- rolldown_plugin_vite_css_post: avoid unnecessary string clones in `resolve_asset_urls_in_css` (#7250) by @shulaoda

### 🧪 Testing

- generate relative path like name in advanced chunks (#7267) by @IWANABETHATGUY
- add test case for preserveEntrySignatures with re-exports (#7279) by @IWANABETHATGUY
- add test262 integration tests (#7196) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- deps: update dependency rolldown-plugin-dts to v0.18.1 (#7304) by @renovate[bot]
- enable tracing feature for napi (#7322) by @sapphi-red
- deps: update napi (#7320) by @renovate[bot]
- deps: update oxc (#7318) by @renovate[bot]
- deps: update napi (#7317) by @renovate[bot]
- deps: update oxc to v0.100.0 (#7301) by @renovate[bot]
- deps: downgrade pnpm to 10.23.0 to fix Netlify build (#7306) by @shulaoda
- add `trustPolicyExclude` for chokidar and semver (#7302) by @sapphi-red
- update pnpm lockfile (#7291) by @IWANABETHATGUY
- deps: update npm packages (#7272) by @renovate[bot]
- deps: update rust crates (#7270) by @renovate[bot]
- deps: update oxc (#7262) by @renovate[bot]
- deps: update github-actions (#7269) by @renovate[bot]
- deps: update dependency dprint-typescript to v0.95.13 (#7268) by @renovate[bot]
- deps: update `html5gum` to 0.8.1 (#7265) by @shulaoda
- rolldown: remove unused `getModuleOptions` from `PluginContext` (#7266) by @shulaoda
- remove unnecessary justfile ignore (#7243) by @IWANABETHATGUY
- deps: update oxc apps (#7238) by @renovate[bot]
- add `nul` to workaround https://github.com/anthropics/claude-c… (#7237) by @IWANABETHATGUY
- deps: update dependency valibot to v1.2.0 [security] (#7231) by @renovate[bot]
- deps: update crate-ci/typos action to v1.40.0 (#7232) by @renovate[bot]

### ❤️ New Contributors

* @logaretm made their first contribution in [#7234](#7234)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@shulaoda shulaoda shulaoda approved these changes

Assignees

@IWANABETHATGUY IWANABETHATGUY

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IWANABETHATGUY @shulaoda