fix: call `defer_sync_scan_data` in non-incremental build mode by shulaoda · Pull Request #7255 · rolldown/rolldown

shulaoda · 2025-11-28T12:43:07Z

Related to #6568

Previously, defer_sync_scan_data was only called when incremental build was enabled, causing moduleSideEffects mutations via getModuleInfo() to be ignored in regular builds.

shulaoda · 2025-11-28T12:43:24Z

fix: call defer_sync_scan_data in non-incremental build mode #7255 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2025-11-28T12:44:48Z

❌ Deploy Preview for rolldown-rs failed.

Name	Link
🔨 Latest commit	`148bb25`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/692d09df6f751000085f75c0

Copilot

Pull request overview

This PR fixes a bug where moduleSideEffects mutations made via getModuleInfo() in plugins were ignored in non-incremental build mode. The fix ensures defer_sync_scan_data is called for both incremental and non-incremental builds, allowing plugin mutations to be applied consistently.

Refactored defer_sync_scan_data to build module ID mapping from scan output instead of requiring it as a parameter
Updated build logic to call defer_sync_scan_data in non-incremental mode
Updated test expectations to verify the fix works correctly

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
crates/rolldown/src/bundle/bundle.rs	Modified build logic to call `defer_sync_scan_data` for non-incremental builds; simplified method by removing intermediate helper
crates/rolldown/src/module_loader/deferred_scan_data.rs	Refactored to build module ID index internally from scan output, removing dependency on cache's `module_id_to_idx` parameter
crates/rolldown/src/types/scan_stage_cache.rs	Updated function call to match new `defer_sync_scan_data` signature
packages/rolldown/tests/fixtures/tree-shake/module-side-effects-proxy2/_config.ts	Updated test expectations to verify `moduleSideEffects` mutations are now correctly applied (changed from `true` to `false`)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2025-11-28T12:58:33Z

Benchmarks Rust

target: main(5208010)
pr: 11-28-fix_call_defer_sync_scan_data_in_non-incremental_build_mode(148bb25)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     68.0±2.04ms        ? ?/sec    1.00     67.0±1.89ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.09     80.2±2.84ms        ? ?/sec    1.00     73.7±1.69ms        ? ?/sec
bundle/bundle@rome_ts                                        1.04    112.6±2.53ms        ? ?/sec    1.00    108.1±1.89ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    124.0±2.37ms        ? ?/sec    1.00    122.3±2.30ms        ? ?/sec
bundle/bundle@threejs                                        1.01     40.7±0.98ms        ? ?/sec    1.00     40.1±0.97ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     44.0±1.11ms        ? ?/sec    1.00     43.5±0.77ms        ? ?/sec
bundle/bundle@threejs10x                                     1.04    414.5±9.98ms        ? ?/sec    1.00    399.6±9.24ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.03    470.4±7.50ms        ? ?/sec    1.00    458.7±5.24ms        ? ?/sec
scan/scan@rome_ts                                            1.00     86.0±1.80ms        ? ?/sec    1.01     86.7±1.66ms        ? ?/sec
scan/scan@threejs                                            1.03     29.9±0.83ms        ? ?/sec    1.00     29.0±0.77ms        ? ?/sec
scan/scan@threejs10x                                         1.02    308.6±5.37ms        ? ?/sec    1.00    301.3±4.82ms        ? ?/sec

crates/rolldown/src/bundle/bundle.rs

packages/rolldown/tests/fixtures/tree-shake/module-side-effects-proxy2/_config.ts

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

graphite-app · 2025-12-01T03:43:18Z

Merge activity

Dec 1, 3:43 AM UTC: shulaoda added this pull request to the Graphite merge queue.

@sapphi-red

## [1.0.0-beta.53] - 2025-12-03 💥 Breaking Changes - Drop `i686-pc-windows-msvc` target support 🚀 Chunk Merging Optimization - Rolldown now automatically merges shared chunks when entries import each other (when `preserveEntrySignature` is not `strict`) ```shell Before: entry.js → imports → shared.js (common chunk) entry2.js → imports → shared.js Output: 3 chunks (entry.js, entry2.js, shared.js) After: entry.js → contains shared code entry2.js → imports → entry.js Output: 2 chunks (entry.js, entry2.js) ``` ### 💥 BREAKING CHANGES - drop `i686-pc-windows-msvc` target support (#7230) by @sapphi-red ### 🚀 Features - rolldown_plugin_vite_manifest: pass normalized options to `isLegacy` callback (#7321) by @shulaoda - plugin/vite-resolve: add `disableCache` option (#6763) by @sapphi-red - rolldown: export `createTokioRuntime` for tsdown (#7264) by @shulaoda - rolldown_plugin_vite_html: sync `moduleSideEffects` for already loaded modules (#7254) by @shulaoda - rolldown_plugin_vite_html: load module scripts with side effects to prevent tree-shaking (#7244) by @shulaoda - rolldown_plugin_vite_css_post: implement `cssScopeTo` for scoped CSS tree-shaking (#7240) by @shulaoda ### 🐛 Bug Fixes - export default class decl __name runtime insertion (#7316) by @IWANABETHATGUY - chunk side effects calculation (#7273) by @IWANABETHATGUY - node: `output.generateCode.preset: 'es2015'` should set `output.generateCode.symbols: true` by default (#7314) by @sapphi-red - skip name helper for classes with static name property (#7312) by @IWANABETHATGUY - preserve chunk imports relationship after chunk merging (#7303) by @shulaoda - dev: make `register_modules` async (#7289) by @hyf0 - preserve computed property in object destructuring (#7288) by @IWANABETHATGUY - support dynamic imports with shared dependencies (#7261) by @IWANABETHATGUY - call `defer_sync_scan_data` in non-incremental build mode (#7255) by @shulaoda - optimize chunk merging for shared entry points (#7194) by @IWANABETHATGUY - add indentation for UMD format output (#7263) by @IWANABETHATGUY - rolldown_plugin_vite_css_post: pass options to `isLegacy` callback for proper legacy detection (#7260) by @shulaoda - rolldown_plugin_vite_css_post: also detect `?inline=true` query for inlined CSS (#7245) by @shulaoda - rolldown_plugin_vite_css_post: distinguish empty CSS from no CSS (#7241) by @shulaoda - add Windows support for t-run command (#7242) by @IWANABETHATGUY - cjs: prevent duplicate require declarations for external modules with preserveModules (#7234) by @logaretm - rolldown_plugin_vite_resolve: resolve from root for virtual modules (#7236) by @sapphi-red - include entry level external modules in chunk exports (#7218) by @IWANABETHATGUY ### 🚜 Refactor - dev: make `removeClient` async (#7313) by @hyf0 - move chunk merging code out of code_splitting.rs (#7285) by @IWANABETHATGUY - extract common function util for chunk merging (#7271) by @IWANABETHATGUY - use iterative method to merge chunks (#7256) by @IWANABETHATGUY - use concat_string! instead of string replace for generating chunk level exports (#7247) by @IWANABETHATGUY ### 📚 Documentation - add warning to experimental.resolveNewUrlToAsset about JS/TS files (#7300) by @Copilot - add sequential hook execution difference in plugin-api.md (#7308) by @Copilot - add migration example from onwarn to onLog (#7299) by @Copilot - add migration example for manualChunks to advancedChunks (#7298) by @Copilot - deps: bump vitepress to fix build (#7307) by @sapphi-red - examples & text for experimental.resolveNewUrlToAsset (#7259) by @TheAlexLichter ### ⚡ Performance - rolldown_plugin_vite_css_post: lazily load `cssScopeTo` from JS module options (#7253) by @shulaoda - rolldown_plugin_vite_css_post: avoid unnecessary string clones in `resolve_asset_urls_in_css` (#7250) by @shulaoda ### 🧪 Testing - generate relative path like name in advanced chunks (#7267) by @IWANABETHATGUY - add test case for preserveEntrySignatures with re-exports (#7279) by @IWANABETHATGUY - add test262 integration tests (#7196) by @sapphi-red ### ⚙️ Miscellaneous Tasks - deps: update dependency rolldown-plugin-dts to v0.18.1 (#7304) by @renovate[bot] - enable tracing feature for napi (#7322) by @sapphi-red - deps: update napi (#7320) by @renovate[bot] - deps: update oxc (#7318) by @renovate[bot] - deps: update napi (#7317) by @renovate[bot] - deps: update oxc to v0.100.0 (#7301) by @renovate[bot] - deps: downgrade pnpm to 10.23.0 to fix Netlify build (#7306) by @shulaoda - add `trustPolicyExclude` for chokidar and semver (#7302) by @sapphi-red - update pnpm lockfile (#7291) by @IWANABETHATGUY - deps: update npm packages (#7272) by @renovate[bot] - deps: update rust crates (#7270) by @renovate[bot] - deps: update oxc (#7262) by @renovate[bot] - deps: update github-actions (#7269) by @renovate[bot] - deps: update dependency dprint-typescript to v0.95.13 (#7268) by @renovate[bot] - deps: update `html5gum` to 0.8.1 (#7265) by @shulaoda - rolldown: remove unused `getModuleOptions` from `PluginContext` (#7266) by @shulaoda - remove unnecessary justfile ignore (#7243) by @IWANABETHATGUY - deps: update oxc apps (#7238) by @renovate[bot] - add `nul` to workaround https://github.com/anthropics/claude-c… (#7237) by @IWANABETHATGUY - deps: update dependency valibot to v1.2.0 [security] (#7231) by @renovate[bot] - deps: update crate-ci/typos action to v1.40.0 (#7232) by @renovate[bot] ### ❤️ New Contributors * @logaretm made their first contribution in [#7234](#7234) Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned shulaoda Nov 28, 2025

shulaoda changed the title ~~fix: call defer_sync_scan_data in non-incremental build mode~~ fix: call defer_sync_scan_data in non-incremental build mode Nov 28, 2025

shulaoda requested review from IWANABETHATGUY and sapphi-red November 28, 2025 12:43

shulaoda marked this pull request as ready for review November 28, 2025 12:43

Copilot AI review requested due to automatic review settings November 28, 2025 12:43

Copilot started reviewing on behalf of shulaoda November 28, 2025 12:44 View session

Copilot finished reviewing on behalf of shulaoda November 28, 2025 12:46

Copilot AI reviewed Nov 28, 2025

View reviewed changes

shulaoda marked this pull request as draft November 28, 2025 14:03

shulaoda marked this pull request as ready for review November 28, 2025 14:15

shulaoda requested a review from hyf0 November 28, 2025 14:20

hyf0 reviewed Dec 1, 2025

View reviewed changes

crates/rolldown/src/bundle/bundle.rs Outdated Show resolved Hide resolved

sapphi-red reviewed Dec 1, 2025

View reviewed changes

packages/rolldown/tests/fixtures/tree-shake/module-side-effects-proxy2/_config.ts Outdated Show resolved Hide resolved

fix: call defer_sync_scan_data in non-incremental build mode

e09a330

Copilot AI review requested due to automatic review settings December 1, 2025 03:20

shulaoda force-pushed the 11-28-fix_call_defer_sync_scan_data_in_non-incremental_build_mode branch from c35d0ed to f082c56 Compare December 1, 2025 03:20

Copilot started reviewing on behalf of shulaoda December 1, 2025 03:20 View session

Copilot finished reviewing on behalf of shulaoda December 1, 2025 03:21

u

148bb25

shulaoda force-pushed the 11-28-fix_call_defer_sync_scan_data_in_non-incremental_build_mode branch from f082c56 to 148bb25 Compare December 1, 2025 03:22

Copilot AI reviewed Dec 1, 2025

View reviewed changes

hyf0 approved these changes Dec 1, 2025

View reviewed changes

shulaoda merged commit b296b30 into main Dec 1, 2025
24 of 28 checks passed

shulaoda deleted the 11-28-fix_call_defer_sync_scan_data_in_non-incremental_build_mode branch December 1, 2025 03:43

github-actions bot mentioned this pull request Dec 3, 2025

release: v1.0.0-beta.53 #7319

Closed

github-actions bot mentioned this pull request Dec 3, 2025

release: v1.0.0-beta.53 #7324

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

fix: call `defer_sync_scan_data` in non-incremental build mode#7255

fix: call `defer_sync_scan_data` in non-incremental build mode#7255
shulaoda merged 2 commits intomainfrom
11-28-fix_call_defer_sync_scan_data_in_non-incremental_build_mode

shulaoda commented Nov 28, 2025 •

edited

Loading

Uh oh!

shulaoda commented Nov 28, 2025

Uh oh!

netlify bot commented Nov 28, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions bot commented Nov 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

graphite-app bot commented Dec 1, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

shulaoda commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shulaoda commented Nov 28, 2025

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Deploy Preview for rolldown-rs failed.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

github-actions bot commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

graphite-app bot commented Dec 1, 2025

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shulaoda commented Nov 28, 2025 •

edited

Loading

netlify bot commented Nov 28, 2025 •

edited

Loading

github-actions bot commented Nov 28, 2025 •

edited

Loading