refactor: use concat_string! instead of string replace for generating chunk level exports by IWANABETHATGUY · Pull Request #7247 · rolldown/rolldown

IWANABETHATGUY · 2025-11-27T13:19:24Z

It should also improve perf a little

IWANABETHATGUY · 2025-11-27T13:19:44Z

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

package.json

netlify · 2025-11-27T13:45:33Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`3c130a3`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/692928f3f7eb350007c9df09

Copilot

Pull request overview

This PR refactors string generation for chunk-level exports by replacing a .replace() operation with the concat_string! macro for improved performance. The change also includes standardizing the format checking command to use pnpm scripts.

Replaces string template replacement with direct string concatenation using concat_string! macro
Adds fmt-check npm script for consistency
Updates justfile to use pnpm scripts instead of direct dprint invocation

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
package.json	Adds `fmt-check` script that wraps `dprint check` command for formatting validation
justfile	Updates `lint-repo` target to use `pnpm fmt-check` instead of direct `dprint check` for consistency
crates/rolldown/src/utils/chunk/render_chunk_exports.rs	Refactors export statement generation from template string with `.replace()` to `concat_string!` macro for better performance

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/rolldown/src/utils/chunk/render_chunk_exports.rs

github-actions · 2025-11-27T13:59:45Z

Benchmarks Rust

target: main(7ada037)
pr: 11-27-refactor_use_concat_string_to_generate_chunk_level_exports(3c130a3)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.03     66.8±2.80ms        ? ?/sec    1.00     64.8±1.97ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.04     74.6±3.42ms        ? ?/sec    1.00     71.5±2.06ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    109.9±2.85ms        ? ?/sec    1.00    107.7±3.76ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    122.2±2.83ms        ? ?/sec    1.00    122.0±2.84ms        ? ?/sec
bundle/bundle@threejs                                        1.00     40.2±2.13ms        ? ?/sec    1.01     40.6±2.78ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     43.3±0.68ms        ? ?/sec    1.01     43.7±0.89ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    405.1±7.73ms        ? ?/sec    1.00    402.3±8.45ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    461.3±5.68ms        ? ?/sec    1.00    458.8±5.67ms        ? ?/sec
scan/scan@rome_ts                                            1.00     85.5±1.74ms        ? ?/sec    1.01     86.0±1.74ms        ? ?/sec
scan/scan@threejs                                            1.03     29.9±1.93ms        ? ?/sec    1.00     28.9±0.54ms        ? ?/sec
scan/scan@threejs10x                                         1.01    300.3±5.25ms        ? ?/sec    1.00    297.0±4.73ms        ? ?/sec

graphite-app · 2025-11-28T04:45:23Z

Merge activity

Nov 28, 4:45 AM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Nov 28, 4:59 AM UTC: Merged by the Graphite merge queue.

… chunk level exports (#7247) It should also improve perf a little

@sapphi-red

## [1.0.0-beta.53] - 2025-12-03 💥 Breaking Changes - Drop `i686-pc-windows-msvc` target support 🚀 Chunk Merging Optimization - Rolldown now automatically merges shared chunks when entries import each other (when `preserveEntrySignature` is not `strict`) ```shell Before: entry.js → imports → shared.js (common chunk) entry2.js → imports → shared.js Output: 3 chunks (entry.js, entry2.js, shared.js) After: entry.js → contains shared code entry2.js → imports → entry.js Output: 2 chunks (entry.js, entry2.js) ``` ### 💥 BREAKING CHANGES - drop `i686-pc-windows-msvc` target support (#7230) by @sapphi-red ### 🚀 Features - rolldown_plugin_vite_manifest: pass normalized options to `isLegacy` callback (#7321) by @shulaoda - plugin/vite-resolve: add `disableCache` option (#6763) by @sapphi-red - rolldown: export `createTokioRuntime` for tsdown (#7264) by @shulaoda - rolldown_plugin_vite_html: sync `moduleSideEffects` for already loaded modules (#7254) by @shulaoda - rolldown_plugin_vite_html: load module scripts with side effects to prevent tree-shaking (#7244) by @shulaoda - rolldown_plugin_vite_css_post: implement `cssScopeTo` for scoped CSS tree-shaking (#7240) by @shulaoda ### 🐛 Bug Fixes - export default class decl __name runtime insertion (#7316) by @IWANABETHATGUY - chunk side effects calculation (#7273) by @IWANABETHATGUY - node: `output.generateCode.preset: 'es2015'` should set `output.generateCode.symbols: true` by default (#7314) by @sapphi-red - skip name helper for classes with static name property (#7312) by @IWANABETHATGUY - preserve chunk imports relationship after chunk merging (#7303) by @shulaoda - dev: make `register_modules` async (#7289) by @hyf0 - preserve computed property in object destructuring (#7288) by @IWANABETHATGUY - support dynamic imports with shared dependencies (#7261) by @IWANABETHATGUY - call `defer_sync_scan_data` in non-incremental build mode (#7255) by @shulaoda - optimize chunk merging for shared entry points (#7194) by @IWANABETHATGUY - add indentation for UMD format output (#7263) by @IWANABETHATGUY - rolldown_plugin_vite_css_post: pass options to `isLegacy` callback for proper legacy detection (#7260) by @shulaoda - rolldown_plugin_vite_css_post: also detect `?inline=true` query for inlined CSS (#7245) by @shulaoda - rolldown_plugin_vite_css_post: distinguish empty CSS from no CSS (#7241) by @shulaoda - add Windows support for t-run command (#7242) by @IWANABETHATGUY - cjs: prevent duplicate require declarations for external modules with preserveModules (#7234) by @logaretm - rolldown_plugin_vite_resolve: resolve from root for virtual modules (#7236) by @sapphi-red - include entry level external modules in chunk exports (#7218) by @IWANABETHATGUY ### 🚜 Refactor - dev: make `removeClient` async (#7313) by @hyf0 - move chunk merging code out of code_splitting.rs (#7285) by @IWANABETHATGUY - extract common function util for chunk merging (#7271) by @IWANABETHATGUY - use iterative method to merge chunks (#7256) by @IWANABETHATGUY - use concat_string! instead of string replace for generating chunk level exports (#7247) by @IWANABETHATGUY ### 📚 Documentation - add warning to experimental.resolveNewUrlToAsset about JS/TS files (#7300) by @Copilot - add sequential hook execution difference in plugin-api.md (#7308) by @Copilot - add migration example from onwarn to onLog (#7299) by @Copilot - add migration example for manualChunks to advancedChunks (#7298) by @Copilot - deps: bump vitepress to fix build (#7307) by @sapphi-red - examples & text for experimental.resolveNewUrlToAsset (#7259) by @TheAlexLichter ### ⚡ Performance - rolldown_plugin_vite_css_post: lazily load `cssScopeTo` from JS module options (#7253) by @shulaoda - rolldown_plugin_vite_css_post: avoid unnecessary string clones in `resolve_asset_urls_in_css` (#7250) by @shulaoda ### 🧪 Testing - generate relative path like name in advanced chunks (#7267) by @IWANABETHATGUY - add test case for preserveEntrySignatures with re-exports (#7279) by @IWANABETHATGUY - add test262 integration tests (#7196) by @sapphi-red ### ⚙️ Miscellaneous Tasks - deps: update dependency rolldown-plugin-dts to v0.18.1 (#7304) by @renovate[bot] - enable tracing feature for napi (#7322) by @sapphi-red - deps: update napi (#7320) by @renovate[bot] - deps: update oxc (#7318) by @renovate[bot] - deps: update napi (#7317) by @renovate[bot] - deps: update oxc to v0.100.0 (#7301) by @renovate[bot] - deps: downgrade pnpm to 10.23.0 to fix Netlify build (#7306) by @shulaoda - add `trustPolicyExclude` for chokidar and semver (#7302) by @sapphi-red - update pnpm lockfile (#7291) by @IWANABETHATGUY - deps: update npm packages (#7272) by @renovate[bot] - deps: update rust crates (#7270) by @renovate[bot] - deps: update oxc (#7262) by @renovate[bot] - deps: update github-actions (#7269) by @renovate[bot] - deps: update dependency dprint-typescript to v0.95.13 (#7268) by @renovate[bot] - deps: update `html5gum` to 0.8.1 (#7265) by @shulaoda - rolldown: remove unused `getModuleOptions` from `PluginContext` (#7266) by @shulaoda - remove unnecessary justfile ignore (#7243) by @IWANABETHATGUY - deps: update oxc apps (#7238) by @renovate[bot] - add `nul` to workaround https://github.com/anthropics/claude-c… (#7237) by @IWANABETHATGUY - deps: update dependency valibot to v1.2.0 [security] (#7231) by @renovate[bot] - deps: update crate-ci/typos action to v1.40.0 (#7232) by @renovate[bot] ### ❤️ New Contributors * @logaretm made their first contribution in [#7234](#7234) Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned IWANABETHATGUY Nov 27, 2025

IWANABETHATGUY mentioned this pull request Nov 27, 2025

refactor: remove expect usage #7246

Closed

IWANABETHATGUY changed the title ~~refactor: use concat_string to generate chunk level exports~~ refactor: use concat_string! instead of string replace for import statement Nov 27, 2025

IWANABETHATGUY changed the title ~~refactor: use concat_string! instead of string replace for import statement~~ refactor: use concat_string! instead of string replace for generating chunk level exports Nov 27, 2025

IWANABETHATGUY commented Nov 27, 2025

View reviewed changes

package.json Show resolved Hide resolved

IWANABETHATGUY marked this pull request as ready for review November 27, 2025 13:31

IWANABETHATGUY changed the base branch from 11-27-refactor_remove_expect_usage to graphite-base/7247 November 27, 2025 13:32

IWANABETHATGUY force-pushed the graphite-base/7247 branch from f51a0ee to 64dadf2 Compare November 27, 2025 13:32

IWANABETHATGUY force-pushed the 11-27-refactor_use_concat_string_to_generate_chunk_level_exports branch from 0e0a726 to 4af134b Compare November 27, 2025 13:32

IWANABETHATGUY changed the base branch from graphite-base/7247 to main November 27, 2025 13:32

Copilot AI review requested due to automatic review settings November 27, 2025 13:44

IWANABETHATGUY force-pushed the 11-27-refactor_use_concat_string_to_generate_chunk_level_exports branch from 4af134b to 7f835f5 Compare November 27, 2025 13:44

IWANABETHATGUY requested review from hyf0 and shulaoda November 27, 2025 13:45

Copilot started reviewing on behalf of IWANABETHATGUY November 27, 2025 13:45 View session

Copilot finished reviewing on behalf of IWANABETHATGUY November 27, 2025 13:47

Copilot AI reviewed Nov 27, 2025

View reviewed changes

crates/rolldown/src/utils/chunk/render_chunk_exports.rs Show resolved Hide resolved

shulaoda approved these changes Nov 28, 2025

View reviewed changes

IWANABETHATGUY force-pushed the 11-27-refactor_use_concat_string_to_generate_chunk_level_exports branch from 7f835f5 to 82218d0 Compare November 28, 2025 04:30

refactor: use concat_string! instead of string replace for generating…

3c130a3

… chunk level exports (#7247) It should also improve perf a little

graphite-app bot force-pushed the 11-27-refactor_use_concat_string_to_generate_chunk_level_exports branch from 82218d0 to 3c130a3 Compare November 28, 2025 04:45

graphite-app bot merged commit 3c130a3 into main Nov 28, 2025
28 checks passed

graphite-app bot deleted the 11-27-refactor_use_concat_string_to_generate_chunk_level_exports branch November 28, 2025 04:59

This was referenced Dec 3, 2025

release: v1.0.0-beta.53 #7319

Closed

release: v1.0.0-beta.53 #7324

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

refactor: use concat_string! instead of string replace for generating chunk level exports#7247

refactor: use concat_string! instead of string replace for generating chunk level exports#7247
graphite-app[bot] merged 1 commit intomainfrom
11-27-refactor_use_concat_string_to_generate_chunk_level_exports

IWANABETHATGUY commented Nov 27, 2025 •

edited

Loading

Uh oh!

IWANABETHATGUY commented Nov 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

netlify bot commented Nov 27, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

github-actions bot commented Nov 27, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Nov 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

IWANABETHATGUY commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IWANABETHATGUY commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Uh oh!

netlify bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

github-actions bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

graphite-app bot commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IWANABETHATGUY commented Nov 27, 2025 •

edited

Loading

IWANABETHATGUY commented Nov 27, 2025 •

edited

Loading

netlify bot commented Nov 27, 2025 •

edited

Loading

github-actions bot commented Nov 27, 2025 •

edited

Loading

graphite-app bot commented Nov 28, 2025 •

edited

Loading