Skip to content

Comments

fix(rolldown_plugin_vite_resolve): resolve from root for virtual modules#7236

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-27-fix_rolldown_plugin_vite_resolve_resolve_from_root_for_virtual_modules
Nov 27, 2025
Merged

fix(rolldown_plugin_vite_resolve): resolve from root for virtual modules#7236
graphite-app[bot] merged 1 commit intomainfrom
11-27-fix_rolldown_plugin_vite_resolve_resolve_from_root_for_virtual_modules

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Nov 27, 2025

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red requested a review from shulaoda November 27, 2025 03:28
@sapphi-red sapphi-red self-assigned this Nov 27, 2025
@netlify
Copy link

netlify bot commented Nov 27, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 4b067c3
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6927d9221e57650008dd59ce

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

Benchmarks Rust

  • target: main(11d0760)
  • pr: 11-27-fix_rolldown_plugin_vite_resolve_resolve_from_root_for_virtual_modules(4b067c3)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     65.8±1.62ms        ? ?/sec    1.00     65.5±1.47ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     72.9±2.30ms        ? ?/sec    1.00     72.0±2.27ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    109.3±1.86ms        ? ?/sec    1.00    109.3±1.95ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    122.9±2.46ms        ? ?/sec    1.00    122.9±2.17ms        ? ?/sec
bundle/bundle@threejs                                        1.02     40.5±2.54ms        ? ?/sec    1.00     39.8±0.60ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     43.6±0.91ms        ? ?/sec    1.01     43.8±0.91ms        ? ?/sec
bundle/bundle@threejs10x                                     1.02    402.3±6.06ms        ? ?/sec    1.00    395.8±4.20ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    461.9±5.33ms        ? ?/sec    1.00    456.2±5.35ms        ? ?/sec
scan/scan@rome_ts                                            1.01     86.2±2.31ms        ? ?/sec    1.00     85.8±2.56ms        ? ?/sec
scan/scan@threejs                                            1.02     29.4±1.90ms        ? ?/sec    1.00     28.7±0.38ms        ? ?/sec
scan/scan@threejs10x                                         1.01    301.4±4.11ms        ? ?/sec    1.00    298.7±4.87ms        ? ?/sec

@sapphi-red sapphi-red marked this pull request as ready for review November 27, 2025 03:42
Copilot AI review requested due to automatic review settings November 27, 2025 03:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors module resolution logic to fix virtual module handling. It replaces the get_base_dir function with should_use_importer, which returns a boolean instead of an optional directory string. This change ensures that virtual modules (which don't exist on the filesystem) resolve from the project root rather than trying to resolve from their non-existent importer directory.

Key changes:

  • Refactored get_base_dir function to should_use_importer with boolean return type
  • Modified the logic for determining when to use the importer's directory vs the root directory
  • Updated both call sites to use the new function signature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 27, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 11-27-fix_rolldown_plugin_vite_resolve_resolve_from_root_for_virtual_modules branch from 6f5bc11 to 4b067c3 Compare November 27, 2025 04:52
@graphite-app graphite-app bot merged commit 4b067c3 into main Nov 27, 2025
44 of 45 checks passed
@graphite-app graphite-app bot deleted the 11-27-fix_rolldown_plugin_vite_resolve_resolve_from_root_for_virtual_modules branch November 27, 2025 06:54
This was referenced Dec 3, 2025
shulaoda added a commit that referenced this pull request Dec 3, 2025
## [1.0.0-beta.53] - 2025-12-03

💥 Breaking Changes
- Drop `i686-pc-windows-msvc` target support

🚀 Chunk Merging Optimization
- Rolldown now automatically merges shared chunks when entries import each other (when `preserveEntrySignature` is not `strict`)
```shell
Before:
entry.js   → imports → shared.js (common chunk)
entry2.js  → imports → shared.js
Output: 3 chunks (entry.js, entry2.js, shared.js)

After:
entry.js   → contains shared code
entry2.js  → imports → entry.js
Output: 2 chunks (entry.js, entry2.js)
```

### 💥 BREAKING CHANGES

- drop `i686-pc-windows-msvc` target support (#7230) by @sapphi-red

### 🚀 Features

- rolldown_plugin_vite_manifest: pass normalized options to `isLegacy` callback (#7321) by @shulaoda
- plugin/vite-resolve: add `disableCache` option (#6763) by @sapphi-red
- rolldown: export `createTokioRuntime` for tsdown (#7264) by @shulaoda
- rolldown_plugin_vite_html: sync `moduleSideEffects` for already loaded modules (#7254) by @shulaoda
- rolldown_plugin_vite_html: load module scripts with side effects to prevent tree-shaking (#7244) by @shulaoda
- rolldown_plugin_vite_css_post: implement `cssScopeTo` for scoped CSS tree-shaking (#7240) by @shulaoda

### 🐛 Bug Fixes

- export default class decl __name runtime insertion (#7316) by @IWANABETHATGUY
- chunk side effects calculation (#7273) by @IWANABETHATGUY
- node: `output.generateCode.preset: 'es2015'` should set `output.generateCode.symbols: true` by default (#7314) by @sapphi-red
- skip name helper for classes with static name property (#7312) by @IWANABETHATGUY
- preserve chunk imports relationship after chunk merging (#7303) by @shulaoda
- dev: make `register_modules` async (#7289) by @hyf0
- preserve computed property in object destructuring (#7288) by @IWANABETHATGUY
- support dynamic imports with shared dependencies (#7261) by @IWANABETHATGUY
- call `defer_sync_scan_data` in non-incremental build mode (#7255) by @shulaoda
- optimize chunk merging for shared entry points (#7194) by @IWANABETHATGUY
- add indentation for UMD format output (#7263) by @IWANABETHATGUY
- rolldown_plugin_vite_css_post: pass options to `isLegacy` callback for proper legacy detection (#7260) by @shulaoda
- rolldown_plugin_vite_css_post: also detect `?inline=true` query for inlined CSS (#7245) by @shulaoda
- rolldown_plugin_vite_css_post: distinguish empty CSS from no CSS (#7241) by @shulaoda
- add Windows support for t-run command (#7242) by @IWANABETHATGUY
- cjs: prevent duplicate require declarations for external modules with preserveModules (#7234) by @logaretm
- rolldown_plugin_vite_resolve: resolve from root for virtual modules (#7236) by @sapphi-red
- include entry level external modules in chunk exports (#7218) by @IWANABETHATGUY

### 🚜 Refactor

- dev: make `removeClient` async (#7313) by @hyf0
- move chunk merging code out of code_splitting.rs (#7285) by @IWANABETHATGUY
- extract common function util for chunk merging (#7271) by @IWANABETHATGUY
- use iterative method to merge chunks (#7256) by @IWANABETHATGUY
- use concat_string! instead of string replace for generating chunk level exports (#7247) by @IWANABETHATGUY

### 📚 Documentation

- add warning to experimental.resolveNewUrlToAsset about JS/TS files (#7300) by @Copilot
- add sequential hook execution difference in plugin-api.md (#7308) by @Copilot
- add migration example from onwarn to onLog (#7299) by @Copilot
- add migration example for manualChunks to advancedChunks (#7298) by @Copilot
- deps: bump vitepress to fix build (#7307) by @sapphi-red
- examples & text for experimental.resolveNewUrlToAsset (#7259) by @TheAlexLichter

### ⚡ Performance

- rolldown_plugin_vite_css_post: lazily load `cssScopeTo` from JS module options (#7253) by @shulaoda
- rolldown_plugin_vite_css_post: avoid unnecessary string clones in `resolve_asset_urls_in_css` (#7250) by @shulaoda

### 🧪 Testing

- generate relative path like name in advanced chunks (#7267) by @IWANABETHATGUY
- add test case for preserveEntrySignatures with re-exports (#7279) by @IWANABETHATGUY
- add test262 integration tests (#7196) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- deps: update dependency rolldown-plugin-dts to v0.18.1 (#7304) by @renovate[bot]
- enable tracing feature for napi (#7322) by @sapphi-red
- deps: update napi (#7320) by @renovate[bot]
- deps: update oxc (#7318) by @renovate[bot]
- deps: update napi (#7317) by @renovate[bot]
- deps: update oxc to v0.100.0 (#7301) by @renovate[bot]
- deps: downgrade pnpm to 10.23.0 to fix Netlify build (#7306) by @shulaoda
- add `trustPolicyExclude` for chokidar and semver (#7302) by @sapphi-red
- update pnpm lockfile (#7291) by @IWANABETHATGUY
- deps: update npm packages (#7272) by @renovate[bot]
- deps: update rust crates (#7270) by @renovate[bot]
- deps: update oxc (#7262) by @renovate[bot]
- deps: update github-actions (#7269) by @renovate[bot]
- deps: update dependency dprint-typescript to v0.95.13 (#7268) by @renovate[bot]
- deps: update `html5gum` to 0.8.1 (#7265) by @shulaoda
- rolldown: remove unused `getModuleOptions` from `PluginContext` (#7266) by @shulaoda
- remove unnecessary justfile ignore (#7243) by @IWANABETHATGUY
- deps: update oxc apps (#7238) by @renovate[bot]
- add `nul` to workaround https://github.com/anthropics/claude-c… (#7237) by @IWANABETHATGUY
- deps: update dependency valibot to v1.2.0 [security] (#7231) by @renovate[bot]
- deps: update crate-ci/typos action to v1.40.0 (#7232) by @renovate[bot]

### ❤️ New Contributors

* @logaretm made their first contribution in [#7234](#7234)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vite:import-analysis cannot find the file

2 participants