Skip to content

Comments

refactor(rolldown_utils): add guess_mime_skip_utf8_check for binary assets#7161

Merged
shulaoda merged 3 commits intomainfrom
11-20-refactor_rolldown_utils_add_guess_mime_skip_utf8_check_for_binary_assets
Nov 20, 2025
Merged

refactor(rolldown_utils): add guess_mime_skip_utf8_check for binary assets#7161
shulaoda merged 3 commits intomainfrom
11-20-refactor_rolldown_utils_add_guess_mime_skip_utf8_check_for_binary_assets

Conversation

@shulaoda
Copy link
Member

No description provided.

Copy link
Member Author

shulaoda commented Nov 20, 2025


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shulaoda shulaoda changed the title refactor(rolldown_utils): add guess_mime_skip_utf8_check for binary assets refactor(rolldown_utils): add guess_mime_skip_utf8_check for binary assets Nov 20, 2025
@shulaoda shulaoda marked this pull request as ready for review November 20, 2025 14:57
@github-actions
Copy link
Contributor

Benchmarks Rust

  • target: 11-20-fix_rolldown_plugin_vite_css_post_use_correct_start_position_in_magic_string_updates(acb7346)
  • pr: 11-20-refactor_rolldown_utils_add_guess_mime_skip_utf8_check_for_binary_assets(c7cab3b)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     61.0±1.06ms        ? ?/sec    1.05     63.7±1.28ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     67.4±0.92ms        ? ?/sec    1.04     70.2±1.96ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    105.5±1.52ms        ? ?/sec    1.02    107.7±1.65ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    117.4±1.58ms        ? ?/sec    1.04    121.8±1.76ms        ? ?/sec
bundle/bundle@threejs                                        1.00     38.9±2.78ms        ? ?/sec    1.00     38.8±2.31ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.04     43.6±1.74ms        ? ?/sec    1.00     42.1±0.49ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    387.5±4.89ms        ? ?/sec    1.01    392.5±4.59ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    445.6±4.23ms        ? ?/sec    1.01    449.9±4.34ms        ? ?/sec
scan/scan@rome_ts                                            1.00     83.1±1.37ms        ? ?/sec    1.02     84.5±2.52ms        ? ?/sec
scan/scan@threejs                                            1.00     28.4±1.87ms        ? ?/sec    1.00     28.5±1.97ms        ? ?/sec
scan/scan@threejs10x                                         1.00    289.7±3.49ms        ? ?/sec    1.00    291.0±3.85ms        ? ?/sec

@graphite-app graphite-app bot changed the base branch from 11-20-fix_rolldown_plugin_vite_css_post_use_correct_start_position_in_magic_string_updates to graphite-base/7161 November 20, 2025 17:34
@graphite-app graphite-app bot force-pushed the 11-20-refactor_rolldown_utils_add_guess_mime_skip_utf8_check_for_binary_assets branch from c7cab3b to e864539 Compare November 20, 2025 17:51
@graphite-app graphite-app bot force-pushed the graphite-base/7161 branch from acb7346 to a2f4267 Compare November 20, 2025 17:51
@graphite-app graphite-app bot changed the base branch from graphite-base/7161 to main November 20, 2025 17:52
@graphite-app graphite-app bot force-pushed the 11-20-refactor_rolldown_utils_add_guess_mime_skip_utf8_check_for_binary_assets branch from e864539 to 3249da6 Compare November 20, 2025 17:52
@netlify
Copy link

netlify bot commented Nov 20, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 3249da6
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/691f5554901dc900085fa93f

@shulaoda shulaoda changed the base branch from main to graphite-base/7161 November 20, 2025 18:06
@shulaoda shulaoda force-pushed the 11-20-refactor_rolldown_utils_add_guess_mime_skip_utf8_check_for_binary_assets branch from 3249da6 to badb741 Compare November 20, 2025 18:07
@shulaoda shulaoda changed the base branch from graphite-base/7161 to 11-20-fix_rolldown_plugin_vite_css_post_use_correct_start_position_in_magic_string_updates November 20, 2025 18:07
Base automatically changed from 11-20-fix_rolldown_plugin_vite_css_post_use_correct_start_position_in_magic_string_updates to main November 20, 2025 18:23
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 20, 2025

Merge activity

@shulaoda shulaoda merged commit 088d29e into main Nov 20, 2025
23 of 26 checks passed
@shulaoda shulaoda deleted the 11-20-refactor_rolldown_utils_add_guess_mime_skip_utf8_check_for_binary_assets branch November 20, 2025 18:23
This was referenced Nov 26, 2025
shulaoda added a commit that referenced this pull request Nov 26, 2025
## [1.0.0-beta.52] - 2025-11-26

💥 Breaking Change

- Change `output.generatedCode.profilerNames` default to `false`

🔧 Vite-Style TypeScript Configuration

- Rolldown now supports Vite-style automatic tsconfig resolution. Use `tsconfig: true` to enable auto-discovery mode where each module finds its nearest `tsconfig.json`. See more details [here](https://rolldown.rs/options/tsconfig)

⚙️ Upgraded to oxc v0.99.0

- Add `TSGlobalDeclaration` type
- More details: https://github.com/oxc-project/oxc/releases/tag/crates_v0.99.0

### 💥 BREAKING CHANGES

- change `output.generatedCode.profilerNames` default to false (#7139) by @Copilot

### 🚀 Features

- support vite-style tsconfig resolution (#6873) by @shulaoda
- rolldown: oxc v0.99.0  (#7165) by @camc314
- browser: export `plugins` (#7210) by @sxzz
- rolldown_plugin_vite_css_post: add `inline` parameter to `cssMinify` callback (#7191) by @shulaoda
- rolldown_plugin_vite_build_import_analysis: implement `render_chunk` to replace `__VITE_IS_MODERN__` flag (#7178) by @shulaoda
- rolldown_plugin_utils: optimize SVG data URL encoding (#7156) by @shulaoda
- dev: replace `DevEngine::hasLatestBuildOutput` with `DevEngine::getBundleState` (#7145) by @sapphi-red
- rolldown_plugin_vite_asset_import_meta_url: support `@vite-ignore` comment (#7141) by @shulaoda
- rolldown_plugin_vite_asset_import_meta_url: implement static URL processing (#7140) by @shulaoda
- rolldown_plugin_vite_asset_import_meta_url: align `asset_resolver` logic (#7137) by @shulaoda
- rolldown_plugin_vite_asset_import_meta_url: align `try_fs_resolve` logic (#7136) by @shulaoda
- rolldown_plugin_vite_asset_import_meta_url: validate relative paths (#7120) by @shulaoda
- export `viteAssetImportMetaUrlPlugin` and add dynamic URL tests (#7119) by @shulaoda

### 🐛 Bug Fixes

- watch overwrite rename event on linux (#7201) by @sapphi-red
- preserve name for parenthesized anonymous default exports and arrow functions with keepNames (#7159) by @Copilot
- rolldown_plugin_vite_html: add missing async attribute for inlined entry scripts (#7202) by @shulaoda
- respect target setting in DCE to prevent modern syntax generation (#7128) by @Copilot
- rolldown_plugin_vite_html: add semicolon to import statement in CSS removal (#7200) by @shulaoda
- rolldown_plugin_vite_html: use correct CSS asset filename in HTML injection (#7199) by @shulaoda
- rolldown_plugin_vite_css_post: handle scoped package names in lib CSS filename (#7198) by @shulaoda
- rolldown_plugin_vite_html: use patched `html5gum` with correct span tracking (#7193) by @shulaoda
- rolldown_plugin_vite_html: handle HTML strings in script tags correctly (#7192) by @shulaoda
- handle JSON import namespace property access correctly (#7190) by @IWANABETHATGUY
- only include runtime helpers from included modules (#7183) by @IWANABETHATGUY
- rolldown_plugin_vite_html: normalize paths to use forward slashes in `original_file_name` (#7175) by @shulaoda
- rolldown_plugin_vite_css_post: use `filename` instead of `reference_id` for imported assets (#7174) by @shulaoda
- rolldown_plugin_vite_css_post: correct regex escaping in pure CSS chunk pruning (#7173) by @shulaoda
- rolldown_plugin_vite_html: use correct dependency path for modulepreload links (#7172) by @shulaoda
- update cur_stmt_index when processing top level statements (#7157) by @IWANABETHATGUY
- rolldown_plugin_utils: strip leading character from public asset URL (#7170) by @shulaoda
- rolldown_plugin_vite_html: use correct `public_base` for `html_result_map` key (#7169) by @shulaoda
- rolldown_plugin_utils: correct runtime handling and escape single quotes in asset paths (#7168) by @shulaoda
- rolldown_plugin_utils: prevent data race in `file_to_url` cache (#7166) by @shulaoda
- rolldown_plugin_vite_asset_import_meta_url: correct glob pattern and query string handling in dynamic URLs (#7162) by @shulaoda
- rolldown_plugin_vite_css_post: use correct start position in magic string updates (#7158) by @shulaoda
- data race in `FileEmitter::emit_file` causing duplicate asset emissions (#7164) by @shulaoda
- dev: watch files even if the build failed (#7149) by @sapphi-red
- rolldown_plugin_utils: always use base64 encoding for data URLs (#7148) by @shulaoda
- preserve "default" name for anonymous default exports with keepNames (#7151) by @Copilot
- correctly handle cjs json module as entry point (#7147) by @IWANABETHATGUY
- rolldown_plugin_utils: correct `reference_id` parsing in `render_asset_url_in_js` (#7143) by @shulaoda
- rolldown_plugin_vite_asset_import_meta_url: exclude quotes from URL span (#7142) by @shulaoda
- rolldown_plugin_vite_asset_import_meta_url: use template literal for glob result indexing (#7134) by @shulaoda
- tree shake unused dynamic entry when `inlineDynamicImports` is enabled (#7129) by @IWANABETHATGUY
- correct return value of `parse` / `parseSync` functions (#7127) by @sapphi-red

### 🚜 Refactor

- rolldown_plugin_vite_transform: use `oxc_resolver` for tsconfig discovery (#7220) by @shulaoda
- rolldown_plugin_vite_resolve: use `resolve_file` for tsconfig discovery (#7216) by @shulaoda
- rolldown_plugin_utils: remove redundant `ViteMetadata::get_or_insert_default()` (#7189) by @shulaoda
- rolldown_plugin_utils: simplify `ViteMetadata::get()` to always return a value (#7188) by @shulaoda
- rolldown_utils: add `guess_mime_skip_utf8_check` for binary assets (#7161) by @shulaoda
- rolldown_plugin_utils: extract asset URL parsing into `AssetUrlIter` (#7144) by @shulaoda
- store pattern name in FilenameTemplate (#7132) by @IWANABETHATGUY

### 📚 Documentation

- tsconfig: document auto-discovery mode and improve structure (#7228) by @shulaoda
- add plugin hook filter compatibility and fallback guide (#7138) by @Copilot
- update top level navigation (#7092) by @mdong1909

### 🧪 Testing

- add tsconfig include/exclude/files matching test cases (#6899) by @shulaoda
- vite-tests: run `playwright install` in case playwright binary is missing (#7226) by @sapphi-red
- watch: close watcher when an error occured in the test cases (#7225) by @sapphi-red
- watch: reject `waitBuildFinished` if `ERROR` event occurs (#7224) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- example: revert accidental changes to basic-typescript (#7227) by @shulaoda
- deps: update oxc apps (#7212) by @renovate[bot]
- deps: update rust crates (#7204) by @renovate[bot]
- deps: update `oxc_resolver_napi` to 11.14.0 (#7217) by @shulaoda
- deps: update oxc_resolver (#6909) by @shulaoda
- deps: update dependency glob to v13 (#7208) by @renovate[bot]
- deps: update actions/checkout action to v6 (#7207) by @renovate[bot]
- deps: update npm packages (#7206) by @renovate[bot]
- deps: update github-actions (#7205) by @renovate[bot]
- add missing status code comment (#7185) by @iiio2
- deps: update dependency oxlint-tsgolint to v0.8.1 (#7197) by @renovate[bot]
- rust: add more tracing log for hmr + dev logic (#7179) by @hyf0
- deps: update dependency oxlint-tsgolint to v0.8.0 (#7167) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.7.3 (#7133) by @renovate[bot]
- merge similar inlineDynamicImports test case (#7131) by @IWANABETHATGUY
- deps: update `rolldown-plugin-dts` to 0.18.0 (#7125) by @shulaoda

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants