Skip to content

Comments

feat: verify spans#7096

Closed
sapphi-red wants to merge 1 commit intomainfrom
11-17-feat_verify_spans
Closed

feat: verify spans#7096
sapphi-red wants to merge 1 commit intomainfrom
11-17-feat_verify_spans

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Nov 17, 2025 •
edited
Loading

Used to debug oxc-project/oxc#15778

@sapphi-red Graphite App
Copy link
Member Author

sapphi-red commented Nov 17, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red mentioned this pull request Nov 17, 2025
Merged
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 17, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #7096 will degrade performances by 15.9%

Comparing 11-17-feat_verify_spans (04a58f3) with main (3d970e8)

Summary

❌ 8 regressions

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ bundle@multi-duplicated-top-level-symbol 272.6 ms 290.9 ms -6.31%
❌ bundle@multi-duplicated-top-level-symbol-sourcemap 304.6 ms 322.9 ms -5.69%
❌ bundle@rome_ts 520.8 ms 577.9 ms -9.88%
❌ bundle@rome_ts-sourcemap 598 ms 657.4 ms -9.04%
❌ bundle@threejs 201.8 ms 231.8 ms -12.94%
❌ bundle@threejs-sourcemap 235.5 ms 266.9 ms -11.76%
❌ scan@rome_ts 424.2 ms 481.4 ms -11.87%
❌ scan@threejs 157.2 ms 186.9 ms -15.9%

@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2025 •
edited
Loading

Benchmarks Rust

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.08     70.3±2.51ms        ? ?/sec    1.00     65.1±1.84ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.06     76.5±1.92ms        ? ?/sec    1.00     72.0±1.89ms        ? ?/sec
bundle/bundle@rome_ts                                        1.11    118.1±1.99ms        ? ?/sec    1.00    106.8±1.95ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.10    131.4±2.84ms        ? ?/sec    1.00    119.4±1.86ms        ? ?/sec
bundle/bundle@threejs                                        1.12     43.7±1.22ms        ? ?/sec    1.00     39.1±0.75ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.11     47.6±1.36ms        ? ?/sec    1.00     42.8±0.68ms        ? ?/sec
bundle/bundle@threejs10x                                     1.11    435.5±5.08ms        ? ?/sec    1.00    392.7±7.13ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.10    496.0±3.66ms        ? ?/sec    1.00    451.1±4.31ms        ? ?/sec
scan/scan@rome_ts                                            1.09     93.0±1.58ms        ? ?/sec    1.00     85.7±1.67ms        ? ?/sec
scan/scan@threejs                                            1.14     33.2±2.12ms        ? ?/sec    1.00     29.1±1.92ms        ? ?/sec
scan/scan@threejs10x                                         1.12    332.8±4.65ms        ? ?/sec    1.00    297.4±4.71ms        ? ?/sec

@graphite-app graphite-app bot changed the base branch from 11-17-feat_show_error_contexts_for_unhandleable_errors to graphite-base/7096 November 17, 2025 13:59
@graphite-app graphite-app bot force-pushed the 11-17-feat_verify_spans branch from 66c5714 to 117aa94 Compare November 17, 2025 14:13
@graphite-app graphite-app bot changed the base branch from graphite-base/7096 to main November 17, 2025 14:14
@graphite-app graphite-app bot force-pushed the 11-17-feat_verify_spans branch from 117aa94 to 04a58f3 Compare November 17, 2025 14:14
@netlify
Copy link

netlify bot commented Nov 17, 2025

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 04a58f3
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/691b2dc75c66210008119dcf

@sapphi-red sapphi-red closed this Nov 23, 2025
@sapphi-red sapphi-red deleted the 11-17-feat_verify_spans branch November 23, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sapphi-red