feat: change "could not clean directory" from error to warning by Copilot · Pull Request #6955 · rolldown/rolldown

Copilot · 2025-11-12T04:20:09Z

Implementation complete for converting "could not clean directory" error to a warning:

Summary

Successfully converted the "could not clean directory" error into a warning. The bundler will now continue building even if it cannot clean the output directory due to permission issues or other filesystem constraints. The warning provides detailed information about the directory and the reason for the failure.

The CouldNotCleanDirectory warning is now configurable via checks options with a default of true (enabled).

Changes Made

Added CouldNotCleanDirectory event kind to enum
Created event struct with directory path and error reason
Updated bundle logic to catch clean_dir errors and emit warnings instead of failing
Generated code automatically updated for EventKindSwitcher and checks options
Made the warning configurable through checks options (per review feedback)
Updated CLI help message snapshot to include the new --checks.could-not-clean-directory option

Original prompt

This section details on the original issue you should resolve

<issue_title>Change could not clean directory error to a warning</issue_title>
<issue_description>I think a warning would be more friendly than error. Unable to clean the dir isn't worth to block the build. If you to think so, let's create an issue to turn this into a builtin warning.

Originally posted by @hyf0 in #6952 (comment)
</issue_description>

<agent_instructions>Add a new struct that implements BuildEvent for this new warning</agent_instructions>

Comments on the Issue (you are @copilot in this section)

Fixes Change could not clean directory error to a warning #6954

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

graphite-app · 2025-11-12T04:20:15Z

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

netlify · 2025-11-12T04:21:34Z

✅ Deploy Preview for rolldown-rs ready!

Name	Link
🔨 Latest commit	`cac3879`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/6914c3f548cafe0008417168
😎 Deploy Preview	https://deploy-preview-6955--rolldown-rs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

packages/rolldown/src/options/generated/checks-options.ts

github-actions · 2025-11-12T05:35:21Z

Benchmarks Rust

target: main(8e4f6e2)
pr: copilot/change-clean-directory-error-to-warning(cac3879)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.09     69.9±2.15ms        ? ?/sec    1.00     64.0±1.59ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.09     76.8±1.52ms        ? ?/sec    1.00     70.8±3.54ms        ? ?/sec
bundle/bundle@rome_ts                                        1.05    112.5±2.38ms        ? ?/sec    1.00    107.2±1.62ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.04    125.7±1.97ms        ? ?/sec    1.00    120.3±2.07ms        ? ?/sec
bundle/bundle@threejs                                        1.03     41.8±1.80ms        ? ?/sec    1.00     40.6±2.29ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.06     45.0±1.14ms        ? ?/sec    1.00     42.3±0.66ms        ? ?/sec
bundle/bundle@threejs10x                                     1.05    407.6±6.52ms        ? ?/sec    1.00    388.7±4.54ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.03    464.6±4.59ms        ? ?/sec    1.00    449.9±3.20ms        ? ?/sec
scan/scan@rome_ts                                            1.00     86.6±1.63ms        ? ?/sec    1.01     87.1±1.94ms        ? ?/sec
scan/scan@threejs                                            1.05     29.9±1.96ms        ? ?/sec    1.00     28.5±0.39ms        ? ?/sec
scan/scan@threejs10x                                         1.00    300.5±4.10ms        ? ?/sec    1.01    302.7±4.52ms        ? ?/sec

tasks/generator/src/main.rs

sapphi-red · 2025-11-12T12:04:48Z

@copilot update the snapshot in node tests

Copilot · 2025-11-12T12:13:41Z

@copilot update the snapshot in node tests

Updated the CLI help message snapshot to include the new --checks.could-not-clean-directory option. Changes in commit d815642.

hyf0 · 2025-11-12T17:28:56Z

Merge activity

Nov 12, 5:28 PM UTC: The merge label 'graphite: merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Nov 12, 5:28 PM UTC: hyf0 added this pull request to the Graphite merge queue.
Nov 12, 5:42 PM UTC: Merged by the Graphite merge queue.

@hyf0

Implementation complete for converting "could not clean directory" error to a warning: - [x] Explore codebase and understand BuildEvent structure - [x] Add new EventKind::CouldNotCleanDirectory to event_kind.rs - [x] Create new could_not_clean_directory.rs event file - [x] Add constructor to BuildDiagnostic in constructors.rs - [x] Update bundle.rs to emit warning instead of error - [x] Register new event in events/mod.rs - [x] Build and test changes - all tests passing - [x] Run linter - Rust linting passed - [x] Update generated code files - [x] Re-add couldNotCleanDirectory to checks options per review feedback - [x] Update CLI snapshot for the new option - [x] Security scan (codeql timed out, but changes are minimal and safe) ## Summary Successfully converted the "could not clean directory" error into a warning. The bundler will now continue building even if it cannot clean the output directory due to permission issues or other filesystem constraints. The warning provides detailed information about the directory and the reason for the failure. The `CouldNotCleanDirectory` warning is now configurable via checks options with a default of `true` (enabled). ## Changes Made 1. Added `CouldNotCleanDirectory` event kind to enum 2. Created event struct with directory path and error reason 3. Updated bundle logic to catch clean_dir errors and emit warnings instead of failing 4. Generated code automatically updated for EventKindSwitcher and checks options 5. Made the warning configurable through checks options (per review feedback) 6. Updated CLI help message snapshot to include the new --checks.could-not-clean-directory option  <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>Change could not clean directory error to a warning</issue_title> > <issue_description>I think a warning would be more friendly than error. Unable to clean the dir isn't worth to block the build. If you to think so, let's create an issue to turn this into a builtin warning. > > _Originally posted by @hyf0 in #6952 (comment) > </issue_description> > > <agent_instructions>Add a new struct that implements BuildEvent for this new warning</agent_instructions> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > </comments> > </details> - Fixes #6954  --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs.

@shulaoda

## [1.0.0-beta.51] - 2025-11-19 ### 💥 BREAKING CHANGES - rolldown_plugin_vite_react_refresh_wrapper: add vite prefix (#7086) by @shulaoda - rolldown_plugin_vite_web_worker_post: add vite prefix (#7085) by @shulaoda - rolldown_plugin_vite_wasm_helper: add vite prefix (#7084) by @shulaoda - rolldown_plugin_vite_wasm_fallback: add vite prefix (#7083) by @shulaoda - rolldown_plugin_vite_transform: add vite prefix (#7082) by @shulaoda - rolldown_plugin_vite_reporter: add vite prefix (#7081) by @shulaoda - rolldown_plugin_vite_module_preload_polyfill: add vite prefix (#7080) by @shulaoda - rolldown_plugin_vite_manifest: add vite prefix (#7079) by @shulaoda - rolldown_plugin_vite_load_fallback: add vite prefix (#7072) by @shulaoda - rolldown_plugin_vite_json: add vite prefix (#7071) by @shulaoda - rolldown_plugin_vite_import_glob: add vite prefix (#7070) by @shulaoda - rolldown_plugin_vite_html_inline_proxy: add vite prefix (#7069) by @shulaoda - rolldown_plugin_vite_dynamic_import_vars: add vite prefix (#7068) by @shulaoda - rolldown_plugin_vite_build_import_analysis: add vite prefix (#7067) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: add vite prefix (#7066) by @shulaoda - rolldown_plugin_vite_alias: add vite prefix (#7065) by @shulaoda - rolldown_plugin_vite_asset_plugin: add vite prefix (#7064) by @shulaoda ### 🚀 Features - export sync APIs to experimental (#7122) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: implement template literal support for dynamic URLs (#7118) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: implement AST-based URL detection (#7113) by @shulaoda - add isPathFragment validation for filename patterns (rollup compat) (#7101) by @IWANABETHATGUY - rolldown_plugin_vite_asset_import_meta_url: align filter logic (#7103) by @shulaoda - rolldown: oxc v0.98.0 (#6961) by @camc314 - show error contexts for unhandleable errors (#7095) by @sapphi-red - rolldown_plugin_utils: extract `get_hash` utility function (#7059) by @shulaoda - rolldown_plugin_asset: initialize `CSSEntriesCache` (#7015) by @shulaoda - rolldown_plugin_vite_html: align `transformIndexHtml` logic (#7010) by @shulaoda - builtin-plugin: support `bindingifyViteHtmlPlugin` (#7008) by @shulaoda - impl `generatedCode.symbols` for reexport dynamic modules. (#6993) by @IWANABETHATGUY - rolldown_plugin_manifest: support v2 logic (#6979) by @shulaoda - support Node.js `module.exports` ESM export (#6967) by @Copilot - change "could not clean directory" from error to warning (#6955) by @Copilot - rolldown_binding: add context to errors thrown by plugin hooks (#6964) by @sapphi-red ### 🐛 Bug Fixes - content hash should be affected by the minify behavior (#7102) by @hyf0 - `canonical name not found for "__toESM"` error when only named imports are used from a CJS module (#7094) by @sapphi-red - preserve directory structure in chunk names with preserveModules (#6872) by @IWANABETHATGUY - rolldown_plugin_asset: correct bundle deletion index calculation (#7063) by @shulaoda - rolldown_plugin_utils: correct string slicing in `render_asset_url_in_js` (#7061) by @shulaoda - rolldown_plugin_vite_html: use transformed result in asset URL handling (#7060) by @shulaoda - rolldown_plugin_vite_html: skip redundant path resolution for processed URLs (#7058) by @shulaoda - rolldown_plugin_vite_css_post: data race in CSS URL processing (#7055) by @shulaoda - rolldown_plugin_vite_css_post: always compute css asset dirname in build command (#7054) by @shulaoda - rolldown_plugin_vite_css: ensure consistent url in import and export (#7053) by @shulaoda - rolldown_plugin_vite_css_post: use `get_or_insert_default` for `HTMLProxyResult` (#7052) by @shulaoda - rolldown_plugin_vite_css: skip `commonjs-proxy` CSS requests (#7050) by @shulaoda - rolldown_plugin_utils: correct `is_css_module` (#7049) by @shulaoda - rolldown_plugin_utils: correct `is_css_request` (#7048) by @shulaoda - rolldown_plugin_vite_html: use correct inline module index (#7046) by @shulaoda - rolldown_plugin_vite_html: correct scripts url update logic (#7045) by @shulaoda - rolldown_plugin_vite_html: fallback to original url on NotFound error (#7043) by @shulaoda - rolldown_plugin_vite_html: move src_tasks to correct branch (#7040) by @shulaoda - rolldown_plugin_vite_html: correct `handle_style_tag_or_attribute` (#7038) by @shulaoda - builtin-plugin: add `config` to `htmlInlineProxyPlugin` (#7036) by @shulaoda - missing CJS default export when SafelyMergeCjsNs optimization is enabled (#7006) by @Copilot - reserve global names before deconflicting external symbols (#7022) by @IWANABETHATGUY - rolldown_plugin_build_import_analysis: process all bundle outputs correctly (#7020) by @shulaoda - rolldown_plugin_vite_css_post: process all bundle outputs correctly (#7019) by @shulaoda - rolldown_plugin_vite_css_post: remove `/*$vite$:1*/` correctly (#7018) by @shulaoda - rolldown_plugin_vite_html: use correct span for `style_urls` (#7017) by @shulaoda - rolldown_plugin_vite_html: track full element span from start to end tag (#7016) by @shulaoda - builtin-plugin: correct `viteHtmlPlugin` related logic (#7013) by @shulaoda - remove unused module namespace object exporting (#7002) by @IWANABETHATGUY - rust/dev: allow to recover from hmr rebuild failure (#6991) by @hyf0 - rust/dev: `ensure_latest_bundle_output` shouldn't loop infinitely (#6974) by @hyf0 - rust/dev: `DevEngine#ensure_latest_bundle_output` should schedule a rebuild task if there're no queued tasks (#6968) by @hyf0 - add Symbol.toStringTag to module facades when generatedCode.symbols is enabled (#6784) by @Copilot ### 🚜 Refactor - extension checking to use constant array (#7057) by @Copilot - rust/devtools: tweak namings and introduction comments (#7028) by @hyf0 - rolldown_plugin_vite_html: use `root` instead of `cwd` (#7035) by @shulaoda - rolldown_plugin_vite_css_post: use `root` instead of `cwd` (#7034) by @shulaoda - rolldown_plugin_vite_css: use `root` instead of `cwd` (#7033) by @shulaoda - rolldown_plugin_transform: use `root` instead of `cwd` (#7032) by @shulaoda - rolldown_plugin_reporter: use `root` instead of `cwd` (#7031) by @shulaoda - rolldown_plugin_asset: use `root` instead of `cwd` (#7030) by @shulaoda - rolldown_plugin_html_inline_proxy: use `root` instead of `cwd` (#7029) by @shulaoda - rust/dev: remove dead code of `rolldown_dev` crate (#6997) by @hyf0 - rust: move dev related code into new `rolldown_dev` crate (#6996) by @hyf0 - rolldown_resolver: use consistent generic parameter name `Fs` (#6998) by @shulaoda - rolldown_resolver: improve resolve method clarity and documentation (#6986) by @shulaoda - rename `is_module_facade()` to `is_entry_point()` for clarity (#6994) by @IWANABETHATGUY - rust/dev: unwrap `Result<_>` from the return type of `BundleCoordinator::schedule_build_if_stale` (#6980) by @sapphi-red - rolldown_resolver: reorganize impl blocks (#6984) by @shulaoda - rolldown_resolver: extract configuration logic into separate module (#6983) by @shulaoda - rolldown_resolver: improve error messages (#6982) by @shulaoda - rust/dev: rename `CoordinatorStatus` to `CoordinatorStateSnapshot` (#6973) by @hyf0 - rust/dev: replace `InitialBuildState` with `CoordinatorState` (#6972) by @hyf0 - ast_scanner: derive `Debug`, `Clone`, `Copy` for `CjsGlobalAssignmentType` (#6971) by @camc314 - rust: filter out devtools specific events for normal tracing (#6965) by @hyf0 - rust/dev: replace `CoordinatorMsg::HasLatestBuildOutput` with `GetStatus` (#6960) by @hyf0 - rust/dev: `ensure_current_build_finish` shouldn't block the coordinator's event loop (#6959) by @hyf0 ### 📚 Documentation - in-depth/directives: remove TODOs and fix code (#7112) by @sapphi-red - clarify concepts of rolldown's test infra (#7047) by @hyf0 - contrib/style: add suggestions about choosing file names (#6989) by @hyf0 ### ⚡ Performance - rolldown_plugin_vite_css_post: cache CSS URL processing results (#7056) by @shulaoda - remove unnecessary `collect_vec` (#6999) by @IWANABETHATGUY ### 🧪 Testing - add testcase for #6880 and #6879 (#7107) by @IWANABETHATGUY - vite-tests: use integration branch for vite compatibility tests (#7091) by @shulaoda ### ⚙️ Miscellaneous Tasks - remove redundant chunk level linefeed (#7109) by @IWANABETHATGUY - pin oxc-minify to 0.97.0 (#7108) by @IWANABETHATGUY - deps: update oxc apps (#7104) by @renovate[bot] - deps: update glob for security (#7105) by @shulaoda - rolldown: add aliases for renamed vite plugins (#7087) by @shulaoda - automate weekly beta releases (#7089) by @Boshen - deps: update dependency oxlint-tsgolint to v0.7.0 (#7088) by @renovate[bot] - deps: update github-actions (#7075) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.6.0 (#7037) by @renovate[bot] - deps: update npm packages (#7076) by @renovate[bot] - deps: update rust crates (#7077) by @renovate[bot] - add retry to flaky tests (#7041) by @sapphi-red - rust: rename `rolldown_debug` to `rolldown_devtools` (#7026) by @hyf0 - deps: update crate-ci/typos action to v1.39.2 (#7001) by @renovate[bot] - ai/github: make copilot review check rust api style (#6988) by @hyf0 - move test `recover_from_initial_build_error` to `error_recovery/from_initial_build_syntax_error` (#6990) by @hyf0 - oxlint: enable `typescript/consistent-type-imports` rule (#6987) by @shulaoda - deps: update crate-ci/typos action to v1.39.1 (#6975) by @renovate[bot] - build.ts: separate import type (#6921) by @iiio2 - format rolldown runtime (#6966) by @IWANABETHATGUY Co-authored-by: shulaoda <[email protected]>

Copilot AI assigned Copilot and sapphi-red Nov 12, 2025

Copilot started work on behalf of sapphi-red November 12, 2025 04:20 View session

Copilot AI changed the title ~~[WIP] Change could not clean directory error to warning~~ Change "could not clean directory" from error to warning Nov 12, 2025

Copilot AI requested a review from sapphi-red November 12, 2025 04:40

Copilot finished work on behalf of sapphi-red November 12, 2025 04:40

sapphi-red reviewed Nov 12, 2025

View reviewed changes

packages/rolldown/src/options/generated/checks-options.ts Show resolved Hide resolved

Copilot started work on behalf of sapphi-red November 12, 2025 04:58 View session

Copilot AI requested a review from sapphi-red November 12, 2025 05:08

Copilot finished work on behalf of sapphi-red November 12, 2025 05:08

sapphi-red changed the title ~~Change "could not clean directory" from error to warning~~ feat: change "could not clean directory" from error to warning Nov 12, 2025

Copilot started work on behalf of sapphi-red November 12, 2025 05:41 View session

Copilot finished work on behalf of sapphi-red November 12, 2025 05:45

sapphi-red reviewed Nov 12, 2025

View reviewed changes

tasks/generator/src/main.rs Show resolved Hide resolved

Copilot started work on behalf of sapphi-red November 12, 2025 07:15 View session

Copilot AI requested a review from sapphi-red November 12, 2025 07:22

Copilot finished work on behalf of sapphi-red November 12, 2025 07:22

Copilot started work on behalf of sapphi-red November 12, 2025 12:05 View session

Copilot finished work on behalf of sapphi-red November 12, 2025 12:15

sapphi-red approved these changes Nov 12, 2025

View reviewed changes

sapphi-red force-pushed the copilot/change-clean-directory-error-to-warning branch from d815642 to 7d711fb Compare November 12, 2025 16:36

sapphi-red marked this pull request as ready for review November 12, 2025 16:36

sapphi-red requested a review from hyf0 November 12, 2025 16:36

hyf0 approved these changes Nov 12, 2025

View reviewed changes

hyf0 added the graphite: merge label Nov 12, 2025

graphite-app bot force-pushed the copilot/change-clean-directory-error-to-warning branch from 7d711fb to cac3879 Compare November 12, 2025 17:29

graphite-app bot merged commit cac3879 into main Nov 12, 2025
28 checks passed

graphite-app bot deleted the copilot/change-clean-directory-error-to-warning branch November 12, 2025 17:42

graphite-app bot removed the graphite: merge label Nov 12, 2025

sapphi-red mentioned this pull request Nov 13, 2025

Change could not clean directory error to a warning #6954

Closed

This was referenced Nov 18, 2025

release: v1.0.0-beta.51 #7106

Closed

release: v1.0.0-beta.51 #7121

Closed

release: v1.0.0-beta.51 #7124

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

feat: change "could not clean directory" from error to warning#6955

feat: change "could not clean directory" from error to warning#6955
graphite-app[bot] merged 1 commit intomainfrom
copilot/change-clean-directory-error-to-warning

Copilot AI commented Nov 12, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Nov 12, 2025

Uh oh!

netlify bot commented Nov 12, 2025 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Nov 12, 2025 •

edited

Loading

Uh oh!

Uh oh!

sapphi-red commented Nov 12, 2025

Uh oh!

Copilot AI commented Nov 12, 2025

Uh oh!

hyf0 commented Nov 12, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

Copilot AI commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes Made

Comments on the Issue (you are @copilot in this section)

Uh oh!

graphite-app bot commented Nov 12, 2025

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs ready!

Uh oh!

Uh oh!

github-actions bot commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

Uh oh!

sapphi-red commented Nov 12, 2025

Uh oh!

Copilot AI commented Nov 12, 2025

Uh oh!

hyf0 commented Nov 12, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Nov 12, 2025 •

edited

Loading

netlify bot commented Nov 12, 2025 •

edited

Loading

github-actions bot commented Nov 12, 2025 •

edited

Loading

hyf0 commented Nov 12, 2025 •

edited by graphite-app bot

Loading