Skip to content

Comments

refactor(rolldown_binding): correct renderBuiltUrl#6835

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-04-refactor_rolldown_binding_correct_renderbuilturl
Nov 4, 2025
Merged

refactor(rolldown_binding): correct renderBuiltUrl#6835
graphite-app[bot] merged 1 commit intomainfrom
11-04-refactor_rolldown_binding_correct_renderbuilturl

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Nov 4, 2025

No description provided.

Copy link
Member Author

shulaoda commented Nov 4, 2025


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shulaoda shulaoda changed the title refactor(rolldown_binding): correct renderBuiltUrl refactor(rolldown_binding): correct renderBuiltUrl Nov 4, 2025
@shulaoda shulaoda marked this pull request as ready for review November 4, 2025 08:37
@netlify
Copy link

netlify bot commented Nov 4, 2025

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 7604b8b
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6909d8d5b5e3bd0008a1738e
😎 Deploy Preview https://deploy-preview-6835--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

Benchmarks Rust

  • target: main(fbcc945)
  • pr: 11-04-refactor_rolldown_binding_correct_renderbuilturl(7604b8b)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     67.0±2.14ms        ? ?/sec    1.05     70.6±1.93ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     75.3±3.35ms        ? ?/sec    1.06     80.2±2.68ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    113.3±2.31ms        ? ?/sec    1.00    111.6±2.12ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    124.6±2.90ms        ? ?/sec    1.00    125.1±2.19ms        ? ?/sec
bundle/bundle@threejs                                        1.01     41.1±2.69ms        ? ?/sec    1.00     40.7±1.21ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     44.5±1.28ms        ? ?/sec    1.00     44.2±1.13ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    405.3±5.65ms        ? ?/sec    1.03    418.2±6.68ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    463.6±5.84ms        ? ?/sec    1.03    479.1±6.18ms        ? ?/sec
scan/scan@rome_ts                                            1.00     87.2±1.60ms        ? ?/sec    1.01     88.3±3.66ms        ? ?/sec
scan/scan@threejs                                            1.00     29.9±2.16ms        ? ?/sec    1.00     29.9±0.37ms        ? ?/sec
scan/scan@threejs10x                                         1.00    302.4±5.17ms        ? ?/sec    1.03    310.3±4.51ms        ? ?/sec

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 4, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 11-04-refactor_rolldown_binding_correct_renderbuilturl branch from 08397cb to 7604b8b Compare November 4, 2025 10:43
@graphite-app graphite-app bot merged commit 7604b8b into main Nov 4, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 11-04-refactor_rolldown_binding_correct_renderbuilturl branch November 4, 2025 10:57
@github-actions github-actions bot mentioned this pull request Nov 5, 2025
shulaoda added a commit that referenced this pull request Nov 5, 2025
## [1.0.0-beta.47] - 2025-11-05

### 💥 BREAKING CHANGES

- `meta.magicString` and `meta.ast` now only initialized once (#6828) by @IWANABETHATGUY

### 🚀 Features

- rolldown_plugin_utils: support common module preload config (#6839) by @shulaoda
- expose `minify` function (#6836) by @sapphi-red
- rolldown_plugin_build_import_analysis: remove all `__VITE_PRELOAD__` (#6833) by @shulaoda
- rolldown_plugin_build_import_analysis: inject __vite__mapDeps (#6832) by @shulaoda
- rolldown_plugin_build_import_analysis: align partial logic (#6831) by @shulaoda
- expose more magic string method in js binding (#6819) by @IWANABETHATGUY
- rolldown_plugin_build_import_analysis: align renderBuiltUrl logic (#6808) by @shulaoda
- rolldown_plugin_build_import_analysis: align resolve dependencies logic (#6803) by @shulaoda
- rolldown_plugin_build_import_analysis: align partial logic (#6802) by @shulaoda

### 🐛 Bug Fixes

- rolldown_plugin_build_import_analysis: correct unaligned code (#6845) by @shulaoda
- rolldown_binding: resolveDependencies shouldn't return Promise (#6844) by @shulaoda
- browser: correct binding file (#6830) by @sxzz

### 🚜 Refactor

- rolldown_plugin_vite_html: use module preload instead (#6843) by @shulaoda
- rolldown_plugin_build_import_analysis: use module preload config instead (#6841) by @shulaoda
- rolldown_binding: correct `renderBuiltUrl` (#6835) by @shulaoda
- rolldown_plugin_build_import_analysis: remove unnecessary is_module_preload (#6834) by @shulaoda
- rolldown_plugin_build_import_analysis: remove unnecessary `IS_MODERN_FLAG` (#6823) by @shulaoda
- rolldown_plugin_build_import_analysis: tweak v2 config (#6804) by @shulaoda

### 📚 Documentation

- add link to Native MagicString In-Depth Guide and fix broken markdown syntax (#6827) by @IWANABETHATGUY
- update current status of native magic string (#6820) by @IWANABETHATGUY
- add specific use cases (#6822) by @shulaoda
- add minification preservation instructions for banner/footer options (#6786) by @ZiuChen

### ⚙️ Miscellaneous Tasks

- deps: bump oxc-resolver to v11.13.1 (#6847) by @renovate[bot]
- deps: update dependency tsdown to v0.16.0 (#6840) by @renovate[bot]
- README.md: fix broken documentation link to getting started guide (#6837) by @Cheng-fung

### ❤️ New Contributors

* @Cheng-fung made their first contribution in [#6837](#6837)
* @ZiuChen made their first contribution in [#6786](#6786)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants