feat(plugin/vite-resolve): add `disableCache` option by sapphi-red · Pull Request #6763 · rolldown/rolldown

sapphi-red · 2025-10-30T03:59:36Z

requires oxc-project/oxc-resolver#791, oxc-project/oxc-resolver#817, oxc-project/oxc-resolver#872

sapphi-red · 2025-10-30T03:59:51Z

feat(plugin/vite-resolve): add disableCache option #6763 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2025-10-30T04:00:34Z

✅ Deploy Preview for rolldown-rs ready!

Name	Link
🔨 Latest commit	`c44a9c9`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/692fa567a0b4800008be03f1
😎 Deploy Preview	https://deploy-preview-6763--rolldown-rs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2025-10-30T04:13:08Z

Benchmarks Rust

target: main(5c9b6f8)
pr: 10-30-feat_plugin_vite-resolve_add_disablecache_option(c44a9c9)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     63.2±1.66ms        ? ?/sec    1.13     71.2±2.41ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     73.1±2.33ms        ? ?/sec    1.03     75.4±2.24ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    110.6±2.60ms        ? ?/sec    1.04    114.7±2.20ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    121.0±2.76ms        ? ?/sec    1.04    126.3±2.05ms        ? ?/sec
bundle/bundle@threejs                                        1.00     41.2±1.63ms        ? ?/sec    1.04     42.8±0.63ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     43.9±0.69ms        ? ?/sec    1.06     46.7±0.61ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    401.5±6.71ms        ? ?/sec    1.04    416.2±8.43ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    465.0±5.65ms        ? ?/sec    1.02    473.7±5.68ms        ? ?/sec
scan/scan@rome_ts                                            1.00     86.8±1.66ms        ? ?/sec    1.01     87.6±1.58ms        ? ?/sec
scan/scan@threejs                                            1.00     29.0±0.41ms        ? ?/sec    1.01     29.4±0.46ms        ? ?/sec
scan/scan@threejs10x                                         1.00    304.8±4.46ms        ? ?/sec    1.00    303.5±5.68ms        ? ?/sec

pkg-pr-new · 2025-10-30T04:18:00Z

Open in StackBlitz

@rolldown/browser

npm i https://pkg.pr.new/@rolldown/browser@6763

@rolldown/debug

npm i https://pkg.pr.new/@rolldown/debug@6763

@rolldown/pluginutils

npm i https://pkg.pr.new/@rolldown/pluginutils@6763

rolldown

npm i https://pkg.pr.new/rolldown@6763

@rolldown/binding-android-arm64

npm i https://pkg.pr.new/@rolldown/binding-android-arm64@6763

@rolldown/binding-darwin-arm64

npm i https://pkg.pr.new/@rolldown/binding-darwin-arm64@6763

@rolldown/binding-darwin-x64

npm i https://pkg.pr.new/@rolldown/binding-darwin-x64@6763

@rolldown/binding-freebsd-x64

npm i https://pkg.pr.new/@rolldown/binding-freebsd-x64@6763

@rolldown/binding-linux-arm-gnueabihf

npm i https://pkg.pr.new/@rolldown/binding-linux-arm-gnueabihf@6763

@rolldown/binding-linux-arm64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-gnu@6763

@rolldown/binding-linux-arm64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-musl@6763

@rolldown/binding-linux-x64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-gnu@6763

@rolldown/binding-linux-x64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-musl@6763

@rolldown/binding-openharmony-arm64

npm i https://pkg.pr.new/@rolldown/binding-openharmony-arm64@6763

@rolldown/binding-wasm32-wasi

npm i https://pkg.pr.new/@rolldown/binding-wasm32-wasi@6763

@rolldown/binding-win32-arm64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-arm64-msvc@6763

@rolldown/binding-win32-x64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-x64-msvc@6763

commit: 1e8617f

Copilot

Pull request overview

This PR adds a disableCache option to the Vite resolve plugin to address caching issues with files that are not watched by Vite or Rollup (referenced in vitejs/rolldown-vite#466). The implementation adds a boolean configuration option that, when enabled, clears the resolver cache on every resolution call.

Key Changes:

Added disableCache optional boolean field to the TypeScript binding interface
Implemented cache clearing logic in the resolve_id hook when the option is enabled
Removed a TODO comment about needing to avoid cache for unwatched files

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
packages/rolldown/src/binding.d.cts	Added optional `disableCache` boolean field to `BindingViteResolvePluginConfig` interface
crates/rolldown_plugin_vite_resolve/src/vite_resolve_plugin.rs	Added `disable_cache` field to structs and implemented cache clearing in `resolve_id` hook; removed TODO comment about cache handling
crates/rolldown_binding/src/options/plugin/config/binding_vite_resolve_plugin_config.rs	Added `disable_cache` optional field and conversion logic using `unwrap_or_default()`

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/rolldown_plugin_vite_resolve/src/vite_resolve_plugin.rs

graphite-app · 2025-12-03T02:49:57Z

Merge activity

Dec 3, 2:49 AM UTC: sapphi-red added this pull request to the Graphite merge queue.
Dec 3, 3:07 AM UTC: Merged by the Graphite merge queue.

For vitejs/rolldown-vite#466 requires oxc-project/oxc-resolver#791, oxc-project/oxc-resolver#817, oxc-project/oxc-resolver#872

@sapphi-red

## [1.0.0-beta.53] - 2025-12-03 💥 Breaking Changes - Drop `i686-pc-windows-msvc` target support 🚀 Chunk Merging Optimization - Rolldown now automatically merges shared chunks when entries import each other (when `preserveEntrySignature` is not `strict`) ```shell Before: entry.js → imports → shared.js (common chunk) entry2.js → imports → shared.js Output: 3 chunks (entry.js, entry2.js, shared.js) After: entry.js → contains shared code entry2.js → imports → entry.js Output: 2 chunks (entry.js, entry2.js) ``` ### 💥 BREAKING CHANGES - drop `i686-pc-windows-msvc` target support (#7230) by @sapphi-red ### 🚀 Features - rolldown_plugin_vite_manifest: pass normalized options to `isLegacy` callback (#7321) by @shulaoda - plugin/vite-resolve: add `disableCache` option (#6763) by @sapphi-red - rolldown: export `createTokioRuntime` for tsdown (#7264) by @shulaoda - rolldown_plugin_vite_html: sync `moduleSideEffects` for already loaded modules (#7254) by @shulaoda - rolldown_plugin_vite_html: load module scripts with side effects to prevent tree-shaking (#7244) by @shulaoda - rolldown_plugin_vite_css_post: implement `cssScopeTo` for scoped CSS tree-shaking (#7240) by @shulaoda ### 🐛 Bug Fixes - export default class decl __name runtime insertion (#7316) by @IWANABETHATGUY - chunk side effects calculation (#7273) by @IWANABETHATGUY - node: `output.generateCode.preset: 'es2015'` should set `output.generateCode.symbols: true` by default (#7314) by @sapphi-red - skip name helper for classes with static name property (#7312) by @IWANABETHATGUY - preserve chunk imports relationship after chunk merging (#7303) by @shulaoda - dev: make `register_modules` async (#7289) by @hyf0 - preserve computed property in object destructuring (#7288) by @IWANABETHATGUY - support dynamic imports with shared dependencies (#7261) by @IWANABETHATGUY - call `defer_sync_scan_data` in non-incremental build mode (#7255) by @shulaoda - optimize chunk merging for shared entry points (#7194) by @IWANABETHATGUY - add indentation for UMD format output (#7263) by @IWANABETHATGUY - rolldown_plugin_vite_css_post: pass options to `isLegacy` callback for proper legacy detection (#7260) by @shulaoda - rolldown_plugin_vite_css_post: also detect `?inline=true` query for inlined CSS (#7245) by @shulaoda - rolldown_plugin_vite_css_post: distinguish empty CSS from no CSS (#7241) by @shulaoda - add Windows support for t-run command (#7242) by @IWANABETHATGUY - cjs: prevent duplicate require declarations for external modules with preserveModules (#7234) by @logaretm - rolldown_plugin_vite_resolve: resolve from root for virtual modules (#7236) by @sapphi-red - include entry level external modules in chunk exports (#7218) by @IWANABETHATGUY ### 🚜 Refactor - dev: make `removeClient` async (#7313) by @hyf0 - move chunk merging code out of code_splitting.rs (#7285) by @IWANABETHATGUY - extract common function util for chunk merging (#7271) by @IWANABETHATGUY - use iterative method to merge chunks (#7256) by @IWANABETHATGUY - use concat_string! instead of string replace for generating chunk level exports (#7247) by @IWANABETHATGUY ### 📚 Documentation - add warning to experimental.resolveNewUrlToAsset about JS/TS files (#7300) by @Copilot - add sequential hook execution difference in plugin-api.md (#7308) by @Copilot - add migration example from onwarn to onLog (#7299) by @Copilot - add migration example for manualChunks to advancedChunks (#7298) by @Copilot - deps: bump vitepress to fix build (#7307) by @sapphi-red - examples & text for experimental.resolveNewUrlToAsset (#7259) by @TheAlexLichter ### ⚡ Performance - rolldown_plugin_vite_css_post: lazily load `cssScopeTo` from JS module options (#7253) by @shulaoda - rolldown_plugin_vite_css_post: avoid unnecessary string clones in `resolve_asset_urls_in_css` (#7250) by @shulaoda ### 🧪 Testing - generate relative path like name in advanced chunks (#7267) by @IWANABETHATGUY - add test case for preserveEntrySignatures with re-exports (#7279) by @IWANABETHATGUY - add test262 integration tests (#7196) by @sapphi-red ### ⚙️ Miscellaneous Tasks - deps: update dependency rolldown-plugin-dts to v0.18.1 (#7304) by @renovate[bot] - enable tracing feature for napi (#7322) by @sapphi-red - deps: update napi (#7320) by @renovate[bot] - deps: update oxc (#7318) by @renovate[bot] - deps: update napi (#7317) by @renovate[bot] - deps: update oxc to v0.100.0 (#7301) by @renovate[bot] - deps: downgrade pnpm to 10.23.0 to fix Netlify build (#7306) by @shulaoda - add `trustPolicyExclude` for chokidar and semver (#7302) by @sapphi-red - update pnpm lockfile (#7291) by @IWANABETHATGUY - deps: update npm packages (#7272) by @renovate[bot] - deps: update rust crates (#7270) by @renovate[bot] - deps: update oxc (#7262) by @renovate[bot] - deps: update github-actions (#7269) by @renovate[bot] - deps: update dependency dprint-typescript to v0.95.13 (#7268) by @renovate[bot] - deps: update `html5gum` to 0.8.1 (#7265) by @shulaoda - rolldown: remove unused `getModuleOptions` from `PluginContext` (#7266) by @shulaoda - remove unnecessary justfile ignore (#7243) by @IWANABETHATGUY - deps: update oxc apps (#7238) by @renovate[bot] - add `nul` to workaround https://github.com/anthropics/claude-c… (#7237) by @IWANABETHATGUY - deps: update dependency valibot to v1.2.0 [security] (#7231) by @renovate[bot] - deps: update crate-ci/typos action to v1.40.0 (#7232) by @renovate[bot] ### ❤️ New Contributors * @logaretm made their first contribution in [#7234](#7234) Co-authored-by: shulaoda <[email protected]>

sapphi-red added the trigger: preview label Oct 30, 2025

sapphi-red mentioned this pull request Oct 30, 2025

fix: disable resolver cache when watcher is disabled vitejs/rolldown-vite#471

Merged

sapphi-red force-pushed the 10-30-feat_plugin_vite-resolve_add_disablecache_option branch from a143b81 to 51ddacf Compare October 30, 2025 04:43

sapphi-red added trigger: preview and removed trigger: preview labels Oct 30, 2025

sapphi-red force-pushed the 10-30-feat_plugin_vite-resolve_add_disablecache_option branch from 6de293e to e1f35e5 Compare November 5, 2025 12:17

sapphi-red added trigger: preview and removed trigger: preview labels Nov 6, 2025

sapphi-red force-pushed the 10-30-feat_plugin_vite-resolve_add_disablecache_option branch from e1f35e5 to 6cc3f4a Compare November 6, 2025 18:00

sapphi-red added trigger: preview and removed trigger: preview labels Nov 6, 2025

sapphi-red force-pushed the 10-30-feat_plugin_vite-resolve_add_disablecache_option branch from 6cc3f4a to ba1ff56 Compare November 26, 2025 11:02

sapphi-red added trigger: preview and removed trigger: preview labels Nov 26, 2025

sapphi-red mentioned this pull request Nov 28, 2025

Rolldown CI Failures vitest-dev/vitest#8754

Closed

6 tasks

sapphi-red force-pushed the 10-30-feat_plugin_vite-resolve_add_disablecache_option branch from ba1ff56 to 1e8617f Compare December 3, 2025 02:24

sapphi-red added trigger: preview and removed trigger: preview labels Dec 3, 2025

sapphi-red marked this pull request as ready for review December 3, 2025 02:45

Copilot AI review requested due to automatic review settings December 3, 2025 02:45

Copilot started reviewing on behalf of sapphi-red December 3, 2025 02:46 View session

sapphi-red requested a review from shulaoda December 3, 2025 02:46

shulaoda approved these changes Dec 3, 2025

View reviewed changes

Copilot finished reviewing on behalf of sapphi-red December 3, 2025 02:49

Copilot AI reviewed Dec 3, 2025

View reviewed changes

crates/rolldown_plugin_vite_resolve/src/vite_resolve_plugin.rs Show resolved Hide resolved

crates/rolldown_plugin_vite_resolve/src/vite_resolve_plugin.rs Show resolved Hide resolved

feat(plugin/vite-resolve): add disableCache option (#6763)

c44a9c9

For vitejs/rolldown-vite#466 requires oxc-project/oxc-resolver#791, oxc-project/oxc-resolver#817, oxc-project/oxc-resolver#872

graphite-app bot force-pushed the 10-30-feat_plugin_vite-resolve_add_disablecache_option branch from 1e8617f to c44a9c9 Compare December 3, 2025 02:50

graphite-app bot merged commit c44a9c9 into main Dec 3, 2025
28 checks passed

graphite-app bot deleted the 10-30-feat_plugin_vite-resolve_add_disablecache_option branch December 3, 2025 03:07

github-actions bot mentioned this pull request Dec 3, 2025

release: v1.0.0-beta.53 #7324

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

feat(plugin/vite-resolve): add `disableCache` option#6763

feat(plugin/vite-resolve): add `disableCache` option#6763
graphite-app[bot] merged 1 commit intomainfrom
10-30-feat_plugin_vite-resolve_add_disablecache_option

sapphi-red commented Oct 30, 2025 •

edited

Loading

Uh oh!

sapphi-red commented Oct 30, 2025 •

edited

Loading

Uh oh!

netlify bot commented Oct 30, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 30, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Oct 30, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

graphite-app bot commented Dec 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

sapphi-red commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sapphi-red commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs ready!

Uh oh!

github-actions bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

pkg-pr-new bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

graphite-app bot commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sapphi-red commented Oct 30, 2025 •

edited

Loading

sapphi-red commented Oct 30, 2025 •

edited

Loading

netlify bot commented Oct 30, 2025 •

edited

Loading

github-actions bot commented Oct 30, 2025 •

edited

Loading

pkg-pr-new bot commented Oct 30, 2025 •

edited

Loading

graphite-app bot commented Dec 3, 2025 •

edited

Loading