Skip to content

Comments

fix!: this.emitFile does not respect chunkFileNames#6716

Closed
shulaoda wants to merge 1 commit intomainfrom
10-27-fix_this.emitfile_does_not_respect_chunkfilenames
Closed

fix!: this.emitFile does not respect chunkFileNames#6716
shulaoda wants to merge 1 commit intomainfrom
10-27-fix_this.emitfile_does_not_respect_chunkfilenames

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Oct 26, 2025 •
edited
Loading

closes #6674

This is a breaking fix. So far, I’ve noticed that it affects rolldown_plugin_dts.

@shulaoda Graphite App
Copy link
Member Author

shulaoda commented Oct 26, 2025

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Oct 26, 2025

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 5345f40
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68feaac1b0b74b0008e977ec

@shulaoda shulaoda changed the title fix: this.emitFile does not respect chunkFileNames fix!: this.emitFile does not respect chunkFileNames Oct 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2025

Benchmarks Rust

  • target: main(d8d9fe3)
  • pr: 10-27-fix_this.emitfile_does_not_respect_chunkfilenames(5345f40)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     58.7±1.24ms        ? ?/sec    1.07     62.9±1.36ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     64.6±1.51ms        ? ?/sec    1.07     69.4±1.28ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    100.1±1.52ms        ? ?/sec    1.03    103.1±1.38ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    113.2±1.34ms        ? ?/sec    1.04    117.4±1.55ms        ? ?/sec
bundle/bundle@threejs                                        1.00     37.3±0.96ms        ? ?/sec    1.02     38.0±1.76ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     41.3±0.65ms        ? ?/sec    1.03     42.6±0.70ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    378.4±4.75ms        ? ?/sec    1.02    385.4±5.06ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    445.2±7.91ms        ? ?/sec    1.01    450.6±4.65ms        ? ?/sec
scan/scan@rome_ts                                            1.00     79.0±1.14ms        ? ?/sec    1.01     79.4±1.20ms        ? ?/sec
scan/scan@threejs                                            1.00     27.5±1.83ms        ? ?/sec    1.00     27.6±0.96ms        ? ?/sec
scan/scan@threejs10x                                         1.00    280.4±3.14ms        ? ?/sec    1.00    280.9±2.99ms        ? ?/sec

@shulaoda shulaoda added the on hold: to be discussed Waiting for team to discuss this issue label Oct 26, 2025
@shulaoda shulaoda mentioned this pull request Nov 10, 2025
Merged
@shulaoda shulaoda closed this in 4b59864 Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 Awaiting requested review from hyf0

@IWANABETHATGUY IWANABETHATGUY Awaiting requested review from IWANABETHATGUY

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@shulaoda shulaoda

Labels

on hold: to be discussed Waiting for team to discuss this issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: this.emitFile does not respect chunkFileNames

1 participant

@shulaoda