perf(rolldown): make chunks generation more parallel by Brooooooklyn · Pull Request #6599 · rolldown/rolldown

Brooooooklyn · 2025-10-17T07:30:57Z

No description provided.

Brooooooklyn · 2025-10-17T07:31:12Z

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull Request Overview

This PR optimizes chunk generation performance by making the process more parallel. The main change is restructuring the chunk generation code to avoid sequential execution of generator types (ECMA, CSS, and Asset) and instead execute them all in parallel.

Refactored chunk generation to use flat_map instead of nested async blocks
Replaced try_join3 with individual async futures to enable better parallelization
Added type alias for cleaner future handling and better code organization

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

crates/rolldown/src/stages/generate_stage/render_chunk_to_assets.rs

github-actions · 2025-10-17T07:46:54Z

Benchmarks Rust

target: 10-17-perf_rolldown_utils_only_allocate_hash_placeholder_left_once(63785e9)
pr: 10-17-perf_rolldown_make_chunks_generation_more_parallel(f28b03f)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.02     69.2±4.01ms        ? ?/sec    1.00     67.7±1.89ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     73.2±1.53ms        ? ?/sec    1.02     74.3±1.81ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    108.6±2.91ms        ? ?/sec    1.02    110.6±1.71ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    120.7±1.46ms        ? ?/sec    1.02    123.6±1.56ms        ? ?/sec
bundle/bundle@threejs                                        1.02     41.1±2.63ms        ? ?/sec    1.00     40.4±1.73ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     44.4±0.68ms        ? ?/sec    1.00     44.2±0.69ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    399.0±4.15ms        ? ?/sec    1.01    403.1±7.22ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    460.5±4.10ms        ? ?/sec    1.01    464.3±5.06ms        ? ?/sec
scan/scan@rome_ts                                            1.01     88.9±1.68ms        ? ?/sec    1.00     87.7±1.53ms        ? ?/sec
scan/scan@threejs                                            1.01     30.5±2.03ms        ? ?/sec    1.00     30.2±1.97ms        ? ?/sec
scan/scan@threejs10x                                         1.00    299.5±4.26ms        ? ?/sec    1.00    300.5±4.44ms        ? ?/sec

Brooooooklyn · 2025-10-17T07:56:02Z

Merge activity

Oct 17, 7:56 AM UTC: The merge label 'graphite: merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Oct 17, 7:56 AM UTC: Brooooooklyn added this pull request to the Graphite merge queue.
Oct 17, 8:18 AM UTC: Merged by the Graphite merge queue.

The chunk generation is already in parallel in #6599 Remove `par_iter` to reduce thread race

@sapphi-red

## [1.0.0-beta.44] - 2025-10-20 :boom: Breaking Changes - Top-level `jsx` removed, use `transform.jsx` instead - `output.minifyInternalExports` now enabled by default :dart: Enhanced Tree-Shaking - JSON default imports are now tree-shakeable ```js // config.json { "apiUrl": "[https://api.example.com](https://api.example.com/)", "timeout": 5000, "retries": 3, "debug": false } // main.js // Before: Entire JSON was included in bundle import config from './config.json'; console.log(config.apiUrl); // After: Only the used property is included // Bundle now contains just the apiUrl value ``` - Built-in typed array constructors (`new Uint8Array()`, `new Int32Array()`, etc.) marked as pure :gear: Configuration Improvements - Support `output.cleanDir` option - Deprecated some top-level options - `define` → `transform.define` - `inject` → `transform.inject` - `dropLabels` → `transform.dropLabels` - `keepNames` → `output.keepNames` - `profilerNames` → `output.generatedCode.profilerNames` ### 💥 BREAKING CHANGES - enable `output.minifyInternalExports` for `format: 'es'` or `minify: true` (#6594) by @sapphi-red - node/options: remove `InputOptions.jsx`, prefer `transform.jsx` always (#6548) by @hyf0 ### 🚀 Features - support jsx preset for `transform.jsx` (#6630) by @shulaoda - rolldown_plugin_vite_html: align `inject_to_body` function (#6622) by @shulaoda - rolldown_vite_css_post_plugin: tweak `is_legacy` field (#6620) by @shulaoda - native-plugin: expose `viteHtmlPlugin` (#6609) by @shulaoda - native-plugin: expose `viteCSSPostPlugin` (#6606) by @shulaoda - builtin-plugin: expose `viteCSSPlugin` (#6605) by @shulaoda - rolldown_plugin_vite_html: complete plugin binding (#6604) by @shulaoda - rolldown_plugin_vite_css: support plugin binding (#6598) by @shulaoda - add TypedArray constructors to side-effect free globals (#6592) by @IWANABETHATGUY - rolldown_plugin_vite_html: align process src attr logic (#6572) by @shulaoda - rolldown: support `output.clearDir` to clean up `dir` before build (#6486) by @aprosail - dev: return `RolldownOutput` instead of `BindingOutputs` from `onOutput` (#6563) by @sapphi-red - rolldown_plugin_vite_html: align process srcset logic (#6560) by @shulaoda - rolldown_plugin_vite_html: align process src function (#6559) by @shulaoda - rolldown_plugin_vite_html: align parse secset function (#6558) by @shulaoda - node/options: deprecate `dropLabels` and add `transform.dropLabels` (#6557) by @hyf0 - node/options: deprecate `keepNames` and add `output.keepNames` (#6556) by @hyf0 - node/options: deprecate `profilerNames` and add `output.generatedCode.profilerNames` (#6555) by @hyf0 - node/options: deprecate top level `inject` and `define` and add `transform.define`, `transform.inject` (#6544) by @hyf0 - rolldown_plugin_vite_html: initialize attributes handle logic (#6543) by @shulaoda - rolldown: oxc v0.95.0 (#6541) by @Boshen - rolldown_plugin_vite_html: align inject css logic (#6528) by @shulaoda - rolldown_plugin_vite_html: align modulepreload inject logic (#6526) by @shulaoda - rolldown_plugin_vite_html: align css bundle output inject logic (#6524) by @shulaoda - rolldown_plugin_vite_html: support inject_to_head function (#6522) by @shulaoda - rolldown_plugin_vite_html: align emit and delete logic (#6521) by @shulaoda - rolldown_vite_html: align handle html asset url logic (#6518) by @shulaoda - add an example how to transform code and generate sourcemap with `experimental.nativeMagicString` (#6514) by @IWANABETHATGUY - rolldown_plugin_vite_html: align handle inline css logic (#6517) by @shulaoda ### 🐛 Bug Fixes - native-plugin: use correct config for assetPlugin (#6638) by @shulaoda - no_color not being respected on reporter (#6615) by @H4ad - improve tree shaking for JSON default imports (#6626) by @IWANABETHATGUY - cjs treeshaking removes used code (#6597) by @IWANABETHATGUY - plugin/vite-resolve: return `package_json_path` from resolveId hook (#6434) by @sapphi-red - dev: `should have idx` error happens with `deferSyncScanData` + incremental rebuild (#6568) by @sapphi-red - rolldown: sync scoping properly in pre_process_ecma_ast (#6537) by @Boshen - process CJS tree shaking bailout modules before eliminating unused dynamic entries (#6549) by @IWANABETHATGUY - rust/dev: error of `bundler.scan`doesn't get handled (#6547) by @Copilot - inline only self referenced json module properties (#6519) by @IWANABETHATGUY - avoid processing native MagicString sourcemap when `sourcemap` is disabled (#6510) by @IWANABETHATGUY ### 🚜 Refactor - rolldown_binding: unify `BindingAssetInlineLimit` (#6625) by @shulaoda - rolldown_binding: tweak `BindingAssetPluginConfig` (#6624) by @shulaoda - tweak `viteCSSPlugin` config (#6610) by @shulaoda - rust/dev: remove unnecessary bundler cache management of dev engine (#6576) by @hyf0 - rust/dev: refactor `TaskInput` into enum to reduce invalid states (#6575) by @hyf0 - improve the error message of `ScanStageCache#merge` (#6564) by @IWANABETHATGUY - rust/dev: use `client_id` to check if module is executed for test environment (#6566) by @hyf0 - rust/binding: mark napi object that won't be received from js side (#6531) by @hyf0 - rust/binding: mark napi object struct that won't be passed to js explicitly (#6525) by @hyf0 - rust/binding: use `&str` or `JsString` to avoid unnecessary clone (#6523) by @hyf0 - rust/binding: use `&str` to avoid unnecessary clone (#6520) by @hyf0 - rust: replace unwrap with expect for better error handling in message sending (#6509) by @hyf0 ### 📚 Documentation - add redirect from `/guide/in-depth/` to `/in-depth/` (#6554) by @Copilot - guide: polish notable features page (#6535) by @sapphi-red - builtin-plugins: add replace plugin docs (#6534) by @sapphi-red - add `Additional Thanks` in `acknowledgements` page (#6507) by @hyf0 - polish doc for `experimental.nativeMagicString` (#6504) by @IWANABETHATGUY ### ⚡ Performance - cli: advance `createTokioRuntime` (#6618) by @hyf0 - rolldown: reduce unnecessary Vec allocate (#6601) by @Brooooooklyn - rolldown: make derived assets generation more parallel (#6600) by @Brooooooklyn - rolldown: make chunks generation more parallel (#6599) by @Brooooooklyn - rolldown_utils: only allocate HASH_PLACEHOLDER_LEFT once (#6595) by @Brooooooklyn - rolldown: use oxc-resolver with simd-json (#6591) by @Boshen - rolldown: avoid allocate the sourcemap sources on non Windows os (#6590) by @Brooooooklyn - resolver: use optimized fs.read_to_string impl (#6589) by @Brooooooklyn - deps: upgrade json-escape-simd and add simdutf8 dependency (#6579) by @Brooooooklyn - rust/dev: remove unncessary clone for `ClientInput` (#6565) by @hyf0 - visit ast in `cross_module_optimization` stage parallel (#6552) by @IWANABETHATGUY ### 🧪 Testing - json module prop conflict with normal module declaration binding (#6540) by @IWANABETHATGUY - vite-tests: fix rolldown overrides (#6532) by @sapphi-red ### ⚙️ Miscellaneous Tasks - remove string conversion warning in `replacePlugin` to compatible with rollup (#6639) by @IWANABETHATGUY - deps: update dependency dprint-json to v0.21.0 (#6637) by @renovate[bot] - deps: lock file maintenance (#6635) by @renovate[bot] - deps: lock file maintenance npm packages (#6632) by @renovate[bot] - node: use built-in styleText (#6340) by @dumbmatter - deps: update actions/setup-node action to v6 (#6629) by @renovate[bot] - deps: update github-actions (#6628) by @renovate[bot] - deps: update dependency dprint-markdown to v0.20.0 (#6627) by @renovate[bot] - Switch color dependencies (ansis and picocolors) to built-in styleText (#6619) by @IWANABETHATGUY - native-plugin: tweak assetPlugin (#6623) by @shulaoda - remove deprecated warning in `build.ts` (#6621) by @IWANABETHATGUY - deps: update dependency tsdown to v0.15.8 (#6617) by @renovate[bot] - rolldown_binding: rename vite css plugin config field (#6611) by @shulaoda - add colored deprecation warnings for top-level options (#6612) by @IWANABETHATGUY - rust: make `cargo publish --workspace` work (#6287) by @Boshen - deps: update dependency rolldown-plugin-dts to v0.16.12 (#6608) by @renovate[bot] - test: add `opposite_minify_internal_exports` and remove `minify_internal_exports` extend test (#6596) by @hyf0 - test: render snapshot for build and dev independently (#6584) by @hyf0 - test: split test logic for normal build and dev engine (#6580) by @hyf0 - fix rolldown build self warning (#6578) by @IWANABETHATGUY - tweak `BindingBuiltinPluginName` (#6574) by @shulaoda - rust: use forked `notify` crate (#6573) by @Boshen - add `.len()` and `.is_empty()` to `HybridIndexVec` (#6570) by @sapphi-red - ai: improve `AGENT.md` with verified prompts (#6533) by @hyf0 - clippy: set `too-many-lines-threshold` to 200 (#6530) by @shulaoda - clean up examples/basic-vue (#6515) by @IWANABETHATGUY - deps: update dependency tsdown to v0.15.7 (#6512) by @renovate[bot] - add shulaoda to release PR assignees (#6505) by @shulaoda ### ❤️ New Contributors * @dumbmatter made their first contribution in [#6340](#6340) * @H4ad made their first contribution in [#6615](#6615) * @aprosail made their first contribution in [#6486](#6486) Co-authored-by: shulaoda <[email protected]>

Brooooooklyn mentioned this pull request Oct 17, 2025

perf(rolldown_utils): only allocate HASH_PLACEHOLDER_LEFT once #6595

Merged

github-actions bot assigned Brooooooklyn Oct 17, 2025

Brooooooklyn requested review from IWANABETHATGUY and Copilot and removed request for IWANABETHATGUY October 17, 2025 07:32

Copilot AI reviewed Oct 17, 2025

View reviewed changes

crates/rolldown/src/stages/generate_stage/render_chunk_to_assets.rs Show resolved Hide resolved

crates/rolldown/src/stages/generate_stage/render_chunk_to_assets.rs Show resolved Hide resolved

IWANABETHATGUY approved these changes Oct 17, 2025

View reviewed changes

Brooooooklyn added the graphite: merge label Oct 17, 2025

perf(rolldown): make chunks generation more parallel (#6599)

f28b03f

graphite-app bot force-pushed the 10-17-perf_rolldown_utils_only_allocate_hash_placeholder_left_once branch from 4dc9e85 to 63785e9 Compare October 17, 2025 08:01

graphite-app bot force-pushed the 10-17-perf_rolldown_make_chunks_generation_more_parallel branch from 6a3bdbd to f28b03f Compare October 17, 2025 08:02

Base automatically changed from 10-17-perf_rolldown_utils_only_allocate_hash_placeholder_left_once to main October 17, 2025 08:18

graphite-app bot merged commit f28b03f into main Oct 17, 2025
25 checks passed

graphite-app bot deleted the 10-17-perf_rolldown_make_chunks_generation_more_parallel branch October 17, 2025 08:18

graphite-app bot removed the graphite: merge label Oct 17, 2025

Brooooooklyn added a commit that referenced this pull request Oct 17, 2025

perf(rolldown): remove par_iter in ecma generator

b81f8d7

The chunk generation is already in parallel in #6599 Remove `par_iter` to reduce thread race

Brooooooklyn mentioned this pull request Oct 17, 2025

perf(rolldown): remove par_iter in ecma generator #6603

Draft

github-actions bot mentioned this pull request Oct 20, 2025

release: v1.0.0-beta.44 #6640

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

perf(rolldown): make chunks generation more parallel#6599

perf(rolldown): make chunks generation more parallel#6599
graphite-app[bot] merged 1 commit intomainfrom
10-17-perf_rolldown_make_chunks_generation_more_parallel

Brooooooklyn commented Oct 17, 2025

Uh oh!

Brooooooklyn commented Oct 17, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 17, 2025 •

edited

Loading

Uh oh!

Brooooooklyn commented Oct 17, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

Brooooooklyn commented Oct 17, 2025

Uh oh!

Brooooooklyn commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

Brooooooklyn commented Oct 17, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Brooooooklyn commented Oct 17, 2025 •

edited

Loading

github-actions bot commented Oct 17, 2025 •

edited

Loading

Brooooooklyn commented Oct 17, 2025 •

edited by graphite-app bot

Loading